Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1314#discussion_r153565344
--- Diff: core/sql/executor/OrcFileReader.cpp ---
@@ -122,24 +150,28 @@ OFR_RetCode OrcFileReader::init()
OFR_RetCode OrcFileReader::open(const char* path)
{
QRLogger::log(CAT_SQL_HDFS_ORC_FILE_READER, LL_DEBUG,
"OrcFileReader::open(%s) called.", path);
+
+ if (initJNIEnv() != JOI_OK)
+ return OFR_ERROR_OPEN_PARAM;
jstring js_path = jenv_->NewStringUTF(path);
if (js_path == NULL)
+ {
+ jenv_->PopLocalFrame(NULL);
--- End diff --
I'm a little confused about the rules for when a call to PopLocalFrame is
needed. Is it needed whenever we have previously done a call into any jenv_
method? (in this case NewStringUTF).
---
