Github user zellerh commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1353#discussion_r158095765
  
    --- Diff: install/traf_checkset_env.sh ---
    @@ -0,0 +1,243 @@
    +#!/bin/bash
    +#
    +# @@@ START COPYRIGHT @@@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +#
    +# @@@ END COPYRIGHT @@@
    +#
    +# make sure the environment can build the code of trafodion or not.
    +# must configure the yum repo right before execute this script.
    +# run this script with normal user, while must has sudo permission.
    +
    +#default path
    +MY_JVM_PATH=${MY_JVM_PATH-"/usr/lib/jvm"}
    +MY_JAVA_VER=${MY_JAVA_VER-"java-1.7.0-openjdk"}
    +MY_SUDO=${MY_SUDO-"sudo"}
    +MY_YUM=${MY_YUM-"${MY_SUDO} yum -y"}
    +
    +# for setup tools
    +MY_LOCAL_SW_DIST=${MY_LOCAL_SW_DIST-${HOME}/local_software_tools}
    --- End diff --
    
    It's pretty common that the root directory of a server is small (at least 
on the OpenStack and Amazon VMs I have seen). Maybe add yet another variable 
like this one:
    
    ```
    MY_SW_HOME=${MY_SW_HOME-${HOME}}
    ```
    
    Then use $MY_SW_HOME instead of $HOME below.


---

Reply via email to