Hi,

Let's say I have branches/vvs/feature_4 branch that I've finished and
would like to get a review. I submit it for the review via CodeStriker
1.9.2 alpha-9.
Let's say also that I've modified a file Defs.mk in build subdir.

But reviewers will see the following file names:
branches/vvs/build/Defs.mk (please note that feature_4 part is MISSING!)

I tracked down the problem to Subversion.pm file, line 146:
       if ($line =~ /^svn: URL '.*' refers to a directory/) {

The problem here is that at least with my Subversion 1.3.2 the output
from svn cat command is DIFFIRENT:
svn: warning: URL 'blah-blah-blah' refers to a directory

Please note an extra token - warning:

It seems that CodeStriker should be more flexible and should handle
both outputs, from older Subversion and from newer Subversions: with
"warning:" and without it.

I can confirm that after I modify the line to be like this:
       if ($line =~ /^svn: (warning:)? URL '.*' refers to a directory/) {

The problem is gone.

I'm hoping this would end up in final 1.9.2.

Thank you for the great tool,
 --Vladimir

P.S. I wonder what non-English users of subversion would get from svn
cat, if their svn is localized.... :) Codestriker uses hardcoded
English...


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Codestriker-user mailing list
Codestriker-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/codestriker-user

Reply via email to