Hi Eugene, I use this scripts at my work, so they work fine.
The push and pop operators in perl work more in the metaphor of a stack, not a list. So pop removes the first element from the list, not the last. Cheers, David On Mon, Mar 2, 2009 at 2:10 AM, Eugene Gill <mi...@keergill.co.uk> wrote: > Hi. > > I'm just in the process of trying to set up Codestriker to automatically > generate reviews for SVN commits and am looking at this script. Has it > actually been tested? > > The following lines pop the command line arguments off from the end of the > list and therefore in the opposite order to that suggested in the comment > and the documentation. > > # First argument is the repository followed by the revision number. > my $repository = pop @ARGV; > my $revision = pop @ARGV; > > Apologies if I'm being somehow stupid, but it surprises me that this has > gone unspotted until now. > > Eugene > > > > > > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Codestriker-user mailing list > Codestriker-user@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/codestriker-user > > ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Codestriker-user mailing list Codestriker-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/codestriker-user
