It is inconsistent.. I'll make sure this is cleaned up for 1.9.10. The ClearCase modules were contributed and not well maintained.
On Tue, Oct 6, 2009 at 3:47 PM, <rames...@gmail.com> wrote: > Thanks for the quick response. > > Yes. I got it to work by changing the Clearcase retrieve function to return > 1 if the $error_msg eq "" > > return 1 if ( $error_msg eq "" ); --> added to the ClearcaseDynamic.pm > return $error_msg; > > I am not sure if this is the correct way to handle this..I am seeing > inconsistency in handling error condition and the return values in the > repository implementations for retrieve function. > > For eg: > > in Perforce.pm, we call die in case of error and there is no eval block to > catch the die > and in success scenario the function doesn't return any value to the caller. > The return value is assumed to be 1 > > in ClearcaseDynamic.pm we call die/eval in some places, reuse $error_msg > variable in case of error while closing the view and > mask any error when trying to retrieve the clearcase data. > > I started looking at codestriker today and I am really very impressed. > Thanks for the fantastic tool. > > > thanks > Ramesh > > > On Oct 5, 2009 10:00pm, David Sitsky <david.sit...@gmail.com> wrote: >> > Shouldn't $error_msg in lib/Codestriker/Repository/ClearCaseDynamic.pm >> >> > initialized to undef instead of empty string? >> >> >> >> It appears that way. Does this fix your issue if you make this change? >> >> >> >> Cheers, >> >> David >> ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Codestriker-user mailing list Codestriker-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/codestriker-user
