On Fri, Jan 8, 2010 at 6:02 PM, Sebastian Harl <[email protected]> wrote:
> Thanks for the updated patch! > > I haven't looked at your patch yet (will do so later, unless Florians > beats me to it ;-)), but I've got one quick comment: Other plugins that > use a similar configuration, named their config options "InstanceFrom" > and "ValuesFrom". For consistency, your plugin should follow that scheme > as well. Anyway, no need to send another patch -- we can change that as > well. I just wanted to let you know … ;-) > I am okay doing this change as well :). I would wait for the review comments you would have for the code and then submit the updated patch with all the changes in one go. Regards Amit > > Cheers, > Sebastian > > -- > Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ > > Those who would give up Essential Liberty to purchase a little Temporary > Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAktHJfAACgkQEFEKc4UBx/w56ACfYiINxx8iOaqhHxOAW7shZOd/ > fPoAni6Hkp2Z6Wgcvv9sbUenFF3FHogw > =CUFI > -----END PGP SIGNATURE----- > >
_______________________________________________ collectd mailing list [email protected] http://mailman.verplant.org/listinfo/collectd
