On Wed, Feb 10, 2010 at 6:46 PM, Florian Forster <[email protected]> wrote:
> Hi Amit, > > On Thu, Jan 28, 2010 at 02:03:53PM +0530, Amit Gupta wrote: > > Today, I downloaded collectd-4.9.0 source code. However, I couldn't > > see the jar patch applied as yet. Here is the updated patch with > > respect to 4.9.0 source code. > > sorry, I lost track :/ In general your patch looks fine, thank you very > much :) > > > + mkdir -p .libs > > + mkdir -p "$(DESTDIR)$(pkgdatadir)/java" > > + $(JAR) cf .libs/java-plugin.jar "org/collectd/api"/*.class > > + $(JAR) cf .libs/jmx.jar "org/collectd/java"/*.class > > + $(INSTALL) -m 644 .libs/java-plugin.jar \ > > + "$(DESTDIR)$(pkgdatadir)/java" > > + $(INSTALL) -m 644 .libs/jmx.jar \ > > + "$(DESTDIR)$(pkgdatadir)/java" > > I'm not that happy about the .jar filenames. I propose to use > "collectd-api.jar" and "generic-jmx.jar". Do you see any problems with > that? > I am okay with these names as well. Do you want me to submit a updated patch? Regards Amit > > Regards, > —octo > -- > Florian octo Forster > Hacker in training > GnuPG: 0x91523C3D > http://verplant.org/ > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > > iD8DBQFLcrHIHdggu3Q05IYRAp1FAJ9Th4qw+IdF+WT6ZqQfn6sraJcWmACfdkLw > /PxJ26Ygfhy4OS9kT9D4o28= > =lRS6 > -----END PGP SIGNATURE----- > >
_______________________________________________ collectd mailing list [email protected] http://mailman.verplant.org/listinfo/collectd
