Hi Chris, On Tue, Mar 23, 2010 at 08:53:31PM -0700, Chris Buben wrote: > Make it easier for external systems (i.e. those without visibility > into types.db) to interpret collectd json data.
thanks for this patch, too :)
I've done a minor change here:
> + BUFFER_ADD ("\"");
> + BUFFER_ADD(ds->ds[i].name);
> + BUFFER_ADD ("\"");
I've changed that to:
BUFFER_ADD ("\"%s\"", ds->ds[i].name);
This reduces the calls to "snprintf" to one and prevents formatstring
attacks. Very unlikely, but I feel better with this code nonetheless ;)
Regards,
—octo
--
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
signature.asc
Description: Digital signature
_______________________________________________ collectd mailing list [email protected] http://mailman.verplant.org/listinfo/collectd
