Hi Aurélien, thanks for the update :) I've pushed the changes to the "ar/lpar" branch.
On Thu, Sep 09, 2010 at 10:43:16PM +0200, Aurélien Reynaud wrote:
> - get back to the original implementation with gauges only. A new type
> "vcpu" is created (it was "lpar_pcpu" in the original)
Yeah, makes a lot more sense now that I understand what's going on ;)
> - the "consumed" metric might seem superfluous at first sight […]
> But I thought it might come in handy when dealing with dedicated
> partitions, where donated and stolen values are no easy concepts.
Would it make sense to activate this metric only if the partition is a
dedicated partition and donations have been enabled?
Likewise, would it make sense to submit "entitled" capacity only if the
partition is a shared partition? For dedicated partitions you should be
able to calculate "entitlement" as:
entitled = user + sys + wait + idle + {busy,idle}_donated
> I posted a fix ("Fix errno thread-safety under AIX") on Sat, 19 Jun
> 2010, which if I am not mistaken has not been merged yet.
Thanks for the reminder, I must have overlooked that email. I applied
the fix to the collectd-4.9 branch and will merge it to master
eventually.
> + ssnprintf (typinst, sizeof (typinst), "pool-%X-total",
> lparstats.pool_id);
> + lpar_submit (typinst, (double) pool_max_ns / XINTFRAC /
> (double) ticks);
I'd prefer to account "busy" and "used" (non-busy) rather than "busy"
and "total". Do you see any problem with changing that?
> + save_last_values (&lparstats);
I think it might be easier to keep a (module) global
"perfstat_partition_total_t" around and simply do
memcpy (&lparstats_old, lparstats_new, sizeof (lparstats_old));
in the "save values" function. What do you think?
Regards,
—octo
--
Florian octo Forster
Hacker in training
GnuPG: 0x0C705A15
http://octo.it/
signature.asc
Description: Digital signature
_______________________________________________ collectd mailing list collectd@verplant.org http://mailman.verplant.org/listinfo/collectd
