Hi Colin, thank you very much for your patch!
On Mon, Jul 25, 2011 at 05:00:07PM -0700, Colin McCabe wrote:
> - char values[512];
> + char *values = NULL;
Why don't use stick with stack memory here? Allocating a (fixed sized)
junk on the heap only means that you'll have to free it again.
> - return (-1);
> + goto fail;
Sorry, but "goto" is a no-go for collectd. You can use something like
"do { … } while (0);" if you must, but in this particular case I think
simply using stack memory is the way to go.
Best regards,
—octo
--
Florian octo Forster
Hacker in training
GnuPG: 0x0C705A15
http://octo.it/
signature.asc
Description: Digital signature
_______________________________________________ collectd mailing list collectd@verplant.org http://mailman.verplant.org/listinfo/collectd
