On Sunday 08 January 2012 18:50:27 Phil Kulin wrote: > I welcome from rainy Ingermanland! > > Our thoughts are now occupied by Putin and vodka, however... > > I have paid attention to a little incorrect data which is given out by > a processes plugin on my beautifull FreeBSD system. > I have corrected them and in process have made absolutely slightly > have improved accuracy and productivity of a processes plugin for > FreeBSD systems. > > - Fix strange plural call of getpagesize(). Has entered a global > variable and initialization procedure for FreeBSD > - Data was summarized on all processes including threads. It led to > absolutely uncertain result. Fix based on codebase of FreeBSD top > programm. KERN_PROC_ALL attribute keep for future purposes. > - Gets command argument failed for some processes as system and some > other. It led to error messages to console. Fix based on codebase of > FreeBSD top programm. > - System and user CPU times turned out from the sum of miliseconds > and... Oh! microseconds in one glass with overflow possibility. Fixed. > > My girlfriend has left me for such Christmas vacation, but I am > assured that have made good business. > > Patch in mail attachment.
Hi Phil, I got following errors (warnings) when I tried to make collectd with your patch processes.c: In function 'ps_read': processes.c:1592: warning: 'pse.cpu_user_counter' may be used uninitialized in this function processes.c:1592: warning: 'pse.cpu_system_counter' may be used uninitialized in this function I added pse.cpu_user_counter = 0; and pse.cpu_system_counter = 0; after pse.cpu_system = 0; to remove the warnings. Thanks for your interesting patch. Toni Ylenius
_______________________________________________ collectd mailing list [email protected] http://mailman.verplant.org/listinfo/collectd
