Hi, I agree with the performance argument. However, I think it would be a good thing to allow for including the number of cores, e.g. having the possibility to return either average or sum (average*ncore).
Cheers On Mon, Nov 18, 2013 at 09:30:02AM +0100, Toni Moreno wrote: > Hi Otis. > > I think this approach is much better in very big servers ( I usually work > in servers with up to 40 cores ) and is easier to parse a single line on > /proc/stats than calculate 40* 8 ( metrics/core) averages values. > > It also makes to have simpler config files ( avoiding average plugin). > > I will do a pull request in next days on this week. > > Thanks a lot !! > > > 2013/11/16 Otis Gospodnetic <[email protected]> > > > Hi Toni, > > > > Would it be better to issue a PR at > > https://github.com/collectd/collectdinstead? > > > > Q: why is this approach better than using the aggregate functionality? > > > > Thanks, > > Otis > > -- > > Performance Monitoring * Log Analytics * Search Analytics > > Solr & Elasticsearch Support * http://sematext.com/ > > > > > > On Wed, Nov 6, 2013 at 8:24 AM, Toni Moreno <[email protected]> wrote: > > > >> Hi. > >> > >> I've been working on get global average CPU , from the cpu plugin better > >> than use the "aggregate" to get the same values. > >> > >> I've attached a patch for the cpu plugin. > >> > >> with this patch you will get a new "plugin-instance" named "global" , > >> with % average of all cpu cores . > >> > >> I've obtained these values from the same proc file that cpu plugin uses > >> for the other cores. > >> > >> NOTE: This patch is only for linux. > >> > >> > >> I hope you can enjoy it > >> > >> > >> > >> > >> -- > >> > >> Att > >> > >> Toni Moreno > >> > >> 699706656 > >> > >> > >> > >> *Si no quieres perderte en el olvido tan pronto como est?s muerto y > >> corrompido, * > >> > >> *escribe cosas dignas de leerse, o haz cosas dignas de escribirse.* > >> > >> > >> > >> *Benjamin Franklin* > >> > >> _______________________________________________ > >> collectd mailing list > >> [email protected] > >> http://mailman.verplant.org/listinfo/collectd > >> > >> > > > > > -- > > Att > > Toni Moreno > > 699706656 > > > > *Si no quieres perderte en el olvido tan pronto como est?s muerto y > corrompido, * > > *escribe cosas dignas de leerse, o haz cosas dignas de escribirse.* > > > > *Benjamin Franklin* > _______________________________________________ > collectd mailing list > [email protected] > http://mailman.verplant.org/listinfo/collectd _______________________________________________ collectd mailing list [email protected] http://mailman.verplant.org/listinfo/collectd
