Hi Francesco, Could you give us an estimate when you will be able to open PR? We're interested in extending virt plugin metrics. However, given your work it seems counterproductive to change current implementation now.
Regards, Przemek -----Original Message----- From: collectd [mailto:[email protected]] On Behalf Of Francesco Romani Sent: Friday, November 11, 2016 7:38 AM To: Florian Forster <[email protected]> Cc: [email protected] Subject: Re: [collectd] [RFC] virt2: a rewrite of the virt plugin ----- Original Message ----- > From: "Florian Forster" <[email protected]> > To: "Francesco Romani" <[email protected]> > Cc: [email protected] > Sent: Thursday, November 10, 2016 6:42:53 PM > Subject: Re: [collectd] [RFC] virt2: a rewrite of the virt plugin > > > > Hi Francesco, > > Thank you for reaching out! I think a rewrite is probably better than adding > a plugin doing the same as another, existing plugin – that will confuse > users and increased our maintenance burden. However, this would require that > the observable behavior stays the same: same config options and the same > metric names, primarily. Hi Florian! Those requirements are fine by me. We definitely can keep the same config options, and we are fine with the existing metric names. > I'm happy to review a design document if you have one – that makes it much > easier to understand pull requests and expedites pull requests. I'll make sure to provide such document shortly before, worst case together, with my pull request. Thanks for the feedback, -- Francesco Romani Red Hat Engineering Virtualization R & D Phone: 8261328 IRC: fromani _______________________________________________ collectd mailing list [email protected] https://mailman.verplant.org/listinfo/collectd -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. _______________________________________________ collectd mailing list [email protected] https://mailman.verplant.org/listinfo/collectd
