Hi Matthias, Thanks for your mail, this is very easy. I have done exactly that, and now it's "all checks passed" :-)
Thanks! Marco van Tol > Op 24 apr. 2019, om 09:47 heeft Matthias Runge <[email protected]> het > volgende geschreven: > > On Tue, Apr 23, 2019 at 11:31:27PM +0200, Marco van Tol wrote: > Marco, > > the ChangeLog feature asks for adding a description to the commit > message, see here: > > https://github.com/collectd/collectd/blob/master/docs/CONTRIBUTING.md#changelog > > Another example is here: https://github.com/collectd/collectd/pull/3139 > > Hope that helps, > > Matthias > >> Hi Pavel, >> >> I created a PR now, requesting to merge ometol/collectd:master into >> collectd/collectd:master. >> >> It complains about that I did not update ChangeLog. >> After looking at that file I can of course add a date and a line to it >> indicating what I did. >> Do you want me to do this? >> >> Many thanks in advance! >> >> Marco van Tol >> >> >> >>> Op 23 apr. 2019, om 19:59 heeft Marco van Tol <[email protected]> het volgende >>> geschreven: >>> >>> Hi Pavel, >>> >>> Many thanks for your advise. I'll do what you suggest soon. >>> >>> Marco van Tol >>> >>> >>> >>>> Op 23 apr. 2019, om 19:50 heeft Pavel <[email protected]> het volgende >>>> geschreven: >>>> >>>> 23.04.2019 23:03, Marco van Tol : >>>> >>>> Hi, Marco! >>>> >>>> For your work to be merged into upstream branch, you have to do Pull >>>> Request on Github. >>>> >>>> Also, 'src/collectd.conf.pod' file needs to be updated too. Can you please >>>> do that? >>>> "This plugin is available on Linux and FreeBSD only" >>>> "On Linux, it reads ... " + "On FreeBSD, ... " >>>> >>>> If you do PR on GitHub I will take some care about future steps. >>>> >>>> Thanks for your work on Collectd! >>>> >>>>> Hi there, >>>>> >>>>> This is my first time I do something like a pull request. >>>>> >>>>> Please see attached patch that will allow FreeBSD systems to also enjoy >>>>> the cpufreq plugin. >>>>> >>>>> The github fork of my work can be found here: >>>>> >>>>> https://github.com/ometol/collectd >>>>> >>>>> >>>>> Does this give you enough to consider a merge, or is there anything else >>>>> I should provide? >>>>> >>>>> Thank you very much in advance! >>>>> >>>>> Marco van Tol >>>>> >>>> >>>> >>>> >>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> collectd mailing list >>>>> >>>>> [email protected] >>>>> https://mailman.verplant.org/listinfo/collectd >>>> >>>> >>>> >>> >>> -- >>> Marco van Tol >>> >>> >> >> -- >> Marco van Tol >> >> >> _______________________________________________ >> collectd mailing list >> [email protected] >> https://mailman.verplant.org/listinfo/collectd > > -- > Matthias Runge <[email protected]> > > _______________________________________________ > collectd mailing list > [email protected] > https://mailman.verplant.org/listinfo/collectd -- Marco van Tol _______________________________________________ collectd mailing list [email protected] https://mailman.verplant.org/listinfo/collectd
