Hello community,

here is the log from the commit of package yast2-security for openSUSE:Factory 
checked in at 2020-12-15 12:30:52
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-security (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-security.new.2328 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-security"

Tue Dec 15 12:30:52 2020 rev:98 rq:855797 version:4.3.6

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-security/yast2-security.changes    
2020-12-12 20:30:32.337737768 +0100
+++ /work/SRC/openSUSE:Factory/.yast2-security.new.2328/yast2-security.changes  
2020-12-15 12:33:04.752130584 +0100
@@ -1,0 +2,7 @@
+Mon Dec 14 14:49:26 UTC 2020 - schubi <schubi@intern>
+
+- Removed obsolete setting DISPLAYMANAGER_SHUTDOWN from
+  /etc/sysconfig/displaymanager (bsc#1175495).
+- 4.3.6 
+
+-------------------------------------------------------------------

Old:
----
  yast2-security-4.3.5.tar.bz2

New:
----
  yast2-security-4.3.6.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-security.spec ++++++
--- /var/tmp/diff_new_pack.Bp2qLM/_old  2020-12-15 12:33:05.260130993 +0100
+++ /var/tmp/diff_new_pack.Bp2qLM/_new  2020-12-15 12:33:05.264130996 +0100
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-security
-Version:        4.3.5
+Version:        4.3.6
 Release:        0
 Summary:        YaST2 - Security Configuration
 License:        GPL-2.0-only

++++++ yast2-security-4.3.5.tar.bz2 -> yast2-security-4.3.6.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-security-4.3.5/.rubocop.yml 
new/yast2-security-4.3.6/.rubocop.yml
--- old/yast2-security-4.3.5/.rubocop.yml       2020-12-11 14:02:54.000000000 
+0100
+++ new/yast2-security-4.3.6/.rubocop.yml       2020-12-14 17:21:01.000000000 
+0100
@@ -210,7 +210,7 @@
 # Offense count: 7
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 757
+  Max: 760
 
 # Offense count: 20
 Metrics/PerceivedComplexity:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-security-4.3.5/package/yast2-security.changes 
new/yast2-security-4.3.6/package/yast2-security.changes
--- old/yast2-security-4.3.5/package/yast2-security.changes     2020-12-11 
14:02:54.000000000 +0100
+++ new/yast2-security-4.3.6/package/yast2-security.changes     2020-12-14 
17:21:01.000000000 +0100
@@ -1,4 +1,11 @@
 -------------------------------------------------------------------
+Mon Dec 14 14:49:26 UTC 2020 - schubi <schubi@intern>
+
+- Removed obsolete setting DISPLAYMANAGER_SHUTDOWN from
+  /etc/sysconfig/displaymanager (bsc#1175495).
+- 4.3.6 
+
+-------------------------------------------------------------------
 Fri Dec 11 11:24:05 UTC 2020 - schubi <schubi@localhost>
 
 - Removed handling of obsolete entry SYSTOHC in /etc/sysconfig/clock
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-security-4.3.5/package/yast2-security.spec 
new/yast2-security-4.3.6/package/yast2-security.spec
--- old/yast2-security-4.3.5/package/yast2-security.spec        2020-12-11 
14:02:54.000000000 +0100
+++ new/yast2-security-4.3.6/package/yast2-security.spec        2020-12-14 
17:21:01.000000000 +0100
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-security
-Version:        4.3.5
+Version:        4.3.6
 Release:        0
 Group:          System/YaST
 License:        GPL-2.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-security-4.3.5/src/include/security/dialogs.rb 
new/yast2-security-4.3.6/src/include/security/dialogs.rb
--- old/yast2-security-4.3.5/src/include/security/dialogs.rb    2020-12-11 
14:02:54.000000000 +0100
+++ new/yast2-security-4.3.6/src/include/security/dialogs.rb    2020-12-14 
17:21:01.000000000 +0100
@@ -550,11 +550,18 @@
     end
 
     def vbox_boot_permissions
+      display_manager_widget = Empty()
+      if @display_manager && !@display_manager.shutdown_var_name.empty?
+        display_manager_widget = VBox(
+          VSpacing(1.0),
+          settings2widget(@display_manager.shutdown_var_name)
+        )
+      end
+
       VBox(
         VSpacing(1),
         settings2widget("CONSOLE_SHUTDOWN"),
-        @display_manager ? VSpacing(1.0) : Empty(),
-        @display_manager ? settings2widget(@display_manager.shutdown_var_name) 
: Empty(),
+        display_manager_widget,
         VSpacing(1.0),
         settings2widget("HIBERNATE_SYSTEM"),
         VSpacing(1)
@@ -635,7 +642,9 @@
 
       if ret == :next || Builtins.contains(@tree_dialogs, ret)
         widget2settings("CONSOLE_SHUTDOWN")
-        widget2settings(@display_manager.shutdown_var_name) if @display_manager
+        if @display_manager && !@display_manager.shutdown_var_name.empty?
+          widget2settings(@display_manager.shutdown_var_name)
+        end
         widget2settings("HIBERNATE_SYSTEM")
       end
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-security-4.3.5/src/include/security/widgets.rb 
new/yast2-security-4.3.6/src/include/security/widgets.rb
--- old/yast2-security-4.3.5/src/include/security/widgets.rb    2020-12-11 
14:02:54.000000000 +0100
+++ new/yast2-security-4.3.6/src/include/security/widgets.rb    2020-12-14 
17:21:01.000000000 +0100
@@ -265,7 +265,7 @@
 
       @WIDGETS.merge!(
         @display_manager.shutdown_var_name => shutdown_login_manager_widget
-      ) if @display_manager
+      ) if @display_manager && !@display_manager.shutdown_var_name.empty?
     end
 
     def shutdown_login_manager_widget
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-security-4.3.5/src/lib/security/display_manager.rb 
new/yast2-security-4.3.6/src/lib/security/display_manager.rb
--- old/yast2-security-4.3.5/src/lib/security/display_manager.rb        
2020-12-11 14:02:54.000000000 +0100
+++ new/yast2-security-4.3.6/src/lib/security/display_manager.rb        
2020-12-14 17:21:01.000000000 +0100
@@ -51,27 +51,23 @@
     end
 
     def default_settings
-      { shutdown_var_name => shutdown_default_value }
+      kdm? ? { "AllowShutdown" => "All" } : {}
     end
 
     def shutdown_var_name
-      @shutdown_var_name ||= kdm? ? "AllowShutdown" : "DISPLAYMANAGER_SHUTDOWN"
+      @shutdown_var_name ||= kdm? ? "AllowShutdown" : ""
     end
 
     def shutdown_default_value
-      @shutdown_default_value ||= kdm? ? "All" : "all"
+      @shutdown_default_value ||= kdm? ? "All" : ""
     end
 
     def shutdown_options
-      @shutdown_options ||= kdm? ? ["Root", "All", "None"] : ["root", "all", 
"none"]
+      @shutdown_options ||= kdm? ? ["Root", "All", "None"] : []
     end
 
     def default_locations
-      sysconfig_locations = SYSCONFIG_COMMON_LOCATIONS
-      sysconfig_locations << shutdown_var_name if !kdm?
-
-      locations = { ".sysconfig.displaymanager" => sysconfig_locations }
-
+      locations = { ".sysconfig.displaymanager" => SYSCONFIG_COMMON_LOCATIONS }
       locations[".kde4.kdmrc"] = ["AllowShutdown"] if kdm?
 
       locations
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-security-4.3.5/test/security_test.rb 
new/yast2-security-4.3.6/test/security_test.rb
--- old/yast2-security-4.3.5/test/security_test.rb      2020-12-11 
14:02:54.000000000 +0100
+++ new/yast2-security-4.3.6/test/security_test.rb      2020-12-14 
17:21:01.000000000 +0100
@@ -661,10 +661,6 @@
           Security.init_settings
         end
 
-        it "allows everybody to shutdown by default" do
-          expect(Security.Settings["DISPLAYMANAGER_SHUTDOWN"]).to eql("all")
-        end
-
         it "sets login definitions based on /etc/login.defs" do
           Security.read_from_locations
           expect(Security.Settings["FAIL_DELAY"]).to eql("3")
@@ -675,7 +671,6 @@
           expect(Security.Settings["DISPLAYMANAGER_REMOTE_ACCESS"]).to 
eql("yes")
           expect(Security.Settings["DISPLAYMANAGER_ROOT_LOGIN_REMOTE"]).to 
eql("yes")
           
expect(Security.Settings["DISPLAYMANAGER_XSERVER_TCP_PORT_6000_OPEN"]).to 
eql("no")
-          expect(Security.Settings["DISPLAYMANAGER_SHUTDOWN"]).to eql("all")
           expect(Security.Settings["PERMISSION_SECURITY"]).to eql("easy local")
           expect(Security.Settings["DISABLE_RESTART_ON_UPDATE"]).to eql("no")
         end
_______________________________________________
openSUSE Commits mailing list -- [email protected]
To unsubscribe, email [email protected]
List Netiquette: https://en.opensuse.org/openSUSE:Mailing_list_netiquette
List Archives: 
https://lists.opensuse.org/archives/list/[email protected]

Reply via email to