Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package remmina for openSUSE:Factory checked in at 2021-02-09 21:16:36 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/remmina (Old) and /work/SRC/openSUSE:Factory/.remmina.new.28504 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "remmina" Tue Feb 9 21:16:36 2021 rev:62 rq:870294 version:1.4.11 Changes: -------- --- /work/SRC/openSUSE:Factory/remmina/remmina.changes 2020-12-11 20:16:54.896664592 +0100 +++ /work/SRC/openSUSE:Factory/.remmina.new.28504/remmina.changes 2021-02-09 21:16:36.994797831 +0100 @@ -1,0 +2,61 @@ +Mon Feb 8 12:01:39 UTC 2021 - Johannes Weberhofer <[email protected]> + +- Added fix_upstream_2196_older_glib_issue.patch to allow building with + older glib versions + +------------------------------------------------------------------- +Sun Feb 7 11:22:53 UTC 2021 - Johannes Weberhofer <[email protected]> + +- Added fix_upstream_2195_spice_plugin.patch to allow building on older + opensuse versions + +------------------------------------------------------------------- +Wed Feb 3 15:41:22 UTC 2021 - Johannes Weberhofer <[email protected]> + +- Update to release 1.4.11 + * New features: + - Implementing simple SSH multi factor authentication. + !2162 (merged) @antenore + - Implementing dynamic resolution in SPICE plugin + !2150 (merged) @hadogenes + - Disabling Python support by default !2158 (merged) @antenore + - Add capability to load Python plugins (not finished). + !2157 (merged) @ToolsDevler + + * Improvements + - Suppress Output PDU when the RDP window is not visible + !2159 (merged) @antenore + - Several improvements on spelling + - Command line help improvements !2185 (merged) @antenore + - Improving error detection !2181 (merged) @antenore + - Using curly double quotes where possible !2182 (merged) @antenore + - Refactoring the RCW toolbar to use the right tool items types + !2188 (merged) @antenore + + * Fixes + - rdp/cliprdr: Fix header of FormatList message !2147 (merged) @pnowack + - rdp/event: Fix wheel value for GDK_SCROLL_DOWN events !2149 (merged) @pnowack + - Resolve "Remmina does not handle file:///some/path/to/file.rdp syntax" + !2152 (merged) @antenore + - Resolve "SSH tunneling, honoring ssh_config (User, HostKeyAlias, + ProxyJump, HostKeyAlgorithms, IdentitiesOnly, etc.)" + !2154 (merged) @antenore + - Resolve "While in the main window, bind F10 keyboard shortcut to + toggling the main menubutton" !2156 (merged) @antenore + - Refactoring SSH plugin !2160 (merged) @antenore + - Remove extra parenthesis !2164 (merged) @yurchor + - Spice option to choose Prefered Video Codec and Image Compressor + !2165 (merged) @hadogenes + - Correct iterating lines in string - address sanitizer fix #2390 (closed) + !2174 (merged) @hadogenes + - Correct freeing memory in spice !2175 (merged) @hadogenes + - Issue/2391 randomness !2176 (merged) @antenore + - Resolve "Missing keyboard shortcuts to toggle search (Ctrl+F, Escape), + and closing the search doesn't clear the search" !2179 (merged) @antenore + - Resolve "Always false contition in remmina_ssh.c" !2180 (merged) @antenore + - Fix minor typo !2186 (merged) @yurchor + - Resolve "Remmina Crashes when opening the preferences with the accelerator" + !2189 (merged) @antenore + - Fixing #2401 (closed) - crash when using ctrl+p !2190 (merged) @antenore + +------------------------------------------------------------------- Old: ---- Remmina-v1.4.10.tar.bz2 New: ---- Remmina-v1.4.11.tar.bz2 fix_upstream_2195_spice_plugin.patch fix_upstream_2196_older_glib_issue.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ remmina.spec ++++++ --- /var/tmp/diff_new_pack.3JrFgt/_old 2021-02-09 21:16:37.934798900 +0100 +++ /var/tmp/diff_new_pack.3JrFgt/_new 2021-02-09 21:16:37.938798903 +0100 @@ -1,7 +1,7 @@ # # spec file for package remmina # -# Copyright (c) 2020 SUSE LLC +# Copyright (c) 2021 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -18,13 +18,17 @@ %bcond_with nx Name: remmina -Version: 1.4.10 +Version: 1.4.11 Release: 0 Summary: Versatile Remote Desktop Client License: GPL-2.0-or-later Group: Productivity/Networking/Other URL: https://www.remmina.org/ Source0: https://gitlab.com/Remmina/Remmina/-/archive/v%{version}/Remmina-v%{version}.tar.bz2 +#PATCH-FIX-UPSTREAM fix_upstream_2195_spice_plugin.patch [email protected] -- fix for older opensuse versions +Patch0: fix_upstream_2195_spice_plugin.patch +#PATCH-FIX-UPSTREAM fix_upstream_2196_older_glib_issue.patch [email protected] -- fix for buildng with older glib versions +Patch1: fix_upstream_2196_older_glib_issue.patch BuildRequires: cmake BuildRequires: cups-devel BuildRequires: ed ++++++ Remmina-v1.4.10.tar.bz2 -> Remmina-v1.4.11.tar.bz2 ++++++ ++++ 184276 lines of diff (skipped) ++++++ fix_upstream_2195_spice_plugin.patch ++++++ >From 93709309fe7da80d3bbab4e138d01291d14b3b05 Mon Sep 17 00:00:00 2001 From: Jacek Szafarkiewicz <[email protected]> Date: Sat, 6 Feb 2021 23:52:15 +0100 Subject: [PATCH] Add ifdefs for spice version less then 0.38 (fix #2408) --- plugins/spice/spice_plugin.c | 54 +++++++++++++++++++++++++++++++++--- 1 file changed, 50 insertions(+), 4 deletions(-) diff --git a/plugins/spice/spice_plugin.c b/plugins/spice/spice_plugin.c index 0c91fe821..f03247c16 100644 --- a/plugins/spice/spice_plugin.c +++ b/plugins/spice/spice_plugin.c @@ -348,8 +348,6 @@ static void remmina_plugin_spice_display_ready_cb(GObject *display, GParamSpec * g_object_get(display, "ready", &ready, NULL); if (ready) { - SpiceVideoCodecType videocodec; - SpiceImageCompression imagecompression; RemminaPluginSpiceData *gpdata = GET_PLUGIN_DATA(gp); RemminaFile *remminafile = remmina_plugin_service->protocol_plugin_get_file(gp); @@ -363,8 +361,11 @@ static void remmina_plugin_spice_display_ready_cb(GObject *display, GParamSpec * "resize-guest", (scaleMode == REMMINA_PROTOCOL_WIDGET_SCALE_MODE_DYNRES), NULL); - videocodec = remmina_plugin_service->file_get_int(remminafile, "videocodec", 0); +#ifdef SPICE_GTK_CHECK_VERSION +# if SPICE_GTK_CHECK_VERSION(0, 34, 0) + SpiceVideoCodecType videocodec = remmina_plugin_service->file_get_int(remminafile, "videocodec", 0); if (videocodec) { +# if SPICE_GTK_CHECK_VERSION(0, 38, 0) GError *err = NULL; guint i; @@ -388,13 +389,32 @@ static void remmina_plugin_spice_display_ready_cb(GObject *display, GParamSpec * } g_clear_pointer(&preferred_codecs, g_array_unref); + +# elif SPICE_GTK_CHECK_VERSION(0, 35, 0) + spice_display_channel_change_preferred_video_codec_type(SPICE_CHANNEL(gpdata->display_channel), + videocodec); +# else + spice_display_change_preferred_video_codec_type(SPICE_CHANNEL(gpdata->display_channel), + videocodec); +# endif } +# endif +#endif - imagecompression = remmina_plugin_service->file_get_int(remminafile, "imagecompression", 0); +#ifdef SPICE_GTK_CHECK_VERSION +# if SPICE_GTK_CHECK_VERSION(0, 31, 0) + SpiceImageCompression imagecompression = remmina_plugin_service->file_get_int(remminafile, "imagecompression", 0); if (imagecompression) { +# if SPICE_GTK_CHECK_VERSION(0, 35, 0) spice_display_channel_change_preferred_compression(SPICE_CHANNEL(gpdata->display_channel), imagecompression); +# else + spice_display_change_preferred_compression(SPICE_CHANNEL(gpdata->display_channel), + imagecompression); +# endif } +# endif +#endif gtk_container_add(GTK_CONTAINER(gp), GTK_WIDGET(display)); gtk_widget_show(GTK_WIDGET(display)); @@ -496,6 +516,8 @@ static void remmina_plugin_spice_call_feature(RemminaProtocolWidget *gp, const R } } +#ifdef SPICE_GTK_CHECK_VERSION +# if SPICE_GTK_CHECK_VERSION(0, 34, 0) /* Array of key/value pairs for prefered video codec * Key - SpiceVideoCodecType (spice/enums.h) */ @@ -509,7 +531,11 @@ static gpointer videocodec_list[] = "5", "h265", NULL }; +# endif +#endif +#ifdef SPICE_GTK_CHECK_VERSION +# if SPICE_GTK_CHECK_VERSION(0, 31, 0) /* Array of key/value pairs for prefered video codec * Key - SpiceImageCompression (spice/enums.h) */ @@ -525,9 +551,15 @@ static gpointer imagecompression_list[] = "7", "LZ4", NULL }; +# endif +#endif +#ifdef SPICE_GTK_CHECK_VERSION +# if SPICE_GTK_CHECK_VERSION(0, 34, 0) static gchar disablegstvideooverlay_tooltip[] = N_("Disable video overlay if videos are not displayed properly.\n"); +# endif +#endif /* Array of RemminaProtocolSetting for basic settings. * Each item is composed by: @@ -559,9 +591,15 @@ static const RemminaProtocolSetting remmina_plugin_spice_basic_settings[] = */ static const RemminaProtocolSetting remmina_plugin_spice_advanced_settings[] = { +#ifdef SPICE_GTK_CHECK_VERSION +# if SPICE_GTK_CHECK_VERSION(0, 35, 0) { REMMINA_PROTOCOL_SETTING_TYPE_SELECT, "videocodec", N_("Prefered video codec"), FALSE, videocodec_list, NULL}, { REMMINA_PROTOCOL_SETTING_TYPE_CHECK, "disablegstvideooverlay", N_("Turn off GStreamer overlay"), FALSE, NULL, disablegstvideooverlay_tooltip}, +# endif +# if SPICE_GTK_CHECK_VERSION(0, 31, 0) { REMMINA_PROTOCOL_SETTING_TYPE_SELECT, "imagecompression", N_("Prefered image compression"), FALSE, imagecompression_list, NULL}, +# endif +#endif { REMMINA_PROTOCOL_SETTING_TYPE_CHECK, "disableclipboard", N_("No clipboard sync"), TRUE, NULL, NULL}, { REMMINA_PROTOCOL_SETTING_TYPE_CHECK, "disablepasswordstoring", N_("Forget passwords after use"), TRUE, NULL, NULL}, { REMMINA_PROTOCOL_SETTING_TYPE_CHECK, "enableaudio", N_("Enable audio channel"), TRUE, NULL, NULL}, @@ -625,6 +663,8 @@ void remmina_plugin_spice_remove_list_option(gpointer *option_list, const gchar *dst = NULL; } +#ifdef SPICE_GTK_CHECK_VERSION +# if SPICE_GTK_CHECK_VERSION(0, 31, 0) gboolean remmina_plugin_spice_is_lz4_supported() { gboolean result = FALSE; GOptionContext *context; @@ -659,6 +699,8 @@ gboolean remmina_plugin_spice_is_lz4_supported() { return result; } +# endif +#endif G_MODULE_EXPORT gboolean remmina_plugin_entry(RemminaPluginService *service) @@ -669,11 +711,15 @@ remmina_plugin_entry(RemminaPluginService *service) bindtextdomain(GETTEXT_PACKAGE, REMMINA_RUNTIME_LOCALEDIR); bind_textdomain_codeset(GETTEXT_PACKAGE, "UTF-8"); +#ifdef SPICE_GTK_CHECK_VERSION +# if SPICE_GTK_CHECK_VERSION(0, 31, 0) if (!remmina_plugin_spice_is_lz4_supported()) { char key_str[10]; sprintf(key_str, "%d", SPICE_IMAGE_COMPRESSION_LZ4); remmina_plugin_spice_remove_list_option(imagecompression_list, key_str); } +# endif +#endif if (!service->register_plugin((RemminaPlugin*)&remmina_plugin_spice)) { return FALSE; -- GitLab ++++++ fix_upstream_2196_older_glib_issue.patch ++++++ >From 04eb76c1de7a1bd2998ecb0615b90436a3ec4f80 Mon Sep 17 00:00:00 2001 From: Antenore Gatta <[email protected]> Date: Mon, 8 Feb 2021 07:43:08 +0100 Subject: [PATCH] Ignoring glib functions if glib version older then 2.56 Closes #2409 --- src/remmina.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/remmina.c b/src/remmina.c index 344a37638..53c1fc4ff 100644 --- a/src/remmina.c +++ b/src/remmina.c @@ -322,7 +322,6 @@ int main(int argc, char *argv[]) TRACE_CALL(__func__); GtkApplication *app; const gchar *app_id; - gchar *summary; int status; g_unsetenv("GDK_CORE_DEVICE_EVENTS"); @@ -368,7 +367,8 @@ int main(int argc, char *argv[]) g_set_prgname(app_id); #endif g_application_add_main_option_entries(G_APPLICATION(app), remmina_options); - summary = g_strdup_printf ("%s %s", app_id, VERSION); +#if GLIB_CHECK_VERSION(2,56,0) + gchar *summary = g_strdup_printf ("%s %s", app_id, VERSION); g_application_set_option_context_summary (G_APPLICATION(app), summary); g_free(summary); // TRANSLATORS: Shown in terminal. Do not use characters that may be not supported on a terminal @@ -402,6 +402,7 @@ int main(int argc, char *argv[]) "To update username and password and set a different resolution mode of a Remmina connection profile, use:\n" "\n" "\techo \"username\\napassword\" | remmina --update-profile /PATH/TO/FOO.remmina --set-option username --set-option resolution_mode=2 --set-option password\n")); +#endif g_signal_connect(app, "startup", G_CALLBACK(remmina_on_startup), NULL); g_signal_connect(app, "command-line", G_CALLBACK(remmina_on_command_line), NULL); -- GitLab
