Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package kguiaddons for openSUSE:Factory checked in at 2021-02-17 18:10:51 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kguiaddons (Old) and /work/SRC/openSUSE:Factory/.kguiaddons.new.28504 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kguiaddons" Wed Feb 17 18:10:51 2021 rev:87 rq:871695 version:5.79.0 Changes: -------- --- /work/SRC/openSUSE:Factory/kguiaddons/kguiaddons.changes 2021-01-13 18:17:45.169076734 +0100 +++ /work/SRC/openSUSE:Factory/.kguiaddons.new.28504/kguiaddons.changes 2021-02-17 18:12:02.193964978 +0100 @@ -1,0 +2,9 @@ +Mon Feb 8 08:46:20 UTC 2021 - Christophe Giboudeaux <[email protected]> + +- Update to 5.79.0 + * New feature release + * For more details please see: + * https://kde.org/announcements/kde-frameworks-5.79.0 +- No code change since 5.78.0 + +------------------------------------------------------------------- Old: ---- kguiaddons-5.78.0.tar.xz kguiaddons-5.78.0.tar.xz.sig New: ---- kguiaddons-5.79.0.tar.xz kguiaddons-5.79.0.tar.xz.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kguiaddons.spec ++++++ --- /var/tmp/diff_new_pack.5zoWwm/_old 2021-02-17 18:12:02.789965466 +0100 +++ /var/tmp/diff_new_pack.5zoWwm/_new 2021-02-17 18:12:02.793965469 +0100 @@ -17,7 +17,7 @@ %define lname libKF5GuiAddons5 -%define _tar_path 5.78 +%define _tar_path 5.79 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) @@ -25,7 +25,7 @@ # Only needed for the package signature condition %bcond_without lang Name: kguiaddons -Version: 5.78.0 +Version: 5.79.0 Release: 0 Summary: Utilities for graphical user interfaces License: LGPL-2.1-or-later ++++++ kguiaddons-5.78.0.tar.xz -> kguiaddons-5.79.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/.gitignore new/kguiaddons-5.79.0/.gitignore --- old/kguiaddons-5.78.0/.gitignore 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/.gitignore 2021-01-30 18:35:37.000000000 +0100 @@ -20,3 +20,4 @@ CMakeLists.txt.user* *.unc-backup* .cmake/ +/.clang-format diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/CMakeLists.txt new/kguiaddons-5.79.0/CMakeLists.txt --- old/kguiaddons-5.78.0/CMakeLists.txt 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/CMakeLists.txt 2021-01-30 18:35:37.000000000 +0100 @@ -1,10 +1,10 @@ cmake_minimum_required(VERSION 3.5) -set(KF5_VERSION "5.78.0") # handled by release scripts +set(KF5_VERSION "5.79.0") # handled by release scripts project(KGuiAddons VERSION ${KF5_VERSION}) include(FeatureSummary) -find_package(ECM 5.78.0 NO_MODULE) +find_package(ECM 5.79.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://commits.kde.org/extra-cmake-modules") feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/src/CMakeLists.txt new/kguiaddons-5.79.0/src/CMakeLists.txt --- old/kguiaddons-5.78.0/src/CMakeLists.txt 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/src/CMakeLists.txt 2021-01-30 18:35:37.000000000 +0100 @@ -66,7 +66,7 @@ ${XCB_XCB_INCLUDE_DIR} ) target_link_libraries(kmodifierkey_xcb PRIVATE ${X11_LIBRARIES} ${XCB_XCB_LIBRARY} Qt5::X11Extras KF5::GuiAddons) - install( TARGETS kmodifierkey_xcb DESTINATION ${PLUGIN_INSTALL_DIR}/kf5/kguiaddons/kmodifierkey/) + install( TARGETS kmodifierkey_xcb DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf5/kguiaddons/kmodifierkey/) endif() endif () diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/src/colors/kcolorcollection.cpp new/kguiaddons-5.79.0/src/colors/kcolorcollection.cpp --- old/kguiaddons-5.78.0/src/colors/kcolorcollection.cpp 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/src/colors/kcolorcollection.cpp 2021-01-30 18:35:37.000000000 +0100 @@ -13,13 +13,14 @@ #include <QTextStream> #include <QSaveFile> #include <QStandardPaths> +#include <QSharedData> //BEGIN KColorCollectionPrivate -class KColorCollectionPrivate +class KColorCollectionPrivate : public QSharedData { public: KColorCollectionPrivate(const QString &); - KColorCollectionPrivate(const KColorCollectionPrivate &); + KColorCollectionPrivate(const KColorCollectionPrivate &) = default; ~KColorCollectionPrivate() {} struct ColorNode { ColorNode(const QColor &c, const QString &n) @@ -88,11 +89,6 @@ } } } - -KColorCollectionPrivate::KColorCollectionPrivate(const KColorCollectionPrivate &p) - : colorList(p.colorList), name(p.name), desc(p.desc), editable(p.editable) -{ -} //END KColorCollectionPrivate QStringList KColorCollection::installedCollections() @@ -111,20 +107,14 @@ } KColorCollection::KColorCollection(const QString &name) + : d(new KColorCollectionPrivate(name)) { - d = new KColorCollectionPrivate(name); } -KColorCollection::KColorCollection(const KColorCollection &p) -{ - d = new KColorCollectionPrivate(*p.d); -} +KColorCollection::KColorCollection(const KColorCollection &p) = default; -KColorCollection::~KColorCollection() -{ - // Need auto-save? - delete d; -} +// Need auto-save? +KColorCollection::~KColorCollection() = default; bool KColorCollection::save() @@ -139,11 +129,7 @@ QTextStream str(&sf); QString description = d->desc.trimmed(); -#if QT_VERSION < QT_VERSION_CHECK(5, 15, 0) - description = QLatin1Char('#') + description.split(QLatin1Char('\n'), QString::KeepEmptyParts).join(QLatin1String("\n#")); -#else description = QLatin1Char('#') + description.split(QLatin1Char('\n'), Qt::KeepEmptyParts).join(QLatin1String("\n#")); -#endif str << QLatin1String("KDE RGB Palette\n"); str << description << QLatin1Char('\n'); @@ -191,18 +177,7 @@ return d->colorList.count(); } -KColorCollection & -KColorCollection::operator=(const KColorCollection &p) -{ - if (&p == this) { - return *this; - } - d->colorList = p.d->colorList; - d->name = p.d->name; - d->desc = p.d->desc; - d->editable = p.d->editable; - return *this; -} +KColorCollection & KColorCollection::operator=(const KColorCollection &p) = default; QColor KColorCollection::color(int index) const diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/src/colors/kcolorcollection.h new/kguiaddons-5.79.0/src/colors/kcolorcollection.h --- old/kguiaddons-5.78.0/src/colors/kcolorcollection.h 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/src/colors/kcolorcollection.h 2021-01-30 18:35:37.000000000 +0100 @@ -14,6 +14,7 @@ #include <QColor> #include <QString> #include <QStringList> +#include <QSharedDataPointer> /** * @class KColorCollection kcolorcollection.h KColorCollection @@ -188,7 +189,7 @@ const QString &newColorName = QString()); private: - class KColorCollectionPrivate *d; + QSharedDataPointer<class KColorCollectionPrivate> d; }; #endif // KDELIBS_KCOLORCOLLECTION_H diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/src/recorder/keysequencerecorder.h new/kguiaddons-5.79.0/src/recorder/keysequencerecorder.h --- old/kguiaddons-5.78.0/src/recorder/keysequencerecorder.h 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/src/recorder/keysequencerecorder.h 2021-01-30 18:35:37.000000000 +0100 @@ -124,9 +124,10 @@ void currentKeySequenceChanged(); void multiKeyShortcutsAllowedChanged(); void modifierlessAllowedChanged(); + private: friend class KeySequenceRecorderPrivate; - std::unique_ptr<KeySequenceRecorderPrivate> d; + std::unique_ptr<KeySequenceRecorderPrivate> const d; }; #endif diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/src/text/kdatevalidator.cpp new/kguiaddons-5.79.0/src/text/kdatevalidator.cpp --- old/kguiaddons-5.78.0/src/text/kdatevalidator.cpp 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/src/text/kdatevalidator.cpp 2021-01-30 18:35:37.000000000 +0100 @@ -12,7 +12,7 @@ #include <QDate> #include <QLocale> -class Q_DECL_HIDDEN KDateValidator::KDateValidatorPrivate +class KDateValidatorPrivate { public: KDateValidatorPrivate(KDateValidator *q): q(q) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/src/text/kdatevalidator.h new/kguiaddons-5.79.0/src/text/kdatevalidator.h --- old/kguiaddons-5.78.0/src/text/kdatevalidator.h 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/src/text/kdatevalidator.h 2021-01-30 18:35:37.000000000 +0100 @@ -28,9 +28,9 @@ void fixup(QString &input) const override; State date(const QString &text, QDate &date) const; private: - class KDateValidatorPrivate; + // KF6 TODO: add explicit destructor, use std::unique_ptr friend class KDateValidatorPrivate; - KDateValidatorPrivate *const d; + class KDateValidatorPrivate *const d; }; #endif // KDATEVALIDATOR_H diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/src/util/klocalimagecacheimpl.cpp new/kguiaddons-5.79.0/src/util/klocalimagecacheimpl.cpp --- old/kguiaddons-5.78.0/src/util/klocalimagecacheimpl.cpp 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/src/util/klocalimagecacheimpl.cpp 2021-01-30 18:35:37.000000000 +0100 @@ -72,10 +72,7 @@ d->pixmapCache.setMaxCost(qMax(defaultCacheSize / 8, (unsigned int) 16384)); } -KLocalImageCacheImplementation::~KLocalImageCacheImplementation() -{ - delete d; -} +KLocalImageCacheImplementation::~KLocalImageCacheImplementation() = default; void KLocalImageCacheImplementation::updateModifiedTime() { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/src/util/klocalimagecacheimpl.h new/kguiaddons-5.79.0/src/util/klocalimagecacheimpl.h --- old/kguiaddons-5.78.0/src/util/klocalimagecacheimpl.h 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/src/util/klocalimagecacheimpl.h 2021-01-30 18:35:37.000000000 +0100 @@ -8,6 +8,9 @@ #define KLOCALIMAGECACHEIMPL_H #include <kguiaddons_export.h> + +#include <memory> + class KLocalImageCacheImplementationPrivate; class QImage; @@ -46,7 +49,7 @@ void clearLocalCache(); private: - KLocalImageCacheImplementationPrivate *const d; ///< @internal + std::unique_ptr<KLocalImageCacheImplementationPrivate> const d; ///< @internal template<class T> friend class KSharedPixmapCacheMixin; }; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/src/util/kmodifierkeyinfoprovider.cpp new/kguiaddons-5.79.0/src/util/kmodifierkeyinfoprovider.cpp --- old/kguiaddons-5.78.0/src/util/kmodifierkeyinfoprovider.cpp 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/src/util/kmodifierkeyinfoprovider.cpp 2021-01-30 18:35:37.000000000 +0100 @@ -81,13 +81,13 @@ const auto difference = (newState ^ state); state = newState; if (difference & Pressed) { - emit keyPressed(key, newState & Pressed); + Q_EMIT keyPressed(key, newState & Pressed); } if (difference & Latched) { - emit keyLatched(key, newState & Latched); + Q_EMIT keyLatched(key, newState & Latched); } if (difference & Locked) { - emit keyLocked(key, newState & Locked); + Q_EMIT keyLocked(key, newState & Locked); } } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kguiaddons-5.78.0/src/util/kmodifierkeyinfoprovider_xcb.cpp new/kguiaddons-5.79.0/src/util/kmodifierkeyinfoprovider_xcb.cpp --- old/kguiaddons-5.78.0/src/util/kmodifierkeyinfoprovider_xcb.cpp 2021-01-02 13:26:42.000000000 +0100 +++ new/kguiaddons-5.79.0/src/util/kmodifierkeyinfoprovider_xcb.cpp 2021-01-30 18:35:37.000000000 +0100 @@ -259,7 +259,7 @@ newButtonState = (ptr_buttons & it.value()); if (newButtonState != m_buttonStates[it.key()]) { m_buttonStates[it.key()] = newButtonState; - emit buttonPressed(it.key(), newButtonState); + Q_EMIT buttonPressed(it.key(), newButtonState); } } } @@ -311,7 +311,7 @@ // previously unknown modifier if (!m_modifierStates.contains(it->key)) { m_modifierStates.insert(it->key, Nothing); - emit keyAdded(it->key); + Q_EMIT keyAdded(it->key); } } } @@ -323,7 +323,7 @@ if (!m_xkbModifiers.contains(i.key())) { Qt::Key key = i.key(); i.remove(); - emit keyRemoved(key); + Q_EMIT keyRemoved(key); } }
