Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-nfs-client for
openSUSE:Factory checked in at 2021-02-26 21:58:27
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-nfs-client (Old)
and /work/SRC/openSUSE:Factory/.yast2-nfs-client.new.2378 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-nfs-client"
Fri Feb 26 21:58:27 2021 rev:87 rq:873454 version:4.3.3
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-nfs-client/yast2-nfs-client.changes
2020-08-14 13:09:10.693206749 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-nfs-client.new.2378/yast2-nfs-client.changes
2021-02-26 21:58:28.523769387 +0100
@@ -1,0 +2,7 @@
+Thu Feb 18 15:16:03 UTC 2021 - Josef Reidinger <[email protected]>
+
+- Adapted unit test to recent changes in Yast::Report (related to
+ bsc#1179893).
+- 4.3.3
+
+-------------------------------------------------------------------
Old:
----
yast2-nfs-client-4.3.2.tar.bz2
New:
----
yast2-nfs-client-4.3.3.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-nfs-client.spec ++++++
--- /var/tmp/diff_new_pack.EGi4Jz/_old 2021-02-26 21:58:28.983769792 +0100
+++ /var/tmp/diff_new_pack.EGi4Jz/_new 2021-02-26 21:58:28.987769795 +0100
@@ -1,7 +1,7 @@
#
# spec file for package yast2-nfs-client
#
-# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2021 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -12,14 +12,14 @@
# license that conforms to the Open Source Definition (Version 1.9)
# published by the Open Source Initiative.
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
#
Name: yast2-nfs-client
-Version: 4.3.2
+Version: 4.3.3
Release: 0
-Url: https://github.com/yast/yast-nfs-client
+URL: https://github.com/yast/yast-nfs-client
Summary: YaST2 - NFS Configuration
License: GPL-2.0-or-later
Group: System/YaST
++++++ yast2-nfs-client-4.3.2.tar.bz2 -> yast2-nfs-client-4.3.3.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-nfs-client-4.3.2/.github/workflows/ci.yml
new/yast2-nfs-client-4.3.3/.github/workflows/ci.yml
--- old/yast2-nfs-client-4.3.2/.github/workflows/ci.yml 1970-01-01
01:00:00.000000000 +0100
+++ new/yast2-nfs-client-4.3.3/.github/workflows/ci.yml 2021-02-18
16:22:37.000000000 +0100
@@ -0,0 +1,70 @@
+
+# See
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions
+
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+ Tests:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ # just for easier debugging...
+ - name: Inspect Installed Packages
+ run: rpm -qa | sort
+
+ - name: Unit Tests
+ run: rake test:unit
+ # enable code coverage reporting
+ env:
+ COVERAGE: 1
+
+ # send the coverage report to coveralls.io
+ - name: Coveralls Report
+ uses: coverallsapp/github-action@master
+ with:
+ github-token: ${{ secrets.GITHUB_TOKEN }}
+
+ Rubocop:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ - name: Rubocop
+ run: rake check:rubocop
+
+ Package:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ - name: Package Build
+ run: yast-ci-ruby -o package
+
+ # downloading the Docker image takes some time so bundling several fast
+ # checks into one job avoids that overhead
+ Checks:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ - name: POT Check
+ run: rake check:pot
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-nfs-client-4.3.2/.travis.yml
new/yast2-nfs-client-4.3.3/.travis.yml
--- old/yast2-nfs-client-4.3.2/.travis.yml 2020-08-12 12:07:51.000000000
+0200
+++ new/yast2-nfs-client-4.3.3/.travis.yml 1970-01-01 01:00:00.000000000
+0100
@@ -1,11 +0,0 @@
-sudo: required
-language: bash
-services:
- - docker
-
-before_install:
- - docker build -t yast-nfs-client-image .
-script:
- # the "yast-travis-ruby" script is included in the base yastdevel/ruby image
- # see https://github.com/yast/docker-yast-ruby/blob/master/yast-travis-ruby
- - docker run -it -e TRAVIS=1 -e TRAVIS_JOB_ID="$TRAVIS_JOB_ID"
yast-nfs-client-image yast-travis-ruby
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-nfs-client-4.3.2/Dockerfile
new/yast2-nfs-client-4.3.3/Dockerfile
--- old/yast2-nfs-client-4.3.2/Dockerfile 2020-08-12 12:07:51.000000000
+0200
+++ new/yast2-nfs-client-4.3.3/Dockerfile 1970-01-01 01:00:00.000000000
+0100
@@ -1,3 +0,0 @@
-FROM registry.opensuse.org/yast/head/containers/yast-ruby:latest
-COPY . /usr/src/app
-
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-nfs-client-4.3.2/README.md
new/yast2-nfs-client-4.3.3/README.md
--- old/yast2-nfs-client-4.3.2/README.md 2020-08-12 12:07:51.000000000
+0200
+++ new/yast2-nfs-client-4.3.3/README.md 2021-02-18 16:22:37.000000000
+0100
@@ -1,7 +1,8 @@
# YaST - The NFS Client Module #
-[](https://coveralls.io/github/yast/yast-nfs-client?branch=master)
-[](https://travis-ci.org/yast/yast-nfs-client)
-[](https://ci.opensuse.org/view/Yast/job/yast-nfs-client-master/)
-
+[](
+https://github.com/yast/yast-nfs-client/actions?query=branch%3Amaster)
+[](
+https://ci.opensuse.org/view/Yast/job/yast-yast-nfs-client-master/)
+[](https://coveralls.io/r/yast/yast-nfs-client?branch=master)
+[](http://inch-ci.org/github/yast/yast-nfs-client)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-nfs-client-4.3.2/package/yast2-nfs-client.changes
new/yast2-nfs-client-4.3.3/package/yast2-nfs-client.changes
--- old/yast2-nfs-client-4.3.2/package/yast2-nfs-client.changes 2020-08-12
12:07:51.000000000 +0200
+++ new/yast2-nfs-client-4.3.3/package/yast2-nfs-client.changes 2021-02-18
16:22:37.000000000 +0100
@@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Thu Feb 18 15:16:03 UTC 2021 - Josef Reidinger <[email protected]>
+
+- Adapted unit test to recent changes in Yast::Report (related to
+ bsc#1179893).
+- 4.3.3
+
+-------------------------------------------------------------------
Mon Aug 10 17:10:07 CEST 2020 - [email protected]
- AutoYaST: Added supplements: autoyast(nfs) into the spec file
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-nfs-client-4.3.2/package/yast2-nfs-client.spec
new/yast2-nfs-client-4.3.3/package/yast2-nfs-client.spec
--- old/yast2-nfs-client-4.3.2/package/yast2-nfs-client.spec 2020-08-12
12:07:51.000000000 +0200
+++ new/yast2-nfs-client-4.3.3/package/yast2-nfs-client.spec 2021-02-18
16:22:37.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-nfs-client
-Version: 4.3.2
+Version: 4.3.3
Release: 0
Url: https://github.com/yast/yast-nfs-client
Summary: YaST2 - NFS Configuration
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-nfs-client-4.3.2/test/nfs_test.rb
new/yast2-nfs-client-4.3.3/test/nfs_test.rb
--- old/yast2-nfs-client-4.3.2/test/nfs_test.rb 2020-08-12 12:07:51.000000000
+0200
+++ new/yast2-nfs-client-4.3.3/test/nfs_test.rb 2021-02-18 16:22:37.000000000
+0100
@@ -64,7 +64,7 @@
allow(sm).to receive(:probe).and_return true
# prevent storage-commit
- allow(sm).to receive(:commit)
+ allow(sm).to receive(:commit).and_return(true)
end
subject { Yast::Nfs }
@@ -258,7 +258,7 @@
allow(Yast::Progress).to receive(:set)
allow(Yast::Service).to receive(:Enable)
allow(Yast::SCR).to receive(:Execute)
- .with(path(".target.mkdir"), anything)
+ .with(path(".target.mkdir"), anything).and_return(true)
allow(Yast::SCR).to receive(:Write)
.with(path_matching(/^\.sysconfig\.nfs/), any_args)
allow(Yast::SCR).to receive(:Write)
@@ -461,7 +461,7 @@
allow(Yast::Progress).to receive(:set)
allow(Yast::Service).to receive(:Start)
allow(Yast::Service).to receive(:Stop)
- allow(Yast::Service).to receive(:active?)
+ allow(Yast::Service).to receive(:active?).and_return(true)
allow(Yast::Execute).to receive(:locally).and_return(execute_object)
allow_read_side_effects
@@ -485,9 +485,9 @@
.and_return(service_status1, service_status2)
end
- let(:service_status1) { nil }
+ let(:service_status1) { true }
- let(:service_status2) { nil }
+ let(:service_status2) { true }
context "and the portmapper service is not active" do
let(:service_status1) { false }
@@ -515,6 +515,10 @@
context "and the portmapper service was not activated" do
let(:service_status2) { false }
+ before do
+ allow(Yast::Report).to receive(:Error)
+ end
+
it "reports an error" do
expect(Yast::Report).to receive(:Error).with(/Cannot start/)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-nfs-client-4.3.2/test/routines_test.rb
new/yast2-nfs-client-4.3.3/test/routines_test.rb
--- old/yast2-nfs-client-4.3.2/test/routines_test.rb 2020-08-12
12:07:51.000000000 +0200
+++ new/yast2-nfs-client-4.3.3/test/routines_test.rb 2021-02-18
16:22:37.000000000 +0100
@@ -293,6 +293,10 @@
end
end
context "and does not begin with a slash" do
+ before do
+ allow(Yast::Report).to receive(:Error)
+ end
+
it "returns false" do
expect(subject.CheckPath(path.to_s)).to eq(false)
end
@@ -304,10 +308,15 @@
end
end
context "when the given path size is out of the 1..69 range" do
+ before do
+ allow(Yast::Report).to receive(:Error)
+ end
+
it "reports and error" do
expect(Yast::Report).to receive(:Error).with(/The path entered is
invalid/)
subject.CheckPath("/#{path}/verylong")
end
+
it "returns false" do
expect(subject.CheckPath("/#{path}/verylong")).to eq(false)
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-nfs-client-4.3.2/test/spec_helper.rb
new/yast2-nfs-client-4.3.3/test/spec_helper.rb
--- old/yast2-nfs-client-4.3.2/test/spec_helper.rb 2020-08-12
12:07:51.000000000 +0200
+++ new/yast2-nfs-client-4.3.3/test/spec_helper.rb 2021-02-18
16:22:37.000000000 +0100
@@ -28,23 +28,41 @@
require "yast"
require "yast/rspec"
+RSpec.configure do |config|
+ config.mock_with :rspec do |mocks|
+ # If you misremember a method name both in code and in tests,
+ # will save you.
+ #
https://relishapp.com/rspec/rspec-mocks/v/3-0/docs/verifying-doubles/partial-doubles
+ #
+ # With graceful degradation for RSpec 2
+ mocks.verify_partial_doubles = true if
mocks.respond_to?(:verify_partial_doubles=)
+ end
+end
+
if ENV["COVERAGE"]
require "simplecov"
-
- # use coveralls for on-line code coverage reporting at Travis CI
- if ENV["TRAVIS"]
- require "coveralls"
- SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
- SimpleCov::Formatter::HTMLFormatter,
- Coveralls::SimpleCov::Formatter
- ]
+ SimpleCov.start do
+ add_filter "/test/"
end
+ src_location = File.expand_path("../src", __dir__)
# track all ruby files under src
- src_location = File.expand_path("../../src", __FILE__)
SimpleCov.track_files("#{src_location}/**/*.rb")
- SimpleCov.start do
- add_filter "/test/"
+ # additionally use the LCOV format for on-line code coverage reporting at CI
+ if ENV["CI"] || ENV["COVERAGE_LCOV"]
+ require "simplecov-lcov"
+
+ SimpleCov::Formatter::LcovFormatter.config do |c|
+ c.report_with_single_file = true
+ # this is the default Coveralls GitHub Action location
+ # https://github.com/marketplace/actions/coveralls-github-action
+ c.single_report_path = "coverage/lcov.info"
+ end
+
+ SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+ SimpleCov::Formatter::HTMLFormatter,
+ SimpleCov::Formatter::LcovFormatter
+ ]
end
end
