Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2 for openSUSE:Factory checked in at 2021-03-12 13:31:26 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2 (Old) and /work/SRC/openSUSE:Factory/.yast2.new.2401 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2" Fri Mar 12 13:31:26 2021 rev:506 rq:877909 version:4.3.59 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2/yast2.changes 2021-03-08 15:17:10.213934869 +0100 +++ /work/SRC/openSUSE:Factory/.yast2.new.2401/yast2.changes 2021-03-12 13:31:41.530188866 +0100 @@ -1,0 +2,22 @@ +Tue Mar 9 08:23:44 UTC 2021 - David Diaz <[email protected]> + +- Use meaningful button labels when asking the user if would like + to continue when an installation client is missing + (related to bsc#1180594). +- 4.3.59 + +------------------------------------------------------------------- +Mon Mar 8 16:41:27 UTC 2021 - Josef Reidinger <[email protected]> + +- save_y2logs: Make modified content of log files just warning + instead of fatal (bsc#1182710 see comment 2) +- 4.3.58 + +------------------------------------------------------------------- +Mon Mar 8 09:19:37 UTC 2021 - David Diaz <[email protected]> + +- Ask the user if would like to continue when an installation + client is missing (related to bsc#1180594). +- 4.3.57 + +------------------------------------------------------------------- Old: ---- yast2-4.3.56.tar.bz2 New: ---- yast2-4.3.59.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2.spec ++++++ --- /var/tmp/diff_new_pack.Av1mXq/_old 2021-03-12 13:31:42.338190000 +0100 +++ /var/tmp/diff_new_pack.Av1mXq/_new 2021-03-12 13:31:42.338190000 +0100 @@ -17,7 +17,7 @@ Name: yast2 -Version: 4.3.56 +Version: 4.3.59 Release: 0 Summary: YaST2 Main Package License: GPL-2.0-only ++++++ yast2-4.3.56.tar.bz2 -> yast2-4.3.59.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.3.56/library/control/src/modules/ProductControl.rb new/yast2-4.3.59/library/control/src/modules/ProductControl.rb --- old/yast2-4.3.56/library/control/src/modules/ProductControl.rb 2021-03-04 14:03:33.000000000 +0100 +++ new/yast2-4.3.59/library/control/src/modules/ProductControl.rb 2021-03-09 09:41:31.000000000 +0100 @@ -29,6 +29,7 @@ # require "yast" require "yast2/control_log_dir_rotator" +require "yast2/popup" module Yast class ProductControlClass < Module @@ -1336,16 +1337,46 @@ end end - Hooks.run("before_#{step_name}") + client_name = getClientName(step_name, step_execute) - result = WFM.CallFunction(getClientName(step_name, step_execute), args) + # Check if client exist before continuing + if WFM.ClientExists(client_name) + Hooks.run("before_#{step_name}") - # this code will be triggered before the red pop window appears on the user's screen - Hooks.run("installation_failure") if result == false + result = WFM.CallFunction(client_name, args) - result = Convert.to_symbol(result) + # This code will be triggered before the red pop window appears on the user's screen + Hooks.run("installation_failure") if result == false - Hooks.run("after_#{step_name}") + result = result.to_sym + + Hooks.run("after_#{step_name}") + else + # Client not found. Ask the user if want to continue (related to bsc#1180954) + log.error("Client '#{client_name}' not found") + + text = format( + # TRANSLATORS: Message warning the user that a client is missing where %{client} is + # replaced by the client name (e.g. "registration", "user") + _( + "Something went wrong and the expected '%{client}' dialog was not found.\n\n" \ + "Would you like to skip the dialog and continue anyway?" + ), + client: client_name + ) + + options = { yes: Label.ContinueButton, no: Label.AbortButton } + continue = Yast2::Popup.show(text, buttons: options) == :yes + + if continue + log.warn("Continuing after skipping the '#{client_name}' missing client") + # If user decided to continue, uses the former_result (:next or :back) + result = former_result + else + # :abort because user decided to not continue + result = :abort + end + end Builtins.y2milestone("Calling %1 returned %2", argterm, result) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.3.56/package/yast2.changes new/yast2-4.3.59/package/yast2.changes --- old/yast2-4.3.56/package/yast2.changes 2021-03-04 14:03:33.000000000 +0100 +++ new/yast2-4.3.59/package/yast2.changes 2021-03-09 09:41:31.000000000 +0100 @@ -1,4 +1,26 @@ ------------------------------------------------------------------- +Tue Mar 9 08:23:44 UTC 2021 - David Diaz <[email protected]> + +- Use meaningful button labels when asking the user if would like + to continue when an installation client is missing + (related to bsc#1180594). +- 4.3.59 + +------------------------------------------------------------------- +Mon Mar 8 16:41:27 UTC 2021 - Josef Reidinger <[email protected]> + +- save_y2logs: Make modified content of log files just warning + instead of fatal (bsc#1182710 see comment 2) +- 4.3.58 + +------------------------------------------------------------------- +Mon Mar 8 09:19:37 UTC 2021 - David Diaz <[email protected]> + +- Ask the user if would like to continue when an installation + client is missing (related to bsc#1180594). +- 4.3.57 + +------------------------------------------------------------------- Thu Mar 4 12:41:56 UTC 2021 - Josef Reidinger <[email protected]> - Fix backward compatibility for focus parameter of diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.3.56/package/yast2.spec new/yast2-4.3.59/package/yast2.spec --- old/yast2-4.3.56/package/yast2.spec 2021-03-04 14:03:33.000000000 +0100 +++ new/yast2-4.3.59/package/yast2.spec 2021-03-09 09:41:31.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2 -Version: 4.3.56 +Version: 4.3.59 Release: 0 Summary: YaST2 Main Package License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-4.3.56/scripts/save_y2logs new/yast2-4.3.59/scripts/save_y2logs --- old/yast2-4.3.56/scripts/save_y2logs 2021-03-04 14:03:33.000000000 +0100 +++ new/yast2-4.3.59/scripts/save_y2logs 2021-03-09 09:41:31.000000000 +0100 @@ -142,11 +142,14 @@ [ -n "$COMPRESSION" ] && COMPRESSION="--$COMPRESSION" -tar cf "$TARGET" $COMPRESSION --dereference -C / $LIST -C /var/log $LIST_VAR -C $TMPDIR $LIST_TMP +tar cf "$TARGET" --warning=no-file-changed $COMPRESSION --dereference -C / $LIST -C /var/log $LIST_VAR -C $TMPDIR $LIST_TMP err=$? rm -rf $TMPDIR +# tar returns 1 when content of tarball is older than the current system. Happen when something still writting to logs or memsampler (bsc#1182710#c2) +[ $err == 1 ] && echo "Warning: logs modified during save. Yast is probably running. Content of tarball can be older than current content." >&2 && err=0 + [ $err != 0 ] && echo "FATAL: Error creating archive $TARGET" >&2 exit $err
