Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package makedumpfile for openSUSE:Factory checked in at 2024-08-13 13:22:18 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/makedumpfile (Old) and /work/SRC/openSUSE:Factory/.makedumpfile.new.7232 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "makedumpfile" Tue Aug 13 13:22:18 2024 rev:94 rq:1193375 version:1.7.5 Changes: -------- --- /work/SRC/openSUSE:Factory/makedumpfile/makedumpfile.changes 2024-08-07 06:10:33.714715054 +0200 +++ /work/SRC/openSUSE:Factory/.makedumpfile.new.7232/makedumpfile.changes 2024-08-13 13:22:27.412278593 +0200 @@ -1,0 +2,6 @@ +Fri Aug 9 14:51:00 UTC 2024 - Jiri Bohac <[email protected]> + +- add (bsc#1226183) + * make-reserve_diskspace-do-nothing-for-flattened-form.patch + +------------------------------------------------------------------- New: ---- make-reserve_diskspace-do-nothing-for-flattened-form.patch BETA DEBUG BEGIN: New:- add (bsc#1226183) * make-reserve_diskspace-do-nothing-for-flattened-form.patch BETA DEBUG END: ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ makedumpfile.spec ++++++ --- /var/tmp/diff_new_pack.412d8T/_old 2024-08-13 13:22:29.540367260 +0200 +++ /var/tmp/diff_new_pack.412d8T/_new 2024-08-13 13:22:29.556367926 +0200 @@ -42,6 +42,7 @@ Patch2: %{name}-PN_XNUM.patch Patch3: 0001-PATCH-Fix-failure-of-hugetlb-pages-exclusion-on-Linu.patch Patch4: 0002-PATCH-Fix-wrong-exclusion-of-Slab-pages-on-Linux-6.1.patch +Patch5: make-reserve_diskspace-do-nothing-for-flattened-form.patch BuildRequires: libbz2-devel BuildRequires: libdw-devel BuildRequires: libelf-devel ++++++ make-reserve_diskspace-do-nothing-for-flattened-form.patch ++++++ From: Jiri Bohac <[email protected]> Subject: make reserve_diskspace do nothing for flattened format Git-commit: 0bcf67df2114ee932af7e0af3ccafa0b349e90c1 References: bsc#1226183 Acked-by: Jiri Bohac <[email protected]> reserve_diskspace() is called by write_elf_header() to make sure there is always space to write the program header, even if writing other data fails because of ENOSPC. This is harmful when writing the flattened format to STDOUT for two reasons: First, it actually wastes disk space, because first the block of zeroes is sent to STDOUT by reserve_diskspace() and then the actual program header is sent, meant to overwrite the zeroes when the flattened format is rearranged. Second, the algorithm used to read flattened format directly by the crash program does not cope with the flattened file containing two chunks meant for the same offset. It uses a binary search on a sorted array of flat_data headers to find the data in the flat file. It may return the zeroed chunk written by reserve_diskspace() near the beginning of the file instead of the actual ELF header located near the end of the flattened file. Fixes: e39216fce9f73759509ec158e39c289e6c211125 ("Make the incomplete dumpfile generated by ENOSPC error analyzable.") diff --git a/makedumpfile.c b/makedumpfile.c index cadc596..9624c3f 100644 --- a/makedumpfile.c +++ b/makedumpfile.c @@ -5206,6 +5206,9 @@ reserve_diskspace(int fd, off_t start_offset, off_t end_offset, char *file_name) int ret = FALSE; + if (info->flag_flatten) + return TRUE; + assert(start_offset < end_offset); buf_size = end_offset - start_offset; -- 2.45.2
