Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-09-19 21:16:50 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.29891 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-manager" Thu Sep 19 21:16:50 2024 rev:262 rq:1201813 version:4.1.0 Changes: -------- --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2024-08-08 10:57:33.433545333 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.29891/virt-manager.changes 2024-09-19 21:17:01.865696022 +0200 @@ -1,0 +2,19 @@ +Tue Sep 17 14:30:56 MDT 2024 - [email protected] + +- Fix SUSE SL Micro detection + virtinst-add-slem60-detection-support.patch + +------------------------------------------------------------------- +Mon Aug 26 15:11:42 MDT 2024 - [email protected] + +- Solve bsc#1228384 --dry-run creating pools in a different way + virtinst-dont-create-storage-pool-for-dryrun.patch + +------------------------------------------------------------------- +Thu Aug 22 10:44:23 MDT 2024 - [email protected] + +- Upstream bug fixes (bsc#1027942) (jsc#PED-8910) + 094-uitests-handle-newer-libvirt-test-driver-UpdateDevice-support.patch + 095-uitests-force-internal-snapshots-in-test_snapshot.py.patch + +------------------------------------------------------------------- New: ---- 094-uitests-handle-newer-libvirt-test-driver-UpdateDevice-support.patch 095-uitests-force-internal-snapshots-in-test_snapshot.py.patch BETA DEBUG BEGIN: New:- Upstream bug fixes (bsc#1027942) (jsc#PED-8910) 094-uitests-handle-newer-libvirt-test-driver-UpdateDevice-support.patch 095-uitests-force-internal-snapshots-in-test_snapshot.py.patch New: 094-uitests-handle-newer-libvirt-test-driver-UpdateDevice-support.patch 095-uitests-force-internal-snapshots-in-test_snapshot.py.patch BETA DEBUG END: ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ virt-manager.spec ++++++ --- /var/tmp/diff_new_pack.x46lJC/_old 2024-09-19 21:17:05.273837298 +0200 +++ /var/tmp/diff_new_pack.x46lJC/_new 2024-09-19 21:17:05.277837464 +0200 @@ -131,6 +131,8 @@ Patch91: 091-uitests-Fix-with-GtkFileChooserNative.patch Patch92: 092-cli-Use-regex-for-grep-and-nogrep-args.patch Patch93: 093-cli-Fix-with-latest-libvirt.patch +Patch94: 094-uitests-handle-newer-libvirt-test-driver-UpdateDevice-support.patch +Patch95: 095-uitests-force-internal-snapshots-in-test_snapshot.py.patch Patch100: revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch # SUSE Only Patch150: virtman-desktop.patch ++++++ 094-uitests-handle-newer-libvirt-test-driver-UpdateDevice-support.patch ++++++ Subject: uitests: handle newer libvirt test driver UpdateDevice support From: Cole Robinson [email protected] Wed Aug 7 14:24:33 2024 -0400 Date: Mon Aug 12 19:55:58 2024 -0400: Git: a00c090022dda9019c38c1f86ca3f7274ae63b43 Make it fail for the cases that expect it Signed-off-by: Cole Robinson <[email protected]> --- a/tests/uitests/test_details.py +++ b/tests/uitests/test_details.py @@ -672,6 +672,7 @@ def testDetailsMiscEdits(app): Test misc editing behavior, like checking for unapplied changes """ + app.open(extra_opts=["--test-options=test-update-device-fail"]) win = app.manager_open_details("test-many-devices") hwlist = win.find("hw-list") --- a/tests/uitests/test_mediachange.py +++ b/tests/uitests/test_mediachange.py @@ -86,7 +86,8 @@ def testMediaHotplug(app): Test in the case of a running VM """ vmname = "test-many-devices" - app.open(show_console=vmname) + app.open(show_console=vmname, + extra_opts=["--test-options=test-update-device-fail"]) win = app.find_details_window(vmname, click_details=True) hw = win.find("hw-list") entry = win.find("media-entry") --- a/virtManager/lib/testmock.py +++ b/virtManager/lib/testmock.py @@ -163,6 +163,7 @@ class CLITestOptionsClass: managed save issues * test-vm-run-fail: Make VM run fail, so we can test the error path + * test-update-device-fail: Make UpdateDevice API call fail * spice-agent: Make spice-agent detection return true in viewer.py @@ -219,6 +220,7 @@ class CLITestOptionsClass: self.enable_libguestfs = _get("enable-libguestfs") self.test_managed_save = _get("test-managed-save") self.test_vm_run_fail = _get("test-vm-run-fail") + self.test_update_device_fail = _get("test-update-device-fail") self.spice_agent = _get("spice-agent") self.firstrun_uri = _get_value("firstrun-uri") self.fake_vnc_username = _get("fake-vnc-username") --- a/virtManager/object/domain.py +++ b/virtManager/object/domain.py @@ -1083,6 +1083,9 @@ class vmmDomain(vmmLibvirtObject): xml = devobj.get_xml() log.debug("update_device with xml=\n%s", xml) + + if self.config.CLITestOptions.test_update_device_fail: + raise RuntimeError("fake update device failure") self._backend.updateDeviceFlags(xml, flags) def hotplug(self, memory=_SENTINEL, maxmem=_SENTINEL, ++++++ 095-uitests-force-internal-snapshots-in-test_snapshot.py.patch ++++++ Subject: uitests: force internal snapshots in test_snapshot.py From: Cole Robinson [email protected] Wed Aug 7 11:38:26 2024 -0400 Date: Mon Aug 12 19:55:58 2024 -0400: Git: 0cad0c4dff6aa2c5e46a286a0cacfea124fb48bf Incase the libvirt test driver ever starts advertising support Signed-off-by: Cole Robinson <[email protected]> diff --git a/tests/uitests/test_snapshot.py b/tests/uitests/test_snapshot.py index 4eb478cf..72ece0be 100644 --- a/tests/uitests/test_snapshot.py +++ b/tests/uitests/test_snapshot.py @@ -80,6 +80,7 @@ def testSnapshotLifecycle(app): newwin = app.find_window("Create snapshot") snapname = "testnewsnap" newwin.find("Name:", "text").set_text(snapname) + newwin.find("internal", "radio button").click() newwin.find("Description:", "text").set_text("testdesc") newwin.find("Finish", "push button").click() lib.utils.check(lambda: not newwin.showing) @@ -99,6 +100,7 @@ def testSnapshotLifecycle(app): newwin = app.find_window("Create snapshot") snapname = "testnewsnap" newwin.find("Name:", "text").set_text(snapname) + newwin.find("internal", "radio button").click() newwin.find("Finish", "push button").click() lib.utils.check(lambda: not newwin.showing) newc = win.find(snapname, "table cell") @@ -126,6 +128,7 @@ def testSnapshotMisc1(app): newwin = app.find_window("Create snapshot") snapname1 = "testnewsnap1" newwin.find("Name:", "text").set_text(snapname1) + newwin.find("internal", "radio button").click() newwin.find("Finish", "push button").click() lib.utils.check(lambda: not newwin.showing) newc = win.find(snapname1, "table cell") @@ -136,6 +139,7 @@ def testSnapshotMisc1(app): lib.utils.check(lambda: not vmrun.sensitive) win.find("snapshot-add", "push button").click() newwin = app.find_window("Create snapshot") + newwin.find("internal", "radio button").click() # Force validation error newwin.find("Name:", "text").set_text("bad name") newwin.find("Finish", "push button").click() ++++++ virtinst-add-hyperv-performance-options.patch ++++++ --- /var/tmp/diff_new_pack.x46lJC/_old 2024-09-19 21:17:05.829860347 +0200 +++ /var/tmp/diff_new_pack.x46lJC/_new 2024-09-19 21:17:05.837860679 +0200 @@ -4,8 +4,10 @@ synic requires vpindex stimer requires vpindex and synic ---- virt-manager-4.1.0/virtinst/domain/features.py.orig 2024-07-23 14:08:31.059017630 -0600 -+++ virt-manager-4.1.0/virtinst/domain/features.py 2024-07-23 14:09:33.071019107 -0600 +Index: virt-manager-4.1.0/virtinst/domain/features.py +=================================================================== +--- virt-manager-4.1.0.orig/virtinst/domain/features.py ++++ virt-manager-4.1.0/virtinst/domain/features.py @@ -32,7 +32,9 @@ class DomainFeatures(XMLBuilder): hyperv_spinlocks = XMLProperty("./hyperv/spinlocks/@state", is_onoff=True) hyperv_spinlocks_retries = XMLProperty("./hyperv/spinlocks/@retries", @@ -26,8 +28,10 @@ + self.hyperv_synic = True + if self.hyperv_stimer is None: + self.hyperv_stimer = True ---- virt-manager-4.1.0/virtinst/cli.py.orig 2024-07-23 13:37:39.086973500 -0600 -+++ virt-manager-4.1.0/virtinst/cli.py 2024-07-23 13:38:28.030974666 -0600 +Index: virt-manager-4.1.0/virtinst/cli.py +=================================================================== +--- virt-manager-4.1.0.orig/virtinst/cli.py ++++ virt-manager-4.1.0/virtinst/cli.py @@ -2989,7 +2989,9 @@ class ParserFeatures(VirtCLIParser): "hyperv.relaxed.state": "hyperv_relaxed", "hyperv.spinlocks.state": "hyperv_spinlocks", @@ -48,9 +52,11 @@ cls.add_arg("vmport.state", "vmport", is_onoff=True) cls.add_arg("kvm.hidden.state", "kvm_hidden", is_onoff=True) ---- virt-manager-4.1.0/tests/test_cli.py.orig 2024-07-23 14:37:19.511058816 -0600 -+++ virt-manager-4.1.0/tests/test_cli.py 2024-07-23 14:38:46.819060897 -0600 -@@ -554,7 +554,7 @@ memorytune0.vcpus=0-3,memorytune0.node0. +Index: virt-manager-4.1.0/tests/test_cli.py +=================================================================== +--- virt-manager-4.1.0.orig/tests/test_cli.py ++++ virt-manager-4.1.0/tests/test_cli.py +@@ -555,7 +555,7 @@ memorytune0.vcpus=0-3,memorytune0.node0. --metadata title=my-title,description=my-description,uuid=00000000-1111-2222-3333-444444444444,genid=e9392370-2917-565e-692b-d057f46512d6,genid_enable=yes @@ -59,8 +65,10 @@ --clock offset=utc,hpet_present=no,rtc_tickpolicy=merge,timer2.name=hypervclock,timer3.name=pit,timer1.present=yes,timer3.tickpolicy=delay,timer2.present=no,timer4.name=rtc,timer5.name=tsc,timer6.name=tsc,timer4.track=wall,timer5.frequency=10,timer6.mode=emulate,timer7.name=rtc,timer7.tickpolicy=catchup,timer7.catchup.threshold=123,timer7.catchup.slew=120,timer7.catchup.limit=10000,rtc_present=no,pit_present=yes,pit_tickpolicy=catchup,tsc_present=no,platform_present=no,hypervclock_present=no,platform_tickpolicy=foo,hpet_tickpolicy=bar,tsc_tickpolicy=wibble,kvmclock_tickpolicy=wobble,hypervclock_tickpolicy=woo ---- virt-manager-4.1.0/tests/data/cli/compare/virt-install-many-devices.xml.orig 2024-07-23 14:45:20.019070266 -0600 -+++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-many-devices.xml 2024-07-23 14:45:41.667070782 -0600 +Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-many-devices.xml +=================================================================== +--- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-many-devices.xml ++++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-many-devices.xml @@ -138,7 +138,9 @@ <vapic state="on"/> <relaxed state="off"/> @@ -71,8 +79,10 @@ </hyperv> <vmport state="off"/> <kvm> ---- virt-manager-4.1.0/tests/data/cli/compare/virt-install-win7-uefi.xml.orig 2024-07-23 15:09:45.803105194 -0600 -+++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-win7-uefi.xml 2024-07-23 15:11:30.679107693 -0600 +Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-win7-uefi.xml +=================================================================== +--- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-win7-uefi.xml ++++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-win7-uefi.xml @@ -23,6 +23,9 @@ <relaxed state="on"/> <vapic state="on"/> @@ -93,8 +103,10 @@ </hyperv> <vmport state="off"/> </features> ---- virt-manager-4.1.0/tests/data/cli/compare/virt-install-kvm-win10.xml.orig 2024-07-23 15:09:30.155104821 -0600 -+++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-kvm-win10.xml 2024-07-23 15:10:20.443106019 -0600 +Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-kvm-win10.xml +=================================================================== +--- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-kvm-win10.xml ++++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-kvm-win10.xml @@ -21,6 +21,9 @@ <relaxed state="on"/> <vapic state="on"/> @@ -115,8 +127,10 @@ </hyperv> <vmport state="off"/> </features> ---- virt-manager-4.1.0/tests/data/cli/compare/virt-install-os-detect-fail-fallback.xml.orig 2024-07-23 15:12:52.567109644 -0600 -+++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-os-detect-fail-fallback.xml 2024-07-23 15:12:13.607108716 -0600 +Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-os-detect-fail-fallback.xml +=================================================================== +--- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-os-detect-fail-fallback.xml ++++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-os-detect-fail-fallback.xml @@ -19,6 +19,9 @@ <relaxed state="on"/> <vapic state="on"/> @@ -137,8 +151,10 @@ </hyperv> </features> <clock offset="localtime"/> ---- virt-manager-4.1.0/tests/data/cli/compare/virt-install-kvm-win2k3-cdrom.xml.orig 2024-07-23 15:09:35.051104938 -0600 -+++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-kvm-win2k3-cdrom.xml 2024-07-23 15:10:40.211106490 -0600 +Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-kvm-win2k3-cdrom.xml +=================================================================== +--- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-kvm-win2k3-cdrom.xml ++++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-kvm-win2k3-cdrom.xml @@ -21,6 +21,9 @@ <relaxed state="on"/> <vapic state="on"/> @@ -159,8 +175,10 @@ </hyperv> <vmport state="off"/> </features> ---- virt-manager-4.1.0/tests/data/cli/compare/virt-install-w2k3-cdrom.xml.orig 2024-07-23 15:22:42.151123693 -0600 -+++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-w2k3-cdrom.xml 2024-07-23 15:23:37.299125007 -0600 +Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-w2k3-cdrom.xml +=================================================================== +--- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-w2k3-cdrom.xml ++++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-w2k3-cdrom.xml @@ -20,6 +20,9 @@ <relaxed state="on"/> <vapic state="on"/> @@ -181,8 +199,10 @@ </hyperv> </features> <cpu> ---- virt-manager-4.1.0/tests/data/cli/compare/virt-install-unattended-remote-cdrom.xml.orig 2024-07-23 15:23:07.827124305 -0600 -+++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-unattended-remote-cdrom.xml 2024-07-23 15:24:16.387125939 -0600 +Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-unattended-remote-cdrom.xml +=================================================================== +--- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-unattended-remote-cdrom.xml ++++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-unattended-remote-cdrom.xml @@ -19,6 +19,9 @@ <relaxed state="on"/> <vapic state="on"/> @@ -203,8 +223,10 @@ </hyperv> </features> <clock offset="localtime"/> ---- virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-win7-unattended.xml.orig 2024-07-23 15:22:54.103123978 -0600 -+++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-win7-unattended.xml 2024-07-23 15:23:56.535125466 -0600 +Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-win7-unattended.xml +=================================================================== +--- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-osinfo-win7-unattended.xml ++++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-win7-unattended.xml @@ -20,6 +20,9 @@ <relaxed state="on"/> <vapic state="on"/> ++++++ virtinst-add-pvh-support.patch ++++++ --- /var/tmp/diff_new_pack.x46lJC/_old 2024-09-19 21:17:05.857861507 +0200 +++ /var/tmp/diff_new_pack.x46lJC/_new 2024-09-19 21:17:05.861861673 +0200 @@ -45,7 +45,7 @@ =================================================================== --- virt-manager-4.1.0.orig/virtManager/object/domain.py +++ virt-manager-4.1.0/virtManager/object/domain.py -@@ -1313,6 +1313,8 @@ class vmmDomain(vmmLibvirtObject): +@@ -1316,6 +1316,8 @@ class vmmDomain(vmmLibvirtObject): return self.get_xmlobj().os.is_xenpv() def is_hvm(self): return self.get_xmlobj().os.is_hvm() ++++++ virtinst-add-slem60-detection-support.patch ++++++ --- /var/tmp/diff_new_pack.x46lJC/_old 2024-09-19 21:17:05.889862834 +0200 +++ /var/tmp/diff_new_pack.x46lJC/_new 2024-09-19 21:17:05.897863166 +0200 @@ -21,7 +21,7 @@ sle_version = self.product_name.strip().rsplit(' ')[6] else: - sle_version = self.product_name.strip().rsplit(' ')[4] -+ if "SUSE Linux Micro" in self.product_name: ++ if "SUSE SL Micro" in self.product_name: + sle_version = self.product_name.strip().rsplit(' ')[3] + else: + sle_version = self.product_name.strip().rsplit(' ')[4] @@ -33,7 +33,7 @@ matching_distros = ["slem"] _variant_prefix = "slem" - _suse_regex = [".*SUSE Linux Enterprise Micro*", ".*SUSE Micro*"] -+ _suse_regex = [".*SUSE Linux Enterprise Micro*", ".*SUSE Linux Micro*", ".*SUSE Micro*"] ++ _suse_regex = [".*SUSE Linux Enterprise Micro*", ".*SUSE Linux Micro*", ".*SUSE Micro*", ".*SUSE SL Micro*"] famregex = ".*SUSE Linux Enterprise Micro.*" ++++++ virtinst-dont-create-storage-pool-for-dryrun.patch ++++++ --- /var/tmp/diff_new_pack.x46lJC/_old 2024-09-19 21:17:05.929864492 +0200 +++ /var/tmp/diff_new_pack.x46lJC/_new 2024-09-19 21:17:05.933864658 +0200 @@ -5,38 +5,32 @@ =================================================================== --- virt-manager-4.1.0.orig/virtinst/cli.py +++ virt-manager-4.1.0/virtinst/cli.py -@@ -69,6 +69,14 @@ def _reset_global_state(): - _globalstate = _GlobalState() - - -+_dryrun = False -+ -+def get_dryrun(): -+ return _dryrun -+def set_dryrun(val): -+ global _dryrun -+ _dryrun = val -+ - VIRT_PARSERS = [] - - -@@ -646,6 +654,7 @@ def add_misc_options(grp, prompt=False, - help=argparse.SUPPRESS) - - if dryrun: -+ set_dryrun(True) - grp.add_argument("--dry-run", action="store_true", dest="dry", - help=_("Run through install process, but do not " - "create devices or define the guest.")) -@@ -3615,7 +3624,7 @@ class ParserDisk(VirtCLIParser): +@@ -1330,6 +1330,7 @@ class VirtCLIParser(metaclass=_InitClass + _virtargs = [] + aliases = {} + supports_clearxml = True ++ dryrun = False + + @classmethod + def add_arg(cls, cliname, propname, *args, **kwargs): +@@ -3615,7 +3616,7 @@ class ParserDisk(VirtCLIParser): ################### def set_path_cb(self, inst, val, virtarg): - inst.set_source_path(val) -+ inst.set_source_path(val, get_dryrun()) ++ inst.set_source_path(val, self.dryrun) def path_lookup_cb(self, inst, val, virtarg): return inst.get_source_path() == val +@@ -4834,6 +4835,8 @@ def run_parser(options, guest, parsercla + ret = [] + optstr_list = xmlutil.listify(getattr(options, parserclass.cli_arg_name)) + ++ if hasattr(options, "dry"): ++ parserclass.dryrun = options.dry + for optstr in optstr_list: + parserobj = parserclass(optstr, guest=guest, editing=bool(editinst)) + parseret = parserobj.parse(editinst) Index: virt-manager-4.1.0/virtinst/devices/disk.py =================================================================== --- virt-manager-4.1.0.orig/virtinst/devices/disk.py ++++++ virtman-add-sev-memory-support.patch ++++++ --- /var/tmp/diff_new_pack.x46lJC/_old 2024-09-19 21:17:06.033868803 +0200 +++ /var/tmp/diff_new_pack.x46lJC/_new 2024-09-19 21:17:06.037868969 +0200 @@ -119,7 +119,7 @@ self._redefine_xmlobj(guest) -@@ -1331,6 +1349,9 @@ class vmmDomain(vmmLibvirtObject): +@@ -1334,6 +1352,9 @@ class vmmDomain(vmmLibvirtObject): def get_description(self): return self.get_xmlobj().description ++++++ virtman-fix-restore-vm-menu-selection.patch ++++++ --- /var/tmp/diff_new_pack.x46lJC/_old 2024-09-19 21:17:06.093871290 +0200 +++ /var/tmp/diff_new_pack.x46lJC/_new 2024-09-19 21:17:06.097871456 +0200 @@ -7,7 +7,7 @@ =================================================================== --- virt-manager-4.1.0.orig/virtManager/object/domain.py +++ virt-manager-4.1.0/virtManager/object/domain.py -@@ -1623,7 +1623,8 @@ class vmmDomain(vmmLibvirtObject): +@@ -1626,7 +1626,8 @@ class vmmDomain(vmmLibvirtObject): return (self.is_stoppable() or self.status() in [libvirt.VIR_DOMAIN_CRASHED]) def is_runable(self):
