Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package rsync for openSUSE:Factory checked in at 2024-09-25 21:52:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/rsync (Old) and /work/SRC/openSUSE:Factory/.rsync.new.29891 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "rsync" Wed Sep 25 21:52:53 2024 rev:91 rq:1202965 version:3.3.0 Changes: -------- --- /work/SRC/openSUSE:Factory/rsync/rsync.changes 2024-09-08 12:00:31.643825551 +0200 +++ /work/SRC/openSUSE:Factory/.rsync.new.29891/rsync.changes 2024-09-25 21:53:01.159603118 +0200 @@ -6,0 +7,5 @@ +Thu Sep 5 23:44:21 UTC 2024 - Georg Pfuetzenreuter <[email protected]> + +- Add rsyncd-return-from-list-command-with-0.patch to not treat #list as failure + +------------------------------------------------------------------- New: ---- rsyncd-return-from-list-command-with-0.patch BETA DEBUG BEGIN: New: - Add rsyncd-return-from-list-command-with-0.patch to not treat #list as failure BETA DEBUG END: ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rsync.spec ++++++ --- /var/tmp/diff_new_pack.CrITQY/_old 2024-09-25 21:53:02.639664679 +0200 +++ /var/tmp/diff_new_pack.CrITQY/_new 2024-09-25 21:53:02.643664846 +0200 @@ -58,6 +58,8 @@ Patch1: rsync-gcc14.patch Patch2: rsync-usr-etc.patch Patch3: rsync-run-dir.patch +# https://github.com/RsyncProject/rsync/pull/639 +Patch5: rsyncd-return-from-list-command-with-0.patch BuildRequires: autoconf BuildRequires: automake BuildRequires: c++_compiler ++++++ rsync-usr-etc.patch ++++++ --- /var/tmp/diff_new_pack.CrITQY/_old 2024-09-25 21:53:02.711667674 +0200 +++ /var/tmp/diff_new_pack.CrITQY/_new 2024-09-25 21:53:02.715667841 +0200 @@ -1,4 +1,3 @@ -Nur in a: .cirrus.yml. diff -ur a/clientserver.c b/clientserver.c --- a/clientserver.c 2023-11-28 17:12:41.643268046 +0100 +++ b/clientserver.c 2023-11-28 17:25:30.476279700 +0100 ++++++ rsyncd-return-from-list-command-with-0.patch ++++++ >From bfb95e4a60c27ec0f9bb4668cc6163f5cfb3e635 Mon Sep 17 00:00:00 2001 From: Georg Pfuetzenreuter <[email protected]> Date: Fri, 6 Sep 2024 01:39:32 +0200 Subject: [PATCH] Return from #list command with 0 The "#list" command should not be treated as a failure when it is both a legitimate request by the client, and correctly answered by the server. It is commonly used for assessing whether a rsync endpoint is healthy, having it return with a non-zero exit code causes misleading error reports, and, in case of socket activation, failed service instances on the server. Signed-off-by: Georg Pfuetzenreuter <[email protected]> --- clientserver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clientserver.c b/clientserver.c index 7c897abc..c507ea91 100644 --- a/clientserver.c +++ b/clientserver.c @@ -1371,7 +1371,7 @@ int start_daemon(int f_in, int f_out) rprintf(FLOG, "module-list request from %s (%s)\n", host, addr); send_listing(f_out); - return -1; + return 0; } if (*line == '#') { -- 2.46.0
