Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package nodejs-electron for openSUSE:Factory
checked in at 2025-05-30 14:38:20
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/nodejs-electron (Old)
and /work/SRC/openSUSE:Factory/.nodejs-electron.new.25440 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "nodejs-electron"
Fri May 30 14:38:20 2025 rev:159 rq:1281189 version:35.5.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/nodejs-electron/nodejs-electron.changes
2025-05-20 09:38:28.566360956 +0200
+++
/work/SRC/openSUSE:Factory/.nodejs-electron.new.25440/nodejs-electron.changes
2025-05-30 17:24:22.732904732 +0200
@@ -1,0 +2,20 @@
+Thu May 29 17:37:49 UTC 2025 - Bruno Pitrus <[email protected]>
+
+- New upstream release 35.5.0
+ * Node 22.15.1
+ * Added innerWidth and innerHeight options for window.open. #47045 (Also in
36, 37)
+ * Added support for screen.dipToScreenPoint(point) and
screen.screenToDipPoint(point) on Linux X11.
+ * Added support for node option --experimental-network-inspection.
+ * Security fixes for for CVE-2025-4609 CVE-2025-4664 (bsc#1243205)
+- Do not build Chromium extensions support as it's not used by us
+ * reduce-gn-tree.patch
+ * build-without-extensions.patch
+ * build-without-guest-view.patch
+ * extensions-common-assert.patch
+
+-------------------------------------------------------------------
+Sat May 24 13:25:36 UTC 2025 - Bruno Pitrus <[email protected]>
+
+- Fedora 43+: bacport change to fix build with llhttp 9.3
(node-llhttp9.3.patch)
+
+-------------------------------------------------------------------
Old:
----
electron-35.4.0.tar.zst
New:
----
build-without-extensions.patch
build-without-guest-view.patch
electron-35.5.0.tar.zst
extensions-common-assert.patch
node-llhttp9.3.patch
reduce-gn-tree.patch
BETA DEBUG BEGIN:
New: * reduce-gn-tree.patch
* build-without-extensions.patch
* build-without-guest-view.patch
New: * build-without-extensions.patch
* build-without-guest-view.patch
* extensions-common-assert.patch
New: * build-without-guest-view.patch
* extensions-common-assert.patch
New:
- Fedora 43+: bacport change to fix build with llhttp 9.3 (node-llhttp9.3.patch)
New:- Do not build Chromium extensions support as it's not used by us
* reduce-gn-tree.patch
* build-without-extensions.patch
BETA DEBUG END:
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ nodejs-electron.spec ++++++
--- /var/tmp/diff_new_pack.94pbVG/_old 2025-05-30 17:24:27.209090483 +0200
+++ /var/tmp/diff_new_pack.94pbVG/_new 2025-05-30 17:24:27.213090649 +0200
@@ -124,6 +124,11 @@
%bcond_with system_ada
%endif
+%if 0%{?fedora} >= 43
+%bcond_without llhttp_93
+%else
+%bcond_with llhttp_93
+%endif
# requires `base64_options`
%if 0%{?fedora} >= 42
@@ -189,7 +194,7 @@
Name: nodejs-electron
-Version: 35.4.0
+Version: 35.5.0
%global tag_version %version
Release: 0
Summary: Build cross platform desktop apps with JavaScript, HTML, and
CSS
@@ -245,6 +250,7 @@
Patch97: chromium-127-cargo_crate.patch
Patch98: gn-logspam-breaks-install.patch
Patch99: torque-debuginfo.patch
+Patch100: reduce-gn-tree.patch
# PATCHES that remove code we don't want. Most of them can be reused verbatim
by other distributors,
@@ -279,6 +285,8 @@
Patch603: build-without-mesage-center.patch
Patch604: disable-avif-really.patch
Patch605: permission-gcc14.2.patch
+Patch606: build-without-extensions.patch
+Patch607: build-without-guest-view.patch
@@ -339,7 +347,11 @@
Patch2063: fix-building-with-pipewire-1.3.82.patch
#Conditionably disable feature which requires new highway
Patch2064: blink-shape_result-highway.patch
-
+%if %{with system_llhttp} && %{with llhttp_93}
+Patch2065: node-llhttp9.3.patch
+%else
+Source2065: node-llhttp9.3.patch
+%endif
# PATCHES that should be submitted upstream verbatim or near-verbatim
# Fix blink nodestructor
@@ -384,6 +396,7 @@
Patch3208: to_vector-std-projected-gcc119888.patch
Patch3209: file_dialog-missing-uint32_t.patch
Patch3211: html_permission_element_strings_map-reproducible.patch
+Patch3212: extensions-common-assert.patch
# Patches to re-enable upstream force disabled features.
# There's no sense in submitting them but they may be reused as-is by other
packagers.
@@ -426,6 +439,11 @@
BuildRequires: libXNVCtrl-devel
%if %{with system_llhttp}
BuildRequires: llhttp-devel >= 8
+%if %{with llhttp_93}
+BuildRequires: llhttp-devel >= 9.3
+%else
+BuildRequires: llhttp-devel < 9.3
+%endif
%endif
%if %{with swiftshader} && %{without subzero}
BuildRequires: llvm-devel >= 16
@@ -1035,7 +1053,7 @@
%if %{with lto}
%ifarch aarch64
-export LDFLAGS="$LDFLAGS -flto=auto --param ggc-min-expand=20 --param
ggc-min-heapsize=32768 --param lto-max-streaming-parallelism=3
-Wl,--no-keep-memory -Wl,--reduce-memory-overheads"
+export LDFLAGS="$LDFLAGS -flto=auto --param ggc-min-expand=20 --param
ggc-min-heapsize=32768 --param lto-max-streaming-parallelism=4 "
%else
# x64 is fine with the the default settings (the machines have 30GB+ ram)
export LDFLAGS="$LDFLAGS -flto=auto"
@@ -1163,8 +1181,12 @@
%if 0%{?fedora}
myconf_gn+=' symbol_level=1' #OOM during linking
%else
+%ifarch aarch64 #OOM or logidlelimit, pick your poison
+myconf_gn+=' symbol_level=1'
+%else
myconf_gn+=' symbol_level=2'
%endif
+%endif
myconf_gn+=' blink_symbol_level=1'
myconf_gn+=' v8_symbol_level=1'
@@ -1178,7 +1200,6 @@
# do not build some chrome features not used by electron
# (some of these only go to buildflag_headers and are dead code rn, but
disabling them preemptively as long as they're visible)
myconf_gn+=" enable_vr=false"
-myconf_gn+=" enable_reading_list=false"
myconf_gn+=" enable_reporting=false"
myconf_gn+=" build_with_tflite_lib=false"
myconf_gn+=" build_tflite_with_xnnpack=false"
@@ -1196,7 +1217,6 @@
myconf_gn+=" enable_webui_tab_strip=false"
myconf_gn+=" enable_webui_certificate_viewer=false"
myconf_gn+=" enable_background_contents=false"
-myconf_gn+=" enable_extractors=false"
myconf_gn+=" ozone_platform_headless=false"
myconf_gn+=" angle_enable_gl_null=false"
myconf_gn+=" enable_paint_preview=false"
@@ -1214,12 +1234,20 @@
myconf_gn+=' enable_video_effects=false'
myconf_gn+=' use_fake_screen_ai=true'
myconf_gn+=' webnn_use_tflite=false'
-myconf_gn+=' structured_metrics_enabled=false'
-myconf_gn+=' structured_metrics_debug_enabled=false'
myconf_gn+=' build_dawn_tests=false'
myconf_gn+=' enable_compute_pressure=false'
+#These can only be disabled if we don't start at //... but at //electron:...
+myconf_gn+=' absl_build_tests=false'
+myconf_gn+=' build_with_model_execution=false'
+myconf_gn+=' enable_extensions=false'
+myconf_gn+=' enable_guest_view=false'
+myconf_gn+=' enable_extensions_core=true' #cannot be disabled yet
+myconf_gn+=' enable_on_device_translation=false'
+myconf_gn+=' enable_session_service=false'
+
+
#FIXME: possibly enable this when skia gets built with rust code by default.
#Need to patch in optflags and possibly FFI LTO hacks (see signal-desktop
package for how it's done)
@@ -1230,8 +1258,6 @@
myconf_gn+=' chrome_root_store_cert_management_ui=false'
myconf_gn+=' use_kerberos=false'
-myconf_gn+=' disable_histogram_support=true'
-
#Do not build Chromecast
myconf_gn+=" enable_remoting=false"
@@ -1240,7 +1266,6 @@
myconf_gn+=' enable_mdns=false'
#disable some debug/tracing hooks, they increase size and we do not build
chrome://tracing anyway (see disable-catapult.patch)
-myconf_gn+=" enable_trace_logging=false"
myconf_gn+=" optional_trace_events_enabled=false"
myconf_gn+=" rtc_disable_logging=true"
myconf_gn+=" rtc_disable_metrics=true"
@@ -1348,7 +1373,13 @@
# GN does not support passing cflags:
# https://bugs.chromium.org/p/chromium/issues/detail?id=642016
-gn gen out/Release --testonly=false
--args="import(\"//electron/build/args/release.gn\") ${myconf_gn}"
+gn gen out/Release --testonly=false \
+--root-target=//electron:electron_app \
+--root-pattern=//electron:electron_app \
+--root-pattern=//electron:chromium_licenses \
+--root-pattern=//electron:copy_node_headers \
+--root-pattern=//electron:electron_version_file \
+--args="import(\"//electron/build/args/release.gn\") ${myconf_gn}"
# dump the linker command line (if any) in case of failure
@@ -1379,7 +1410,13 @@
pushd out/Release
install -pm 0644 version -t %{buildroot}%{_libdir}/electron/
-gn desc . //electron:electron_app runtime_deps | grep -v ^gen/ | sort | uniq |
xargs -t cp -a -v --parents -t %{buildroot}%{_libdir}/electron/ --
+gn desc \
+--root-target=//electron:electron_app \
+--root-pattern=//electron:electron_app \
+--root-pattern=//electron:chromium_licenses \
+--root-pattern=//electron:copy_node_headers \
+--root-pattern=//electron:electron_version_file \
+. //electron:electron_app runtime_deps | grep -v ^gen/ | sort | uniq | xargs
-t cp -a -v --parents -t %{buildroot}%{_libdir}/electron/ --
popd
@@ -1472,11 +1509,11 @@
chmod -v 644 %{buildroot}%{_rpmconfigdir}/macros.d/macros.electron
#help debugedit find the source files
-ln -srv third_party/emoji-segmenter/src/emoji_presentation_scanner.c -t
out/Release
-ln -srv third_party/emoji-segmenter/src/emoji_presentation_scanner.rl -t
out/Release
-ln -srv third_party/angle/src/compiler/translator/glslang.l -t out/Release
-ln -srv third_party/angle/src/compiler/preprocessor/preprocessor.l -t
out/Release
-ln -srv third_party -t out/Release
+ln -srvf third_party/emoji-segmenter/src/emoji_presentation_scanner.c -t
out/Release
+ln -srvf third_party/emoji-segmenter/src/emoji_presentation_scanner.rl -t
out/Release
+ln -srvf third_party/angle/src/compiler/translator/glslang.l -t out/Release
+ln -srvf third_party/angle/src/compiler/preprocessor/preprocessor.l -t
out/Release
+ln -srvf third_party -t out/Release
%files
%license electron/LICENSE out/Release/LICENSES.chromium.html
++++++ build-without-extensions.patch ++++++
--- src/extensions/common/BUILD.gn.orig 2025-05-22 20:15:08.686176429 +0200
+++ src/extensions/common/BUILD.gn 2025-05-24 11:58:30.839954172 +0200
@@ -243,10 +243,6 @@ static_library("common") {
"api/commands/commands_handler.h",
"api/declarative/declarative_constants.cc",
"api/declarative/declarative_constants.h",
- "api/declarative/declarative_manifest_data.cc",
- "api/declarative/declarative_manifest_data.h",
- "api/declarative/declarative_manifest_handler.cc",
- "api/declarative/declarative_manifest_handler.h",
"api/declarative_net_request/constants.cc",
"api/declarative_net_request/constants.h",
"api/declarative_net_request/dnr_manifest_data.cc",
@@ -266,8 +262,6 @@ static_library("common") {
"api/printer_provider/usb_printer_manifest_data.h",
"api/printer_provider/usb_printer_manifest_handler.cc",
"api/printer_provider/usb_printer_manifest_handler.h",
- "api/scripts_internal/script_serialization.cc",
- "api/scripts_internal/script_serialization.h",
"api/sockets/sockets_manifest_data.cc",
"api/sockets/sockets_manifest_data.h",
"api/sockets/sockets_manifest_handler.cc",
@@ -378,8 +372,6 @@ static_library("common") {
"manifest_handlers/background_info.h",
"manifest_handlers/content_capabilities_handler.cc",
"manifest_handlers/content_capabilities_handler.h",
- "manifest_handlers/content_scripts_handler.cc",
- "manifest_handlers/content_scripts_handler.h",
"manifest_handlers/cross_origin_isolation_info.cc",
"manifest_handlers/cross_origin_isolation_info.h",
"manifest_handlers/csp_info.cc",
@@ -390,10 +382,6 @@ static_library("common") {
"manifest_handlers/extension_action_handler.h",
"manifest_handlers/externally_connectable.cc",
"manifest_handlers/externally_connectable.h",
- "manifest_handlers/file_handler_info.cc",
- "manifest_handlers/file_handler_info.h",
- "manifest_handlers/icon_variants_handler.cc",
- "manifest_handlers/icon_variants_handler.h",
"manifest_handlers/icons_handler.cc",
"manifest_handlers/icons_handler.h",
"manifest_handlers/incognito_info.cc",
@@ -422,8 +410,6 @@ static_library("common") {
"manifest_handlers/trial_tokens_handler.h",
"manifest_handlers/web_accessible_resources_info.cc",
"manifest_handlers/web_accessible_resources_info.h",
- "manifest_handlers/web_file_handlers_info.cc",
- "manifest_handlers/web_file_handlers_info.h",
"manifest_handlers/webview_info.cc",
"manifest_handlers/webview_info.h",
"manifest_url_handlers.cc",
@@ -481,8 +467,6 @@ static_library("common") {
"user_script.h",
"utils/base_string.cc",
"utils/base_string.h",
- "utils/content_script_utils.cc",
- "utils/content_script_utils.h",
"utils/extension_types_utils.cc",
"utils/extension_types_utils.h",
"utils/extension_utils.cc",
++++++ build-without-guest-view.patch ++++++
--- src/components/permissions/permission_context_base.cc.orig 2025-05-22
20:15:04.346176805 +0200
+++ src/components/permissions/permission_context_base.cc 2025-05-24
13:09:21.758872333 +0200
@@ -26,6 +26,7 @@
#include "components/content_settings/core/common/content_settings_pattern.h"
#include "components/content_settings/core/common/content_settings_types.h"
#include "components/content_settings/core/common/features.h"
+#include "components/guest_view/buildflags/buildflags.h"
#include "components/permissions/features.h"
#include "components/permissions/permission_context_base.h"
#include "components/permissions/permission_decision_auto_blocker.h"
@@ -46,7 +47,7 @@
#include
"services/network/public/mojom/permissions_policy/permissions_policy_feature.mojom.h"
#include "url/gurl.h"
-#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS)
+#if BUILDFLAG(ENABLE_GUEST_VIEW)
#include "components/guest_view/browser/guest_view_base.h"
#endif
@@ -316,7 +317,7 @@ content::PermissionResult PermissionCont
}
}
-#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS)
+#if BUILDFLAG(ENABLE_GUEST_VIEW)
guest_view::GuestViewBase* guest =
guest_view::GuestViewBase::FromRenderFrameHost(render_frame_host);
if (guest) {
++++++ electron-35.4.0.tar.zst -> electron-35.5.0.tar.zst ++++++
/work/SRC/openSUSE:Factory/nodejs-electron/electron-35.4.0.tar.zst
/work/SRC/openSUSE:Factory/.nodejs-electron.new.25440/electron-35.5.0.tar.zst
differ: char 7, line 1
++++++ extensions-common-assert.patch ++++++
>From cf0e064ce3b7c6b809861a6d299165b74cce109e Mon Sep 17 00:00:00 2001
From: James Cook <[email protected]>
Date: Thu, 22 May 2025 10:23:47 -0700
Subject: [PATCH] extensions: Clean up ENABLE_EXTENSIONS in //extensions
TestRuntimeApiDelegate can be safely added to the build now.
Also, replace ENABLE_EXTENSIONS || ENABLE_DESKTOP_ANDROID_EXTENSIONS
with ENABLE_EXTENSIONS_CORE, to be consistent with the rest of the
codebase.
Bug: 356905053
Change-Id: I616391c2843c6c5e20188803f2a51c6f83165927
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6576511
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1464202}
---
extensions/BUILD.gn | 12 ++----------
extensions/browser/extension_registry.h | 3 +--
extensions/browser/extension_system.h | 3 +--
extensions/browser/test_extensions_browser_client.cc | 12 +-----------
extensions/common/extension.h | 3 +--
5 files changed, 6 insertions(+), 27 deletions(-)
diff --git a/extensions/BUILD.gn b/extensions/BUILD.gn
index 0ea291f16ba70b..586fd7461e4cd9 100644
--- a/extensions/BUILD.gn
+++ b/extensions/BUILD.gn
@@ -111,6 +111,8 @@ static_library("test_support") {
"browser/test_image_loader.h",
"browser/test_management_policy.cc",
"browser/test_management_policy.h",
+ "browser/test_runtime_api_delegate.cc",
+ "browser/test_runtime_api_delegate.h",
"common/extension_builder.cc",
"common/extension_builder.h",
"common/manifest_test.cc",
@@ -198,16 +200,6 @@ static_library("test_support") {
deps += [ "//components/guest_view/browser:test_support" ]
}
- # TODO(https://crbug.com/356905053): The following files don't compile
cleanly
- # with desktop-android. Either make them compile, or determine they should
- # not be included and place them under a more appropriate if-block.
- if (enable_extensions) {
- sources += [
- "browser/test_runtime_api_delegate.cc",
- "browser/test_runtime_api_delegate.h",
- ]
- }
-
# Generally, //extensions should not depend on //chromeos. However, a number
# of the APIs and the extensions shell already do. We should try to avoid
# expanding these dependencies.
diff --git a/extensions/browser/extension_registry.h
b/extensions/browser/extension_registry.h
index 4ed65fdce8af21..1ee1b70458a068 100644
--- a/extensions/browser/extension_registry.h
+++ b/extensions/browser/extension_registry.h
@@ -19,8 +19,7 @@
#include "extensions/common/extension_id.h"
#include "extensions/common/extension_set.h"
-static_assert(BUILDFLAG(ENABLE_EXTENSIONS) ||
- BUILDFLAG(ENABLE_DESKTOP_ANDROID_EXTENSIONS));
+static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
namespace content {
class BrowserContext;
diff --git a/extensions/browser/extension_system.h
b/extensions/browser/extension_system.h
index 369dad723495a4..eccf3b2d331724 100644
--- a/extensions/browser/extension_system.h
+++ b/extensions/browser/extension_system.h
@@ -17,8 +17,7 @@
#include "extensions/common/extension.h"
#include "extensions/common/extension_id.h"
-static_assert(BUILDFLAG(ENABLE_EXTENSIONS) ||
- BUILDFLAG(ENABLE_DESKTOP_ANDROID_EXTENSIONS));
+static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
namespace base {
class OneShotEvent;
diff --git a/extensions/browser/test_extensions_browser_client.cc
b/extensions/browser/test_extensions_browser_client.cc
index 88ce18dd343016..f914fae7205f88 100644
--- a/extensions/browser/test_extensions_browser_client.cc
+++ b/extensions/browser/test_extensions_browser_client.cc
@@ -10,6 +10,7 @@
#include "build/chromeos_buildflags.h"
#include "content/public/browser/browser_context.h"
#include "extensions/browser/extension_host_delegate.h"
+#include "extensions/browser/test_runtime_api_delegate.h"
#include "extensions/browser/updater/null_extension_cache.h"
#include "extensions/buildflags/buildflags.h"
#include "extensions/common/extension_id.h"
@@ -17,13 +18,6 @@
#include "services/network/public/mojom/url_loader.mojom.h"
#include "ui/base/l10n/l10n_util.h"
-// TODO(https://crbug.com/356905053): The following files don't compile cleanly
-// with desktop-android. Either make them compile, or determine they should
-// not be included and place them under a more appropriate if-block.
-#if BUILDFLAG(ENABLE_EXTENSIONS)
-#include "extensions/browser/test_runtime_api_delegate.h"
-#endif
-
#if BUILDFLAG(IS_CHROMEOS)
#include "chromeos/ash/components/login/login_state/login_state.h"
#endif
@@ -260,11 +254,7 @@ void
TestExtensionsBrowserClient::RegisterBrowserInterfaceBindersForFrame(
std::unique_ptr<RuntimeAPIDelegate>
TestExtensionsBrowserClient::CreateRuntimeAPIDelegate(
content::BrowserContext* context) const {
-#if BUILDFLAG(ENABLE_EXTENSIONS)
return std::unique_ptr<RuntimeAPIDelegate>(new TestRuntimeAPIDelegate());
-#else
- return nullptr;
-#endif
}
const ComponentExtensionResourceManager*
diff --git a/extensions/common/extension.h b/extensions/common/extension.h
index ec776e6207057b..33a196f11a519a 100644
--- a/extensions/common/extension.h
+++ b/extensions/common/extension.h
@@ -29,8 +29,7 @@
#include "url/gurl.h"
#include "url/origin.h"
-static_assert(BUILDFLAG(ENABLE_EXTENSIONS) ||
- BUILDFLAG(ENABLE_DESKTOP_ANDROID_EXTENSIONS));
+static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
namespace extensions {
class HashedExtensionId;
++++++ node-llhttp9.3.patch ++++++
>From 4454d09e8f7225ec1b576ef86c8705bca63a136c Mon Sep 17 00:00:00 2001
From: Fedor Indutny <[email protected]>
Date: Wed, 7 May 2025 07:21:52 -0700
Subject: [PATCH] deps: update llhttp to 9.3.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
[email protected] optimizes header value parsing on ARM Neon/WASM, and adds
support for a protocol callback for use outside of the typical HTTP
setting (RTSP/ICE).
PR-URL: https://github.com/nodejs/node/pull/58144
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
---
deps/llhttp/CMakeLists.txt | 7 +-
deps/llhttp/LICENSE | 22 +
deps/llhttp/README.md | 9 +-
deps/llhttp/include/llhttp.h | 10 +-
deps/llhttp/libllhttp.pc.in | 8 +-
deps/llhttp/src/api.c | 45 +-
deps/llhttp/src/llhttp.c | 2841 ++++++++---------
src/node_http_parser.cc | 6 +
test/parallel/test-http-client-parse-error.js | 2 +-
9 files changed, 1459 insertions(+), 1491 deletions(-)
create mode 100644 deps/llhttp/LICENSE
diff --git a/src/node_http_parser.cc b/src/node_http_parser.cc
index acebdd952eb943..25aa204ee2c851 100644
--- a/third_party/electron_node/src/node_http_parser.cc
+++ b/third_party/electron_node/src/node_http_parser.cc
@@ -1204,6 +1204,10 @@ void ConnectionsList::Expired(const
FunctionCallbackInfo<Value>& args) {
const llhttp_settings_t Parser::settings = {
Proxy<Call, &Parser::on_message_begin>::Raw,
+
+ // on_protocol
+ nullptr,
+
Proxy<DataCall, &Parser::on_url>::Raw,
Proxy<DataCall, &Parser::on_status>::Raw,
@@ -1223,6 +1227,8 @@ const llhttp_settings_t Parser::settings = {
Proxy<DataCall, &Parser::on_body>::Raw,
Proxy<Call, &Parser::on_message_complete>::Raw,
+ // on_protocol_complete
+ nullptr,
// on_url_complete
nullptr,
// on_status_complete
++++++ reduce-gn-tree.patch ++++++
Run gn starting at only the targets we want to build (//electron:blah), not at
(//...) to avoid hitting asserts in dead code.
This makes this overriden build argument dead code which causes a warning
during `gen` and more importantly `desc`. Remove it.
--- src/electron/build/args/all.gn 2025-05-22 20:03:50.586242102 +0200
+++ src/electron/build/args/all.gn 2025-05-22 21:32:07.485697337 +0200
@@ -1,5 +1,4 @@
is_electron_build = true
-root_extra_deps = [ "//electron" ]
# Registry of NMVs -->
https://github.com/nodejs/node/blob/main/doc/abi_version_registry.json
node_module_version = 133
All gn list calls must be also fixed because otherwise they fail just as gn gen
does
--- src/third_party/electron_node/tools/generate_config_gypi.py.orig
2025-05-22 20:19:41.558145459 +0200
+++ src/third_party/electron_node/tools/generate_config_gypi.py 2025-05-22
22:01:23.213518671 +0200
@@ -30,7 +30,13 @@ def bool_string_to_number(v):
def get_gn_config(out_dir):
# Read args from GN configurations.
gn_args = subprocess.check_output(
- [GN, 'args', '--list', '--short', '-C', out_dir])
+ [GN, 'args', '--list',
+ '--root-target=//electron:electron_app',
+ '--root-pattern=//electron:electron_app',
+ '--root-pattern=//electron:chromium_licenses',
+ '--root-pattern=//electron:copy_node_headers',
+ '--root-pattern=//electron:electron_version_file',
+ '--short', '-C', out_dir])
config = dict(re.findall(GN_RE, gn_args.decode()))
# Get napi_build_version from Node, which is not part of GN args.
config['napi_build_version'] = getnapibuildversion.get_napi_version()
