Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package qt6-networkauth for openSUSE:Factory
checked in at 2025-06-05 20:32:15
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/qt6-networkauth (Old)
and /work/SRC/openSUSE:Factory/.qt6-networkauth.new.19631 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "qt6-networkauth"
Thu Jun 5 20:32:15 2025 rev:36 rq:1282567 version:6.9.1
Changes:
--------
--- /work/SRC/openSUSE:Factory/qt6-networkauth/qt6-networkauth.changes
2025-04-07 17:35:35.682257626 +0200
+++
/work/SRC/openSUSE:Factory/.qt6-networkauth.new.19631/qt6-networkauth.changes
2025-06-05 20:32:37.553018959 +0200
@@ -1,0 +2,6 @@
+Tue Jun 3 07:49:29 UTC 2025 - Christophe Marin <[email protected]>
+
+- Update to 6.9.1:
+ * https://www.qt.io/blog/qt-6.9.1-released
+
+-------------------------------------------------------------------
Old:
----
qtnetworkauth-everywhere-src-6.9.0.tar.xz
New:
----
qtnetworkauth-everywhere-src-6.9.1.tar.xz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ qt6-networkauth.spec ++++++
--- /var/tmp/diff_new_pack.Y7J6fg/_old 2025-06-05 20:32:38.221046735 +0200
+++ /var/tmp/diff_new_pack.Y7J6fg/_new 2025-06-05 20:32:38.221046735 +0200
@@ -16,7 +16,7 @@
#
-%define real_version 6.9.0
+%define real_version 6.9.1
%define short_version 6.9
%define short_name qtnetworkauth
%define tar_name qtnetworkauth-everywhere-src
@@ -28,7 +28,7 @@
%endif
#
Name: qt6-networkauth%{?pkg_suffix}
-Version: 6.9.0
+Version: 6.9.1
Release: 0
Summary: Set of APIs to obtain limited access to online accounts and
HTTP services
License: GPL-3.0-only WITH Qt-GPL-exception-1.0
++++++ qtnetworkauth-everywhere-src-6.9.0.tar.xz ->
qtnetworkauth-everywhere-src-6.9.1.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qtnetworkauth-everywhere-src-6.9.0/.cmake.conf
new/qtnetworkauth-everywhere-src-6.9.1/.cmake.conf
--- old/qtnetworkauth-everywhere-src-6.9.0/.cmake.conf 2025-03-28
16:40:07.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/.cmake.conf 2025-05-28
21:48:57.000000000 +0200
@@ -1,4 +1,4 @@
-set(QT_REPO_MODULE_VERSION "6.9.0")
+set(QT_REPO_MODULE_VERSION "6.9.1")
set(QT_REPO_MODULE_PRERELEASE_VERSION_SEGMENT "alpha1")
set(QT_EXTRA_INTERNAL_TARGET_DEFINES "QT_NO_AS_CONST=1")
list(APPEND QT_EXTRA_INTERNAL_TARGET_DEFINES "QT_NO_FOREACH=1")
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qtnetworkauth-everywhere-src-6.9.0/.gitreview
new/qtnetworkauth-everywhere-src-6.9.1/.gitreview
--- old/qtnetworkauth-everywhere-src-6.9.0/.gitreview 1970-01-01
01:00:00.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/.gitreview 2025-05-28
21:48:57.000000000 +0200
@@ -0,0 +1,4 @@
+[gerrit]
+host=codereview.qt-project.org
+project=qt/qtnetworkauth
+defaultbranch=dev
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qtnetworkauth-everywhere-src-6.9.0/.tag
new/qtnetworkauth-everywhere-src-6.9.1/.tag
--- old/qtnetworkauth-everywhere-src-6.9.0/.tag 2025-03-28 16:40:07.000000000
+0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/.tag 2025-05-28 21:48:57.000000000
+0200
@@ -1 +1 @@
-26d7973d560c0c3307c7ef895836d95ff79a028c
+407d7cbb55139b598519e858107bb361a674e5c3
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qtnetworkauth-everywhere-src-6.9.0/REUSE.toml
new/qtnetworkauth-everywhere-src-6.9.1/REUSE.toml
--- old/qtnetworkauth-everywhere-src-6.9.0/REUSE.toml 2025-03-28
16:40:07.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/REUSE.toml 2025-05-28
21:48:57.000000000 +0200
@@ -1,11 +1,11 @@
version = 1
[[annotations]]
-path = [".tag", "**/.gitattributes", "**.gitignore"]
+path = ["**/.gitattributes", "**.gitignore", "**.gitreview"]
precedence = "closest"
-comment = "not sure at all"
+comment = "infrastructure"
SPDX-FileCopyrightText = "Copyright (C) 2024 The Qt Company Ltd."
-SPDX-License-Identifier = "BSD-3-Clause"
+SPDX-License-Identifier = "LicenseRef-Qt-Commercial OR BSD-3-Clause"
[[annotations]]
path = ["tests/**"]
@@ -14,7 +14,7 @@
SPDX-License-Identifier = "LicenseRef-Qt-Commercial OR GPL-3.0-only"
[[annotations]]
-path = [".cmake.conf", "**.yaml", "**.pro", "**ci_config_linux.json"]
+path = [".tag", ".cmake.conf", "**.yaml", "**.pro", "**ci_config_linux.json"]
precedence = "closest"
comment = "build system"
SPDX-FileCopyrightText = "Copyright (C) 2024 The Qt Company Ltd."
@@ -39,7 +39,7 @@
path = ["**.toml", "licenseRule.json"]
precedence = "override"
SPDX-FileCopyrightText = "Copyright (C) 2024 The Qt Company Ltd."
-SPDX-License-Identifier = "LicenseRef-Qt-Commercial OR
GFDL-1.3-no-invariants-only"
+SPDX-License-Identifier = "LicenseRef-Qt-Commercial OR BSD-3-Clause"
[[annotations]]
path = ["**/qt_attribution.json"]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qtnetworkauth-everywhere-src-6.9.0/dependencies.yaml
new/qtnetworkauth-everywhere-src-6.9.1/dependencies.yaml
--- old/qtnetworkauth-everywhere-src-6.9.0/dependencies.yaml 2025-03-28
16:40:07.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/dependencies.yaml 2025-05-28
21:48:57.000000000 +0200
@@ -1,4 +1,4 @@
dependencies:
../qtbase:
- ref: 25986746947798e1a22d0830d3bcb11a55fcd3ae
+ ref: 2ad23cd72d5f122f88ce95792a4323d639c27d25
required: true
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/examples/oauth/redditclient/CMakeLists.txt
new/qtnetworkauth-everywhere-src-6.9.1/examples/oauth/redditclient/CMakeLists.txt
---
old/qtnetworkauth-everywhere-src-6.9.0/examples/oauth/redditclient/CMakeLists.txt
2025-03-28 16:40:07.000000000 +0100
+++
new/qtnetworkauth-everywhere-src-6.9.1/examples/oauth/redditclient/CMakeLists.txt
2025-05-28 21:48:57.000000000 +0200
@@ -1,43 +1,34 @@
# Copyright (C) 2022 The Qt Company Ltd.
# SPDX-License-Identifier: LicenseRef-Qt-Commercial OR BSD-3-Clause
-# Generated from redditclient.pro.
-
cmake_minimum_required(VERSION 3.16)
project(redditclient LANGUAGES CXX)
-set(CMAKE_INCLUDE_CURRENT_DIR ON)
-
-set(CMAKE_AUTOMOC ON)
-set(CMAKE_AUTORCC ON)
-set(CMAKE_AUTOUIC ON)
-
if(NOT DEFINED INSTALL_EXAMPLESDIR)
set(INSTALL_EXAMPLESDIR "examples")
endif()
set(INSTALL_EXAMPLEDIR "${INSTALL_EXAMPLESDIR}/oauth/redditclient")
-find_package(Qt6 COMPONENTS Core)
-find_package(Qt6 COMPONENTS Gui)
-find_package(Qt6 COMPONENTS Widgets)
-find_package(Qt6 COMPONENTS Network)
-find_package(Qt6 COMPONENTS NetworkAuth)
+find_package(Qt6 REQUIRED COMPONENTS Core Gui Network NetworkAuth Widgets)
+
+qt_standard_project_setup()
qt_add_executable(redditclient
main.cpp
redditmodel.cpp redditmodel.h
)
+
set_target_properties(redditclient PROPERTIES
WIN32_EXECUTABLE TRUE
MACOSX_BUNDLE TRUE
)
-target_link_libraries(redditclient PUBLIC
- Qt::Core
- Qt::Gui
- Qt::Network
- Qt::NetworkAuth
- Qt::Widgets
+target_link_libraries(redditclient PRIVATE
+ Qt6::Core
+ Qt6::Gui
+ Qt6::Network
+ Qt6::NetworkAuth
+ Qt6::Widgets
)
install(TARGETS redditclient
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/examples/oauth/redditclient/doc/src/qtnetworkauth-redditclient.qdoc
new/qtnetworkauth-everywhere-src-6.9.1/examples/oauth/redditclient/doc/src/qtnetworkauth-redditclient.qdoc
---
old/qtnetworkauth-everywhere-src-6.9.0/examples/oauth/redditclient/doc/src/qtnetworkauth-redditclient.qdoc
2025-03-28 16:40:07.000000000 +0100
+++
new/qtnetworkauth-everywhere-src-6.9.1/examples/oauth/redditclient/doc/src/qtnetworkauth-redditclient.qdoc
2025-05-28 21:48:57.000000000 +0200
@@ -14,9 +14,12 @@
Reddit posts (in text format) associated with the authenticated user.
To use this example, a consumer key from Reddit is needed.
- To register the application visit https://www.reddit.com/prefs/apps/.
+ To register the application visit \l{https://www.reddit.com/prefs/apps/}.
\note Choose \e {installed app} when creating the application.
\note Set the redirect URI to \e http://localhost:1337/ in Reddit settings.
\include examples-run.qdocinc
+
+ Before launching, add \c --client-id to the executable command line,
+ followed by your consumer key from \l {https://www.reddit.com/prefs/apps/}.
*/
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/examples/oauth/redditclient/main.cpp
new/qtnetworkauth-everywhere-src-6.9.1/examples/oauth/redditclient/main.cpp
--- old/qtnetworkauth-everywhere-src-6.9.0/examples/oauth/redditclient/main.cpp
2025-03-28 16:40:07.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/examples/oauth/redditclient/main.cpp
2025-05-28 21:48:57.000000000 +0200
@@ -3,10 +3,10 @@
#include "redditmodel.h"
-#include <QtWidgets/qapplication.h>
-#include <QtWidgets/qlistview.h>
+#include <QCommandLineParser>
-#include <QtCore/qcommandlineparser.h>
+#include <QApplication>
+#include <QListView>
using namespace Qt::StringLiterals;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/examples/oauth/redditclient/redditmodel.cpp
new/qtnetworkauth-everywhere-src-6.9.1/examples/oauth/redditclient/redditmodel.cpp
---
old/qtnetworkauth-everywhere-src-6.9.0/examples/oauth/redditclient/redditmodel.cpp
2025-03-28 16:40:07.000000000 +0100
+++
new/qtnetworkauth-everywhere-src-6.9.1/examples/oauth/redditclient/redditmodel.cpp
2025-05-28 21:48:57.000000000 +0200
@@ -3,15 +3,15 @@
#include "redditmodel.h"
-#include <QtNetworkAuth/qoauthhttpserverreplyhandler.h>
+#include <QJsonArray>
-#include <QtGui/qdesktopservices.h>
+#include <QDesktopServices>
-#include <QtNetwork/qrestaccessmanager.h>
-#include <QtNetwork/qrestreply.h>
+#include <QNetworkAccessManager>
+#include <QRestAccessManager>
+#include <QRestReply>
-#include <QtCore/qjsonarray.h>
-#include <QtCore/qjsondocument.h>
+#include <QOAuthHttpServerReplyHandler>
using namespace Qt::StringLiterals;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/examples/oauth/redditclient/redditmodel.h
new/qtnetworkauth-everywhere-src-6.9.1/examples/oauth/redditclient/redditmodel.h
---
old/qtnetworkauth-everywhere-src-6.9.0/examples/oauth/redditclient/redditmodel.h
2025-03-28 16:40:07.000000000 +0100
+++
new/qtnetworkauth-everywhere-src-6.9.1/examples/oauth/redditclient/redditmodel.h
2025-05-28 21:48:57.000000000 +0200
@@ -4,13 +4,13 @@
#ifndef REDDITMODEL_H
#define REDDITMODEL_H
-#include <QtNetworkAuth/qoauth2authorizationcodeflow.h>
+#include <QAbstractTableModel>
+#include <QJsonObject>
+#include <QModelIndex>
-#include <QtNetwork/qnetworkrequestfactory.h>
+#include <QNetworkRequestFactory>
-#include <QtCore/qabstractitemmodel.h>
-#include <QtCore/qjsonobject.h>
-#include <QtCore/qpointer.h>
+#include <QOAuth2AuthorizationCodeFlow>
QT_FORWARD_DECLARE_CLASS(QRestAccessManager)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/qtnetworkauth-everywhere-src-6.9.0/licenseRule.json
new/qtnetworkauth-everywhere-src-6.9.1/licenseRule.json
--- old/qtnetworkauth-everywhere-src-6.9.0/licenseRule.json 2025-03-28
16:40:07.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/licenseRule.json 2025-05-28
21:48:57.000000000 +0200
@@ -1,6 +1,6 @@
[
{
- "comment" : ["file_pattern_ending: strings matched against the end of
a file name.",
+ "comment": ["file_pattern_ending: strings matched against the end of a
file name.",
"location keys: regular expression matched against the
beginning of",
"the file path (relative to the git submodule root).",
"spdx: list of SPDX-License-Expression's allowed in the
matching files.",
@@ -9,98 +9,110 @@
"unless they are examples",
"Files with other endings can also be build system files"
],
- "file_pattern_ending" : ["CMakeLists.txt", ".cmake", ".pro", ".pri",
".prf",
+ "file_pattern_ending": ["CMakeLists.txt", ".cmake", ".pro", ".pri",
".prf",
"configure", "configure.bat", "cmake.in", "plist.in",
"CMakeLists.txt.in",
- ".cmake.conf", ".gitattributes", ".gitignore", ".tag",
"ci_config_linux.json",
+ ".cmake.conf", ".tag", "ci_config_linux.json",
".yaml"],
- "location" : {
- "" : {
- "comment" : "Default",
- "file type" : "build system",
- "spdx" : ["BSD-3-Clause"]
- },
- "(.*)(examples/|snippets/)" : {
- "comment" : "Example takes precedence",
- "file type" : "examples and snippets",
- "spdx" : ["LicenseRef-Qt-Commercial OR BSD-3-Clause"]
- },
- "tests/manual/examples/twittertimeline/" : {
- "comment" : "test, not example",
- "file type" : "build system",
- "spdx" : ["BSD-3-Clause"]
+ "location": {
+ "": {
+ "comment": "Default",
+ "file type": "build system",
+ "spdx": ["BSD-3-Clause"]
+ },
+ "(.*)(examples/|snippets/)": {
+ "comment": "Example takes precedence",
+ "file type": "examples and snippets",
+ "spdx": ["LicenseRef-Qt-Commercial OR BSD-3-Clause"]
+ },
+ "tests/manual/examples/twittertimeline/": {
+ "comment": "test, not example",
+ "file type": "build system",
+ "spdx": ["BSD-3-Clause"]
}
}
},
{
- "comments" : ["Files with the following endings are Tool licensed,",
+ "comments": ["Files with the following endings are infrastructure
licensed"],
+ "file_pattern_ending": [".gitattributes", ".gitignore", ".gitmodules",
".gitreview",
+ "_clang-format", "licenseRule.json",
"REUSE.toml"],
+ "location":{
+ "": {
+ "comment": "Default",
+ "file type": "infrastructure",
+ "spdx": ["LicenseRef-Qt-Commercial OR BSD-3-Clause"]
+ }
+ }
+ },
+ {
+ "comments": ["Files with the following endings are Tool licensed,",
"unless they are examples.",
"Files with other endings can also be tool files."],
- "file_pattern_ending" : [".sh", ".py", ".pl", ".bat", ".ps1"],
- "location" :{
- "" : {
- "comment" : "Default",
- "file type" : "tools and utils",
- "spdx" : ["LicenseRef-Qt-Commercial OR GPL-3.0-only WITH
Qt-GPL-exception-1.0"]
- },
- "(.*)(examples/|snippets/)" : {
- "comment" : "Example takes precedence",
- "file type" : "examples and snippets",
- "spdx" : ["LicenseRef-Qt-Commercial OR BSD-3-Clause"]
+ "file_pattern_ending": [".sh", ".py", ".pl", ".bat", ".ps1"],
+ "location":{
+ "": {
+ "comment": "Default",
+ "file type": "tools and utils",
+ "spdx": ["LicenseRef-Qt-Commercial OR GPL-3.0-only WITH
Qt-GPL-exception-1.0"]
+ },
+ "(.*)(examples/|snippets/)": {
+ "comment": "Example takes precedence",
+ "file type": "examples and snippets",
+ "spdx": ["LicenseRef-Qt-Commercial OR BSD-3-Clause"]
}
}
},
{
- "comment" : "Files with the following endings are Documentation
licensed.",
- "file_pattern_ending" : [".qdoc", ".qdocinc" , ".qdocconf", "README",
"qt_attribution.json",
- "REUSE.toml", "licenseRule.json", ".webp"],
- "location" :{
- "" : {
- "comment" : "",
- "file type" : "documentation",
- "spdx" : ["LicenseRef-Qt-Commercial OR
GFDL-1.3-no-invariants-only"]
+ "comment": "Files with the following endings are Documentation
licensed.",
+ "file_pattern_ending": [".qdoc", ".qdocinc" , ".qdocconf", "README",
"qt_attribution.json",
+ ".webp"],
+ "location":{
+ "": {
+ "comment": "",
+ "file type": "documentation",
+ "spdx": ["LicenseRef-Qt-Commercial OR
GFDL-1.3-no-invariants-only"]
}
}
},
{
- "comment" : ["All other files",
+ "comment": ["All other files",
"The licensing is defined only by the file location in
the Qt module repository.",
"NO <file_pattern_ending> key for this case!",
"This needs to be the last entry of the file."],
- "location" : {
- "" : {
- "comment" : "Default",
- "file type" : "module and plugin",
- "spdx" : ["LicenseRef-Qt-Commercial OR GPL-3.0-only"]
- },
- "dist/" : {
- "comment" : "Default",
- "file type" : "documentation",
- "spdx" : ["LicenseRef-Qt-Commercial OR
GFDL-1.3-no-invariants-only"]
- },
- "src/" : {
- "comment" : "Default",
- "file type" : "module and plugin",
- "spdx" : ["LicenseRef-Qt-Commercial OR GPL-3.0-only"]
- },
- "tests/" : {
- "comment" : "Default",
- "file type" : "test",
- "spdx" : ["LicenseRef-Qt-Commercial OR GPL-3.0-only"]
- },
- "tests/manual/examples/twittertimeline/twitterdialog.ui" : {
- "comment" : "Default",
- "file type" : "test",
- "spdx" : ["LicenseRef-Qt-Commercial OR GPL-3.0-only"]
- },
- "(.*)(examples/|snippets/)" : {
- "comment" : "Default",
- "file type" : "examples and snippets",
- "spdx" : ["LicenseRef-Qt-Commercial OR BSD-3-Clause"]
- },
- "(.*|examples).*/doc/images" : {
- "comment" : "Default",
- "file type" : "documentation",
- "spdx" : ["LicenseRef-Qt-Commercial OR
GFDL-1.3-no-invariants-only"]
+ "location": {
+ "": {
+ "comment": "Default",
+ "file type": "module and plugin",
+ "spdx": ["LicenseRef-Qt-Commercial OR GPL-3.0-only"]
+ },
+ "dist/": {
+ "comment": "Default",
+ "file type": "documentation",
+ "spdx": ["LicenseRef-Qt-Commercial OR
GFDL-1.3-no-invariants-only"]
+ },
+ "src/": {
+ "comment": "Default",
+ "file type": "module and plugin",
+ "spdx": ["LicenseRef-Qt-Commercial OR GPL-3.0-only"]
+ },
+ "tests/": {
+ "comment": "Default",
+ "file type": "test",
+ "spdx": ["LicenseRef-Qt-Commercial OR GPL-3.0-only"]
+ },
+ "tests/manual/examples/twittertimeline/twitterdialog.ui": {
+ "comment": "Default",
+ "file type": "test",
+ "spdx": ["LicenseRef-Qt-Commercial OR GPL-3.0-only"]
+ },
+ "(.*)(examples/|snippets/)": {
+ "comment": "Default",
+ "file type": "examples and snippets",
+ "spdx": ["LicenseRef-Qt-Commercial OR BSD-3-Clause"]
+ },
+ "(.*|examples).*/doc/images": {
+ "comment": "Default",
+ "file type": "documentation",
+ "spdx": ["LicenseRef-Qt-Commercial OR
GFDL-1.3-no-invariants-only"]
}
}
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qabstractoauth.cpp
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qabstractoauth.cpp
--- old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qabstractoauth.cpp
2025-03-28 16:40:07.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qabstractoauth.cpp
2025-05-28 21:48:57.000000000 +0200
@@ -1,5 +1,6 @@
// Copyright (C) 2017 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
+// Qt-Security score:critical reason:authorization-protocol
#include <qabstractoauth.h>
#include <qabstractoauthreplyhandler.h>
@@ -19,8 +20,6 @@
#include <QtCore/qrandom.h>
#include <QtCore/private/qlocking_p.h>
-#include <utility>
-
QT_BEGIN_NAMESPACE
/*!
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qabstractoauth2.cpp
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qabstractoauth2.cpp
--- old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qabstractoauth2.cpp
2025-03-28 16:40:07.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qabstractoauth2.cpp
2025-05-28 21:48:57.000000000 +0200
@@ -1,5 +1,6 @@
// Copyright (C) 2017 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
+// Qt-Security score:critical reason:authorization-protocol
#include <qabstractoauth2.h>
#include <private/qabstractoauth2_p.h>
@@ -713,7 +714,7 @@
//
// Note: 'scope' variable has two roles: requested scope, and later
granted scope.
// Therefore 'scope' needs to be set if the granted scope differs from
'scope'.
- const QString receivedGrantedScope =
values.value(QtOAuth2RfcKeywords::scope).toString();
+ QString receivedGrantedScope =
values.value(QtOAuth2RfcKeywords::scope).toString();
const QSet<QByteArray> splitGrantedScope =
splitScope(receivedGrantedScope);
if (splitGrantedScope.isEmpty()) {
setGrantedScopeTokens(requestedScopeTokens);
@@ -721,7 +722,7 @@
setGrantedScopeTokens(splitGrantedScope);
#ifndef QOAUTH2_NO_LEGACY_SCOPE
if (receivedGrantedScope != legacyScope) {
- legacyScope = receivedGrantedScope;
+ legacyScope = std::move(receivedGrantedScope);
QT_IGNORE_DEPRECATIONS(Q_EMIT q->scopeChanged(legacyScope);)
}
#endif
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qabstractoauth_p.h
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qabstractoauth_p.h
--- old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qabstractoauth_p.h
2025-03-28 16:40:07.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qabstractoauth_p.h
2025-05-28 21:48:57.000000000 +0200
@@ -60,7 +60,6 @@
QUrl authorizationUrl;
QVariantMap extraTokens;
QAbstractOAuth::Status status = QAbstractOAuth::Status::NotAuthenticated;
- QNetworkAccessManager::Operation operation;
QPointer<QAbstractOAuthReplyHandler> replyHandler;
QScopedPointer<QOAuthOobReplyHandler> defaultReplyHandler;
QPointer<QNetworkAccessManager> networkAccessManagerPointer;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauth1.cpp
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauth1.cpp
--- old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauth1.cpp
2025-03-28 16:40:07.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauth1.cpp
2025-05-28 21:48:57.000000000 +0200
@@ -1,5 +1,6 @@
// Copyright (C) 2017 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
+// Qt-Security score:critical reason:authorization-protocol
#include "qoauth1.h"
#include "qoauth1_p.h"
@@ -150,8 +151,8 @@
QMultiMap<QString, QVariant> remainingParameters;
appendCommonHeaders(&headers);
for (auto it = parameters.begin(), end = parameters.end(); it != end;
++it) {
- const auto key = it.key();
- const auto value = it.value();
+ const auto &key = it.key();
+ const auto &value = it.value();
if (key.startsWith(QStringLiteral("oauth_")))
headers.insert(key, value);
else
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauth1signature.cpp
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauth1signature.cpp
--- old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauth1signature.cpp
2025-03-28 16:40:07.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauth1signature.cpp
2025-05-28 21:48:57.000000000 +0200
@@ -1,5 +1,6 @@
// Copyright (C) 2017 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
+// Qt-Security score:critical reason:authorization-protocol
#include "qoauth1signature.h"
#include "qoauth1signature_p.h"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauth2authorizationcodeflow.cpp
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauth2authorizationcodeflow.cpp
---
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauth2authorizationcodeflow.cpp
2025-03-28 16:40:07.000000000 +0100
+++
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauth2authorizationcodeflow.cpp
2025-05-28 21:48:57.000000000 +0200
@@ -1,5 +1,6 @@
// Copyright (C) 2017 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
+// Qt-Security score:critical reason:authorization-protocol
#include <qoauth2authorizationcodeflow.h>
#include <private/qoauth2authorizationcodeflow_p.h>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauth2deviceauthorizationflow.cpp
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauth2deviceauthorizationflow.cpp
---
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauth2deviceauthorizationflow.cpp
2025-03-28 16:40:07.000000000 +0100
+++
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauth2deviceauthorizationflow.cpp
2025-05-28 21:48:57.000000000 +0200
@@ -1,5 +1,6 @@
// Copyright (C) 2024 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
+// Qt-Security score:critical reason:authorization-protocol
#include <private/qoauth2deviceauthorizationflow_p.h>
#include <QtNetworkAuth/qoauth2deviceauthorizationflow.h>
@@ -200,7 +201,7 @@
// https://datatracker.ietf.org/doc/html/rfc8628#section-3.2 REQUIRED
parameters
const auto receivedDeviceCode =
data.value(QtOAuth2RfcKeywords::deviceCode).toString();
- const auto receivedUserCode =
data.value(QtOAuth2RfcKeywords::userCode).toString();
+ auto receivedUserCode =
data.value(QtOAuth2RfcKeywords::userCode).toString();
const auto receivedExpiresIn =
data.value(QtOAuth2RfcKeywords::expiresIn).toInt();
QUrl receivedVerificationUrl;
// The RFC keyword is 'verification_uri', but some auth servers provide
'verification_url'
@@ -251,7 +252,7 @@
data.value(QtOAuth2RfcKeywords::completeVerificationUrl).toString();
}
- deviceCode = receivedDeviceCode;
+ deviceCode = std::move(receivedDeviceCode);
setUserCode(receivedUserCode);
setVerificationUrl(receivedVerificationUrl);
setVerificationUrlComplete(receivedVerificationUrlComplete);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauthhttpserverreplyhandler.cpp
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauthhttpserverreplyhandler.cpp
---
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauthhttpserverreplyhandler.cpp
2025-03-28 16:40:07.000000000 +0100
+++
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauthhttpserverreplyhandler.cpp
2025-05-28 21:48:57.000000000 +0200
@@ -1,5 +1,6 @@
// Copyright (C) 2017 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
+// Qt-Security score:critical reason:authorization-protocol
#include <qabstractoauth.h>
#include <qoauthhttpserverreplyhandler.h>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauthoobreplyhandler.cpp
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauthoobreplyhandler.cpp
--- old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauthoobreplyhandler.cpp
2025-03-28 16:40:07.000000000 +0100
+++ new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauthoobreplyhandler.cpp
2025-05-28 21:48:57.000000000 +0200
@@ -1,9 +1,9 @@
// Copyright (C) 2017 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
+// Qt-Security score:critical reason:authorization-protocol
#include "qoauthoobreplyhandler.h"
#include "qoauthoobreplyhandler_p.h"
-#include "qabstractoauthreplyhandler_p.h"
#include <QtCore/qurlquery.h>
#include <QtCore/qjsonobject.h>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauthurischemereplyhandler.cpp
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauthurischemereplyhandler.cpp
---
old/qtnetworkauth-everywhere-src-6.9.0/src/oauth/qoauthurischemereplyhandler.cpp
2025-03-28 16:40:07.000000000 +0100
+++
new/qtnetworkauth-everywhere-src-6.9.1/src/oauth/qoauthurischemereplyhandler.cpp
2025-05-28 21:48:57.000000000 +0200
@@ -1,5 +1,6 @@
// Copyright (C) 2024 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
+// Qt-Security score:critical reason:authorization-protocol
#include "qabstractoauthreplyhandler_p.h" // for lcReplyHandler()
#include "qoauthoobreplyhandler_p.h"
