Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package smartmontools for openSUSE:Factory checked in at 2026-05-05 15:14:23 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/smartmontools (Old) and /work/SRC/openSUSE:Factory/.smartmontools.new.30200 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "smartmontools" Tue May 5 15:14:23 2026 rev:96 rq:1350649 version:7.5 Changes: -------- --- /work/SRC/openSUSE:Factory/smartmontools/smartmontools.changes 2025-12-02 13:19:53.214174744 +0100 +++ /work/SRC/openSUSE:Factory/.smartmontools.new.30200/smartmontools.changes 2026-05-05 15:14:24.732805044 +0200 @@ -1,0 +2,12 @@ +Mon Mar 30 08:08:16 UTC 2026 - Stanislav Brabec <[email protected]> + +- NEW DEFAULT: Never check disks that do not spin + (boo#1259501, smartmontools-suse-default.patch). +- Generate smartd.opts, even if smartd_opts is empty. +- Use "systemctl" instead of "service" + (boo#1259501#c4, smartmontools.generate_smartd_opts.in). +- Fix the package for immutable mode + (jsc#PED-14826, smartmontools.tmpfiles.in). +- Remove obsolete checks from smartmontools-rpmlintrc. + +------------------------------------------------------------------- New: ---- smartmontools.tmpfiles.in ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ smartmontools.spec ++++++ --- /var/tmp/diff_new_pack.DHD5I7/_old 2026-05-05 15:14:25.808849602 +0200 +++ /var/tmp/diff_new_pack.DHD5I7/_new 2026-05-05 15:14:25.808849602 +0200 @@ -1,7 +1,7 @@ # # spec file for package smartmontools # -# Copyright (c) 2025 SUSE LLC and contributors +# Copyright (c) 2026 SUSE LLC and contributors # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -40,6 +40,7 @@ Source7: smartmontools-drivedb.h Source8: smartd_generate_opts.path Source9: smartd_generate_opts.service +Source10: %{name}.tmpfiles.in # PATCH-FEATURE-UPSTREAM smartmontools-update-smart-drivedb.patch [email protected] -- Support download from smartmontools migrated to github (cummulative patch). Patch1: smartmontools-update-smart-drivedb.patch # PATCH-FEATURE-OPENSUSE smartmontools-suse-default.patch [email protected] -- Define smart SUSE defaults. @@ -75,9 +76,11 @@ %prep %autosetup -p1 -cp -a %{SOURCE2} %{SOURCE5} . +cp -a %{SOURCE2} . +cp -a %{SOURCE5} generate_smartd_opts.in # Following line is handled by smartmontools-drivedb_h-update.sh. cp -a %{SOURCE7} drivedb.h.new +cp -a %{SOURCE10} %{name}.tmpfiles.in # # PATCH-FEATURE-OPENSUSE (sed on smartd.service.in) [email protected] -- Use generated smartd_opts (from SUSE sysconfig file). Systemd smartd.service cannot be smart enough to parse SUSE sysconfig file and generate smartd_opts on fly. And we do not want to launch shell just for it in every boot. sed "s:/usr/local/etc/sysconfig/smartmontools:%{_sharedstatedir}/smartmontools/smartd_opts:" <smartd.service.in >smartd.service.in.new @@ -126,8 +129,10 @@ --with-nvme-devicescan %make_build BUILD_INFO='"(SUSE RPM)"' -SERVICE=%{_sbindir}/service -sed "s:@prefix@:%{_prefix}:g;s:@localstatedir@:%{_localstatedir}:g;s:@SERVICE@:$SERVICE:" <smartmontools.generate_smartd_opts.in >generate_smartd_opts +SERVICE=%{_bindir}/systemctl +for NAME in generate_smartd_opts %{name}.tmpfiles ; do + sed "s:@prefix@:%{_prefix}:g;s:@localstatedir@:%{_localstatedir}:g;s:@SYSTEMCTL@:$SERVICE:" <$NAME.in >$NAME +done %install %make_install @@ -147,6 +152,9 @@ rm %{buildroot}%{_defaultdocdir}/%{name}/INSTALL # Create empty ghost files for files created by update-smart-drivedb. touch %{buildroot}%{_sharedstatedir}/smartmontools/drivedb.h{,.{asc,error,error.raw,error.raw.asc,lastcheck,old,old.raw,old.raw.asc,raw,raw.asc}} +# install tmpfiles +mkdir -p %{buildroot}%{_prefix}/lib/tmpfiles.d +install -m 644 %{name}.tmpfiles %{buildroot}%{_prefix}/lib/tmpfiles.d/%{name}.conf # Check syntax of drivedb.h that may come from a later snapshot (code from update-smart-drivedb) if ./smartctl -B drivedb.h -P showall >/dev/null; then :; else @@ -183,6 +191,7 @@ fi %post +%tmpfiles_create %{name}.conf # First prepare sysconfig. %fillup_only # Up to Leap 42.3 and SLE 15 SP3 Maintenance Update there was a "Command" meta comment in the sysconfig file. @@ -248,10 +257,9 @@ %files %doc %{_docdir}/%{name} -%dir %{_datadir}/smartmontools -%verify(not md5 size mtime) %{_datadir}/smartmontools/drivedb.h +%{_datadir}/smartmontools %{_mandir}/man*/* -%dir %{_sharedstatedir}/smartmontools +%ghost %dir %{_sharedstatedir}/smartmontools %ghost %{_sharedstatedir}/smartmontools/smartd_opts %ghost %{_sharedstatedir}/smartmontools/drivedb.h %ghost %{_sharedstatedir}/smartmontools/drivedb.h.asc @@ -265,6 +273,7 @@ %ghost %{_sharedstatedir}/smartmontools/drivedb.h.raw %ghost %{_sharedstatedir}/smartmontools/drivedb.h.raw.asc %{_prefix}/lib/smartmontools +%{_prefix}/lib/tmpfiles.d/%{name}.conf %{_unitdir}/* %{_sbindir}/* %config(noreplace) %{_sysconfdir}/smart_drivedb.h ++++++ smartd_generate_opts.service ++++++ --- /var/tmp/diff_new_pack.DHD5I7/_old 2026-05-05 15:14:25.860851756 +0200 +++ /var/tmp/diff_new_pack.DHD5I7/_new 2026-05-05 15:14:25.864851921 +0200 @@ -1,6 +1,7 @@ [Unit] Description=Update smartd options Wants=local-fs.target +Before=smartd.service [Service] # added automatically, for details please see ++++++ smartmontools-rpmlintrc ++++++ --- /var/tmp/diff_new_pack.DHD5I7/_old 2026-05-05 15:14:25.928854571 +0200 +++ /var/tmp/diff_new_pack.DHD5I7/_new 2026-05-05 15:14:25.928854571 +0200 @@ -1,7 +1,3 @@ # Two .h files are config files in C include file format addFilter("devel-file-in-non-devel-package") -# Use the name registered by LANANA -addFilter("incoherent-init-script-name smartd") -# Still valid for SLE10 -addFilter("obsolete-suse-version-check 1020") ++++++ smartmontools-suse-default.patch ++++++ --- /var/tmp/diff_new_pack.DHD5I7/_old 2026-05-05 15:14:25.944855234 +0200 +++ /var/tmp/diff_new_pack.DHD5I7/_new 2026-05-05 15:14:25.948855399 +0200 @@ -2,7 +2,7 @@ =================================================================== --- a/smartd.conf +++ b/smartd.conf -@@ -9,6 +9,15 @@ +@@ -9,6 +9,17 @@ # device per line. Text after a hash (#) is ignored, and you may use # spaces and tabs for white space. You may use '\' to continue lines. @@ -13,7 +13,9 @@ +# (Takes several minutes.) +# -s L/: Run Extended Self Test every first Sunday in the +# month. (Start earlier, it could take tens of hours.) -+DEFAULT -d removable -s (S/../.././03|L/../(01|02|03|04|05|06|07)/7/01) ++# -n standby,q Never check disks that do not spin and do not report ++# about it. ++DEFAULT -d removable -s (S/../.././03|L/../(01|02|03|04|05|06|07)/7/01) -n standby,q + # The word DEVICESCAN will cause any remaining lines in this # configuration file to be ignored: it tells smartd to scan for all ++++++ smartmontools.generate_smartd_opts.in ++++++ --- /var/tmp/diff_new_pack.DHD5I7/_old 2026-05-05 15:14:25.976856559 +0200 +++ /var/tmp/diff_new_pack.DHD5I7/_new 2026-05-05 15:14:25.980856724 +0200 @@ -14,7 +14,7 @@ # Following code should be in sync with sysv init script for older distros! # source configuration file. -smartd_opts= +smartd_opts=@UNDEFINED@ [ -r @localstatedir@/lib/smartmontools/smartd_opts ] && . @localstatedir@/lib/smartmontools/smartd_opts smartd_opts_old="$smartd_opts" [ -r /etc/sysconfig/smartmontools ] && . /etc/sysconfig/smartmontools @@ -50,6 +50,6 @@ # SMARTD_SKIP_INIT is used during installation. if test -z "$SMARTD_SKIP_INIT" ; then # Behavior of both "Command" and "ServiceRestart" is undefined. Restart service here. - @SERVICE@ smartd try-restart + @SYSTEMCTL@ smartd try-restart fi ++++++ smartmontools.tmpfiles.in ++++++ d @localstatedir@/lib/smartmontools 0755 - - -
