Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package lalapps for openSUSE:Factory checked 
in at 2021-09-15 22:51:28
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/lalapps (Old)
 and      /work/SRC/openSUSE:Factory/.lalapps.new.1899 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "lalapps"

Wed Sep 15 22:51:28 2021 rev:4 rq:919087 version:7.2.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/lalapps/lalapps.changes  2021-06-12 
20:10:45.261210975 +0200
+++ /work/SRC/openSUSE:Factory/.lalapps.new.1899/lalapps.changes        
2021-09-15 22:51:47.242935708 +0200
@@ -1,0 +2,9 @@
+Mon Sep 13 13:58:08 UTC 2021 - Atri Bhattacharya <[email protected]>
+
+- Add lalapps-disable-testWeave-for-non-x86_64.patch: Disable
+  Weave related tests on all but x86_64 where tolerance errors
+  show up, see https://git.ligo.org/lscsoft/lalsuite/-/issues/105,
+  boo#1189928; introduces BuildRequires: libtool and requires
+  running autoreconf before configure.
+
+-------------------------------------------------------------------

New:
----
  lalapps-disable-testWeave-for-non-x86_64.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ lalapps.spec ++++++
--- /var/tmp/diff_new_pack.oTpYrv/_old  2021-09-15 22:51:47.878936468 +0200
+++ /var/tmp/diff_new_pack.oTpYrv/_new  2021-09-15 22:51:47.882936472 +0200
@@ -31,6 +31,8 @@
 Patch0:         lalapps-fix-uninitialised-var.patch
 # PATCH-FIX-UPSTREAM lalapps-gcc11-array-bounds-decl.patch 
[email protected] -- Fix building with gcc 11 by correcting array bounds 
declaration; patch part of upstream merge request 
[https://git.ligo.org/lscsoft/lalsuite/-/merge_requests/1605]
 Patch1:         lalapps-gcc11-array-bounds-decl.patch
+# PATCH-FIX-UPSTREAM lalapps-disable-testWeave-for-non-x86_64.patch 
[email protected] -- Disable Weave related tests on all but x86_64 where 
tolerance errors show up, see https://git.ligo.org/lscsoft/lalsuite/-/issues/105
+Patch2:         lalapps-disable-testWeave-for-non-x86_64.patch
 BuildRequires:  %{python_module astropy}
 BuildRequires:  %{python_module devel}
 BuildRequires:  %{python_module glue}
@@ -67,6 +69,9 @@
 BuildRequires:  lalpulsar-data
 Requires:       python3-%{name} = %{version}
 # /SECTION
+# SECTION Required for Patch2
+BuildRequires:  libtool
+# /SECTION
 # 32-bit no longer supported upstream
 ExcludeArch:    %{ix86}
 %define python_subpackage_only 1
@@ -110,6 +115,8 @@
   src/pulsar/HeterodyneSearch/make_frame_cache
 
 %build
+# Patch2 touches autotool files
+autoreconf -fvi
 %{python_expand # Necessary to run %%configure for all active python flavors
 export PYTHON=%{_bindir}/$python
 mkdir ../$python
@@ -117,7 +124,6 @@
 pushd ../$python
 # FIXME: Failures because XLAL_ERROR implictly converts to function return type
 export CFLAGS+=" -Wno-enum-conversion"
-%configure \
 %configure --enable-swig
 %make_build
 popd

++++++ lalapps-disable-testWeave-for-non-x86_64.patch ++++++
Index: lalapps-7.2.0/src/pulsar/Weave/Makefile.am
===================================================================
--- lalapps-7.2.0.orig/src/pulsar/Weave/Makefile.am
+++ lalapps-7.2.0/src/pulsar/Weave/Makefile.am
@@ -75,5 +75,10 @@ if !CFITSIO
 skip_tests += $(test_scripts)
 endif
 
+# Skip Weave tests on non-x86_64
+if SKIP_WEAVE_TESTS
+skip_tests += $(test_scripts)
+endif
+
 # testWeave_reference_results.sh requires output from tests that compare 
against reference results
 testWeave_reference_results.log: testWeave_interpolating.log 
testWeave_non_interpolating.log testWeave_single_segment.log
Index: lalapps-7.2.0/configure.ac
===================================================================
--- lalapps-7.2.0.orig/configure.ac
+++ lalapps-7.2.0/configure.ac
@@ -318,6 +318,13 @@ AM_CPPFLAGS="-I\$(top_srcdir)/src ${AM_C
 # RedHat-derived systems.
 AC_SUBST([pkgpythondir], ["\${pkgpyexecdir}"])
 
+# testWeave_* results have tolerance issues that show up in some archs, use 
only for x86_64
+# See https://git.ligo.org/lscsoft/lalsuite/-/issues/105
+AC_MSG_CHECKING([if arch is non-x86_64 so weave tests should be disabled])
+AC_DEFINE([SKIP_WEAVE_TESTS], [0], [Set to 1 for non-x86_64 architectures])
+AS_IF([test x"$(arch)" != "xx86_64"], AC_MSG_RESULT([yes]), 
AC_MSG_RESULT([no]))
+AM_CONDITIONAL([SKIP_WEAVE_TESTS], [test x"$(arch)" != "xx86_64"])
+
 # output
 AC_OUTPUT
 AC_MSG_NOTICE([

Reply via email to