Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package applet-window-buttons for
openSUSE:Factory checked in at 2021-10-21 23:55:27
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/applet-window-buttons (Old)
and /work/SRC/openSUSE:Factory/.applet-window-buttons.new.1890 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "applet-window-buttons"
Thu Oct 21 23:55:27 2021 rev:11 rq:926771 version:0.10.0
Changes:
--------
---
/work/SRC/openSUSE:Factory/applet-window-buttons/applet-window-buttons.changes
2021-07-22 22:43:57.147153509 +0200
+++
/work/SRC/openSUSE:Factory/.applet-window-buttons.new.1890/applet-window-buttons.changes
2021-10-21 23:55:45.120032452 +0200
@@ -1,0 +2,17 @@
+Thu Oct 21 12:58:27 UTC 2021 - Cor Blom <[email protected]>
+
+- Update to 0.10.0:
+ * Support Plasma 5.23
+ * Depend only on Plasma and KDecorations2 >=5.23
+ * drop option for plasma panels to disable decoration on maximized
+ windows
+- Remove fix-for-plasma-5.23.patch, part of this release
+
+-------------------------------------------------------------------
+Thu Oct 21 06:23:31 UTC 2021 - Cor Blom <[email protected]>
+
+- Add fix-for-plasma-5.23.patch to fix build with Plasma 5.23
+- This means Plasma 5.23 (specifically kdecoration) 5.23 is now
+ the minumum requirement
+
+-------------------------------------------------------------------
Old:
----
applet-window-buttons-0.9.0.tar.gz
New:
----
applet-window-buttons-0.10.0.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ applet-window-buttons.spec ++++++
--- /var/tmp/diff_new_pack.n3LKRE/_old 2021-10-21 23:55:46.216033016 +0200
+++ /var/tmp/diff_new_pack.n3LKRE/_new 2021-10-21 23:55:46.220033017 +0200
@@ -20,7 +20,7 @@
%define qt5_version 5.9
Name: applet-window-buttons
-Version: 0.9.0
+Version: 0.10.0
Release: 0
Summary: Plasma 5 applet to show window buttons in panels
License: GPL-2.0-or-later
@@ -39,8 +39,8 @@
BuildRequires: kxmlgui-devel >= %{kf5_version}
BuildRequires: libSM-devel
BuildRequires: plasma-framework-devel >= %{kf5_version}
-BuildRequires: plasma5-workspace-devel >= 5.12
-BuildRequires: cmake(KDecoration2) >= 5.12
+BuildRequires: plasma5-workspace-devel >= 5.23
+BuildRequires: cmake(KDecoration2) >= 5.23
BuildRequires: cmake(Qt5Core) >= %{qt5_version}
BuildRequires: cmake(Qt5DBus) >= %{qt5_version}
BuildRequires: cmake(Qt5Quick) >= %{qt5_version}
++++++ applet-window-buttons-0.9.0.tar.gz ->
applet-window-buttons-0.10.0.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/applet-window-buttons-0.9.0/CHANGELOG.md
new/applet-window-buttons-0.10.0/CHANGELOG.md
--- old/applet-window-buttons-0.9.0/CHANGELOG.md 2021-05-11
18:28:50.000000000 +0200
+++ new/applet-window-buttons-0.10.0/CHANGELOG.md 2021-10-21
14:47:15.000000000 +0200
@@ -1,5 +1,11 @@
### CHANGELOG
+#### Version 0.10.0
+
+* support Plasma 5.23
+* depend only on Plasma and KDecorations2 >= 5.23
+* drop option for plasma panels to disable decoration on maximized windows
+
#### Version 0.9.0
* support Plasma 5.18 and 5.21
@@ -11,7 +17,6 @@
* fix, preserve empty space for hidden states when needed
* remove no needed workarounds
-
#### Version 0.8.1
* fix compatibility with Plasma 5.18 (Rodrigo Pedra Brum)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/applet-window-buttons-0.9.0/CMakeLists.txt
new/applet-window-buttons-0.10.0/CMakeLists.txt
--- old/applet-window-buttons-0.9.0/CMakeLists.txt 2021-05-11
18:28:50.000000000 +0200
+++ new/applet-window-buttons-0.10.0/CMakeLists.txt 2021-10-21
14:47:15.000000000 +0200
@@ -2,12 +2,13 @@
cmake_minimum_required(VERSION 3.0 FATAL_ERROR)
set(CMAKE_CXX_STANDARD 14)
-set(VERSION 0.9.0)
+set(VERSION 0.10.0)
set(AUTHOR "Michail Vourlakos")
set(EMAIL "[email protected]")
set(QT_MIN_VERSION "5.9.0")
set(KF5_MIN_VERSION "5.38.0")
+set(KDECORATION2_MIN_VERSION "5.23.0")
set(KF5_LOCALE_PREFIX "")
@@ -16,7 +17,7 @@
find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED NO_MODULE COMPONENTS Gui
Qml Quick)
find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS CoreAddons Declarative
Plasma PlasmaQuick)
-find_package(KDecoration2 REQUIRED)
+find_package(KDecoration2 ${KDECORATION2_MIN_VERSION} REQUIRED)
include(ECMQMLModules)
include(CheckIncludeFiles)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/applet-window-buttons-0.9.0/README.md
new/applet-window-buttons-0.10.0/README.md
--- old/applet-window-buttons-0.9.0/README.md 2021-05-11 18:28:50.000000000
+0200
+++ new/applet-window-buttons-0.10.0/README.md 2021-10-21 14:47:15.000000000
+0200
@@ -18,7 +18,7 @@
</p>
<p align="center">
-<img src="https://imgur.com/ZuL2cxG.png"; width="580"><br/>
+<img src="https://i.imgur.com/Zz20RXC.png"; width="580"><br/>
<i>Settings window</i>
</p>
@@ -26,8 +26,8 @@
- Qt >= 5.9
- KF5 >= 5.38
-- Plasma >= 5.12
-- KDecoration2 >= 5.12
+- Plasma >= 5.23
+- KDecoration2 >= 5.23
**Qt elements**: Gui Qml Quick
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.9.0/libappletdecoration/previewbridge.cpp
new/applet-window-buttons-0.10.0/libappletdecoration/previewbridge.cpp
--- old/applet-window-buttons-0.9.0/libappletdecoration/previewbridge.cpp
2021-05-11 18:28:50.000000000 +0200
+++ new/applet-window-buttons-0.10.0/libappletdecoration/previewbridge.cpp
2021-10-21 14:47:15.000000000 +0200
@@ -77,19 +77,6 @@
return std::move(ptr);
}
-void PreviewBridge::update(KDecoration2::Decoration *decoration, const QRect
&geometry)
-{
- Q_UNUSED(geometry)
-
- auto it = std::find_if(m_previewButtons.constBegin(),
m_previewButtons.constEnd(), [decoration, geometry](PreviewButtonItem *item) {
- return (item->decoration() == decoration) &&
(item->visualGeometry().contains(geometry.center()));
- });
-
- if (it != m_previewButtons.constEnd()) {
- (*it)->update();
- }
-}
-
std::unique_ptr<KDecoration2::DecorationSettingsPrivate>
PreviewBridge::settings(KDecoration2::DecorationSettings *parent)
{
auto ptr = std::unique_ptr<PreviewSettings>(new PreviewSettings(parent));
@@ -201,7 +188,17 @@
return nullptr;
}
- return
m_factory->create<KDecoration2::DecorationButton>(QStringLiteral("button"),
parent, QVariantList({QVariant::fromValue(type),
QVariant::fromValue(decoration)}));
+ auto button = m_factory->create<KDecoration2::DecorationButton>(parent,
QVariantList({QVariant::fromValue(type), QVariant::fromValue(decoration)}));
+
+ if (!button) {
+ //! support decorations that have not been updated yet to KWin 5.23
decoration plugin approach
+ button =
m_factory->create<KDecoration2::DecorationButton>(QStringLiteral("button"),
parent, QVariantList({QVariant::fromValue(type),
QVariant::fromValue(decoration)}));
+ if (button) {
+ qWarning() << "Loading a KDecoration2::DecorationButton using the
button keyword is deprecated in KWin 5.23, register the plugin without a
keyword instead" << m_plugin;
+ }
+ }
+
+ return button;
}
void PreviewBridge::settingsFileChanged(const QString &filename)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.9.0/libappletdecoration/previewbridge.h
new/applet-window-buttons-0.10.0/libappletdecoration/previewbridge.h
--- old/applet-window-buttons-0.9.0/libappletdecoration/previewbridge.h
2021-05-11 18:28:50.000000000 +0200
+++ new/applet-window-buttons-0.10.0/libappletdecoration/previewbridge.h
2021-10-21 14:47:15.000000000 +0200
@@ -50,7 +50,6 @@
explicit PreviewBridge(QObject *parent = nullptr);
virtual ~PreviewBridge();
std::unique_ptr<KDecoration2::DecoratedClientPrivate>
createClient(KDecoration2::DecoratedClient *client, KDecoration2::Decoration
*decoration) override;
- void update(KDecoration2::Decoration *decoration, const QRect &geometry)
override;
std::unique_ptr<KDecoration2::DecorationSettingsPrivate>
settings(KDecoration2::DecorationSettings *parent) override;
PreviewClient *lastCreatedClient() {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.9.0/libappletdecoration/previewbutton.cpp
new/applet-window-buttons-0.10.0/libappletdecoration/previewbutton.cpp
--- old/applet-window-buttons-0.9.0/libappletdecoration/previewbutton.cpp
2021-05-11 18:28:50.000000000 +0200
+++ new/applet-window-buttons-0.10.0/libappletdecoration/previewbutton.cpp
2021-10-21 14:47:15.000000000 +0200
@@ -365,6 +365,20 @@
m_button = m_bridge->createButton(m_sharedDecoration->decoration(),
m_type, this);
+ if (!m_button) {
+ return;
+ }
+
+ if (!m_lastAppliedDecoration.isNull()) {
+ disconnect(m_lastAppliedDecoration.data(),
&KDecoration2::Decoration::damaged, this, &PreviewButtonItem::onDamaged);
+ }
+
+ connect(m_sharedDecoration->decoration(),
&KDecoration2::Decoration::damaged, this, &PreviewButtonItem::onDamaged);
+ m_lastAppliedDecoration = m_sharedDecoration->decoration();
+
+ m_button->setEnabled(true);
+ m_button->setVisible(true);
+
syncInternalGeometry();
}
@@ -390,6 +404,13 @@
update();
}
+void PreviewButtonItem::onDamaged(const QRegion ®ion)
+{
+ if (region.intersects(m_visualGeometry)) {
+ update();
+ }
+}
+
void PreviewButtonItem::paint(QPainter *painter)
{
if (!m_button) {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.9.0/libappletdecoration/previewbutton.h
new/applet-window-buttons-0.10.0/libappletdecoration/previewbutton.h
--- old/applet-window-buttons-0.9.0/libappletdecoration/previewbutton.h
2021-05-11 18:28:50.000000000 +0200
+++ new/applet-window-buttons-0.10.0/libappletdecoration/previewbutton.h
2021-10-21 14:47:15.000000000 +0200
@@ -134,11 +134,14 @@
void createButton();
void syncInternalGeometry();
+ void onDamaged(const QRegion ®ion);
+
private:
QPointer<Decoration::Applet::PreviewBridge> m_bridge;
QPointer<Decoration::Applet::PreviewClient> m_client;
QPointer<Decoration::Applet::SharedDecoration> m_sharedDecoration;
+ QPointer<KDecoration2::Decoration> m_lastAppliedDecoration;
KDecoration2::DecorationButton *m_button = nullptr;
KDecoration2::DecorationButtonType m_type =
KDecoration2::DecorationButtonType::Custom;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.9.0/package/contents/config/main.xml
new/applet-window-buttons-0.10.0/package/contents/config/main.xml
--- old/applet-window-buttons-0.9.0/package/contents/config/main.xml
2021-05-11 18:28:50.000000000 +0200
+++ new/applet-window-buttons-0.10.0/package/contents/config/main.xml
2021-10-21 14:47:15.000000000 +0200
@@ -78,15 +78,6 @@
<default>2</default>
<label>it is used in order to inform settings window about the plasmoid
form factor. 2=Horizontal and 3=Vertical</label>
</entry>
- <entry name="disabledMaximizedBorders" type="Enum">
- <choices>
- <choice name="ShowBorders"/>
- <choice name="SystemDecision"/>
- <choice name="NoBorders"/>
- </choices>
- <default>1</default>
- <label>used only when the plasmoid is in a plasma panel in order to
show/system decide/hide windows borders</label>
- </entry>
<entry name="containmentType" type="Enum">
<choices>
<choice name="Loading"/>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.9.0/package/contents/ui/LatteWindowsTracker.qml
new/applet-window-buttons-0.10.0/package/contents/ui/LatteWindowsTracker.qml
--- old/applet-window-buttons-0.9.0/package/contents/ui/LatteWindowsTracker.qml
2021-05-11 18:28:50.000000000 +0200
+++
new/applet-window-buttons-0.10.0/package/contents/ui/LatteWindowsTracker.qml
2021-10-21 14:47:15.000000000 +0200
@@ -41,6 +41,8 @@
readonly property bool isMaximizable:
selectedTracker.lastActiveWindow.hasOwnProperty("isMaximizable") ?
selectedTracker.lastActiveWindow.isMaximizable : true
readonly property bool isVirtualDesktopsChangeable:
selectedTracker.lastActiveWindow.hasOwnProperty("isVirtualDesktopsChangeable") ?
selectedTracker.lastActiveWindow.isVirtualDesktopsChangeable : true
+
+ readonly property int winId:
selectedTracker.lastActiveWindow.hasOwnProperty("winId") ?
selectedTracker.lastActiveWindow.winId : -1
}
function toggleMaximized() {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.9.0/package/contents/ui/config/ConfigGeneral.qml
new/applet-window-buttons-0.10.0/package/contents/ui/config/ConfigGeneral.qml
---
old/applet-window-buttons-0.9.0/package/contents/ui/config/ConfigGeneral.qml
2021-05-11 18:28:50.000000000 +0200
+++
new/applet-window-buttons-0.10.0/package/contents/ui/config/ConfigGeneral.qml
2021-10-21 14:47:15.000000000 +0200
@@ -39,7 +39,6 @@
property alias cfg_filterByScreen: byScreenChk.checked
property alias cfg_hiddenState: root.hiddenState
property alias cfg_inactiveStateEnabled: inactiveChk.checked
- property alias cfg_disabledMaximizedBorders: root.disabledBorders
property alias cfg_useDecorationMetrics: decorationMetricsChk.checked
property alias cfg_spacing: spacingSpn.value
property alias cfg_lengthFirstMargin: lengthFirstSpn.value
@@ -50,7 +49,6 @@
property bool useCurrent
property int hiddenState
property int visibility
- property int disabledBorders
property string selectedPlugin
property string selectedScheme
property string selectedTheme
@@ -328,44 +326,6 @@
}
}
- GridLayout{
- id: environmentBehaviorGrid
- columns: 2
- visible: plasmoid.configuration.containmentType ===
AppletDecoration.Types.Plasma
-
- Label{
- Layout.minimumWidth: Math.max(centerFactor * root.width,
minimumWidth)
- text: i18n("Environment :")
- horizontalAlignment: Text.AlignRight
- }
-
- CheckBox{
- id: disableMaximizedBordersChk
- text: i18n("Disable borders for maximized windows")
- partiallyCheckedEnabled: true
-
- onCheckedStateChanged: {
- if (checkedState === Qt.Unchecked) {
- root.disabledBorders = 0; /*ShowBorders*/
- } else if (checkedState === Qt.PartiallyChecked) {
- root.disabledBorders = 1; /*SystemDecision*/
- } else if (checkedState === Qt.Checked) {
- root.disabledBorders = 2; /*NoBorders*/
- }
- }
-
- Component.onCompleted: {
- if (root.disabledBorders === 0) {
- checkedState = Qt.Unchecked;
- } else if (root.disabledBorders === 1) {
- checkedState = Qt.PartiallyChecked;
- } else if (root.disabledBorders === 2) {
- checkedState = Qt.Checked;
- }
- }
- }
- }
-
ColumnLayout{
id: visualSettings
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.9.0/package/contents/ui/main.qml
new/applet-window-buttons-0.10.0/package/contents/ui/main.qml
--- old/applet-window-buttons-0.9.0/package/contents/ui/main.qml
2021-05-11 18:28:50.000000000 +0200
+++ new/applet-window-buttons-0.10.0/package/contents/ui/main.qml
2021-10-21 14:47:15.000000000 +0200
@@ -78,7 +78,6 @@
readonly property bool isEmptySpaceEnabled:
plasmoid.configuration.hiddenState === AppletDecoration.Types.EmptySpace
readonly property int containmentType:
plasmoid.configuration.containmentType
- readonly property int disabledMaximizedBorders:
plasmoid.configuration.disabledMaximizedBorders
readonly property int visibility: plasmoid.configuration.visibility
readonly property int minimumWidth: {
@@ -244,18 +243,6 @@
onButtonsStrChanged: initButtons();
- onContainmentTypeChanged: {
- if (containmentType === AppletDecoration.Types.Plasma &&
disabledMaximizedBorders !== 1) { /*SystemDecision*/
- windowSystem.setDisabledMaximizedBorders(disabledMaximizedBorders);
- }
- }
-
- onDisabledMaximizedBordersChanged: {
- if (containmentType === AppletDecoration.Types.Plasma &&
disabledMaximizedBorders !== 1) { /*SystemDecision*/
- windowSystem.setDisabledMaximizedBorders(disabledMaximizedBorders);
- }
- }
-
Connections{
target: !auroraeThemeEngine.isEnabled ? root : null
onThickPaddingChanged: initButtons();
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/applet-window-buttons-0.9.0/package/metadata.desktop
new/applet-window-buttons-0.10.0/package/metadata.desktop
--- old/applet-window-buttons-0.9.0/package/metadata.desktop 2021-05-11
18:28:50.000000000 +0200
+++ new/applet-window-buttons-0.10.0/package/metadata.desktop 2021-10-21
14:47:15.000000000 +0200
@@ -15,7 +15,7 @@
[email protected]
X-KDE-PluginInfo-License=GPLv2
X-KDE-PluginInfo-Name=org.kde.windowbuttons
-X-KDE-PluginInfo-Version=0.9.0
+X-KDE-PluginInfo-Version=0.10.0
X-KDE-PluginInfo-Website=https://github.com/psifidotos/applet-window-buttons
X-KDE-ServiceTypes=Plasma/Applet
![https://imgur.com/ZuL2cxG.png"](https://imgur.com/ZuL2cxG.png"){kind=link}
![https://i.imgur.com/Zz20RXC.png"](https://i.imgur.com/Zz20RXC.png"){kind=link}