Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package kdbusaddons for openSUSE:Factory checked in at 2022-02-24 18:19:26 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kdbusaddons (Old) and /work/SRC/openSUSE:Factory/.kdbusaddons.new.1958 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kdbusaddons" Thu Feb 24 18:19:26 2022 rev:99 rq:954240 version:5.91.0 Changes: -------- --- /work/SRC/openSUSE:Factory/kdbusaddons/kdbusaddons.changes 2022-01-11 21:18:36.000930569 +0100 +++ /work/SRC/openSUSE:Factory/.kdbusaddons.new.1958/kdbusaddons.changes 2022-02-24 18:21:33.782688603 +0100 @@ -1,0 +2,10 @@ +Sun Feb 6 10:16:54 UTC 2022 - Christophe Giboudeaux <[email protected]> + +- Update to 5.91.0 + * New feature release + * For more details please see: + * https://kde.org/announcements/frameworks/5/5.91.0 +- Changes since 5.90.0: + * Add CI qt6 support + +------------------------------------------------------------------- Old: ---- kdbusaddons-5.90.0.tar.xz kdbusaddons-5.90.0.tar.xz.sig New: ---- kdbusaddons-5.91.0.tar.xz kdbusaddons-5.91.0.tar.xz.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kdbusaddons.spec ++++++ --- /var/tmp/diff_new_pack.3i3hy8/_old 2022-02-24 18:21:34.310688461 +0100 +++ /var/tmp/diff_new_pack.3i3hy8/_new 2022-02-24 18:21:34.314688460 +0100 @@ -17,14 +17,14 @@ %define lname libKF5DBusAddons5 -%define _tar_path 5.90 +%define _tar_path 5.91 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} %bcond_without released Name: kdbusaddons -Version: 5.90.0 +Version: 5.91.0 Release: 0 Summary: Convenience classes for QtDBus License: LGPL-2.1-or-later ++++++ kdbusaddons-5.90.0.tar.xz -> kdbusaddons-5.91.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kdbusaddons-5.90.0/.gitlab-ci.yml new/kdbusaddons-5.91.0/.gitlab-ci.yml --- old/kdbusaddons-5.90.0/.gitlab-ci.yml 2022-01-01 13:28:07.000000000 +0100 +++ new/kdbusaddons-5.91.0/.gitlab-ci.yml 2022-02-05 22:20:59.000000000 +0100 @@ -4,3 +4,4 @@ include: - https://invent.kde.org/sysadmin/ci-utilities/raw/master/gitlab-templates/linux.yml - https://invent.kde.org/sysadmin/ci-utilities/raw/master/gitlab-templates/freebsd.yml + - https://invent.kde.org/sysadmin/ci-utilities/raw/master/gitlab-templates/linux-qt6.yml diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kdbusaddons-5.90.0/CMakeLists.txt new/kdbusaddons-5.91.0/CMakeLists.txt --- old/kdbusaddons-5.90.0/CMakeLists.txt 2022-01-01 13:28:07.000000000 +0100 +++ new/kdbusaddons-5.91.0/CMakeLists.txt 2022-02-05 22:20:59.000000000 +0100 @@ -1,10 +1,10 @@ cmake_minimum_required(VERSION 3.16) -set(KF_VERSION "5.90.0") # handled by release scripts +set(KF_VERSION "5.91.0") # handled by release scripts project(KDBusAddons VERSION ${KF_VERSION}) include(FeatureSummary) -find_package(ECM 5.90.0 NO_MODULE) +find_package(ECM 5.91.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://commits.kde.org/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -88,7 +88,7 @@ install(EXPORT KF5DBusAddonsTargets DESTINATION "${CMAKECONFIG_INSTALL_DIR}" FILE KF5DBusAddonsTargets.cmake NAMESPACE KF5:: ) -install(FILES ${CMAKE_CURRENT_BINARY_DIR}/kdbusaddons_version.h DESTINATION ${KDE_INSTALL_INCLUDEDIR_KF} COMPONENT Devel ) +install(FILES ${CMAKE_CURRENT_BINARY_DIR}/kdbusaddons_version.h DESTINATION ${KDE_INSTALL_INCLUDEDIR_KF}/KDBusAddons COMPONENT Devel) feature_summary(WHAT ALL FATAL_ON_MISSING_REQUIRED_PACKAGES) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kdbusaddons-5.90.0/po/zh_CN/kdbusaddons5_qt.po new/kdbusaddons-5.91.0/po/zh_CN/kdbusaddons5_qt.po --- old/kdbusaddons-5.90.0/po/zh_CN/kdbusaddons5_qt.po 2022-01-01 13:28:07.000000000 +0100 +++ new/kdbusaddons-5.91.0/po/zh_CN/kdbusaddons5_qt.po 2022-02-05 22:20:59.000000000 +0100 @@ -2,7 +2,7 @@ msgid "" msgstr "" "Project-Id-Version: kdeorg\n" -"PO-Revision-Date: 2021-12-22 14:05\n" +"PO-Revision-Date: 2022-01-08 15:22\n" "Language-Team: Chinese Simplified\n" "Language: zh_CN\n" "MIME-Version: 1.0\n" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kdbusaddons-5.90.0/src/kdbusservice.h new/kdbusaddons-5.91.0/src/kdbusservice.h --- old/kdbusaddons-5.90.0/src/kdbusservice.h 2022-01-01 13:28:07.000000000 +0100 +++ new/kdbusaddons-5.91.0/src/kdbusservice.h 2022-02-05 22:20:59.000000000 +0100 @@ -229,14 +229,19 @@ * from QX11Info::nextStartupId(), if there is one. * For Wayland, KDBusService provides the token for the XDG Activation protocol in the * "XDG_ACTIVATION_TOKEN" environment variable and unsets it again after the signal, if there is one. + * The util method @c KWindowSystem::updateStartupId(QWindow *window) (since KF 5.91) takes care of that. * A typical implementation in the signal handler would be: * @code * mainWindow->show(); + * #if KWINDOWSYSTEM_VERSION >= QT_VERSION_CHECK(5, 91, 0) + * KWindowSystem::updateStartupId(mainWindow->windowHandle()); + * #else * if (KWindowSystem::isPlatformX11()) { * KStartupInfo::setNewStartupId(mainWindow->windowHandle(), QX11Info::nextStartupId()); * } else if (KWindowSystem::isPlatformWayland()) { * KWindowSystem::setCurrentXdgActivationToken(qEnvironmentVariable("XDG_ACTIVATION_TOKEN")); * } + * #endif * mainWindow->raise(); * KWindowSystem::activateWindow(mainWindow->windowHandle()); * @endcode diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kdbusaddons-5.90.0/src/updatelaunchenvironmentjob.cpp new/kdbusaddons-5.91.0/src/updatelaunchenvironmentjob.cpp --- old/kdbusaddons-5.90.0/src/updatelaunchenvironmentjob.cpp 2022-01-01 13:28:07.000000000 +0100 +++ new/kdbusaddons-5.91.0/src/updatelaunchenvironmentjob.cpp 2022-02-05 22:20:59.000000000 +0100 @@ -16,10 +16,10 @@ #include "kdbusaddons_debug.h" -class Q_DECL_HIDDEN UpdateLaunchEnvironmentJob::Private +class KUpdateLaunchEnvironmentJobPrivate { public: - explicit Private(UpdateLaunchEnvironmentJob *q); + explicit KUpdateLaunchEnvironmentJobPrivate(UpdateLaunchEnvironmentJob *q); void monitorReply(const QDBusPendingReply<> &reply); static bool isPosixName(const QString &name); @@ -30,12 +30,12 @@ int pendingReplies = 0; }; -UpdateLaunchEnvironmentJob::Private::Private(UpdateLaunchEnvironmentJob *q) +KUpdateLaunchEnvironmentJobPrivate::KUpdateLaunchEnvironmentJobPrivate(UpdateLaunchEnvironmentJob *q) : q(q) { } -void UpdateLaunchEnvironmentJob::Private::monitorReply(const QDBusPendingReply<> &reply) +void KUpdateLaunchEnvironmentJobPrivate::monitorReply(const QDBusPendingReply<> &reply) { ++pendingReplies; @@ -51,17 +51,15 @@ }); } +// KF6 TODO: add K-prefix to class name UpdateLaunchEnvironmentJob::UpdateLaunchEnvironmentJob(const QProcessEnvironment &environment) - : d(new Private(this)) + : d(new KUpdateLaunchEnvironmentJobPrivate(this)) { d->environment = environment; QTimer::singleShot(0, this, &UpdateLaunchEnvironmentJob::start); } -UpdateLaunchEnvironmentJob::~UpdateLaunchEnvironmentJob() -{ - delete d; -} +UpdateLaunchEnvironmentJob::~UpdateLaunchEnvironmentJob() = default; void UpdateLaunchEnvironmentJob::start() { @@ -70,7 +68,7 @@ QStringList systemdUpdates; for (const auto &varName : d->environment.keys()) { - if (!Private::isPosixName(varName)) { + if (!KUpdateLaunchEnvironmentJobPrivate::isPosixName(varName)) { qCWarning(KDBUSADDONS_LOG) << "Skipping syncing of environment variable " << varName << "as name contains unsupported characters"; continue; } @@ -101,7 +99,7 @@ // Systemd has stricter parsing of valid environment variables // https://github.com/systemd/systemd/issues/16704 // validate here - if (!Private::isSystemdApprovedValue(value)) { + if (!KUpdateLaunchEnvironmentJobPrivate::isSystemdApprovedValue(value)) { qCWarning(KDBUSADDONS_LOG) << "Skipping syncing of environment variable " << varName << "as value contains unsupported characters"; continue; } @@ -130,7 +128,7 @@ d->monitorReply(systemdActivationReply); } -bool UpdateLaunchEnvironmentJob::Private::isPosixName(const QString &name) +bool KUpdateLaunchEnvironmentJobPrivate::isPosixName(const QString &name) { // Posix says characters like % should be 'tolerated', but it gives issues in practice. // https://bugzilla.redhat.com/show_bug.cgi?id=1754395 @@ -149,7 +147,7 @@ return !first; } -bool UpdateLaunchEnvironmentJob::Private::isSystemdApprovedValue(const QString &value) +bool KUpdateLaunchEnvironmentJobPrivate::isSystemdApprovedValue(const QString &value) { // systemd code checks that a value contains no control characters except \n \t // effectively copied from systemd's string_has_cc diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kdbusaddons-5.90.0/src/updatelaunchenvironmentjob.h new/kdbusaddons-5.91.0/src/updatelaunchenvironmentjob.h --- old/kdbusaddons-5.90.0/src/updatelaunchenvironmentjob.h 2022-01-01 13:28:07.000000000 +0100 +++ new/kdbusaddons-5.91.0/src/updatelaunchenvironmentjob.h 2022-02-05 22:20:59.000000000 +0100 @@ -11,9 +11,14 @@ #include <QProcessEnvironment> +#include <memory> + class QString; +class KUpdateLaunchEnvironmentJobPrivate; /** + * @class UpdateLaunchEnvironmentJob updatelaunchenvironmentjob.h <UpdateLaunchEnvironmentJob> + * * Job for updating the launch environment. * * This job adds or updates an environment variable in process environment that will be used @@ -43,6 +48,7 @@ private: void start(); - class Private; - Private *const d; + +private: + std::unique_ptr<KUpdateLaunchEnvironmentJobPrivate> const d; };
