Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package sca-patterns-sle11 for openSUSE:Factory checked in at 2022-03-09 18:47:28 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/sca-patterns-sle11 (Old) and /work/SRC/openSUSE:Factory/.sca-patterns-sle11.new.2349 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "sca-patterns-sle11" Wed Mar 9 18:47:28 2022 rev:18 rq:960272 version:1.5.0 Changes: -------- --- /work/SRC/openSUSE:Factory/sca-patterns-sle11/sca-patterns-sle11.changes 2021-11-05 22:58:44.832286417 +0100 +++ /work/SRC/openSUSE:Factory/.sca-patterns-sle11.new.2349/sca-patterns-sle11.changes 2022-03-11 11:35:44.358230189 +0100 @@ -1,0 +2,5 @@ +Tue Mar 8 16:32:14 UTC 2022 - Jason Record <[email protected]> + +- Removed OES dependent patterns (bsc#1196873) + +------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ sca-patterns-sle11.spec ++++++ --- /var/tmp/diff_new_pack.ZoWomw/_old 2022-03-11 11:35:44.770230672 +0100 +++ /var/tmp/diff_new_pack.ZoWomw/_new 2022-03-11 11:35:44.778230682 +0100 @@ -1,7 +1,7 @@ # # spec file for package sca-patterns-sle11 # -# Copyright (c) 2021 SUSE LLC +# Copyright (c) 2022 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -29,8 +29,8 @@ Release: 0 Summary: Supportconfig Analysis Patterns for SLE11 License: GPL-2.0-only -Group: System/Monitoring URL: https://github.com/g23guy/sca-patterns-sle11 +Group: System/Monitoring Source: %{name}-%{version}.tar.gz BuildRequires: fdupes Requires: sca-patterns-base >= 1.5.0 ++++++ sca-patterns-sle11-1.5.0.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/sca-patterns-sle11-1.5.0/patterns/SLE/sle11all/pdc-00001.pl new/sca-patterns-sle11-1.5.0/patterns/SLE/sle11all/pdc-00001.pl --- old/sca-patterns-sle11-1.5.0/patterns/SLE/sle11all/pdc-00001.pl 2017-07-07 18:13:55.577779906 +0200 +++ new/sca-patterns-sle11-1.5.0/patterns/SLE/sle11all/pdc-00001.pl 1970-01-01 01:00:00.000000000 +0100 @@ -1,122 +0,0 @@ -#!/usr/bin/perl - -# Title: Samba PDC on OES is unsupported -# Description: Domain Services for Windows is the recommended replacement for PDCs on OES. -# Modified: 2013 Nov 22 - -############################################################################## -# Copyright (C) 2013 SUSE LLC -############################################################################## -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; version 2 of the License. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, see <http://www.gnu.org/licenses/>. - -# Authors/Contributors: -# Jason Record ([email protected]) - -############################################################################## - -############################################################################## -# Module Definition -############################################################################## - -use strict; -use warnings; -use SDP::Core; -use SDP::SUSE; -use SDP::OESLinux; - -############################################################################## -# Overriden (eventually or in part) from SDP::Core Module -############################################################################## - -@PATTERN_RESULTS = ( - PROPERTY_NAME_CLASS."=SLE", - PROPERTY_NAME_CATEGORY."=Samba", - PROPERTY_NAME_COMPONENT."=PDC", - PROPERTY_NAME_PATTERN_ID."=$PATTERN_ID", - PROPERTY_NAME_PRIMARY_LINK."=META_LINK_MISC", - PROPERTY_NAME_OVERALL."=$GSTATUS", - PROPERTY_NAME_OVERALL_INFO."=None", - "META_LINK_MISC=http://www.novell.com/documentation/oes2/file_samba_cifs_lx/?page=/documentation/oes2/file_samba_cifs_lx/data/b48nab9.html"; -); - -############################################################################## -# Local Function Definitions -############################################################################## - -sub oesInstalled { - SDP::Core::printDebug('> oesInstalled', 'BEGIN'); - my $RCODE = 0; - my %HOST_INFO = SDP::SUSE::getHostInfo(); - $RCODE++ if ( $HOST_INFO{'oes'} ); - SDP::Core::printDebug("< oesInstalled", "Returns: $RCODE"); - return $RCODE; -} - -sub isPDC { - SDP::Core::printDebug('> isPDC', 'BEGIN'); - my $RCODE = 0; - my $FILE_OPEN = 'samba.txt'; - my $SECTION = 'smb.conf'; - my @CONTENT = (); - my $GLOBAL = 0; - my $PDC = 0; - - if ( SDP::Core::getSection($FILE_OPEN, $SECTION, \@CONTENT) ) { - foreach $_ (@CONTENT) { - next if ( /^\s*$/ ); # Skip blank lines - if ( $GLOBAL ) { - if ( /domain master.*yes|preferred master.*yes|local master.*yes/i ) { - SDP::Core::printDebug("PROCESSING", $_); - $PDC++; - $GLOBAL = 0; - last; - } - } elsif ( /[global]/i ) { - SDP::Core::printDebug("PROCESSING", $_); - $GLOBAL = 1; - } - } - } else { - SDP::Core::updateStatus(STATUS_ERROR, "ERROR: isPDC(): Cannot find \"$SECTION\" section in $FILE_OPEN"); - } - - my $SMB_DOWN = SDP::SUSE::serviceStatus($FILE_OPEN, 'smb'); - - $RCODE++ if ( ! $SMB_DOWN && $PDC ); - SDP::Core::printDebug("< isPDC", "Returns: $RCODE"); - return $RCODE; -} - -############################################################################## -# Main Program Execution -############################################################################## - -SDP::Core::processOptions(); - if ( oesInstalled() ) { - if ( isPDC() ) { - if ( SDP::OESLinux::dsfwCapable() ) { - SDP::Core::updateStatus(STATUS_WARNING, "DSfW and Samba PDC configured, remove PDC configuration from smb.conf"); - } else { - SDP::Core::updateStatus(STATUS_CRITICAL, "Samba PDCs are not supported on OES, use DSfW"); - } - } else { - SDP::Core::updateStatus(STATUS_ERROR, "Samba PDC not observed on OES"); - } - } else { - SDP::Core::updateStatus(STATUS_ERROR, "Skipping Samba PDC Check, OES not installed"); - } -SDP::Core::printPatternResults(); - -exit; - diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/sca-patterns-sle11-1.5.0/patterns/SLE/sle11all/pdc-00002.pl new/sca-patterns-sle11-1.5.0/patterns/SLE/sle11all/pdc-00002.pl --- old/sca-patterns-sle11-1.5.0/patterns/SLE/sle11all/pdc-00002.pl 2017-07-07 18:13:55.581779902 +0200 +++ new/sca-patterns-sle11-1.5.0/patterns/SLE/sle11all/pdc-00002.pl 1970-01-01 01:00:00.000000000 +0100 @@ -1,122 +0,0 @@ -#!/usr/bin/perl - -# Title: DSfW recommended in OES environments for Samba PDC -# Description: Domain Services for Windows is recommended in OES environments. -# Modified: 2013 Jun 24 - -############################################################################## -# Copyright (C) 2013 SUSE LLC -############################################################################## -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; version 2 of the License. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, see <http://www.gnu.org/licenses/>. - -# Authors/Contributors: -# Jason Record ([email protected]) - -############################################################################## - -############################################################################## -# Module Definition -############################################################################## - -use strict; -use warnings; -use SDP::Core; -use SDP::SUSE; -use SDP::OESLinux; - -############################################################################## -# Overriden (eventually or in part) from SDP::Core Module -############################################################################## - -@PATTERN_RESULTS = ( - PROPERTY_NAME_CLASS."=SLE", - PROPERTY_NAME_CATEGORY."=Samba", - PROPERTY_NAME_COMPONENT."=PDC", - PROPERTY_NAME_PATTERN_ID."=$PATTERN_ID", - PROPERTY_NAME_PRIMARY_LINK."=META_LINK_TID", - PROPERTY_NAME_OVERALL."=$GSTATUS", - PROPERTY_NAME_OVERALL_INFO."=None", - "META_LINK_MISC=http://www.novell.com/documentation/oes2/acc_dsfw_lx/?page=/documentation/oes2/acc_dsfw_lx/data/bookinfo.html#bookinfo"; -); - -############################################################################## -# Local Function Definitions -############################################################################## - -sub oesInstalled { - SDP::Core::printDebug('> oesInstalled', 'BEGIN'); - my $RCODE = 0; - my %HOST_INFO = SDP::SUSE::getHostInfo(); - $RCODE++ if ( $HOST_INFO{'oes'} ); - SDP::Core::printDebug("< oesInstalled", "Returns: $RCODE"); - return $RCODE; -} - -sub isPDC { - SDP::Core::printDebug('> isPDC', 'BEGIN'); - my $RCODE = 0; - my $FILE_OPEN = 'samba.txt'; - my $SECTION = 'smb.conf'; - my @CONTENT = (); - my $GLOBAL = 0; - my $PDC = 0; - - if ( SDP::Core::getSection($FILE_OPEN, $SECTION, \@CONTENT) ) { - foreach $_ (@CONTENT) { - next if ( /^\s*$/ ); # Skip blank lines - if ( $GLOBAL ) { - if ( /domain master.*yes|preferred master.*yes|local master.*yes/i ) { - SDP::Core::printDebug("PROCESSING", $_); - $PDC++; - $GLOBAL = 0; - last; - } - } elsif ( /[global]/i ) { - SDP::Core::printDebug("PROCESSING", $_); - $GLOBAL = 1; - } - } - } else { - SDP::Core::updateStatus(STATUS_ERROR, "ERROR: isPDC(): Cannot find \"$SECTION\" section in $FILE_OPEN"); - } - - my $SMB_DOWN = SDP::SUSE::serviceStatus($FILE_OPEN, 'smb'); - - $RCODE++ if ( ! $SMB_DOWN && $PDC ); - SDP::Core::printDebug("< isPDC", "Returns: $RCODE"); - return $RCODE; -} - -############################################################################## -# Main Program Execution -############################################################################## - -SDP::Core::processOptions(); - if ( SDP::OESLinux::dsfwCapable() ) { - SDP::Core::updateStatus(STATUS_ERROR, "ERROR: DSfW capable, abort PDC test for DSfW recommendation"); - } else { - if ( oesInstalled() ) { - if ( isPDC() ) { - SDP::Core::updateStatus(STATUS_RECOMMEND, "Consider Domain Services for Windows on OES instead of a Samba PDC"); - } else { - SDP::Core::updateStatus(STATUS_ERROR, "Samba PDC not observed on OES for DSfW Recommendation"); - } - } else { - SDP::Core::updateStatus(STATUS_ERROR, "Skipping Samba PDC Check, OES not installed"); - } - } -SDP::Core::printPatternResults(); - -exit; -
