Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package nvme-stas for openSUSE:Factory checked in at 2022-03-25 21:54:58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/nvme-stas (Old) and /work/SRC/openSUSE:Factory/.nvme-stas.new.1900 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "nvme-stas" Fri Mar 25 21:54:58 2022 rev:3 rq:964850 version:1.0~rc5 Changes: -------- --- /work/SRC/openSUSE:Factory/nvme-stas/nvme-stas.changes 2022-03-23 20:20:24.506531671 +0100 +++ /work/SRC/openSUSE:Factory/.nvme-stas.new.1900/nvme-stas.changes 2022-03-25 21:55:17.118313149 +0100 @@ -1,0 +2,11 @@ +Fri Mar 25 11:32:30 UTC 2022 - Daniel Wagner <[email protected]> + +- Update to version 1.0-rc5: + * Remove misconfiguration check. (bsc#1197361) + * Document how to increase the number of interfaces that Avahi can monitor. +- Removed python3-netifaces dependency (bsc#1197361) +- Added ahahi dependency +- Do not list files twice (add %dir to directory paths) +- Drop workaround for Python interpreter path fixup. + +------------------------------------------------------------------- Old: ---- nvme-stas-1.0~rc4.obscpio New: ---- nvme-stas-1.0~rc5.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ nvme-stas.spec ++++++ --- /var/tmp/diff_new_pack.FEjEHc/_old 2022-03-25 21:55:17.726313727 +0100 +++ /var/tmp/diff_new_pack.FEjEHc/_new 2022-03-25 21:55:17.730313731 +0100 @@ -17,7 +17,7 @@ Name: nvme-stas -Version: 1.0~rc4 +Version: 1.0~rc5 Release: 0 Summary: NVMe STorage Appliance Services License: Apache-2.0 @@ -30,14 +30,13 @@ BuildRequires: python3-dasbus BuildRequires: python3-gobject BuildRequires: python3-libnvme >= 1.0~7 -BuildRequires: python3-netifaces BuildRequires: python3-pyudev BuildRequires: python3-systemd BuildRequires: systemd-rpm-macros +Requires: avahi Requires: python3-dasbus Requires: python3-gobject Requires: python3-libnvme >= 1.0~7 -Requires: python3-netifaces Requires: python3-pyudev Requires: python3-systemd @@ -56,17 +55,6 @@ %install %meson_install -# fix up interpreter -sed -i "s;/usr/bin/env python3;/usr/bin/python3;g" -i \ - %{buildroot}%{_bindir}/stacctl -sed -i "s;/usr/bin/env python3;/usr/bin/python3;g" -i \ - %{buildroot}%{_bindir}/stafctl -sed -i "s;/usr/bin/env python3;/usr/bin/python3;g" -i \ - %{buildroot}%{_bindir}/stasadm -sed -i "s;/usr/bin/env python3;/usr/bin/python3;g" -i \ - %{buildroot}%{_sbindir}/stacd -sed -i "s;/usr/bin/env python3;/usr/bin/python3;g" -i \ - %{buildroot}%{_sbindir}/stafd %define services stacd.service stafd.service @@ -85,7 +73,7 @@ %files %license LICENSE %doc README.md -%{_sysconfdir}/stas +%dir %{_sysconfdir}/stas %config(noreplace) %{_sysconfdir}/stas/stacd.conf %config(noreplace) %{_sysconfdir}/stas/stafd.conf %config(noreplace) %{_sysconfdir}/stas/sys.conf.doc @@ -98,7 +86,7 @@ %{_sbindir}/stafd %{_unitdir}/stacd.service %{_unitdir}/stafd.service -%{python3_sitearch}/staslib +%dir %{python3_sitearch}/staslib %{python3_sitearch}/staslib/__init__.py %{python3_sitearch}/staslib/avahi.py %{python3_sitearch}/staslib/defs.py ++++++ _service ++++++ --- /var/tmp/diff_new_pack.FEjEHc/_old 2022-03-25 21:55:17.766313766 +0100 +++ /var/tmp/diff_new_pack.FEjEHc/_new 2022-03-25 21:55:17.766313766 +0100 @@ -5,7 +5,7 @@ <param name="filename">nvme-stas</param> <!-- <param name="versionformat">@PARENT_TAG@+@TAG_OFFSET@</param> --> <param name="versionformat">@PARENT_TAG@</param> - <param name="revision">v1.0-rc4</param> + <param name="revision">v1.0-rc5</param> <param name="match-tag">v[01].[0-9]*</param> <param name="versionrewrite-pattern">v([^+]*)-rc([0-9]+)</param> <param name="versionrewrite-replacement">\1~rc\2</param> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.FEjEHc/_old 2022-03-25 21:55:17.794313792 +0100 +++ /var/tmp/diff_new_pack.FEjEHc/_new 2022-03-25 21:55:17.798313796 +0100 @@ -1,7 +1,7 @@ <servicedata> <service name="tar_scm"> <param name="url">https://github.com/linux-nvme/nvme-stas.git</param> - <param name="changesrevision">3bb3776d81e63eed5b254d453a0cd01fa27ef581</param> + <param name="changesrevision">d014d6e4739cdbe3b595ee55a81e1b047647cea9</param> </service> </servicedata> (No newline at EOF) ++++++ nvme-stas-1.0~rc4.obscpio -> nvme-stas-1.0~rc5.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/.github/workflows/meson-test.yml new/nvme-stas-1.0~rc5/.github/workflows/meson-test.yml --- old/nvme-stas-1.0~rc4/.github/workflows/meson-test.yml 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/.github/workflows/meson-test.yml 2022-03-24 17:54:53.000000000 +0100 @@ -15,7 +15,7 @@ - uses: actions/checkout@v2 - name: Install requirements run: | - sudo apt-get install -y libjson-c-dev python3-pyudev python3-systemd python3-gi python3-netifaces meson + sudo apt-get install -y libjson-c-dev python3-pyudev python3-systemd python3-gi meson python -m pip install --upgrade pip dasbus pylint pyflakes - uses: BSFishy/[email protected] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/DISTROS.md new/nvme-stas-1.0~rc5/DISTROS.md --- old/nvme-stas-1.0~rc4/DISTROS.md 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/DISTROS.md 2022-03-24 17:54:53.000000000 +0100 @@ -31,7 +31,6 @@ | ----------------------------------------------- | ----------- | ------------- | ------------- | | libnvme | 1.0 | **Mandatory** | **Mandatory** | | python3-dasbus | 1.6 | **Mandatory** | **Mandatory** | -| python3-netifaces | 0.10.4 | **Mandatory** | **Mandatory** | | python3-pyudev | 0.22.0 | **Mandatory** | **Mandatory** | | python3-systemd | 234 | **Mandatory** | **Mandatory** | | python3-gi (Debian) OR python3-gobject (Fedora) | 3.36.0 | **Mandatory** | **Mandatory** | diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/Dockerfile new/nvme-stas-1.0~rc5/Dockerfile --- old/nvme-stas-1.0~rc4/Dockerfile 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/Dockerfile 2022-03-24 17:54:53.000000000 +0100 @@ -6,7 +6,7 @@ WORKDIR /root # for nvme-stas -RUN dnf install -y python3-dasbus python3-pyudev python3-systemd python3-gobject python3-netifaces meson +RUN dnf install -y python3-dasbus python3-pyudev python3-systemd python3-gobject meson # for libnvme RUN dnf install -y git gcc g++ cmake openssl-devel libuuid-devel json-c-devel swig python-devel meson diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/README.md new/nvme-stas-1.0~rc5/README.md --- old/nvme-stas-1.0~rc4/README.md 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/README.md 2022-03-24 17:54:53.000000000 +0100 @@ -1,5 +1,8 @@ # STorage Appliance Services (STAS) + + + What does nvme-stas provide? - A Central Discovery Controller (CDC) client for Linux @@ -84,14 +87,14 @@ **Debian packages (tested on Ubuntu 20.04):** ```bash -sudo apt-get install -y python3-pyudev python3-systemd python3-gi python3-netifaces +sudo apt-get install -y python3-pyudev python3-systemd python3-gi sudo pip3 install dasbus ``` **RPM packages (tested on Fedora 34..35 and SLES15):** ```bash -sudo dnf install -y python3-dasbus python3-pyudev python3-systemd python3-gobject python3-netifaces +sudo dnf install -y python3-dasbus python3-pyudev python3-systemd python3-gobject ``` # STAF - STorage Appliance Finder @@ -111,6 +114,12 @@ **`stafd`** can automatically find and set up connections to Discovery Controllers. To do this, **`stafd`** registers with the [Avahi](https://www.avahi.org/), the mDNS/DNS-SD (Service Discovery) daemon. Discovery Controllers that advertise themselves with service type `_nvme-disc._tcp` will be recognized by Avahi, which will inform **`stafd`**. +### Why is Avahi failing to discover services on some interfaces? + +Linux limits the number of multicast group memberships that a host can belong to. The default is 20. For Avahi to monitor mDNS (multicast DNS) packets on all interfaces, the host computer must be able to register one multicast group per interface. This can be physical or logical interfaces. For example, configuring 10 VLANs on a physical interface increases the total number of interfaces by 10. If the total number of interfaces is greater than the limit of 20, then Avahi won't be able to monitor all interfaces. + +The limit can be changed by configuring the variable **`igmp_max_memberships`**. This variable is defined [here](https://sysctl-explorer.net/net/ipv4/igmp_max_memberships/) in the kernel documentation. And this [StackExchange page](https://unix.stackexchange.com/questions/23832/is-there-a-way-to-increase-the-20-multicast-group-limit-per-socket) describes how one can increase the limit. + # STAC - STorage Appliance Connector diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/debian/control new/nvme-stas-1.0~rc5/debian/control --- old/nvme-stas-1.0~rc4/debian/control 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/debian/control 2022-03-24 17:54:53.000000000 +0100 @@ -11,7 +11,7 @@ Package: nvme-stas Architecture: all -Depends: ${python3:Depends}, ${misc:Depends}, python3-pyudev, python3-systemd, python3-gi, python3-netifaces +Depends: ${python3:Depends}, ${misc:Depends}, python3-pyudev, python3-systemd, python3-gi Description: NVMe STorage Appliance Services This package provides two daemons, stafd and stacd. The STorage Appliance Finder Daemon (stafd) automatically discovers NVMe-oF Discovery Controllers (DC) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/man/dbus-idl-to-docbooks.py new/nvme-stas-1.0~rc5/man/dbus-idl-to-docbooks.py --- old/nvme-stas-1.0~rc4/man/dbus-idl-to-docbooks.py 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/man/dbus-idl-to-docbooks.py 2022-03-24 17:54:53.000000000 +0100 @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3 import os import sys import tempfile diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/man/genlist-from-docbooks.py new/nvme-stas-1.0~rc5/man/genlist-from-docbooks.py --- old/nvme-stas-1.0~rc4/man/genlist-from-docbooks.py 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/man/genlist-from-docbooks.py 2022-03-24 17:54:53.000000000 +0100 @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3 import glob from lxml import etree diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/meson.build new/nvme-stas-1.0~rc5/meson.build --- old/nvme-stas-1.0~rc4/meson.build 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/meson.build 2022-03-24 17:54:53.000000000 +0100 @@ -9,7 +9,7 @@ project( 'nvme-stas', meson_version: '>= 0.52.0', - version: '1.0', + version: '1.0rc5', license: 'Apache-2.0', default_options: [ 'buildtype=release', @@ -45,7 +45,6 @@ py_modules_reqd = [ ['dasbus', 'Install python3-dasbus (rpm) OR pip3 install dasbus'], ['pyudev', 'Install python3-pyudev (deb/rpm)'], - ['netifaces', 'Install python3-netifaces (deb/rpm)'], ['systemd', 'Install python3-systemd (deb/rpm)'], ['gi', 'Install python3-gi (deb) OR python3-gobject (rpm)'], ] @@ -71,6 +70,9 @@ #=============================================================================== conf = configuration_data() +conf.set('PROJECT_NAME', meson.project_name()) +conf.set('VERSION', meson.project_version()) +conf.set('LICENSE', meson.project_license()[0]) conf.set('KERNEL_IFACE_MIN_VERSION', '5.14') conf.set('KERNEL_TP8013_MIN_VERSION', '5.16') @@ -86,9 +88,6 @@ conf.set(DAEMON_NAME + '_PROCNAME', daemon_name) conf.set(COMPONENT + '_ACRONYM', COMPONENT) conf.set(COMPONENT + '_DESCRIPTION', component[1]) - conf.set('VERSION', meson.project_version()) - conf.set('LICENSE', meson.project_license()[0]) - conf.set('PROJECT_NAME', meson.project_name()) endforeach #=============================================================================== @@ -163,14 +162,10 @@ endif #=============================================================================== -substs = configuration_data() -substs.set('NAME', meson.project_name()) -substs.set('VERSION', meson.project_version()) -substs.set('LICENSE', meson.project_license()[0]) configure_file( input: 'nvme-stas.spec.in', output: 'nvme-stas.spec', - configuration: substs, + configuration: conf, ) #=============================================================================== diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/nvme-stas.spec.in new/nvme-stas-1.0~rc5/nvme-stas.spec.in --- old/nvme-stas-1.0~rc4/nvme-stas.spec.in 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/nvme-stas.spec.in 2022-03-24 17:54:53.000000000 +0100 @@ -1,34 +1,56 @@ %global _topdir .build/rpm-pkg %global _sourcedir .build/meson-dist -Name: @NAME@ +Name: @PROJECT_NAME@ +Summary: NVMe STorage Appliance Services Version: @VERSION@ Release: 1%{?dist} -Summary: NVMe STorage Appliance Services - License: @LICENSE@ -Source0: %{name}-%{version}.tar.xz +URL: https://github.com/linux-nvme/nvme-stas +Source0: %{url}/archive/v%{version_no_tilde}/%{name}-%{version_no_tilde}.tar.gz + BuildArch: noarch BuildRequires: meson +BuildRequires: glib2-devel +BuildRequires: libnvme-devel +BuildRequires: libxslt +BuildRequires: docbook-style-xsl +BuildRequires: systemd-devel +BuildRequires: systemd-rpm-macros + +BuildRequires: python3 BuildRequires: python3-devel +BuildRequires: python3-pyflakes +BuildRequires: python3-pylint +BuildRequires: pylint + BuildRequires: python3-libnvme -BuildRequires: systemd-rpm-macros +BuildRequires: python3-dasbus +BuildRequires: python3-pyudev +BuildRequires: python3-systemd +BuildRequires: python3-gobject-devel +BuildRequires: python3-lxml + +Requires: avahi Requires: python3-libnvme Requires: python3-dasbus Requires: python3-pyudev Requires: python3-systemd Requires: python3-gobject -Requires: python3-netifaces %description -NVMe STorage Appliance Services +nvme-stas is a Central Discovery Controller (CDC) client for Linux. It +handles Asynchronous Event Notifications (AEN), Automated NVMe subsystem +connection controls, Error handling and reporting, and Automatic (zeroconf) +and Manual configuration. nvme-stas is composed of two daemons: +stafd (STorage Appliance Finder) and stacd (STorage Appliance Connector). %prep -%autosetup -c +%autosetup -p1 -n %{name}-%{version_no_tilde} %build -%meson +%meson -Dman=true -Dhtml=true %meson_build %install @@ -37,78 +59,43 @@ %check %meson_test -%files -%{_sbindir}/stacd -%{_bindir}/stacctl -%{_sbindir}/stafd -%{_bindir}/stafctl -%{_sysconfdir}/dbus-1/system.d/org.nvmexpress.stac.conf -%{_sysconfdir}/dbus-1/system.d/org.nvmexpress.staf.conf -%{_sysconfdir}/stas/stacd.conf -%{_sysconfdir}/stas/stafd.conf -%{_prefix}/lib/systemd/system/stacd.service -%{_prefix}/lib/systemd/system/stafd.service -%{python3_sitelib}/staslib/__init__.py -%{python3_sitelib}/staslib/stas.py -%{python3_sitelib}/staslib/avahi.py -%{python3_sitelib}/staslib/glibudev.py +%define services stacd.service stafd.service + +%pre +%service_add_pre %services -#------------------------------------------------------------------------------- %post -dbus_reload() { - if [ -f /usr/bin/dbus-send ]; then - /usr/bin/dbus-send --system --type=method_call --dest=org.freedesktop.DBus / org.freedesktop.DBus.ReloadConfig - fi -} -systemd_add() { - service=$1 - systemctl --system unmask "${service}" >/dev/null || true - systemctl --system enable "${service}" >/dev/null || true - if [ -d /run/systemd/system ]; then - systemctl --system daemon-reload >/dev/null || true - systemctl --system start "${service}" >/dev/null || true - fi -} -if [ "$1" = 1 ]; then #install - dbus_reload - /usr/sbin/modprobe nvme-tcp - systemd_add stafd.service - systemd_add stacd.service -fi +%service_add_post %services -#------------------------------------------------------------------------------- %preun -systemd_rm { - service=$1 - systemctl --system unmask "${service}" >/dev/null || true - systemctl --system stop "${service}" >/dev/null || true - systemctl --system disable "${service}" >/dev/null || true -} - -if [ $1 == 0 ]; then #uninstall - systemd_rm stafd.service - systemd_rm stacd.service -fi +%service_del_preun %services -#------------------------------------------------------------------------------- %postun -systemd_rm { - service=$1 - systemctl --system unmask "${service}" >/dev/null || true - systemctl --system stop "${service}" >/dev/null || true - systemctl --system disable "${service}" >/dev/null || true -} - -if [ $1 == 0 ]; then #uninstall - if [ -d /run/systemd/system ]; then - systemctl --system daemon-reload >/dev/null || true - fi - dbus_reload -fi - +%service_del_postun %services +%files +%license LICENSE +%doc README.md +%dir %{_sysconfdir}/stas +%config(noreplace) %{_sysconfdir}/stas/stacd.conf +%config(noreplace) %{_sysconfdir}/stas/stafd.conf +%{_sysconfdir}/stas/sys.conf.doc +%{_datadir}/dbus-1/system.d/org.nvmexpress.*.conf +%{_bindir}/stacctl +%{_bindir}/stafctl +%{_bindir}/stasadm +%{_sbindir}/stacd +%{_sbindir}/stafd +%{_unitdir}/stacd.service +%{_unitdir}/stafd.service +%dir %{python3_sitearch}/staslib +%{python3_sitearch}/staslib/* +%doc %{_pkgdocdir} +%{_mandir}/man1/sta*.1* +%{_mandir}/man5/*.5* +%{_mandir}/man7/nvme*.7* +%{_mandir}/man8/sta*.8* %changelog -* Wed Sep 08 2021 Martin Belanger <[email protected]> - Release 0.1 +* Thu Mar 24 2022 Martin Belanger <[email protected]> - Release 1.0-rc4 - - diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/stacctl.py new/nvme-stas-1.0~rc5/stacctl.py --- old/nvme-stas-1.0~rc4/stacctl.py 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/stacctl.py 2022-03-24 17:54:53.000000000 +0100 @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3 # Copyright (c) 2021, Dell Inc. or its subsidiaries. All rights reserved. # SPDX-License-Identifier: Apache-2.0 # See the LICENSE file for details. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/stacd.py new/nvme-stas-1.0~rc5/stacd.py --- old/nvme-stas-1.0~rc4/stacd.py 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/stacd.py 2022-03-24 17:54:53.000000000 +0100 @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3 # Copyright (c) 2021, Dell Inc. or its subsidiaries. All rights reserved. # SPDX-License-Identifier: Apache-2.0 # See the LICENSE file for details. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/stafctl.py new/nvme-stas-1.0~rc5/stafctl.py --- old/nvme-stas-1.0~rc4/stafctl.py 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/stafctl.py 2022-03-24 17:54:53.000000000 +0100 @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3 # Copyright (c) 2021, Dell Inc. or its subsidiaries. All rights reserved. # SPDX-License-Identifier: Apache-2.0 # See the LICENSE file for details. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/stafd.py new/nvme-stas-1.0~rc5/stafd.py --- old/nvme-stas-1.0~rc4/stafd.py 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/stafd.py 2022-03-24 17:54:53.000000000 +0100 @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3 # Copyright (c) 2021, Dell Inc. or its subsidiaries. All rights reserved. # SPDX-License-Identifier: Apache-2.0 # See the LICENSE file for details. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/stasadm.py new/nvme-stas-1.0~rc5/stasadm.py --- old/nvme-stas-1.0~rc4/stasadm.py 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/stasadm.py 2022-03-24 17:54:53.000000000 +0100 @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3 # Copyright (c) 2021, Dell Inc. or its subsidiaries. All rights reserved. # SPDX-License-Identifier: Apache-2.0 # See the LICENSE file for details. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/staslib/stas.py new/nvme-stas-1.0~rc5/staslib/stas.py --- old/nvme-stas-1.0~rc4/staslib/stas.py 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/staslib/stas.py 2022-03-24 17:54:53.000000000 +0100 @@ -17,7 +17,6 @@ import configparser import platform import ipaddress -import netifaces import pyudev import systemd.daemon import dasbus.connection @@ -754,23 +753,7 @@ TransportId(controller), ip.version, CNF.conf_file) continue - # Next, if the interface is not specified, we'll assume that the - # IP address is valid and that there is a route to reach traddr. - iface = controller.get('host-iface') - if not iface: - valid_controllers.append(controller) - else: - # Finally, if there is an interface specified, let's make sure - # that the interface is enabled to connect using traddr. In other - # words, if traddr is an IPv4 address, then the interface must have - # IPv4 enabled. Same logic applies to IPv6. - ifaddresses = netifaces.ifaddresses(iface) # List of IP addresses configured on the interface - if ( (ip.version == 4 and netifaces.AF_INET in ifaddresses) or - (ip.version == 6 and netifaces.AF_INET6 in ifaddresses) ): - valid_controllers.append(controller) - else: - LOG.warning('%s rejected because interface %s is not configured for IPv%s', - TransportId(controller), iface, ip.version) + valid_controllers.append(controller) return valid_controllers diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/subprojects/libnvme.wrap new/nvme-stas-1.0~rc5/subprojects/libnvme.wrap --- old/nvme-stas-1.0~rc4/subprojects/libnvme.wrap 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/subprojects/libnvme.wrap 2022-03-24 17:54:53.000000000 +0100 @@ -1,6 +1,6 @@ [wrap-git] url = https://github.com/linux-nvme/libnvme.git -revision = 3a1bc6c6226d240b544058065382e2546018caa8 +revision = 131ee681a0e394b291cd407442886dbdf9fe124c [provide] libnvme = libnvme_dep diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/nvme-stas-1.0~rc4/utils/nvmet/nvmet.py new/nvme-stas-1.0~rc5/utils/nvmet/nvmet.py --- old/nvme-stas-1.0~rc4/utils/nvmet/nvmet.py 2022-03-15 18:30:55.000000000 +0100 +++ new/nvme-stas-1.0~rc5/utils/nvmet/nvmet.py 2022-03-24 17:54:53.000000000 +0100 @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/python3 # Copyright (c) 2021, Dell Inc. or its subsidiaries. All rights reserved. # SPDX-License-Identifier: Apache-2.0 # See the LICENSE file for details. ++++++ nvme-stas.obsinfo ++++++ --- /var/tmp/diff_new_pack.FEjEHc/_old 2022-03-25 21:55:17.906313899 +0100 +++ /var/tmp/diff_new_pack.FEjEHc/_new 2022-03-25 21:55:17.910313903 +0100 @@ -1,5 +1,5 @@ name: nvme-stas -version: 1.0~rc4 -mtime: 1647365455 -commit: 3fe9da46822603ff3dafb5c8708a1856580df2e5 +version: 1.0~rc5 +mtime: 1648140893 +commit: 52da2fc25d52d3eaaf8cbb8d697631ca348bf713
