Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libupnp for openSUSE:Factory checked in at 2022-10-10 18:43:28 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libupnp (Old) and /work/SRC/openSUSE:Factory/.libupnp.new.2275 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libupnp" Mon Oct 10 18:43:28 2022 rev:31 rq:1008617 version:1.14.14 Changes: -------- --- /work/SRC/openSUSE:Factory/libupnp/libupnp.changes 2022-08-05 19:50:31.969383119 +0200 +++ /work/SRC/openSUSE:Factory/.libupnp.new.2275/libupnp.changes 2022-10-10 18:43:36.538745507 +0200 @@ -1,0 +2,6 @@ +Thu Oct 6 21:45:03 UTC 2022 - Jan Engelhardt <[email protected]> + +- Update to release 1.14.14 + * Skip leading UTF-8 BOM in XML documents + +------------------------------------------------------------------- Old: ---- libupnp-1.14.13.tar.bz2 New: ---- libupnp-1.14.14.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libupnp.spec ++++++ --- /var/tmp/diff_new_pack.Y13tHo/_old 2022-10-10 18:43:37.002746506 +0200 +++ /var/tmp/diff_new_pack.Y13tHo/_new 2022-10-10 18:43:37.006746515 +0200 @@ -20,7 +20,7 @@ %define pnpver 17 %define ixmlver 11 Name: libupnp -Version: 1.14.13 +Version: 1.14.14 Release: 0 Summary: An implementation of Universal Plug and Play (UPnP) License: BSD-3-Clause ++++++ libupnp-1.14.13.tar.bz2 -> libupnp-1.14.14.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/ChangeLog new/libupnp-1.14.14/ChangeLog --- old/libupnp-1.14.13/ChangeLog 2022-08-03 16:02:20.000000000 +0200 +++ new/libupnp-1.14.14/ChangeLog 2022-10-05 19:12:09.000000000 +0200 @@ -9,6 +9,27 @@ Aborted. ******************************************************************************* +Version 1.14.14 +******************************************************************************* + +2022-09-27 philippe44 <[email protected]> + + don't use strxxx_s on Windows + + The use of these fails as 2nd argument is the same as 4th argument. + Reading the cpp_reference defintions of these, it can't be right. + +2022-09-20 Rex Cheung <93339127+rexcheung21(at)users.noreply.github.com> + + Fix #412 + + Skip leading UTF-8 BOM in XML document + +2022-08-04 Hugo Beauz??e-Luyssen <hugo(at)beauzee.fr> + + ThreadPool: Fix non UCRT builds + +******************************************************************************* Version 1.14.13 ******************************************************************************* diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/README.md new/libupnp-1.14.14/README.md --- old/libupnp-1.14.13/README.md 2022-08-03 16:03:34.000000000 +0200 +++ new/libupnp-1.14.14/README.md 2022-10-05 19:27:09.000000000 +0200 @@ -102,6 +102,8 @@ | -------------- | ---------- | ---------------------------------------- | | 1.18.0 | TBA ? | [Portable UPnP SDK][Portable UPnP SDK] | | 1.16.0 | aborted | [Portable UPnP SDK][Portable UPnP SDK] | +| 1.14.15 | TBA | [Portable UPnP SDK][Portable UPnP SDK] | +| 1.14.14 | 2022-10-05 | [Portable UPnP SDK][Portable UPnP SDK] | | 1.14.13 | 2022-08-03 | [Portable UPnP SDK][Portable UPnP SDK] | | 1.14.12 | 2021-09-26 | [Portable UPnP SDK][Portable UPnP SDK] | | 1.14.11 | 2021-08-20 | [Portable UPnP SDK][Portable UPnP SDK] | diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/THANKS new/libupnp-1.14.14/THANKS --- old/libupnp-1.14.13/THANKS 2022-06-19 06:04:05.000000000 +0200 +++ new/libupnp-1.14.14/THANKS 2022-10-05 19:13:19.000000000 +0200 @@ -77,6 +77,7 @@ - Pino Toscano (pinotree) - Rene Hexel - Rene Nielsen +- Rex Cheung - Robert Buckley (rbuckley) - Robert Gingher (robsbox) - Ronan Menard diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/configure new/libupnp-1.14.14/configure --- old/libupnp-1.14.13/configure 2022-08-03 16:04:02.000000000 +0200 +++ new/libupnp-1.14.14/configure 2022-08-04 18:15:51.000000000 +0200 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.71 for libupnp 1.14.13. +# Generated by GNU Autoconf 2.71 for libupnp 1.14.14. # # Report bugs to <[email protected]>. # @@ -621,8 +621,8 @@ # Identity of this package. PACKAGE_NAME='libupnp' PACKAGE_TARNAME='libupnp' -PACKAGE_VERSION='1.14.13' -PACKAGE_STRING='libupnp 1.14.13' +PACKAGE_VERSION='1.14.14' +PACKAGE_STRING='libupnp 1.14.14' PACKAGE_BUGREPORT='[email protected]' PACKAGE_URL='' @@ -1434,7 +1434,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures libupnp 1.14.13 to adapt to many kinds of systems. +\`configure' configures libupnp 1.14.14 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1505,7 +1505,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of libupnp 1.14.13:";; + short | recursive ) echo "Configuration of libupnp 1.14.14:";; esac cat <<\_ACEOF @@ -1652,7 +1652,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -libupnp configure 1.14.13 +libupnp configure 1.14.14 generated by GNU Autoconf 2.71 Copyright (C) 2021 Free Software Foundation, Inc. @@ -2008,7 +2008,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by libupnp $as_me 1.14.13, which was +It was created by libupnp $as_me 1.14.14, which was generated by GNU Autoconf 2.71. Invocation command line was $ $0$ac_configure_args_raw @@ -2766,7 +2766,7 @@ LT_VERSION_IXML=12:2:1 -LT_VERSION_UPNP=18:4:1 +LT_VERSION_UPNP=18:5:1 @@ -3288,7 +3288,7 @@ # Define the identity of the package. PACKAGE='libupnp' - VERSION='1.14.13' + VERSION='1.14.14' printf "%s\n" "#define PACKAGE \"$PACKAGE\"" >>confdefs.h @@ -17722,7 +17722,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by libupnp $as_me 1.14.13, which was +This file was extended by libupnp $as_me 1.14.14, which was generated by GNU Autoconf 2.71. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -17790,7 +17790,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config='$ac_cs_config_escaped' ac_cs_version="\\ -libupnp config.status 1.14.13 +libupnp config.status 1.14.14 configured by $0, generated by GNU Autoconf 2.71, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/configure.ac new/libupnp-1.14.14/configure.ac --- old/libupnp-1.14.13/configure.ac 2022-08-03 15:58:44.000000000 +0200 +++ new/libupnp-1.14.14/configure.ac 2022-08-03 16:14:24.000000000 +0200 @@ -9,7 +9,7 @@ AC_PREREQ(2.60) -AC_INIT([libupnp], [1.14.13], [[email protected]]) +AC_INIT([libupnp], [1.14.14], [[email protected]]) dnl ############################################################################ dnl # *Independently* of the above libupnp package version, the libtool version dnl # of the 3 libraries need to be updated whenever there is a change released: @@ -189,8 +189,18 @@ dnl #AC_SUBST([LT_VERSION_UPNP], [18:4:1]) dnl # dnl ############################################################################ +dnl # Release 1.14.14 +dnl # "current:revision:age" +dnl # +dnl # - Code has changed in upnp +dnl # revision: 4 -> 5 +dnl # +dnl #AC_SUBST([LT_VERSION_IXML], [12:2:1]) +dnl #AC_SUBST([LT_VERSION_UPNP], [18:5:1]) +dnl # +dnl ############################################################################ AC_SUBST([LT_VERSION_IXML], [12:2:1]) -AC_SUBST([LT_VERSION_UPNP], [18:4:1]) +AC_SUBST([LT_VERSION_UPNP], [18:5:1]) dnl ############################################################################ dnl # Repeating the algorithm to place it closer to the modificatin place: dnl # - library code modified: revision++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/docs/Doxyfile new/libupnp-1.14.14/docs/Doxyfile --- old/libupnp-1.14.13/docs/Doxyfile 2022-08-03 15:59:50.000000000 +0200 +++ new/libupnp-1.14.14/docs/Doxyfile 2022-08-03 16:14:24.000000000 +0200 @@ -38,7 +38,7 @@ # could be handy for archiving the generated documentation or if some version # control system is used. -PROJECT_NUMBER = 1.14.13 +PROJECT_NUMBER = 1.14.14 # Using the PROJECT_BRIEF tag one can provide an optional one line description # for a project that appears at the top of each page and should give viewer a diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/ixml/inc/posix_overwrites.h new/libupnp-1.14.14/ixml/inc/posix_overwrites.h --- old/libupnp-1.14.13/ixml/inc/posix_overwrites.h 2022-06-19 06:04:05.000000000 +0200 +++ new/libupnp-1.14.14/ixml/inc/posix_overwrites.h 2022-10-05 18:37:56.000000000 +0200 @@ -12,10 +12,36 @@ #define strnicmp _strnicmp /* Secure versions of functions */ - #define strcat(arg1, arg2) strcat_s(arg1, sizeof(arg1), arg2) - #define strcpy(arg1, arg2) strcpy_s(arg1, _countof(arg1), arg2) - #define strncpy(arg1, arg2, arg3) strncpy_s(arg1, arg3, arg2, arg3) - #define sprintf(arg1, ...) sprintf_s(arg1, sizeof(arg1), __VA_ARGS__) + /* Explicitly disable warnings by pragma/define, see: + * https://www.codegrepper.com/code-examples/c/crt+secure+no+warnings */ + #pragma warning(disable : 4996) + #define _CRT_SECURE_NO_WARNINGS + #if 0 + /* + * The current issues with those 4 defines: + * - strncpy redefinition is wrong + * - Theses functions assume they are being called on C arrays + * only. Using `countof` on a heap allocated pointer is + * undefined behavior and `sizeof` will only return the byte + * size of the pointer. + * + * The reason we can't pin-point the places where it fails is + * because *_s functions have a significantly different + * behaviour than the replaced functions and have actual error + * returns values that are simply ignored here, leading to + * numerous unseen regressions. + * + * A first step could be to actually crash or log on _s failures + * to detect the potentials overflows or bad usages of the + * wrappers. + */ + #define strcat(arg1, arg2) strcat_s(arg1, sizeof(arg1), arg2) + #define strcpy(arg1, arg2) strcpy_s(arg1, _countof(arg1), arg2) + #define strncpy(arg1, arg2, arg3) \ + strncpy_s(arg1, arg3, arg2, arg3) + #define sprintf(arg1, ...) \ + sprintf_s(arg1, sizeof(arg1), __VA_ARGS__) + #endif #endif /* _WIN32 */ #endif /* POSIX_OVERWRTIES_H */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/ixml/src/ixmlparser.c new/libupnp-1.14.14/ixml/src/ixmlparser.c --- old/libupnp-1.14.13/ixml/src/ixmlparser.c 2022-06-19 06:04:05.000000000 +0200 +++ new/libupnp-1.14.14/ixml/src/ixmlparser.c 2022-09-28 20:27:34.000000000 +0200 @@ -74,6 +74,7 @@ static const char *CDEND = "]]>"; static const char *DEC_NUMBERS = "0123456789"; static const char *HEX_NUMBERS = "0123456789ABCDEFabcdef"; +static const char *UTF8_BOM = "\xef\xbb\xbf"; typedef struct char_info { @@ -592,6 +593,19 @@ } /*! + * \brief Skip UTF-8 byte order mark + */ +static void Parser_skipBom( + /*! [in] The XML parser. */ + Parser *xmlParser) +{ + size_t bom_len = strlen(UTF8_BOM); + + if (strncmp(xmlParser->curPtr, UTF8_BOM, bom_len) == 0) + xmlParser->curPtr += bom_len; +} + +/*! * \brief Skip white spaces. */ static void Parser_skipWhiteSpaces( @@ -702,6 +716,7 @@ return IXML_FAILED; } + Parser_skipBom(xmlParser); Parser_skipWhiteSpaces(xmlParser); if (strncmp(xmlParser->curPtr, (char *)XMLDECL, strlen(XMLDECL)) == 0) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/libupnp.spec new/libupnp-1.14.14/libupnp.spec --- old/libupnp-1.14.13/libupnp.spec 2022-08-03 16:00:16.000000000 +0200 +++ new/libupnp-1.14.14/libupnp.spec 2022-08-03 16:14:24.000000000 +0200 @@ -1,4 +1,4 @@ -Version: 1.14.13 +Version: 1.14.14 Summary: Universal Plug and Play (UPnP) SDK Name: libupnp-1.14 Release: 1%{?dist} diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/upnp/src/genlib/miniserver/miniserver.c new/libupnp-1.14.14/upnp/src/genlib/miniserver/miniserver.c --- old/libupnp-1.14.13/upnp/src/genlib/miniserver/miniserver.c 2022-06-19 06:04:05.000000000 +0200 +++ new/libupnp-1.14.14/upnp/src/genlib/miniserver/miniserver.c 2022-10-05 19:20:54.000000000 +0200 @@ -238,7 +238,7 @@ http_message_t *request; MiniServerCallback callback; WebCallback_HostValidate host_validate_callback = 0; - void *cookie; + void *cookie = 0; int rc = UPNP_E_SUCCESS; /* If it does not fit in here, it is likely invalid anyway. */ char host_port[NAME_SIZE]; @@ -1316,7 +1316,7 @@ ssdpAddr.sin_port = htons(miniStopSockPort); sendto(sock, buf, - (int)bufLen, + bufLen, 0, (struct sockaddr *)&ssdpAddr, socklen); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/upnp/src/genlib/net/sock.c new/libupnp-1.14.14/upnp/src/genlib/net/sock.c --- old/libupnp-1.14.13/upnp/src/genlib/net/sock.c 2022-06-19 06:04:05.000000000 +0200 +++ new/libupnp-1.14.14/upnp/src/genlib/net/sock.c 2022-08-05 00:46:18.000000000 +0200 @@ -176,7 +176,7 @@ time_t start_time = time(NULL); SOCKET sockfd = info->socket; long bytes_sent = 0; - size_t byte_left = (size_t)0; + size_t byte_left = 0; ssize_t num_written; FD_ZERO(&readSet); @@ -226,10 +226,8 @@ } else { #endif /* read data. */ - numBytes = (long)recv(sockfd, - buffer, - (int)bufsize, - MSG_NOSIGNAL); + numBytes = (long)recv( + sockfd, buffer, bufsize, MSG_NOSIGNAL); #ifdef UPNP_ENABLE_OPEN_SSL } #endif @@ -247,7 +245,7 @@ /* write data. */ num_written = send(sockfd, buffer + bytes_sent, - (int)byte_left, + byte_left, MSG_DONTROUTE | MSG_NOSIGNAL); #ifdef UPNP_ENABLE_OPEN_SSL } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/upnp/src/ssdp/ssdp_ctrlpt.c new/libupnp-1.14.14/upnp/src/ssdp/ssdp_ctrlpt.c --- old/libupnp-1.14.13/upnp/src/ssdp/ssdp_ctrlpt.c 2022-06-19 06:04:05.000000000 +0200 +++ new/libupnp-1.14.14/upnp/src/ssdp/ssdp_ctrlpt.c 2022-08-05 00:46:18.000000000 +0200 @@ -724,7 +724,7 @@ ReqBufv6UlaGua); sendto(gSsdpReqSocket6, ReqBufv6UlaGua, - (int)strlen(ReqBufv6UlaGua), + strlen(ReqBufv6UlaGua), 0, (struct sockaddr *)&__ss_v6, sizeof(struct sockaddr_in6)); @@ -742,7 +742,7 @@ ReqBufv6); sendto(gSsdpReqSocket6, ReqBufv6, - (int)strlen(ReqBufv6), + strlen(ReqBufv6), 0, (struct sockaddr *)&__ss_v6, sizeof(struct sockaddr_in6)); @@ -763,7 +763,7 @@ ReqBufv4); sendto(gSsdpReqSocket4, ReqBufv4, - (int)strlen(ReqBufv4), + strlen(ReqBufv4), 0, (struct sockaddr *)&__ss_v4, sizeof(struct sockaddr_in)); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/upnp/src/ssdp/ssdp_device.c new/libupnp-1.14.14/upnp/src/ssdp/ssdp_device.c --- old/libupnp-1.14.13/upnp/src/ssdp/ssdp_device.c 2022-06-19 06:04:05.000000000 +0200 +++ new/libupnp-1.14.14/upnp/src/ssdp/ssdp_device.c 2022-08-05 00:46:18.000000000 +0200 @@ -298,7 +298,7 @@ *(RqPacket + Index)); rc = sendto(ReplySock, *(RqPacket + Index), - (int)strlen(*(RqPacket + Index)), + strlen(*(RqPacket + Index)), 0, DestAddr, socklen); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libupnp-1.14.13/upnp/src/threadutil/ThreadPool.c new/libupnp-1.14.14/upnp/src/threadutil/ThreadPool.c --- old/libupnp-1.14.13/upnp/src/threadutil/ThreadPool.c 2022-06-19 06:04:05.000000000 +0200 +++ new/libupnp-1.14.14/upnp/src/threadutil/ThreadPool.c 2022-08-04 18:27:29.000000000 +0200 @@ -1297,10 +1297,15 @@ _tzset(); tzflag++; } + #ifdef _UCRT long itz = 0; _get_timezone(&itz); tz->tz_minuteswest = (int)(itz / 60); _get_daylight(&tz->tz_dsttime); + #else + tz->tz_minuteswest = _timezone / 60; + tz->tz_dsttime = _daylight; + #endif } return 0;
