Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package glib2 for openSUSE:Factory checked 
in at 2022-11-03 19:13:41
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/glib2 (Old)
 and      /work/SRC/openSUSE:Factory/.glib2.new.2275 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "glib2"

Thu Nov  3 19:13:41 2022 rev:259 rq:1032923 version:2.74.1

Changes:
--------
--- /work/SRC/openSUSE:Factory/glib2/glib2.changes      2022-11-01 
13:41:11.331455803 +0100
+++ /work/SRC/openSUSE:Factory/.glib2.new.2275/glib2.changes    2022-11-03 
19:13:50.463886346 +0100
@@ -1,0 +2,6 @@
+Mon Oct 31 15:17:35 UTC 2022 - Bj??rn Lie <[email protected]>
+
+- Add a1151bc1.patch: gio/gdesktopappinfo: Free the wrapped argv
+  array on launch failure.
+
+-------------------------------------------------------------------

New:
----
  a1151bc1.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ glib2.spec ++++++
--- /var/tmp/diff_new_pack.BJC2k9/_old  2022-11-03 19:13:51.263891051 +0100
+++ /var/tmp/diff_new_pack.BJC2k9/_new  2022-11-03 19:13:51.267891074 +0100
@@ -60,6 +60,8 @@
 Patch4:         glib2-gdbus-codegen-version.patch
 # PATCH-FIX-UPSTREAM ca905744.patch [email protected] -- Revert "Handling 
collision between standard i/o file descriptors and newly created ones"
 Patch5:         https://gitlab.gnome.org/GNOME/glib/-/commit/ca905744.patch
+# PATCH-FIX-UPSTREAM a1151bc1.patch -- gio/gdesktopappinfo: Free the wrapped 
argv array on launch failure
+Patch6:         https://gitlab.gnome.org/GNOME/glib/-/commit/a1151bc1.patch
 
 BuildRequires:  docbook-xsl-stylesheets
 BuildRequires:  fdupes
@@ -264,6 +266,7 @@
 %patch3 -p1
 %patch4 -p1
 %patch5 -p1
+%patch6 -p1
 cp -a %{SOURCE1} %{SOURCE2} %{SOURCE5} .
 cp -a %{SOURCE4} gnome_defaults.conf
 # replace /usr/bin/env shebangs

++++++ a1151bc1.patch ++++++
>From efb43ef813d90dca48aa01880f097a2161005db1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= <[email protected]>
Date: Sun, 23 Oct 2022 17:10:59 +0200
Subject: [PATCH] gio/gdesktopappinfo: Free the wrapped argv array on launch
 failure

We create an array that we never free, ensure this is the case.
The previous commit gives CI a chance to check this with valgrind job.

Found as part of another review:
 - https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2839#note_1524922
---
 gio/gdesktopappinfo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gio/gdesktopappinfo.c b/gio/gdesktopappinfo.c
index f8cccca025..c29c309478 100644
--- a/gio/gdesktopappinfo.c
+++ b/gio/gdesktopappinfo.c
@@ -2963,6 +2963,7 @@ g_desktop_app_info_launch_uris_with_spawn 
(GDesktopAppInfo            *info,
 
           g_free (sn_id);
           g_list_free (launched_uris);
+          g_clear_pointer (&wrapped_argv, g_strfreev);
 
           goto out;
         }
-- 
GitLab

Reply via email to