Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libyui for openSUSE:Factory checked in at 2022-11-10 14:19:31 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libyui (Old) and /work/SRC/openSUSE:Factory/.libyui.new.1597 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libyui" Thu Nov 10 14:19:31 2022 rev:82 rq:1034866 version:4.4.6 Changes: -------- --- /work/SRC/openSUSE:Factory/libyui/libyui.changes 2022-08-31 18:08:51.847355791 +0200 +++ /work/SRC/openSUSE:Factory/.libyui.new.1597/libyui.changes 2022-11-10 14:19:35.377439323 +0100 @@ -1,0 +2,13 @@ +Wed Nov 9 13:59:19 UTC 2022 - Stefan Hundhammer <[email protected]> + +- Prevent antisocial focus grabbing in pkg list (bsc#1204429) +- 4.4.6 + +------------------------------------------------------------------- +Mon Sep 19 12:17:15 UTC 2022 - Stefan Hundhammer <[email protected]> + +- Fixed build failure with gcc 13 (gh#libyui/libyui/#80) +- Killed YCP zombies in log output and comments +- 4.4.5 + +------------------------------------------------------------------- Old: ---- libyui-4.4.4.tar.bz2 New: ---- libyui-4.4.6.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libyui-bindings.spec ++++++ --- /var/tmp/diff_new_pack.Z6iWhD/_old 2022-11-10 14:19:35.929442365 +0100 +++ /var/tmp/diff_new_pack.Z6iWhD/_new 2022-11-10 14:19:35.937442410 +0100 @@ -20,7 +20,7 @@ Name: libyui-bindings # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 Summary: Bindings for libyui License: LGPL-2.1-only OR LGPL-3.0-only @@ -50,7 +50,6 @@ - [email protected] - [email protected] - %prep %setup -q -n libyui-%{version} @@ -96,7 +95,6 @@ - [email protected] - [email protected] - %package -n python3-yui Summary: Python 3 bindings for libyui Group: Development/Languages/Python @@ -112,7 +110,6 @@ - [email protected] - [email protected] - %package -n perl-yui %{perl_requires} Summary: Perl bindings for libyui @@ -129,7 +126,6 @@ - [email protected] - [email protected] - %files -n ruby-yui %defattr(-,root,root,-) %doc %{name}/swig/ruby/examples/*.rb ++++++ libyui-ncurses-pkg.spec ++++++ --- /var/tmp/diff_new_pack.Z6iWhD/_old 2022-11-10 14:19:35.961442542 +0100 +++ /var/tmp/diff_new_pack.Z6iWhD/_new 2022-11-10 14:19:35.969442585 +0100 @@ -19,7 +19,7 @@ Name: libyui-ncurses-pkg # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 @@ -43,7 +43,6 @@ This package contains the package selector for the text based (NCurses) user interface component for libyui. - %package -n %{bin_name} Summary: Libyui - yast2 package selector widget for the NCurses UI @@ -70,7 +69,6 @@ This package contains the NCurses (text based) package selector component for libyui. - %package devel Summary: Libyui-ncurses-pkg header files @@ -86,7 +84,6 @@ This package contains the header files for the NCurses (text based) package selector component for libyui. - %prep %setup -q -n libyui-%{version} ++++++ libyui-ncurses-rest-api.spec ++++++ --- /var/tmp/diff_new_pack.Z6iWhD/_old 2022-11-10 14:19:35.997442740 +0100 +++ /var/tmp/diff_new_pack.Z6iWhD/_new 2022-11-10 14:19:36.001442762 +0100 @@ -19,7 +19,7 @@ Name: libyui-ncurses-rest-api # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 @@ -43,7 +43,6 @@ It allows inspecting and controlling the UI remotely via an HTTP REST API. This is designed for automated tests. - %package -n %{bin_name} Summary: Libyui - REST API plugin for the Ncurses frontend @@ -61,7 +60,6 @@ It allows inspecting and controlling the UI remotely via an HTTP REST API. This is designed for automated tests. - %package devel Summary: Libyui - Header files for the NCurses REST API plugin @@ -79,7 +77,6 @@ This is not needed for using the REST API, only for developing extensions for it. - %prep %setup -q -n libyui-%{version} ++++++ libyui-ncurses.spec ++++++ --- /var/tmp/diff_new_pack.Z6iWhD/_old 2022-11-10 14:19:36.021442872 +0100 +++ /var/tmp/diff_new_pack.Z6iWhD/_new 2022-11-10 14:19:36.029442917 +0100 @@ -19,7 +19,7 @@ Name: libyui-ncurses # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 @@ -41,7 +41,6 @@ This package contains the NCurses (text based) user interface component for libyui. - %package -n %{bin_name} Summary: Libyui - NCurses (text based) user interface @@ -75,7 +74,6 @@ This package is not needed to develop libyui-based applications, only to develop extensions for libyui-ncurses. - %package tools Summary: Libyui - tools for the NCurses (text based) user interface @@ -89,7 +87,6 @@ libyui-terminal - useful for testing on headless machines - %prep %setup -q -n libyui-%{version} ++++++ libyui-qt-graph.spec ++++++ --- /var/tmp/diff_new_pack.Z6iWhD/_old 2022-11-10 14:19:36.049443027 +0100 +++ /var/tmp/diff_new_pack.Z6iWhD/_new 2022-11-10 14:19:36.057443070 +0100 @@ -19,7 +19,7 @@ Name: libyui-qt-graph # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 @@ -48,7 +48,6 @@ %description This package contains the Qt graph component for libyui. - %package -n %{bin_name} Summary: Libyui - Qt graph widget Requires: libyui%{so_version} @@ -68,7 +67,6 @@ storage device hierarchy (disks, partitions, subvolumes etc.). and similar graphviz-generated graphs. - %package devel Summary: Libyui - Header files for the Qt graph widget Requires: %{bin_name} = %{version} @@ -78,7 +76,6 @@ This package contains the header files for the Qt graph component for libyui. - %prep %setup -q -n libyui-%{version} ++++++ libyui-qt-pkg.spec ++++++ --- /var/tmp/diff_new_pack.Z6iWhD/_old 2022-11-10 14:19:36.077443181 +0100 +++ /var/tmp/diff_new_pack.Z6iWhD/_new 2022-11-10 14:19:36.085443225 +0100 @@ -19,7 +19,7 @@ Name: libyui-qt-pkg # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 @@ -50,7 +50,6 @@ %description This package contains the Qt package selector component for libyui. - %package -n %{bin_name} Summary: Libyui - Qt package selector @@ -78,7 +77,6 @@ %description -n %{bin_name} This package contains the Qt package selector component for libyui. - %package devel Summary: Libyui-qt-pkg header files @@ -92,7 +90,6 @@ This can be used independently of YaST for generic (C++) applications. This package has very few dependencies. - %prep %setup -q -n libyui-%{version} ++++++ libyui-qt-rest-api.spec ++++++ --- /var/tmp/diff_new_pack.Z6iWhD/_old 2022-11-10 14:19:36.109443357 +0100 +++ /var/tmp/diff_new_pack.Z6iWhD/_new 2022-11-10 14:19:36.113443380 +0100 @@ -19,7 +19,7 @@ Name: libyui-qt-rest-api # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 @@ -50,7 +50,6 @@ It allows inspecting and controlling the UI remotely via an HTTP REST API. This is designed for automated tests. - %package -n %{bin_name} Summary: Libyui - The REST API plugin for the Qt frontend @@ -67,7 +66,6 @@ It allows inspecting and controlling the UI remotely via an HTTP REST API. This is designed for automated tests. - %package devel Summary: Libyui - Header files for the Qt REST API plugin @@ -85,7 +83,6 @@ This is not needed for using the REST API, only for developing extensions for it. - %prep %setup -q -n libyui-%{version} ++++++ libyui-qt.spec ++++++ --- /var/tmp/diff_new_pack.Z6iWhD/_old 2022-11-10 14:19:36.133443490 +0100 +++ /var/tmp/diff_new_pack.Z6iWhD/_new 2022-11-10 14:19:36.141443533 +0100 @@ -19,7 +19,7 @@ Name: libyui-qt # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 @@ -49,7 +49,6 @@ This package contains the Qt (graphical) user interface component for libyui. - %package -n %{bin_name} Summary: Libyui - Qt (graphical) user interface @@ -64,7 +63,6 @@ This package contains the Qt (graphical) user interface component for libyui. - %package devel Summary: Libyui - Header files for the Qt (graphical) user interface @@ -79,7 +77,6 @@ This package is not needed to develop libyui-based applications, only to develop extensions for libyui-qt. - %prep %setup -q -n libyui-%{version} ++++++ libyui-rest-api.spec ++++++ --- /var/tmp/diff_new_pack.Z6iWhD/_old 2022-11-10 14:19:36.161443643 +0100 +++ /var/tmp/diff_new_pack.Z6iWhD/_new 2022-11-10 14:19:36.169443688 +0100 @@ -19,7 +19,7 @@ Name: libyui-rest-api # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 @@ -43,7 +43,6 @@ It allows inspecting and controlling the UI remotely via an HTTP REST API, it is designed for automated tests. - %package -n %{bin_name} Summary: Libyui - REST API plugin, the shared part Requires: libyui%{so_version} @@ -56,7 +55,6 @@ It allows inspecting and controlling the UI remotely via an HTTP REST API, it is designed for automated tests. - %package devel Summary: Libyui - REST API header files @@ -73,7 +71,6 @@ This is a development subpackage. - %prep %setup -q -n libyui-%{version} ++++++ libyui.spec ++++++ --- /var/tmp/diff_new_pack.Z6iWhD/_old 2022-11-10 14:19:36.197443843 +0100 +++ /var/tmp/diff_new_pack.Z6iWhD/_new 2022-11-10 14:19:36.201443865 +0100 @@ -19,7 +19,7 @@ Name: libyui # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 @@ -45,7 +45,6 @@ YaST for generic (C++) applications. This package has very few dependencies. - %package -n %{bin_name} Summary: Libyui - GUI abstraction library @@ -65,7 +64,6 @@ YaST for generic (C++) applications. This package has very few dependencies. - %package devel Summary: Libyui header files and examples @@ -81,7 +79,6 @@ the abstraction from graphical user interfaces (Qt, Gtk) and text based user interfaces (ncurses). - %prep %setup -q -n %{name}-%{version} ++++++ libyui-4.4.4.tar.bz2 -> libyui-4.4.6.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/VERSION.cmake new/libyui-4.4.6/VERSION.cmake --- old/libyui-4.4.4/VERSION.cmake 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/VERSION.cmake 2022-11-09 16:04:22.000000000 +0100 @@ -1,6 +1,6 @@ SET( VERSION_MAJOR "4") SET( VERSION_MINOR "4" ) -SET( VERSION_PATCH "4" ) +SET( VERSION_PATCH "6" ) SET( VERSION "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}" ) SET( SONAME_MAJOR "16" ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui/src/YAlignment.cc new/libyui-4.4.6/libyui/src/YAlignment.cc --- old/libyui-4.4.4/libyui/src/YAlignment.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui/src/YAlignment.cc 2022-11-09 16:04:22.000000000 +0100 @@ -250,7 +250,7 @@ { if ( firstChild()->stretchable( dim ) && ( alignment( dim ) == YAlignUnchanged || - stretchable( dim ) ) ) // special case: promote child stretchability if `opt(`?stretch) set + stretchable( dim ) ) ) // special case: promote child stretchability if Opt(:?stretch) set { newChildSize[ dim ] = newSize[ dim ] - totalMargin[ dim ]; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui/src/YApplication.cc new/libyui-4.4.6/libyui/src/YApplication.cc --- old/libyui-4.4.4/libyui/src/YApplication.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui/src/YApplication.cc 2022-11-09 16:04:22.000000000 +0100 @@ -244,7 +244,7 @@ else if ( sym == YUIGlyph_BulletSquare ) return ( "[]" ); else // unknown glyph symbol { - yuiError() << "Unknown glyph `" << sym << endl; + yuiError() << "Unknown glyph :" << sym << endl; return ""; } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui/src/YDialog.cc new/libyui-4.4.6/libyui/src/YDialog.cc --- old/libyui-4.4.4/libyui/src/YDialog.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui/src/YDialog.cc 2022-11-09 16:04:22.000000000 +0100 @@ -331,7 +331,7 @@ { if ( newDefaultButton && priv->defaultButton ) // already have one? { - yuiError() << "Too many `opt(`default) PushButtons: [" + yuiError() << "Too many Opt(:default) PushButtons: [" << newDefaultButton->label() << "]" << endl; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui/src/YDialog.h new/libyui-4.4.6/libyui/src/YDialog.h --- old/libyui-4.4.4/libyui/src/YDialog.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui/src/YDialog.h 2022-11-09 16:04:22.000000000 +0100 @@ -96,7 +96,7 @@ /** * Wait for a user event. In most cases, this means waiting until the user * has clicked on a button in this dialog. If any widget has its 'notify' - * flag set (`opt(`notify) in YCP, setNotify( true ) in C++), an action on + * flag set (Opt(:notify) in Ruby, setNotify( true ) in C++), an action on * such a widget will also make waitForEvent() return. * * If the specified timeout elapses without any user event, a YTimeoutEvent diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui/src/YMenuButton.h new/libyui-4.4.6/libyui/src/YMenuButton.h --- old/libyui-4.4.4/libyui/src/YMenuButton.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui/src/YMenuButton.h 2022-11-09 16:04:22.000000000 +0100 @@ -25,6 +25,17 @@ #ifndef YMenuButton_h #define YMenuButton_h +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Woverloaded-virtual" +// GCC 13 has an over-sensitive check for shadowing inherited methods: +// +// It complains that YMenuButton::addItem( string label, string icon ) +// shadows the inherited YMenuWidget::addItem( YItem * ) +// despite the completely different signatures; which makes method overloading +// with more convenient parameters pretty much impossible. +// +// See also https://github.com/libyui/libyui/issues/80 + #include "YMenuWidget.h" #include "YMenuItem.h" @@ -121,4 +132,7 @@ }; +// Restore the old handling of "-Woverloaded-virtual" +#pragma GCC diagnostic pop + #endif // YMenuButton_h diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui/src/YRadioButton.cc new/libyui-4.4.6/libyui/src/YRadioButton.cc --- old/libyui-4.4.4/libyui/src/YRadioButton.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui/src/YRadioButton.cc 2022-11-09 16:04:22.000000000 +0100 @@ -198,7 +198,7 @@ { // Only record if this radio button is on. By definition one radio // button of the radio box _must_ be on if the user did anything, so we - // don't record a lot of redundant "ChangeWidget( ..., `Value, false )" + // don't record a lot of redundant "ChangeWidget( ..., :Value, false )" // calls. macroRecorder->recordWidgetProperty( this, YUIProperty_Value ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui/src/YShortcutManager.cc new/libyui-4.4.6/libyui/src/YShortcutManager.cc --- old/libyui-4.4.4/libyui/src/YShortcutManager.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui/src/YShortcutManager.cc 2022-11-09 16:04:22.000000000 +0100 @@ -257,7 +257,7 @@ if ( shortcut->widget()->autoShortcut() ) { yuiDebug() << "Automatically assigning shortcut '" << candidate - << "' to " << shortcut->widgetClass() << "(`opt(`autoShortcut ), \"" + << "' to " << shortcut->widgetClass() << "(Opt(:autoShortcut), \"" << shortcut->cleanShortcutString() << "\" )" << endl; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui/src/YTable.cc new/libyui-4.4.6/libyui/src/YTable.cc --- old/libyui-4.4.4/libyui/src/YTable.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui/src/YTable.cc 2022-11-09 16:04:22.000000000 +0100 @@ -189,7 +189,7 @@ * @property itemList SelectedItems All currently selected items * @property string Cell One cell (one column of one item) * @property integer Cell (ChangeWidget only) One cell as integer - * @property `icon(...) Cell Icon for one cell + * @property Icon(...) Cell Icon for one cell * @property string Item Alias for Cell * @property string Item QueryWidget only: Return one complete item * @property string IconPath Base path for icons diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui/src/YWidget.cc new/libyui-4.4.6/libyui/src/YWidget.cc --- old/libyui-4.4.4/libyui/src/YWidget.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui/src/YWidget.cc 2022-11-09 16:04:22.000000000 +0100 @@ -406,16 +406,16 @@ { /** * @property boolean Enabled enabled/disabled state of this widget - * @property boolean Notify the current notify state (see also `opt( `notify )) - * @property boolean ContextMenu the current contextmenu state (see also `opt( `notifyContextMenu )) + * @property boolean Notify the current notify state (see also Opt( :notify )) + * @property boolean ContextMenu the current contextmenu state (see also Opt( :notifyContextMenu )) * @property string WidgetClass the widget class of this widget (YLabel, YPushButton, ...) * @property string DebugLabel (possibly translated) text describing this widget for debugging * @property string ID widget id as a read-only property * @property string HelpText help text - * @property integer HWeight horizontal layout weight (same as `HWeight(widget()) - * @property integer VWeight vertical layout weight (same as `VWeight(widget()) - * @property boolean HStretch horizontally stretchable? (same as `opt(`hstretch)) - * @property boolean VStretch vertically stretchable? (same as `opt(`vstretch)) + * @property integer HWeight horizontal layout weight (same as HWeight(widget()) + * @property integer VWeight vertical layout weight (same as VWeight(widget()) + * @property boolean HStretch horizontally stretchable? (same as Opt(:hstretch)) + * @property boolean VStretch vertically stretchable? (same as Opt(:vstretch)) **/ propSet.add( YProperty( YUIProperty_Enabled, YBoolProperty ) ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui/src/YWidget.h new/libyui-4.4.6/libyui/src/YWidget.h --- old/libyui-4.4.4/libyui/src/YWidget.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui/src/YWidget.h 2022-11-09 16:04:22.000000000 +0100 @@ -435,20 +435,20 @@ * beyond its preferred size in the specified dimension. A selection box is * stretchable in both dimensions, a push button is not stretchable by * default, a frame is stretchable if its contents are stretchable. Most - * widgets accept a `hstretch or `vstretch option to become stretchable + * widgets accept a :hstretch or :vstretch option to become stretchable * even when by default they are not. **/ virtual bool stretchable( YUIDimension dim ) const; /** - * Set the stretchable state to "newStretch" regardless of any `hstretch or - * `vstretch options. + * Set the stretchable state to "newStretch" regardless of any :hstretch or + * :vstretch options. **/ void setStretchable( YUIDimension dim, bool newStretch ); /** * Set the stretchable state to "newStretch". - * `hstretch or `vstretch options may override this. + * :hstretch or :vstretch options may override this. **/ void setDefaultStretchable( YUIDimension dim, bool newStretch ); @@ -500,7 +500,7 @@ /** * Returns 'true' if this widget should send key events, i.e. if it has - * `opt(`keyEvent) set. + * Opt(:keyEvent) set. **/ bool sendKeyEvents() const; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-ncurses/src/NCDialog.cc new/libyui-4.4.6/libyui-ncurses/src/NCDialog.cc --- old/libyui-4.4.4/libyui-ncurses/src/NCDialog.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-ncurses/src/NCDialog.cc 2022-11-09 16:04:22.000000000 +0100 @@ -1299,7 +1299,7 @@ * Create description for function keys: * * Get all PushButtons and MenuButtons that have a function key std::set - * (`opt(`key_Fn) in YCP) and create a std::map: + * (Opt(:key_Fn) in Ruby) and create a std::map: * $[ 1: "Help", 2: "Info",... ] * NCurses::SetStatusLine will process this. **/ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-ncurses/src/NCPad.h new/libyui-4.4.6/libyui-ncurses/src/NCPad.h --- old/libyui-4.4.4/libyui-ncurses/src/NCPad.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-ncurses/src/NCPad.h 2022-11-09 16:04:22.000000000 +0100 @@ -105,9 +105,9 @@ /// /// In the underlying C ncurses library, a *pad* is a virtual window without a /// position. Of course that is not very useful without any way to display it -/// so there's a `prefresh` function to draw a portion of that pad into a +/// so there's a prefresh() function to draw a portion of that pad into a /// visible "viewport" window. Our NCursesPad fork just directly forwards to -/// `prefresh` without remembering the window. Upstream NCursesPad does know a +/// prefresh() without remembering the window. Upstream NCursesPad does know a /// viewport window and so does NCPad (*destwin*). class NCPad : public NCursesPad, public NCScrollHint { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-ncurses/src/NCTable.cc new/libyui-4.4.6/libyui-ncurses/src/NCTable.cc --- old/libyui-4.4.4/libyui-ncurses/src/NCTable.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-ncurses/src/NCTable.cc 2022-11-09 16:04:22.000000000 +0100 @@ -47,7 +47,7 @@ * * In multi selection mode there can be several items selected (here is means * checked/marked with [x]) and the value is also got from selectedItem() when - * asking for `SelectedItems + * asking for :SelectedItems * (see YCPPropertyHandler::tryGetSelectionWidgetValue). * * This means for multi selection mode: at the moment there isn't a possibility diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-ncurses/src/NCTableItem.h new/libyui-4.4.6/libyui-ncurses/src/NCTableItem.h --- old/libyui-4.4.4/libyui-ncurses/src/NCTableItem.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-ncurses/src/NCTableItem.h 2022-11-09 16:04:22.000000000 +0100 @@ -641,7 +641,7 @@ /** * A column (one cell) used as a selection marker: - * `[ ]`/`[x]` or `( )`/`(x)`. + * '[ ]'/'[x]' or '( )'/'(x)'. **/ class NCTableTag : public NCTableCol { @@ -651,9 +651,9 @@ * Constructor. * * @param item (must not be nullptr, not owned) - * @param sel currently selected, draw an `x` inside - * @param singleSel if true draw this in a radio-button style `(x)`; - * if false draw this in a checkbox style `[x]` + * @param sel currently selected, draw an 'x' inside + * @param singleSel if true draw this in a radio-button style '(x)'; + * if false draw this in a checkbox style '[x]' **/ NCTableTag( YItem *item, bool sel = false, bool singleSel = false ) : NCTableCol( NCstring( singleSel ? "( )" : "[ ]" ), SEPARATOR ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-ncurses/src/ncursesw.cc new/libyui-4.4.6/libyui-ncurses/src/ncursesw.cc --- old/libyui-4.4.4/libyui-ncurses/src/ncursesw.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-ncurses/src/ncursesw.cc 2022-11-09 16:04:22.000000000 +0100 @@ -340,7 +340,7 @@ c = win.width() - begin_x; // Even though we treat subwindows as a tree, the standard curses - // library needs the `subwin' call to link to the parent in + // library needs the 'subwin' call to link to the parent in // order to correctly perform refreshes, etc. // Friendly enough, this also works for pads. w = ::derwin( win.w, l, c, begin_y, begin_x ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-ncurses/src/ncursesw.h new/libyui-4.4.6/libyui-ncurses/src/ncursesw.h --- old/libyui-4.4.4/libyui-ncurses/src/ncursesw.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-ncurses/src/ncursesw.h 2022-11-09 16:04:22.000000000 +0100 @@ -995,7 +995,7 @@ * Constructor. * * If 'absrel' is 'a', begin_x/y are absolute screen pos, - * if `r', they are relative to parent origin. + * if 'r', they are relative to parent origin. **/ NCursesWindow( NCursesWindow & parent, int lines, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-ncurses-pkg/src/NCPackageSelector.cc new/libyui-4.4.6/libyui-ncurses-pkg/src/NCPackageSelector.cc --- old/libyui-4.4.4/libyui-ncurses-pkg/src/NCPackageSelector.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-ncurses-pkg/src/NCPackageSelector.cc 2022-11-09 16:04:22.000000000 +0100 @@ -1326,7 +1326,7 @@ if ( input == NCursesEvent::cancel ) { - // disk space error warning returned `cancel + // disk space error warning returned :cancel closeDialog = false; } } @@ -1761,7 +1761,7 @@ depsMenu = new NCPkgMenuDeps( menu_buttons, NCPkgStrings::Deps(), this); viewMenu = new NCPkgMenuView( menu_buttons, NCPkgStrings::View(), this); - // Add only if requested by `opt(`repoMgr) flag - #381956 + // Add only if requested by Opt(:repoMgr) flag - #381956 if (isRepoMgrEnabled()) configMenu = new NCPkgMenuConfig( menu_buttons, _( "C&onfiguration" ), this); @@ -1911,7 +1911,7 @@ break; } - // if started with `repoMode or `summaryMode replace filter accordingly + // if started with :repoMode or :summaryMode replace filter accordingly if ( repoMode ) { replaceFilter ( NCPackageSelector::Repositories ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-ncurses-pkg/src/NCPackageSelectorPluginImpl.cc new/libyui-4.4.6/libyui-ncurses-pkg/src/NCPackageSelectorPluginImpl.cc --- old/libyui-4.4.4/libyui-ncurses-pkg/src/NCPackageSelectorPluginImpl.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-ncurses-pkg/src/NCPackageSelectorPluginImpl.cc 2022-11-09 16:04:22.000000000 +0100 @@ -103,7 +103,7 @@ } else { - yuiError() << "PkgSpecial( " << subwidget << " ) not found - take default `Label" << endl; + yuiError() << "PkgSpecial( " << subwidget << " ) not found - take default Label" << endl; w = new NCLabel( parent, subwidget, false, false ); } @@ -118,7 +118,7 @@ // METHOD TYPE : YEvent * // // DESCRIPTION : Implementation of UI builtin RunPkgSelection() which -// has to be called after OpenDialog( `PackageSelector() ). +// has to be called after OpenDialog( PackageSelector() ). // YEvent * NCPackageSelectorPluginImpl::runPkgSelection( YDialog * dialog, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-ncurses-pkg/src/NCPkgMenuConfig.cc new/libyui-4.4.6/libyui-ncurses-pkg/src/NCPkgMenuConfig.cc --- old/libyui-4.4.4/libyui-ncurses-pkg/src/NCPkgMenuConfig.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-ncurses-pkg/src/NCPkgMenuConfig.cc 2022-11-09 16:04:22.000000000 +0100 @@ -95,7 +95,7 @@ if ( event.selection == repoManager ) { - // return `repo_mgr symbol to YCP module (FaTE #302517) + // return :repo_mgr symbol to Ruby module (FaTE #302517) const_cast<NCursesEvent &>(event).result = "repo_mgr"; yuiMilestone() << "Launching repository manager " << endl; @@ -104,7 +104,7 @@ } else if ( event.selection == onlineUpdate ) { - // the same as above, return `online_update_config + // the same as above, return :online_update_config const_cast<NCursesEvent &>(event).result = "online_update_configuration"; yuiMilestone() << "Launching YOU configuration " << endl; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-ncurses-pkg/src/NCPkgMenuExtras.cc new/libyui-4.4.6/libyui-ncurses-pkg/src/NCPkgMenuExtras.cc --- old/libyui-4.4.4/libyui-ncurses-pkg/src/NCPkgMenuExtras.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-ncurses-pkg/src/NCPkgMenuExtras.cc 2022-11-09 16:04:22.000000000 +0100 @@ -99,7 +99,7 @@ /*else if ( event.selection == repoManager ) { - // return `repo_mgr symbol to YCP module (FaTE #302517) + // return :repo_mgr symbol to the Ruby module (FaTE #302517) const_cast<NCursesEvent &>(event).result = "repo_mgr"; yuiMilestone() << "Launching repository manager " << endl; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-ncurses-pkg/src/NCPkgPopupDiskspace.cc new/libyui-4.4.6/libyui-ncurses-pkg/src/NCPkgPopupDiskspace.cc --- old/libyui-4.4.4/libyui-ncurses-pkg/src/NCPkgPopupDiskspace.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-ncurses-pkg/src/NCPkgPopupDiskspace.cc 2022-11-09 16:04:22.000000000 +0100 @@ -305,7 +305,7 @@ // // DESCRIPTION : For testing only; called from NCPkgTable if the PackageSelector // running in testMode -// TESTDESCRIPTION: Call `PackageSelector with `opt(`testMode) (ycp example). +// TESTDESCRIPTION: Call PackageSelector with Opt(:testMode) (Ruby example). // With focus on the package list press '+' or '-' to // increase/decrease used diskspace (see y2log). // Use the 'Actions' menu to select/delete a package. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt/src/YQComboBox.h new/libyui-4.4.6/libyui-qt/src/YQComboBox.h --- old/libyui-4.4.4/libyui-qt/src/YQComboBox.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt/src/YQComboBox.h 2022-11-09 16:04:22.000000000 +0100 @@ -129,14 +129,14 @@ /** * Tells the ui that an item has been selected. This is only - * interesting if the `notify option is set. + * interesting if the notify option is set. **/ void slotSelected( int i ); /** - * Tells the ui that the user has edited the text ( if the - * 'editable' option is set ). - * This is only interesting if the `notify option is set. + * Tells the ui that the user has edited the text (if the + * 'editable' option is set). + * This is only interesting if the notify option is set. **/ void textChanged( QString ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt/src/YQDialog.cc new/libyui-4.4.6/libyui-qt/src/YQDialog.cc --- old/libyui-4.4.4/libyui-qt/src/YQDialog.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt/src/YQDialog.cc 2022-11-09 16:04:22.000000000 +0100 @@ -506,7 +506,7 @@ } else { - yuiError() << "Too many `opt(`default) PushButtons: " << newDefaultButton << endl; + yuiError() << "Too many Opt(:default) PushButtons: " << newDefaultButton << endl; newDefaultButton->setDefaultButton( false ); return; } @@ -720,7 +720,7 @@ YQDialog::closeEvent( QCloseEvent * event ) { // The window manager "close window" button (and WM menu, e.g. Alt-F4) will be - // handled just like the user had clicked on the `id`( `cancel ) button in + // handled just like the user had clicked on the Id( :cancel ) button in // that dialog. It's up to the YCP application to handle this (if desired). yuiMilestone() << "Caught window manager close event - returning with YCancelEvent" << endl; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt/src/YQItemSelector.h new/libyui-4.4.6/libyui-qt/src/YQItemSelector.h --- old/libyui-4.4.4/libyui-qt/src/YQItemSelector.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt/src/YQItemSelector.h 2022-11-09 16:04:22.000000000 +0100 @@ -163,7 +163,7 @@ /** * Notification that an item has been selected. - * This is only relevant if `opt(`notify ) is set. + * This is only relevant if Opt( :notify ) is set. **/ void slotSelectionChanged( YQSelectorItemWidget * itemWidget, bool selected ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt/src/YQMainWinDock.cc new/libyui-4.4.6/libyui-qt/src/YQMainWinDock.cc --- old/libyui-4.4.4/libyui-qt/src/YQMainWinDock.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt/src/YQMainWinDock.cc 2022-11-09 16:04:22.000000000 +0100 @@ -292,7 +292,7 @@ YQMainWinDock::closeEvent( QCloseEvent * event ) { // The window manager "close window" button (and WM menu, e.g. Alt-F4) will be - // handled just like the user had clicked on the `id`( `cancel ) button in + // handled just like the user had clicked on the Id( :cancel ) button in // that dialog. It's up to the YCP application to handle this (if desired). yuiMilestone() << "Caught window manager close event - returning with YCancelEvent" << endl; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt/src/YQMultiSelectionBox.h new/libyui-4.4.6/libyui-qt/src/YQMultiSelectionBox.h --- old/libyui-4.4.4/libyui-qt/src/YQMultiSelectionBox.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt/src/YQMultiSelectionBox.h 2022-11-09 16:04:22.000000000 +0100 @@ -145,12 +145,12 @@ protected slots: /** - * Send SelectionChanged event if `opt(`notify) is set. + * Send SelectionChanged event if Opt(:notify) is set. **/ void slotSelected(); /** - * Send ValueChanged event if `opt(`notify) is set. + * Send ValueChanged event if Opt(:notify) is set. **/ void slotValueChanged(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt/src/YQSelectionBox.h new/libyui-4.4.6/libyui-qt/src/YQSelectionBox.h --- old/libyui-4.4.4/libyui-qt/src/YQSelectionBox.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt/src/YQSelectionBox.h 2022-11-09 16:04:22.000000000 +0100 @@ -141,7 +141,7 @@ /** * Notification that an item has been selected. - * This is only relevant if `opt(`notify ) is set. + * This is only relevant if Opt( :notify ) is set. **/ void slotSelectionChanged(); @@ -152,13 +152,13 @@ /** * Return after some millseconds delay - collect multiple events. - * This is only relevant if `opt( `notify ) is set. + * This is only relevant if Opt( :notify ) is set. **/ void returnDelayed(); /** * Return immediately. - * This is only relevant if `opt( `notify ) is set. + * This is only relevant if Opt( :notify ) is set. **/ void returnImmediately(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt/src/YQUI.cc new/libyui-4.4.6/libyui-qt/src/YQUI.cc --- old/libyui-4.4.4/libyui-qt/src/YQUI.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt/src/YQUI.cc 2022-11-09 16:04:22.000000000 +0100 @@ -274,8 +274,8 @@ "Command line options for the YaST2 Qt UI:\n" "\n" "--nothreads run without additional UI threads\n" - "--fullscreen use full screen for `opt(`defaultsize) dialogs\n" - "--noborder no window manager border for `opt(`defaultsize) dialogs\n" + "--fullscreen use full screen for Opt(:defaultsize) dialogs\n" + "--noborder no window manager border for Opt(:defaultsize) dialogs\n" "--auto-fonts automatically pick fonts, disregard Qt standard settings\n" "--help this help text\n" "\n" @@ -375,7 +375,7 @@ yuiMilestone() << "-fullscreen: using " << _defaultSize.width() << " x " << _defaultSize.height() - << "for `opt(`defaultsize)" + << " for Opt(:defaultsize)" << endl; } else diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt/src/YQUI.h new/libyui-4.4.6/libyui-qt/src/YQUI.h --- old/libyui-4.4.4/libyui-qt/src/YQUI.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt/src/YQUI.h 2022-11-09 16:04:22.000000000 +0100 @@ -187,7 +187,7 @@ void raiseFatalError() { _fatalError = true; } /** - * Returns size for `opt(`defaultsize) dialogs (in one dimension). + * Returns size for Opt(:defaultsize) dialogs (in one dimension). **/ int defaultSize( YUIDimension dim ) const; @@ -316,7 +316,7 @@ void processCommandLineArgs( int argc, char **argv ); /** - * Calculate size of `opt(`defaultsize) dialogs + * Calculate size of Opt(:defaultsize) dialogs **/ void calcDefaultSize(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt/src/YQWizard.cc new/libyui-4.4.6/libyui-qt/src/YQWizard.cc --- old/libyui-4.4.4/libyui-qt/src/YQWizard.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt/src/YQWizard.cc 2022-11-09 16:04:22.000000000 +0100 @@ -104,7 +104,7 @@ setWidgetRep( this ); - // either main wizard with `opt(`stepsEnabled), or sub-wizard of steps-enabled wizard + // either main wizard with Opt(:stepsEnabled), or sub-wizard of steps-enabled wizard _stepsEnabled = (wizardMode == YWizardMode_Steps); _treeEnabled = (wizardMode == YWizardMode_Tree); @@ -585,7 +585,7 @@ if ( ! _tree ) { - yuiError() << "YQWizard widget not created with `opt(`treeEnabled) !" << endl; + yuiError() << "YQWizard widget not created with Opt(:treeEnabled) !" << endl; return; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt/src/YQWizard.h new/libyui-4.4.6/libyui-qt/src/YQWizard.h --- old/libyui-4.4.4/libyui-qt/src/YQWizard.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt/src/YQWizard.h 2022-11-09 16:04:22.000000000 +0100 @@ -424,7 +424,7 @@ public slots: /** - * Adapt the size of the client area (the ReplacePoint(`id(`contents)) to + * Adapt the size of the client area (the ReplacePoint(Id(:contents)) to * fit in its current space. **/ void resizeClientArea(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt-pkg/src/YQPackageSelector.cc new/libyui-4.4.6/libyui-qt-pkg/src/YQPackageSelector.cc --- old/libyui-4.4.4/libyui-qt-pkg/src/YQPackageSelector.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt-pkg/src/YQPackageSelector.cc 2022-11-09 16:04:22.000000000 +0100 @@ -964,7 +964,7 @@ pkgList, SLOT ( logExcludeStatistics() ) ); connect( filter, SIGNAL( filterFinished() ), - pkgList, SLOT ( setFocus() ) ); + pkgList, SLOT ( maybeSetFocus() ) ); connect( filter, SIGNAL( filterFinished() ), this, SLOT ( normalCursor() ) ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt-pkg/src/YQPatternSelector.h new/libyui-4.4.6/libyui-qt-pkg/src/YQPatternSelector.h --- old/libyui-4.4.4/libyui-qt-pkg/src/YQPatternSelector.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt-pkg/src/YQPatternSelector.h 2022-11-09 16:04:22.000000000 +0100 @@ -50,7 +50,7 @@ /** * User clicked on "Details..." - start the detailed package selection. - * This will return from UI::RunPkgSelection() with `details . + * This will return from UI::RunPkgSelection() with :details . **/ void detailedPackageSelection(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt-pkg/src/YQPkgObjList.cc new/libyui-4.4.6/libyui-qt-pkg/src/YQPkgObjList.cc --- old/libyui-4.4.4/libyui-qt-pkg/src/YQPkgObjList.cc 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt-pkg/src/YQPkgObjList.cc 2022-11-09 16:04:22.000000000 +0100 @@ -841,6 +841,33 @@ } +void +YQPkgObjList::maybeSetFocus() +{ + if ( ! shouldKeepFocus( QApplication::focusWidget() ) ) + setFocus(); +} + + +bool +YQPkgObjList::shouldKeepFocus( QWidget * widget ) const +{ + if ( ! widget ) + return false; + + // Do not take away the keyboard focus from this kind of widget because it + // also has internal navigation with the cursor keys; for example a + // connected filter view like the patterns view, the repositories view, the + // patches view. + // bsc#1204429 + + if ( dynamic_cast<QAbstractItemView*>( widget ) ) // All kinds of lists and trees + return true; + else + return false; +} + + YQPkgObjListItem::YQPkgObjListItem( YQPkgObjList * pkgObjList, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt-pkg/src/YQPkgObjList.h new/libyui-4.4.6/libyui-qt-pkg/src/YQPkgObjList.h --- old/libyui-4.4.4/libyui-qt-pkg/src/YQPkgObjList.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt-pkg/src/YQPkgObjList.h 2022-11-09 16:04:22.000000000 +0100 @@ -236,6 +236,13 @@ **/ void logExcludeStatistics(); + /** + * Set the keyboard focus to this list unless the focus is currently on a + * similar widget that relies on heavy keyboard interaction, like another + * list. + **/ + void maybeSetFocus(); + // Direct access to some states for menu actions @@ -315,6 +322,13 @@ virtual QMenu * notInstalledContextMenu(); /** + * Return 'true' if 'widget' should keep the keyboard focus, i.e. it's also + * some kind of list widget that has internal navigation with the cursor + * keys; like another list or tree widget. + **/ + bool shouldKeepFocus( QWidget * widget ) const; + + /** * Create the context menu for items that are not installed. **/ virtual void createNotInstalledContextMenu(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/libyui-qt-pkg/src/YQSimplePatchSelector.h new/libyui-4.4.6/libyui-qt-pkg/src/YQSimplePatchSelector.h --- old/libyui-4.4.4/libyui-qt-pkg/src/YQSimplePatchSelector.h 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/libyui-qt-pkg/src/YQSimplePatchSelector.h 2022-11-09 16:04:22.000000000 +0100 @@ -50,7 +50,7 @@ /** * User clicked on "Details..." - start the detailed package selection. - * This will return from UI::RunPkgSelection() with `details . + * This will return from UI::RunPkgSelection() with :details . **/ void detailedPackageSelection(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/package/libyui-bindings.spec new/libyui-4.4.6/package/libyui-bindings.spec --- old/libyui-4.4.4/package/libyui-bindings.spec 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/package/libyui-bindings.spec 2022-11-09 16:04:22.000000000 +0100 @@ -20,7 +20,7 @@ Name: libyui-bindings # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 Summary: Bindings for libyui License: LGPL-2.1-only OR LGPL-3.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/package/libyui-ncurses-pkg.spec new/libyui-4.4.6/package/libyui-ncurses-pkg.spec --- old/libyui-4.4.4/package/libyui-ncurses-pkg.spec 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/package/libyui-ncurses-pkg.spec 2022-11-09 16:04:22.000000000 +0100 @@ -19,7 +19,7 @@ Name: libyui-ncurses-pkg # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/package/libyui-ncurses-rest-api.spec new/libyui-4.4.6/package/libyui-ncurses-rest-api.spec --- old/libyui-4.4.4/package/libyui-ncurses-rest-api.spec 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/package/libyui-ncurses-rest-api.spec 2022-11-09 16:04:22.000000000 +0100 @@ -19,7 +19,7 @@ Name: libyui-ncurses-rest-api # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/package/libyui-ncurses.spec new/libyui-4.4.6/package/libyui-ncurses.spec --- old/libyui-4.4.4/package/libyui-ncurses.spec 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/package/libyui-ncurses.spec 2022-11-09 16:04:22.000000000 +0100 @@ -19,7 +19,7 @@ Name: libyui-ncurses # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/package/libyui-qt-graph.spec new/libyui-4.4.6/package/libyui-qt-graph.spec --- old/libyui-4.4.4/package/libyui-qt-graph.spec 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/package/libyui-qt-graph.spec 2022-11-09 16:04:22.000000000 +0100 @@ -19,7 +19,7 @@ Name: libyui-qt-graph # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/package/libyui-qt-pkg.spec new/libyui-4.4.6/package/libyui-qt-pkg.spec --- old/libyui-4.4.4/package/libyui-qt-pkg.spec 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/package/libyui-qt-pkg.spec 2022-11-09 16:04:22.000000000 +0100 @@ -19,7 +19,7 @@ Name: libyui-qt-pkg # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/package/libyui-qt-rest-api.spec new/libyui-4.4.6/package/libyui-qt-rest-api.spec --- old/libyui-4.4.4/package/libyui-qt-rest-api.spec 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/package/libyui-qt-rest-api.spec 2022-11-09 16:04:22.000000000 +0100 @@ -19,7 +19,7 @@ Name: libyui-qt-rest-api # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/package/libyui-qt.spec new/libyui-4.4.6/package/libyui-qt.spec --- old/libyui-4.4.4/package/libyui-qt.spec 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/package/libyui-qt.spec 2022-11-09 16:04:22.000000000 +0100 @@ -19,7 +19,7 @@ Name: libyui-qt # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/package/libyui-rest-api.spec new/libyui-4.4.6/package/libyui-rest-api.spec --- old/libyui-4.4.4/package/libyui-rest-api.spec 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/package/libyui-rest-api.spec 2022-11-09 16:04:22.000000000 +0100 @@ -19,7 +19,7 @@ Name: libyui-rest-api # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/package/libyui.changes new/libyui-4.4.6/package/libyui.changes --- old/libyui-4.4.4/package/libyui.changes 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/package/libyui.changes 2022-11-09 16:04:22.000000000 +0100 @@ -1,4 +1,17 @@ ------------------------------------------------------------------- +Wed Nov 9 13:59:19 UTC 2022 - Stefan Hundhammer <[email protected]> + +- Prevent antisocial focus grabbing in pkg list (bsc#1204429) +- 4.4.6 + +------------------------------------------------------------------- +Mon Sep 19 12:17:15 UTC 2022 - Stefan Hundhammer <[email protected]> + +- Fixed build failure with gcc 13 (gh#libyui/libyui/#80) +- Killed YCP zombies in log output and comments +- 4.4.5 + +------------------------------------------------------------------- Tue Aug 30 13:25:24 UTC 2022 - Stefan Hundhammer <[email protected]> - Fixed main window stacking order in YQMainWinDock to avoid diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.4.4/package/libyui.spec new/libyui-4.4.6/package/libyui.spec --- old/libyui-4.4.4/package/libyui.spec 2022-08-30 17:29:32.000000000 +0200 +++ new/libyui-4.4.6/package/libyui.spec 2022-11-09 16:04:22.000000000 +0100 @@ -19,7 +19,7 @@ Name: libyui # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.4.4 +Version: 4.4.6 Release: 0 %define so_version 16
