Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-storage-ng for
openSUSE:Factory checked in at 2022-12-08 16:50:23
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-storage-ng (Old)
and /work/SRC/openSUSE:Factory/.yast2-storage-ng.new.1835 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-storage-ng"
Thu Dec 8 16:50:23 2022 rev:134 rq:1041147 version:4.5.15
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-storage-ng/yast2-storage-ng.changes
2022-11-22 16:09:55.821953097 +0100
+++
/work/SRC/openSUSE:Factory/.yast2-storage-ng.new.1835/yast2-storage-ng.changes
2022-12-08 16:50:24.759245748 +0100
@@ -1,0 +2,12 @@
+Wed Dec 7 14:26:51 UTC 2022 - David Diaz <[email protected]>
+
+- Allow reusing LVM volume groups
+- 4.5.15
+
+-------------------------------------------------------------------
+Tue Nov 29 15:07:25 UTC 2022 - Ancor Gonzalez Sosa <[email protected]>
+
+- Proposal: new setting to prevent reusing LVM volume groups
+ (related to gh#yast/d-installer#264).
+
+-------------------------------------------------------------------
Old:
----
yast2-storage-ng-4.5.14.tar.bz2
New:
----
yast2-storage-ng-4.5.15.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-storage-ng.spec ++++++
--- /var/tmp/diff_new_pack.3tnI6j/_old 2022-12-08 16:50:25.195247979 +0100
+++ /var/tmp/diff_new_pack.3tnI6j/_new 2022-12-08 16:50:25.203248019 +0100
@@ -17,7 +17,7 @@
Name: yast2-storage-ng
-Version: 4.5.14
+Version: 4.5.15
Release: 0
Summary: YaST2 - Storage Configuration
License: GPL-2.0-only OR GPL-3.0-only
++++++ yast2-storage-ng-4.5.14.tar.bz2 -> yast2-storage-ng-4.5.15.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.14/package/yast2-storage-ng.changes
new/yast2-storage-ng-4.5.15/package/yast2-storage-ng.changes
--- old/yast2-storage-ng-4.5.14/package/yast2-storage-ng.changes
2022-11-21 16:25:40.000000000 +0100
+++ new/yast2-storage-ng-4.5.15/package/yast2-storage-ng.changes
2022-12-07 15:45:15.000000000 +0100
@@ -1,4 +1,16 @@
-------------------------------------------------------------------
+Wed Dec 7 14:26:51 UTC 2022 - David Diaz <[email protected]>
+
+- Allow reusing LVM volume groups
+- 4.5.15
+
+-------------------------------------------------------------------
+Tue Nov 29 15:07:25 UTC 2022 - Ancor Gonzalez Sosa <[email protected]>
+
+- Proposal: new setting to prevent reusing LVM volume groups
+ (related to gh#yast/d-installer#264).
+
+-------------------------------------------------------------------
Mon Nov 21 11:33:52 UTC 2022 - Ancor Gonzalez Sosa <[email protected]>
- GuidedProposal: support for LUKS2 encryption with a configurable
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.14/package/yast2-storage-ng.spec
new/yast2-storage-ng-4.5.15/package/yast2-storage-ng.spec
--- old/yast2-storage-ng-4.5.14/package/yast2-storage-ng.spec 2022-11-21
16:25:40.000000000 +0100
+++ new/yast2-storage-ng-4.5.15/package/yast2-storage-ng.spec 2022-12-07
15:45:15.000000000 +0100
@@ -16,7 +16,7 @@
#
Name: yast2-storage-ng
-Version: 4.5.14
+Version: 4.5.15
Release: 0
Summary: YaST2 - Storage Configuration
License: GPL-2.0-only OR GPL-3.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.14/src/lib/y2storage/proposal/lvm_helper.rb
new/yast2-storage-ng-4.5.15/src/lib/y2storage/proposal/lvm_helper.rb
--- old/yast2-storage-ng-4.5.14/src/lib/y2storage/proposal/lvm_helper.rb
2022-11-21 16:25:40.000000000 +0100
+++ new/yast2-storage-ng-4.5.15/src/lib/y2storage/proposal/lvm_helper.rb
2022-12-07 15:45:15.000000000 +0100
@@ -169,6 +169,11 @@
#
# @return [Boolean]
def try_to_reuse?
+ # Setting introduced to completely avoid LVM reusing in D-Installer.
+ # It's a new playground, so no need to carry YaST behaviors that have
+ # proven to be confusing.
+ return false if settings.lvm_vg_reuse == false
+
# We introduced this when we still didn't have a mechanism to activate
# existing LUKS. Now such mechanism exists but this check has never
been
# removed. Nobody complained so far.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.14/src/lib/y2storage/proposal_settings.rb
new/yast2-storage-ng-4.5.15/src/lib/y2storage/proposal_settings.rb
--- old/yast2-storage-ng-4.5.14/src/lib/y2storage/proposal_settings.rb
2022-11-21 16:25:40.000000000 +0100
+++ new/yast2-storage-ng-4.5.15/src/lib/y2storage/proposal_settings.rb
2022-12-07 15:45:15.000000000 +0100
@@ -219,6 +219,11 @@
# specify the predefined size of the LVM volume group.
attr_accessor :lvm_vg_size
+ # @return [Boolean] whether a pre-existing LVM volume group should be
reused if
+ # the conditions to do so are met. That is the historical YaST behavior,
which
+ # can be inhibited by setting this to false.
+ attr_accessor :lvm_vg_reuse
+
# @return [Array<VolumeSpecification>] list of volumes specifications used
during
# the proposal
attr_accessor :volumes
@@ -398,6 +403,7 @@
linux_delete_mode: :ondemand,
lvm: false,
lvm_vg_strategy: :use_available,
+ lvm_vg_reuse: true,
encryption_method: EncryptionMethod::LUKS1,
multidisk_first: false,
other_delete_mode: :ondemand,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.14/test/data/devicegraphs/output/windows-linux-lvm-noreuse-lvm-sep-home.yml
new/yast2-storage-ng-4.5.15/test/data/devicegraphs/output/windows-linux-lvm-noreuse-lvm-sep-home.yml
---
old/yast2-storage-ng-4.5.14/test/data/devicegraphs/output/windows-linux-lvm-noreuse-lvm-sep-home.yml
1970-01-01 01:00:00.000000000 +0100
+++
new/yast2-storage-ng-4.5.15/test/data/devicegraphs/output/windows-linux-lvm-noreuse-lvm-sep-home.yml
2022-12-07 15:45:15.000000000 +0100
@@ -0,0 +1,44 @@
+---
+- disk:
+ name: "/dev/sda"
+ size: 800 GiB
+ partition_table: msdos
+ partitions:
+
+ - partition:
+ size: 730 GiB
+ name: /dev/sda1
+ id: ntfs
+ file_system: ntfs
+ label: windows
+
+ - partition:
+ size: unlimited
+ name: /dev/sda2
+ id: lvm
+
+- lvm_vg:
+ vg_name: system
+ lvm_lvs:
+
+ - lvm_lv:
+ lv_name: root
+ size: 40 GiB
+ file_system: btrfs
+ mount_point: "/"
+
+ - lvm_lv:
+ lv_name: home
+ size: 28668 MiB
+ file_system: xfs
+ mount_point: "/home"
+
+ - lvm_lv:
+ lv_name: swap
+ size: 2 GiB
+ file_system: swap
+ mount_point: swap
+
+ lvm_pvs:
+ - lvm_pv:
+ blk_device: /dev/sda2
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.14/test/data/devicegraphs/output/windows-linux-lvm-noreuse-lvm.yml
new/yast2-storage-ng-4.5.15/test/data/devicegraphs/output/windows-linux-lvm-noreuse-lvm.yml
---
old/yast2-storage-ng-4.5.14/test/data/devicegraphs/output/windows-linux-lvm-noreuse-lvm.yml
1970-01-01 01:00:00.000000000 +0100
+++
new/yast2-storage-ng-4.5.15/test/data/devicegraphs/output/windows-linux-lvm-noreuse-lvm.yml
2022-12-07 15:45:15.000000000 +0100
@@ -0,0 +1,45 @@
+---
+- disk:
+ name: "/dev/sda"
+ size: 800 GiB
+ partition_table: msdos
+ partitions:
+
+ - partition:
+ size: 730 GiB
+ name: /dev/sda1
+ id: ntfs
+ file_system: ntfs
+ label: windows
+
+ - partition:
+ size: 50 GiB
+ name: /dev/sda2
+ id: lvm
+
+ - partition:
+ size: unlimited
+ name: /dev/sda3
+ id: 0xb
+ file_system: vfat
+ label: recovery
+
+- lvm_vg:
+ vg_name: system
+ lvm_lvs:
+
+ - lvm_lv:
+ lv_name: root
+ size: 40 GiB
+ file_system: btrfs
+ mount_point: "/"
+
+ - lvm_lv:
+ lv_name: swap
+ size: 2 GiB
+ file_system: swap
+ mount_point: swap
+
+ lvm_pvs:
+ - lvm_pv:
+ blk_device: /dev/sda2
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.14/test/y2storage/proposal/lvm_helper_test.rb
new/yast2-storage-ng-4.5.15/test/y2storage/proposal/lvm_helper_test.rb
--- old/yast2-storage-ng-4.5.14/test/y2storage/proposal/lvm_helper_test.rb
2022-11-21 16:25:40.000000000 +0100
+++ new/yast2-storage-ng-4.5.15/test/y2storage/proposal/lvm_helper_test.rb
2022-12-07 15:45:15.000000000 +0100
@@ -64,6 +64,14 @@
expect(helper.reusable_volume_groups(fake_devicegraph)).to eq []
end
end
+
+ context "and ProposalSettings#lvm_vg_reuse is set to false" do
+ before { settings.lvm_vg_reuse = false }
+
+ it "returns an empty array" do
+ expect(helper.reusable_volume_groups(fake_devicegraph)).to eq []
+ end
+ end
end
context "if some volume groups are big enough" do
@@ -100,6 +108,14 @@
it "returns an empty array" do
expect(helper.reusable_volume_groups(fake_devicegraph)).to eq []
+ end
+ end
+
+ context "and ProposalSettings#lvm_vg_reuse is set to false" do
+ before { settings.lvm_vg_reuse = false }
+
+ it "returns an empty array" do
+ expect(helper.reusable_volume_groups(fake_devicegraph)).to eq []
end
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.5.14/test/y2storage/proposal_scenarios_x86_test.rb
new/yast2-storage-ng-4.5.15/test/y2storage/proposal_scenarios_x86_test.rb
--- old/yast2-storage-ng-4.5.14/test/y2storage/proposal_scenarios_x86_test.rb
2022-11-21 16:25:40.000000000 +0100
+++ new/yast2-storage-ng-4.5.15/test/y2storage/proposal_scenarios_x86_test.rb
2022-12-07 15:45:15.000000000 +0100
@@ -84,6 +84,13 @@
let(:scenario) { "windows-linux-lvm-pc" }
include_examples "LVM-based proposed layouts"
include_examples "partition-based proposed layouts"
+
+ context "if the proposal is configured to not reuse volume groups" do
+ before { settings.lvm_vg_reuse = false }
+
+ let(:expected_scenario) { "windows-linux-lvm-noreuse" }
+ include_examples "LVM-based proposed layouts"
+ end
end
context "in a windows-only PC with GPT partition table" do
