Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package rcm for openSUSE:Factory checked in 
at 2023-01-18 14:23:22
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/rcm (Old)
 and      /work/SRC/openSUSE:Factory/.rcm.new.32243 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "rcm"

Wed Jan 18 14:23:22 2023 rev:6 rq:1059330 version:1.3.6

Changes:
--------
--- /work/SRC/openSUSE:Factory/rcm/rcm.changes  2022-05-10 15:12:05.683582468 
+0200
+++ /work/SRC/openSUSE:Factory/.rcm.new.32243/rcm.changes       2023-01-18 
14:23:26.248158296 +0100
@@ -1,0 +2,7 @@
+Wed Jan 18 10:36:31 UTC 2023 - Andrei Dziahel <[email protected]>
+
+- Update to version 1.3.6
+  * Feature: rcup/rcdn hooks can bail early (Patrick Brisbin)
+  * Documentation improvement (Teo Ljungberg)
+
+-------------------------------------------------------------------

Old:
----
  rcm-1.3.5.tar.gz

New:
----
  rcm-1.3.6.tar.gz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ rcm.spec ++++++
--- /var/tmp/diff_new_pack.F9iclN/_old  2023-01-18 14:23:26.900161948 +0100
+++ /var/tmp/diff_new_pack.F9iclN/_new  2023-01-18 14:23:26.900161948 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package rcm
 #
-# Copyright (c) 2022 SUSE LLC
+# Copyright (c) 2023 SUSE LLC
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -18,7 +18,7 @@
 
 # See also http://en.opensuse.org/openSUSE:Specfile_guidelines
 Name:           rcm
-Version:        1.3.5
+Version:        1.3.6
 Release:        0
 Summary:        An rc file (dotfile) management tool
 License:        BSD-3-Clause

++++++ rcm-1.3.5.tar.gz -> rcm-1.3.6.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/Makefile.am new/rcm-1.3.6/Makefile.am
--- old/rcm-1.3.5/Makefile.am   2022-03-04 22:23:02.000000000 +0100
+++ new/rcm-1.3.6/Makefile.am   2022-12-30 17:37:57.000000000 +0100
@@ -48,9 +48,11 @@
        test/rcup-symlink-existing.t \
        test/rcup-usage.t \
        test/rcdn-hooks.t \
+       test/rcdn-hooks-failure.t \
        test/rcdn-hooks-run-in-situ.t \
        test/rcdn-hooks-run-in-order.t \
        test/rcup-hooks.t \
+       test/rcup-hooks-failure.t \
        test/rcup-hooks-run-in-situ.t \
        test/rcup-hooks-run-in-order.t \
        test/rcup-spaces.t
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/Makefile.in new/rcm-1.3.6/Makefile.in
--- old/rcm-1.3.5/Makefile.in   2022-04-22 22:01:37.000000000 +0200
+++ new/rcm-1.3.6/Makefile.in   2022-12-30 17:39:35.000000000 +0100
@@ -483,9 +483,11 @@
        test/rcup-symlink-existing.t \
        test/rcup-usage.t \
        test/rcdn-hooks.t \
+       test/rcdn-hooks-failure.t \
        test/rcdn-hooks-run-in-situ.t \
        test/rcdn-hooks-run-in-order.t \
        test/rcup-hooks.t \
+       test/rcup-hooks-failure.t \
        test/rcup-hooks-run-in-situ.t \
        test/rcup-hooks-run-in-order.t \
        test/rcup-spaces.t
@@ -1152,6 +1154,13 @@
        --log-file $$b.log --trs-file $$b.trs \
        $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) 
-- $(LOG_COMPILE) \
        "$$tst" $(AM_TESTS_FD_REDIRECT)
+test/rcdn-hooks-failure.t.log: test/rcdn-hooks-failure.t
+       @p='test/rcdn-hooks-failure.t'; \
+       b='test/rcdn-hooks-failure.t'; \
+       $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \
+       --log-file $$b.log --trs-file $$b.trs \
+       $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) 
-- $(LOG_COMPILE) \
+       "$$tst" $(AM_TESTS_FD_REDIRECT)
 test/rcdn-hooks-run-in-situ.t.log: test/rcdn-hooks-run-in-situ.t
        @p='test/rcdn-hooks-run-in-situ.t'; \
        b='test/rcdn-hooks-run-in-situ.t'; \
@@ -1172,6 +1181,13 @@
        $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \
        --log-file $$b.log --trs-file $$b.trs \
        $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) 
-- $(LOG_COMPILE) \
+       "$$tst" $(AM_TESTS_FD_REDIRECT)
+test/rcup-hooks-failure.t.log: test/rcup-hooks-failure.t
+       @p='test/rcup-hooks-failure.t'; \
+       b='test/rcup-hooks-failure.t'; \
+       $(am__check_pre) $(LOG_DRIVER) --test-name "$$f" \
+       --log-file $$b.log --trs-file $$b.trs \
+       $(am__common_driver_flags) $(AM_LOG_DRIVER_FLAGS) $(LOG_DRIVER_FLAGS) 
-- $(LOG_COMPILE) \
        "$$tst" $(AM_TESTS_FD_REDIRECT)
 test/rcup-hooks-run-in-situ.t.log: test/rcup-hooks-run-in-situ.t
        @p='test/rcup-hooks-run-in-situ.t'; \
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/NEWS.md new/rcm-1.3.6/NEWS.md
--- old/rcm-1.3.5/NEWS.md       2022-04-29 21:58:31.000000000 +0200
+++ new/rcm-1.3.6/NEWS.md       2022-12-30 17:47:32.000000000 +0100
@@ -1,3 +1,10 @@
+rcm (1.3.6) unstable; urgency=low
+
+  * Feature: rcup/rcdn hooks can bail early (Patrick Brisbin)
+  * Documentation improvement (Teo Ljungberg)
+  
+ -- Mike Burns <[email protected]>  Fri, 30 Dec 2022 11:43:00 -0500
+
 rcm (1.3.5) unstable; urgency=low
 
   * BUGFIX: *:*~ exclude paterns work again (Alexander Goldstein)
@@ -9,7 +16,7 @@
   * Package and maintenance improvements (Alexander Goldstein, Eric Collins,
       Mat M, Darcy Parker).
   
- -- Mike Burns <[email protected]>  Fri, 13 Jul 2018 14:12:00 -0500
+ -- Mike Burns <[email protected]>  Fri, 22 Apr 2022 15:59:43 -0400
 
 rcm (1.3.4) unstable; urgency=low
 
@@ -18,7 +25,7 @@
   * BUGFIX: all symlinks in mkrc input are rejected (Mat M).
   * Packaging improvements (Stephen Groat, Martin Frost, Link Dupont)
   
- -- Mike Burns <[email protected]>  Fri, 13 Jul 2018 14:12:00 -0500
+ -- Mike Burns <[email protected]>  Fri, 28 Aug 2022 16:38:25 -0400
 
 rcm (1.3.3) unstable; urgency=low
 
@@ -37,7 +44,7 @@
            Matthew Horan, maxice8, Mike Burns, Rebecca Meritz, Scott Stevenson,
            Tyson Gach, Yota Toyama).
 
- -- Mike Burns <[email protected]>  Fri, 06 Jul 2018 11:00:00 -0500
+ -- Mike Burns <[email protected]>  Fri, 06 Jul 2018 11:00:00 -0400
 
 rcm (1.3.1) unstable; urgency=low
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/NEWS.md.in new/rcm-1.3.6/NEWS.md.in
--- old/rcm-1.3.5/NEWS.md.in    2022-04-22 21:59:21.000000000 +0200
+++ new/rcm-1.3.6/NEWS.md.in    2022-12-30 17:45:19.000000000 +0100
@@ -1,5 +1,12 @@
 rcm (@PACKAGE_VERSION@) unstable; urgency=low
 
+  * Feature: rcup/rcdn hooks can bail early (Patrick Brisbin)
+  * Documentation improvement (Teo Ljungberg)
+  
+ -- Mike Burns <[email protected]>  Fri, 30 Dec 2022 11:43:00 -0500
+
+rcm (1.3.5) unstable; urgency=low
+
   * BUGFIX: *:*~ exclude paterns work again (Alexander Goldstein)
   * BUGFIX: messages for -C being a copy so can't update (Mat M).
   * BUGFIX: expect at least one existing dotfiles directory (Mat M).
@@ -9,7 +16,7 @@
   * Package and maintenance improvements (Alexander Goldstein, Eric Collins,
       Mat M, Darcy Parker).
   
- -- Mike Burns <[email protected]>  Fri, 13 Jul 2018 14:12:00 -0500
+ -- Mike Burns <[email protected]>  Fri, 22 Apr 2022 15:59:43 -0400
 
 rcm (1.3.4) unstable; urgency=low
 
@@ -18,7 +25,7 @@
   * BUGFIX: all symlinks in mkrc input are rejected (Mat M).
   * Packaging improvements (Stephen Groat, Martin Frost, Link Dupont)
   
- -- Mike Burns <[email protected]>  Fri, 13 Jul 2018 14:12:00 -0500
+ -- Mike Burns <[email protected]>  Fri, 28 Aug 2022 16:38:25 -0400
 
 rcm (1.3.3) unstable; urgency=low
 
@@ -37,7 +44,7 @@
            Matthew Horan, maxice8, Mike Burns, Rebecca Meritz, Scott Stevenson,
            Tyson Gach, Yota Toyama).
 
- -- Mike Burns <[email protected]>  Fri, 06 Jul 2018 11:00:00 -0500
+ -- Mike Burns <[email protected]>  Fri, 06 Jul 2018 11:00:00 -0400
 
 rcm (1.3.1) unstable; urgency=low
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/bin/rcdn new/rcm-1.3.6/bin/rcdn
--- old/rcm-1.3.5/bin/rcdn      2022-04-29 21:58:31.000000000 +0200
+++ new/rcm-1.3.6/bin/rcdn      2022-12-30 17:47:32.000000000 +0100
@@ -110,6 +110,11 @@
 : ${DOTFILES_DIRS:=$DOTFILES_DIRS $DEFAULT_DOTFILES_DIR}
 
 run_hooks pre down
+pre_dn_ret=$?
+
+if [ "$pre_dn_ret" -ne 0 ]; then
+  exit "$pre_dn_ret"
+fi
 
 dests_and_srcs="$(eval "lsrc $LS_ARGS")"
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/bin/rcdn.in new/rcm-1.3.6/bin/rcdn.in
--- old/rcm-1.3.5/bin/rcdn.in   2022-03-04 20:41:05.000000000 +0100
+++ new/rcm-1.3.6/bin/rcdn.in   2022-12-30 17:37:57.000000000 +0100
@@ -110,6 +110,11 @@
 : ${DOTFILES_DIRS:=$DOTFILES_DIRS $DEFAULT_DOTFILES_DIR}
 
 run_hooks pre down
+pre_dn_ret=$?
+
+if [ "$pre_dn_ret" -ne 0 ]; then
+  exit "$pre_dn_ret"
+fi
 
 dests_and_srcs="$(eval "lsrc $LS_ARGS")"
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/bin/rcup new/rcm-1.3.6/bin/rcup
--- old/rcm-1.3.5/bin/rcup      2022-04-29 21:58:31.000000000 +0200
+++ new/rcm-1.3.6/bin/rcup      2022-12-30 17:47:32.000000000 +0100
@@ -296,6 +296,11 @@
 : ${DOTFILES_DIRS:=$DOTFILES_DIRS $DEFAULT_DOTFILES_DIR}
 
 run_hooks pre up
+pre_up_ret=$?
+
+if [ "$pre_up_ret" -ne 0 ]; then
+  exit "$pre_up_ret"
+fi
 
 dests_and_srcs="$(eval "lsrc $LS_ARGS")"
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/bin/rcup.in new/rcm-1.3.6/bin/rcup.in
--- old/rcm-1.3.5/bin/rcup.in   2020-08-28 22:50:16.000000000 +0200
+++ new/rcm-1.3.6/bin/rcup.in   2022-12-30 17:37:57.000000000 +0100
@@ -296,6 +296,11 @@
 : ${DOTFILES_DIRS:=$DOTFILES_DIRS $DEFAULT_DOTFILES_DIR}
 
 run_hooks pre up
+pre_up_ret=$?
+
+if [ "$pre_up_ret" -ne 0 ]; then
+  exit "$pre_up_ret"
+fi
 
 dests_and_srcs="$(eval "lsrc $LS_ARGS")"
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/configure new/rcm-1.3.6/configure
--- old/rcm-1.3.5/configure     2022-04-22 22:01:35.000000000 +0200
+++ new/rcm-1.3.6/configure     2022-12-30 17:39:30.000000000 +0100
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for rcm 1.3.5.
+# Generated by GNU Autoconf 2.69 for rcm 1.3.6.
 #
 # Report bugs to <[email protected]>.
 #
@@ -579,8 +579,8 @@
 # Identity of this package.
 PACKAGE_NAME='rcm'
 PACKAGE_TARNAME='rcm'
-PACKAGE_VERSION='1.3.5'
-PACKAGE_STRING='rcm 1.3.5'
+PACKAGE_VERSION='1.3.6'
+PACKAGE_STRING='rcm 1.3.6'
 PACKAGE_BUGREPORT='[email protected]'
 PACKAGE_URL=''
 
@@ -1211,7 +1211,7 @@
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat <<_ACEOF
-\`configure' configures rcm 1.3.5 to adapt to many kinds of systems.
+\`configure' configures rcm 1.3.6 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1278,7 +1278,7 @@
 
 if test -n "$ac_init_help"; then
   case $ac_init_help in
-     short | recursive ) echo "Configuration of rcm 1.3.5:";;
+     short | recursive ) echo "Configuration of rcm 1.3.6:";;
    esac
   cat <<\_ACEOF
 
@@ -1352,7 +1352,7 @@
 test -n "$ac_init_help" && exit $ac_status
 if $ac_init_version; then
   cat <<\_ACEOF
-rcm configure 1.3.5
+rcm configure 1.3.6
 generated by GNU Autoconf 2.69
 
 Copyright (C) 2012 Free Software Foundation, Inc.
@@ -1369,7 +1369,7 @@
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by rcm $as_me 1.3.5, which was
+It was created by rcm $as_me 1.3.6, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   $ $0 $@
@@ -2227,7 +2227,7 @@
 
 # Define the identity of the package.
  PACKAGE='rcm'
- VERSION='1.3.5'
+ VERSION='1.3.6'
 
 
 cat >>confdefs.h <<_ACEOF
@@ -2927,7 +2927,7 @@
 # report actual input values of CONFIG_FILES etc. instead of their
 # values after options handling.
 ac_log="
-This file was extended by rcm $as_me 1.3.5, which was
+This file was extended by rcm $as_me 1.3.6, which was
 generated by GNU Autoconf 2.69.  Invocation command line was
 
   CONFIG_FILES    = $CONFIG_FILES
@@ -2980,7 +2980,7 @@
 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; 
s/[\\""\`\$]/\\\\&/g'`"
 ac_cs_version="\\
-rcm config.status 1.3.5
+rcm config.status 1.3.6
 configured by $0, generated by GNU Autoconf 2.69,
   with options \\"\$ac_cs_config\\"
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/configure.ac new/rcm-1.3.6/configure.ac
--- old/rcm-1.3.5/configure.ac  2022-04-22 21:50:05.000000000 +0200
+++ new/rcm-1.3.6/configure.ac  2022-12-30 17:39:27.000000000 +0100
@@ -1,5 +1,5 @@
 AC_PREREQ([2.69])
-AC_INIT([rcm],[1.3.5],[[email protected]])
+AC_INIT([rcm],[1.3.6],[[email protected]])
 AM_INIT_AUTOMAKE([subdir-objects])
 
 # /bin/sh on Solaris is not POSIX, so try to find another one.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/man/lsrc.1 new/rcm-1.3.6/man/lsrc.1
--- old/rcm-1.3.5/man/lsrc.1    2020-08-28 22:50:16.000000000 +0200
+++ new/rcm-1.3.6/man/lsrc.1    2022-12-30 17:36:35.000000000 +0100
@@ -179,7 +179,7 @@
 is maintained by
 .An "Mike Burns" Aq Mt [email protected]
 and
-.Lk http://thoughtbot.se thoughtbot
+.Lk http://thoughtbot.com thoughtbot
 .Sh BUGS
 For macOS systems, we strongly encourage the use of the
 .Va HOSTNAME
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/man/mkrc.1 new/rcm-1.3.6/man/mkrc.1
--- old/rcm-1.3.5/man/mkrc.1    2022-03-04 20:41:05.000000000 +0100
+++ new/rcm-1.3.6/man/mkrc.1    2022-12-30 17:36:35.000000000 +0100
@@ -102,4 +102,4 @@
 is maintained by
 .An "Mike Burns" Aq Mt [email protected]
 and
-.Lk http://thoughtbot.se thoughtbot
+.Lk http://thoughtbot.com thoughtbot
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/man/rcdn.1 new/rcm-1.3.6/man/rcdn.1
--- old/rcm-1.3.5/man/rcdn.1    2020-08-28 22:50:16.000000000 +0200
+++ new/rcm-1.3.6/man/rcdn.1    2022-12-30 17:36:35.000000000 +0100
@@ -161,4 +161,4 @@
 is maintained by
 .An "Mike Burns" Aq Mt [email protected]
 and
-.Lk http://thoughtbot.se thoughtbot
+.Lk http://thoughtbot.com thoughtbot
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/man/rcm.7 new/rcm-1.3.6/man/rcm.7
--- old/rcm-1.3.5/man/rcm.7     2022-04-22 22:01:37.000000000 +0200
+++ new/rcm-1.3.6/man/rcm.7     2022-12-30 17:39:35.000000000 +0100
@@ -299,7 +299,7 @@
 is maintained by
 .An "Mike Burns" Aq Mt [email protected]
 and
-.Lk http://thoughtbot.se thoughtbot
+.Lk http://thoughtbot.com thoughtbot
 .Sh BUGS
 For macOS systems, we strongly encourage the use of the
 .Va HOSTNAME
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/man/rcrc.5 new/rcm-1.3.6/man/rcrc.5
--- old/rcm-1.3.5/man/rcrc.5    2020-08-28 22:50:16.000000000 +0200
+++ new/rcm-1.3.6/man/rcrc.5    2022-12-30 17:36:35.000000000 +0100
@@ -95,7 +95,7 @@
 is maintained by
 .An "Mike Burns" Aq Mt [email protected]
 and
-.Lk http://thoughtbot.se thoughtbot
+.Lk http://thoughtbot.com thoughtbot
 .Sh BUGS
 We only expand tilde inside
 .Va DOTFILES_DIRS
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/man/rcup.1 new/rcm-1.3.6/man/rcup.1
--- old/rcm-1.3.5/man/rcup.1    2022-03-04 20:41:05.000000000 +0100
+++ new/rcm-1.3.6/man/rcup.1    2022-12-30 17:36:35.000000000 +0100
@@ -263,4 +263,4 @@
 is maintained by
 .An "Mike Burns" Aq Mt [email protected]
 and
-.Lk http://thoughtbot.se thoughtbot
+.Lk http://thoughtbot.com thoughtbot
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/share/rcm.sh new/rcm-1.3.6/share/rcm.sh
--- old/rcm-1.3.5/share/rcm.sh  2022-04-29 21:58:31.000000000 +0200
+++ new/rcm-1.3.6/share/rcm.sh  2022-12-30 17:47:32.000000000 +0100
@@ -1,4 +1,4 @@
-VERSION="1.3.5"
+VERSION="1.3.6"
 
 #set -x
 
@@ -143,6 +143,12 @@
         find "$hook_file" -type f \( \( -user $LOGNAME -perm -100 \) -o -perm 
-001 \) \
           | sort | while read file; do
             sh -c 'cd -- "`dirname $1`" && ./"`basename $1`"' arg0 "$file"
+            hook_ret=$?
+
+            if [ "$hook_ret" -ne 0 ]; then
+              echo "$when-$direction hook $file exited non-zero ($hook_ret)" 
>&2
+              exit $hook_ret # NB. this only exits the while-read; caller must 
still check and exit
+            fi
           done
       else
         $DEBUG "no $when-$direction hook present for $dotfiles_dir, skipping"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/share/rcm.sh.in 
new/rcm-1.3.6/share/rcm.sh.in
--- old/rcm-1.3.5/share/rcm.sh.in       2020-08-28 22:50:16.000000000 +0200
+++ new/rcm-1.3.6/share/rcm.sh.in       2022-12-30 17:37:57.000000000 +0100
@@ -143,6 +143,12 @@
         find "$hook_file" -type f \( \( -user $LOGNAME -perm -100 \) -o -perm 
-001 \) \
           | sort | while read file; do
             sh -c 'cd -- "`dirname $1`" && ./"`basename $1`"' arg0 "$file"
+            hook_ret=$?
+
+            if [ "$hook_ret" -ne 0 ]; then
+              echo "$when-$direction hook $file exited non-zero ($hook_ret)" 
>&2
+              exit $hook_ret # NB. this only exits the while-read; caller must 
still check and exit
+            fi
           done
       else
         $DEBUG "no $when-$direction hook present for $dotfiles_dir, skipping"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/test/rcdn-hooks-failure.t 
new/rcm-1.3.6/test/rcdn-hooks-failure.t
--- old/rcm-1.3.5/test/rcdn-hooks-failure.t     1970-01-01 01:00:00.000000000 
+0100
+++ new/rcm-1.3.6/test/rcdn-hooks-failure.t     2022-12-30 17:37:57.000000000 
+0100
@@ -0,0 +1,16 @@
+  $ . "$TESTDIR/helper.sh"
+
+Pre-down hooks failing should prevent rcdn continuing
+
+  $ mkdir -p .dotfiles/hooks/pre-down
+  > printf "#!/bin/sh\necho '1'\nexit 7\n" > 
.dotfiles/hooks/pre-down/00-test.sh
+  > printf "#!/bin/sh\necho '2'\n" > .dotfiles/hooks/pre-down/01-test.sh
+
+  $ chmod +x .dotfiles/hooks/pre-down/00-test.sh
+  > chmod +x .dotfiles/hooks/pre-down/01-test.sh
+
+  $ rcdn
+  1
+  pre-down hook */.dotfiles/hooks/pre-down/00-test.sh exited non-zero (7) 
(glob)
+  [7]
+
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rcm-1.3.5/test/rcup-hooks-failure.t 
new/rcm-1.3.6/test/rcup-hooks-failure.t
--- old/rcm-1.3.5/test/rcup-hooks-failure.t     1970-01-01 01:00:00.000000000 
+0100
+++ new/rcm-1.3.6/test/rcup-hooks-failure.t     2022-12-30 17:37:57.000000000 
+0100
@@ -0,0 +1,15 @@
+  $ . "$TESTDIR/helper.sh"
+
+Pre-up hooks failing should prevent rcup continuing
+
+  $ mkdir -p .dotfiles/hooks/pre-up
+  > printf "#!/bin/sh\necho '1'\nexit 7\n" > .dotfiles/hooks/pre-up/00-test.sh
+  > printf "#!/bin/sh\necho '2'\n" > .dotfiles/hooks/pre-up/01-test.sh
+
+  $ chmod +x .dotfiles/hooks/pre-up/00-test.sh
+  > chmod +x .dotfiles/hooks/pre-up/01-test.sh
+
+  $ rcup
+  1
+  pre-up hook */.dotfiles/hooks/pre-up/00-test.sh exited non-zero (7) (glob)
+  [7]

Reply via email to