Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package nodejs-electron for openSUSE:Factory
checked in at 2023-02-14 16:47:12
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/nodejs-electron (Old)
and /work/SRC/openSUSE:Factory/.nodejs-electron.new.27156 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "nodejs-electron"
Tue Feb 14 16:47:12 2023 rev:55 rq:1065565 version:22.2.1
Changes:
--------
--- /work/SRC/openSUSE:Factory/nodejs-electron/nodejs-electron.changes
2023-02-10 14:34:35.421658811 +0100
+++
/work/SRC/openSUSE:Factory/.nodejs-electron.new.27156/nodejs-electron.changes
2023-02-14 16:47:48.807289721 +0100
@@ -1,0 +2,5 @@
+Mon Feb 13 13:19:38 UTC 2023 - Bruno Pitrus <[email protected]>
+- Add RenderFrameHostImpl-use-after-free.patch to fix a crash reported by an
user.
+- Fix unnecessary libz dependency added for downstream node modules on Fedora.
+
+-------------------------------------------------------------------
New:
----
RenderFrameHostImpl-use-after-free.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ nodejs-electron.spec ++++++
--- /var/tmp/diff_new_pack.mvtwOk/_old 2023-02-14 16:47:53.911319857 +0100
+++ /var/tmp/diff_new_pack.mvtwOk/_new 2023-02-14 16:47:53.935320000 +0100
@@ -307,6 +307,7 @@
Source2033: node-upgrade-llhttp-to-8.patch
%endif
Patch2034: swiftshader-LLVMJIT-AddressSanitizerPass-dead-code-remove.patch
+Patch2035: RenderFrameHostImpl-use-after-free.patch
# PATCHES that should be submitted upstream verbatim or near-verbatim
Patch3016: chromium-98-EnumTable-crash.patch
++++++ RenderFrameHostImpl-use-after-free.patch ++++++
--- src/content/browser/renderer_host/render_frame_host_impl.cc.orig
2023-02-08 21:38:09.974003318 +0100
+++ src/content/browser/renderer_host/render_frame_host_impl.cc 2023-02-13
14:13:50.217792624 +0100
@@ -5,6 +5,7 @@
#include "content/browser/renderer_host/render_frame_host_impl.h"
#include <memory>
+#include <new>
#include <tuple>
#include <unordered_map>
#include <utility>
@@ -1876,7 +1877,12 @@
// completes. Among other things, this ensures that any `SafeRef`s from
// `DocumentService` and `RenderFrameHostUserData` subclasses are still valid
// when their destructors run.
- document_associated_data_.reset();
+ // HACK: Using .reset() here works on MSVC and LLVM libc++ because the
std::optional
+ // is still valid while the destructor runs. This does not work on GNU
libstdc++
+ // however which invalidates the optional before calling the destructor,
causing a crash.
+ // Upstream bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=1415154
+ document_associated_data_->~DocumentAssociatedData();
+ new(&document_associated_data_)
absl::optional<DocumentAssociatedData>(absl::nullopt);
// Ensure that the render process host has been notified that all audio
// streams from this frame have terminated. This is required to ensure the
++++++ electron-16-system-node-headers.patch ++++++
--- /var/tmp/diff_new_pack.mvtwOk/_old 2023-02-14 16:47:54.443322999 +0100
+++ /var/tmp/diff_new_pack.mvtwOk/_new 2023-02-14 16:47:54.471323165 +0100
@@ -8,7 +8,7 @@
}],
+ [ 'OS in "linux"', {
+ 'cflags': [ '-I/usr/include/electron' ],
-+ 'ldflags': [ '-lz' ],
++ 'ldflags': [ '-Wl,--as-needed', '-lz' ],
+ }],
[ 'OS in "linux freebsd openbsd solaris aix"', {
'cflags': [ '-pthread' ],
