Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-storage-ng for
openSUSE:Factory checked in at 2023-04-12 12:51:12
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-storage-ng (Old)
and /work/SRC/openSUSE:Factory/.yast2-storage-ng.new.19717 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-storage-ng"
Wed Apr 12 12:51:12 2023 rev:141 rq:1078465 version:4.6.5
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-storage-ng/yast2-storage-ng.changes
2023-04-04 21:17:05.243915392 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-storage-ng.new.19717/yast2-storage-ng.changes
2023-04-12 12:51:14.716807471 +0200
@@ -1,0 +2,7 @@
+Tue Apr 11 13:38:25 UTC 2023 - Ancor Gonzalez Sosa <[email protected]>
+
+- Adjusted detection of Dell BOSS devices (bsc#1200975).
+- Partitioner: improved column Type for disks (bsc#1200975).
+- 4.6.5
+
+-------------------------------------------------------------------
Old:
----
yast2-storage-ng-4.6.4.tar.bz2
New:
----
yast2-storage-ng-4.6.5.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-storage-ng.spec ++++++
--- /var/tmp/diff_new_pack.uRXQXj/_old 2023-04-12 12:51:15.212810370 +0200
+++ /var/tmp/diff_new_pack.uRXQXj/_new 2023-04-12 12:51:15.216810393 +0200
@@ -17,7 +17,7 @@
Name: yast2-storage-ng
-Version: 4.6.4
+Version: 4.6.5
Release: 0
Summary: YaST2 - Storage Configuration
License: GPL-2.0-only OR GPL-3.0-only
++++++ yast2-storage-ng-4.6.4.tar.bz2 -> yast2-storage-ng-4.6.5.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.6.4/package/yast2-storage-ng.changes
new/yast2-storage-ng-4.6.5/package/yast2-storage-ng.changes
--- old/yast2-storage-ng-4.6.4/package/yast2-storage-ng.changes 2023-04-03
11:29:17.000000000 +0200
+++ new/yast2-storage-ng-4.6.5/package/yast2-storage-ng.changes 2023-04-11
16:24:45.000000000 +0200
@@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Tue Apr 11 13:38:25 UTC 2023 - Ancor Gonzalez Sosa <[email protected]>
+
+- Adjusted detection of Dell BOSS devices (bsc#1200975).
+- Partitioner: improved column Type for disks (bsc#1200975).
+- 4.6.5
+
+-------------------------------------------------------------------
Mon Apr 3 09:01:17 UTC 2023 - Ancor Gonzalez Sosa <[email protected]>
- AutoYaST: export thin LVM volumes when cloning (bsc#1209725)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-storage-ng-4.6.4/package/yast2-storage-ng.spec
new/yast2-storage-ng-4.6.5/package/yast2-storage-ng.spec
--- old/yast2-storage-ng-4.6.4/package/yast2-storage-ng.spec 2023-04-03
11:29:17.000000000 +0200
+++ new/yast2-storage-ng-4.6.5/package/yast2-storage-ng.spec 2023-04-11
16:24:45.000000000 +0200
@@ -16,7 +16,7 @@
#
Name: yast2-storage-ng
-Version: 4.6.4
+Version: 4.6.5
Release: 0
Summary: YaST2 - Storage Configuration
License: GPL-2.0-only OR GPL-3.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.6.4/src/lib/y2partitioner/widgets/columns/type.rb
new/yast2-storage-ng-4.6.5/src/lib/y2partitioner/widgets/columns/type.rb
--- old/yast2-storage-ng-4.6.4/src/lib/y2partitioner/widgets/columns/type.rb
2023-04-03 11:29:17.000000000 +0200
+++ new/yast2-storage-ng-4.6.5/src/lib/y2partitioner/widgets/columns/type.rb
2023-04-11 16:24:45.000000000 +0200
@@ -292,9 +292,11 @@
#
# @return [String]
def default_unformatted_label(device)
- data = [device.vendor, device.model].compact
+ # The "model" field from hwinfo is a combination of vendor + device
with quite some added
+ # heuristics to make the result nice looking. See comment#66 at
bsc#1200975.
+ model = device.model || ""
- return data.join("-") unless data.empty?
+ return model unless model.empty?
return device.id.to_human_string if device.respond_to?(:id)
default_label(device)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.6.4/src/lib/y2storage/blk_device.rb
new/yast2-storage-ng-4.6.5/src/lib/y2storage/blk_device.rb
--- old/yast2-storage-ng-4.6.4/src/lib/y2storage/blk_device.rb 2023-04-03
11:29:17.000000000 +0200
+++ new/yast2-storage-ng-4.6.5/src/lib/y2storage/blk_device.rb 2023-04-11
16:24:45.000000000 +0200
@@ -665,16 +665,20 @@
# @return [Array<String>] empty if the driver is unknown
# @see #boss?
- BOSS_REGEXP = Regexp.new("dell.*boss", Regexp::IGNORECASE).freeze
+ DELL_REGEXP = Regexp.new("dell", Regexp::IGNORECASE).freeze
+ BOSS_REGEXP = Regexp.new("BOSS").freeze
+ private_constant :DELL_REGEXP
private_constant :BOSS_REGEXP
# Whether this device is a Dell BOSS (Boot Optimized Storage Solution)
#
- # See https://jira.suse.com/browse/SLE-17578
+ # See https://jira.suse.com/browse/SLE-17578 and bsc#1200975
#
# @return [Boolean]
def boss?
- !!model&.match?(BOSS_REGEXP)
+ return false unless model
+
+ model.match?(BOSS_REGEXP) && model.match?(DELL_REGEXP)
end
# Size of the space that could be theoretically reclaimed by shrinking the
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-storage-ng-4.6.4/test/y2storage/blk_device_test.rb
new/yast2-storage-ng-4.6.5/test/y2storage/blk_device_test.rb
--- old/yast2-storage-ng-4.6.4/test/y2storage/blk_device_test.rb
2023-04-03 11:29:17.000000000 +0200
+++ new/yast2-storage-ng-4.6.5/test/y2storage/blk_device_test.rb
2023-04-11 16:24:45.000000000 +0200
@@ -1186,6 +1186,71 @@
end
end
+ describe "#boss?" do
+ let(:device_name) { "/dev/sda" }
+
+ before { allow(device).to receive(:model).and_return model }
+
+ context "when no model information is available" do
+ let(:model) { nil }
+
+ it "returns false" do
+ expect(device.boss?).to eq false
+ end
+ end
+
+ context "when the model information is empty" do
+ let(:model) { "" }
+
+ it "returns false" do
+ expect(device.boss?).to eq false
+ end
+ end
+
+ # Original criteria provided by Dell at jsc#SLE-17578
+ context "when the model contains DELLBOSS" do
+ let(:model) { "A DELLBOSS device" }
+
+ it "returns true" do
+ expect(device.boss?).to eq true
+ end
+ end
+
+ # Used in some models like the one reported as bsc#1200975
+ context "when the model contains 'Dell BOSS'" do
+ let(:model) { "Dell BOSS-N1 Modular" }
+
+ it "returns true" do
+ expect(device.boss?).to eq true
+ end
+ end
+
+ # Hypothetical string based on the criteria exposed at comment#84 of
bsc#1200975
+ context "when the model contains first 'BOSS' and then 'Dell'" do
+ let(:model) { "Cool BOSS device by Dell" }
+
+ it "returns true" do
+ expect(device.boss?).to eq true
+ end
+ end
+
+ context "when the model contains 'Dell' but not 'BOSS'" do
+ let(:model) { "Dell controller" }
+
+ it "returns false" do
+ expect(device.boss?).to eq false
+ end
+ end
+
+ context "when the model contains 'BOSS' but not 'Dell'" do
+ let(:model) { "BOSS as Back Office Support System" }
+
+ it "returns false" do
+ expect(device.boss?).to eq false
+ end
+ end
+ end
+
describe ".sorted_by_name" do
let(:scenario) { "sorting/disks_and_dasds1" }
