Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2-network for openSUSE:Factory checked in at 2023-05-09 13:08:00 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-network (Old) and /work/SRC/openSUSE:Factory/.yast2-network.new.1533 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-network" Tue May 9 13:08:00 2023 rev:498 rq:1085502 version:4.6.2 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-network/yast2-network.changes 2023-05-06 22:08:36.952524403 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-network.new.1533/yast2-network.changes 2023-05-09 13:08:08.373307286 +0200 @@ -1,0 +2,7 @@ +Mon May 8 09:07:07 UTC 2023 - Knut Anderssen <[email protected]> + +- Fix summary crash when there is no interface available + (bsc#1209589, bsc#1211161). +- 4.6.2 + +------------------------------------------------------------------- Old: ---- yast2-network-4.6.1.tar.bz2 New: ---- yast2-network-4.6.2.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-network.spec ++++++ --- /var/tmp/diff_new_pack.esltiV/_old 2023-05-09 13:08:09.061311380 +0200 +++ /var/tmp/diff_new_pack.esltiV/_new 2023-05-09 13:08:09.065311404 +0200 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 4.6.1 +Version: 4.6.2 Release: 0 Summary: YaST2 - Network Configuration License: GPL-2.0-only ++++++ yast2-network-4.6.1.tar.bz2 -> yast2-network-4.6.2.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.6.1/package/yast2-network.changes new/yast2-network-4.6.2/package/yast2-network.changes --- old/yast2-network-4.6.1/package/yast2-network.changes 2023-05-05 10:30:35.000000000 +0200 +++ new/yast2-network-4.6.2/package/yast2-network.changes 2023-05-08 13:17:03.000000000 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Mon May 8 09:07:07 UTC 2023 - Knut Anderssen <[email protected]> + +- Fix summary crash when there is no interface available + (bsc#1209589, bsc#1211161). +- 4.6.2 + +------------------------------------------------------------------- Thu May 4 11:21:13 UTC 2023 - Knut Anderssen <[email protected]> - Display information about firmware configured interfaces and diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.6.1/package/yast2-network.spec new/yast2-network-4.6.2/package/yast2-network.spec --- old/yast2-network-4.6.1/package/yast2-network.spec 2023-05-05 10:30:35.000000000 +0200 +++ new/yast2-network-4.6.2/package/yast2-network.spec 2023-05-08 13:17:03.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 4.6.1 +Version: 4.6.2 Release: 0 Summary: YaST2 - Network Configuration License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.6.1/src/lib/y2network/presenters/interface_summary.rb new/yast2-network-4.6.2/src/lib/y2network/presenters/interface_summary.rb --- old/yast2-network-4.6.1/src/lib/y2network/presenters/interface_summary.rb 2023-05-05 10:30:35.000000000 +0200 +++ new/yast2-network-4.6.2/src/lib/y2network/presenters/interface_summary.rb 2023-05-08 13:17:03.000000000 +0200 @@ -45,6 +45,8 @@ end def text + return "" if @name.to_s.empty? + interface = @config.interfaces.by_name(@name) hardware = interface ? interface.hardware : nil descr = hardware ? hardware.description : "" @@ -104,14 +106,14 @@ rich << Yast::HTML.Bold(dev_name) << "<br>" end - unless interface.firmware_configured? + if interface && !interface.firmware_configured? rich << "<p>" rich << _("The device is not configured. Press <b>Edit</b>\nto configure.\n") rich << "</p>" end end - if interface.firmware_configured? + if interface&.firmware_configured? rich << "<p><b>" << _("The device is configured by: ") << "</b>" rich << interface.firmware_configured_by.to_s << "</p>" end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.6.1/src/lib/y2network/widgets/interfaces_table.rb new/yast2-network-4.6.2/src/lib/y2network/widgets/interfaces_table.rb --- old/yast2-network-4.6.1/src/lib/y2network/widgets/interfaces_table.rb 2023-05-05 10:30:35.000000000 +0200 +++ new/yast2-network-4.6.2/src/lib/y2network/widgets/interfaces_table.rb 2023-05-08 13:17:03.000000000 +0200 @@ -165,6 +165,8 @@ def create_description summary = Presenters.const_get("#{summary_class_name}Summary") + return "" if value.to_s.empty? + summary.new(value, config).text end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-4.6.1/test/y2network/presenters/interface_summary_test.rb new/yast2-network-4.6.2/test/y2network/presenters/interface_summary_test.rb --- old/yast2-network-4.6.1/test/y2network/presenters/interface_summary_test.rb 2023-05-05 10:30:35.000000000 +0200 +++ new/yast2-network-4.6.2/test/y2network/presenters/interface_summary_test.rb 2023-05-08 13:17:03.000000000 +0200 @@ -76,8 +76,15 @@ describe "#text" do it "returns a summary in text form" do - text = presenter.text - expect(text).to be_a(String) + expect(presenter.text).to be_a(String) + end + + context "when an empty name is given" do + let(:name) { "" } + + it "returns an empty text" do + expect(presenter.text).to eql("") + end end context "when a remote IP address is configured" do
