Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package nodejs-electron for openSUSE:Factory
checked in at 2023-10-12 23:44:39
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/nodejs-electron (Old)
and /work/SRC/openSUSE:Factory/.nodejs-electron.new.1807 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "nodejs-electron"
Thu Oct 12 23:44:39 2023 rev:82 rq:1117503 version:25.9.1
Changes:
--------
--- /work/SRC/openSUSE:Factory/nodejs-electron/nodejs-electron.changes
2023-10-06 21:16:24.084099740 +0200
+++
/work/SRC/openSUSE:Factory/.nodejs-electron.new.1807/nodejs-electron.changes
2023-10-12 23:48:03.365815792 +0200
@@ -1,0 +2,13 @@
+Thu Oct 12 17:04:40 UTC 2023 - Bruno Pitrus <[email protected]>
+
+- New upstream release 25.9.1
+ * Fixed an issue where calling loadURL during some webContents url loading
events could crash.
+ * Fixed deprecated gpu-process-crashed / renderer-process-crashed events
being emitted twice and with incorrect arguments.
+- Desktop integration cleanup:
+ * edit .desktop file to not show Electron in start menu as it is useless
when run by itself
+ * drop electron-logo-symbolic.svg and instead use upstream supplied icon
+ * do not install icon twice (icon.patch)
+ * do not create /{etc,usr/share}/webapps directories which do not belong here
+ * do not recommend noto-coloremoji-fonts, if an app needs it it should pull
it by itself.
+
+-------------------------------------------------------------------
Old:
----
electron-25.9.0.tar.zst
electron-logo-symbolic.svg
New:
----
electron-25.9.1.tar.zst
icon.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ nodejs-electron.spec ++++++
--- /var/tmp/diff_new_pack.idJKIA/_old 2023-10-12 23:48:06.661935138 +0200
+++ /var/tmp/diff_new_pack.idJKIA/_new 2023-10-12 23:48:06.665935283 +0200
@@ -197,7 +197,7 @@
Name: nodejs-electron
-Version: 25.9.0
+Version: 25.9.1
Release: 0
Summary: Build cross platform desktop apps with JavaScript, HTML, and
CSS
License: AFL-2.0 AND Apache-2.0 AND blessing AND BSD-2-Clause AND
BSD-3-Clause AND BSD-Protection AND BSD-Source-Code AND bzip2-1.0.6 AND IJG AND
ISC AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND MIT AND MIT-CMU AND
MIT-open-group AND (MPL-1.1 OR GPL-2.0-or-later OR LGPL-2.1-or-later) AND
MPL-2.0 AND OpenSSL AND SGI-B-2.0 AND SUSE-Public-Domain AND X11
@@ -207,7 +207,6 @@
Source1: create_tarball.sh
Source10: electron-launcher.sh
Source11: electron.desktop
-Source12: electron-logo-symbolic.svg
# Shim generators for unbundling libraries
Source50: flatbuffers.gn
Source51: libsecret.gn
@@ -258,6 +257,7 @@
Patch77: angle_link_glx.patch
Patch78: rdynamic.patch
Patch79: v8-hide-private-symbols.patch
+Patch80: icon.patch
# PATCHES to use system libs
Patch1000: do-not-build-libvulkan.so.patch
@@ -383,6 +383,7 @@
%endif
BuildRequires: hicolor-icon-theme
BuildRequires: hwdata
+BuildRequires: ImageMagick
%if 0%{?fedora}
BuildRequires: libatomic
%endif
@@ -614,7 +615,6 @@
Requires: hicolor-icon-theme
Requires: google-roboto-fonts
-Recommends: noto-coloremoji-fonts
# This required library is dlopened
%if %{without link_vulkan}
@@ -730,6 +730,16 @@
%build
+pushd electron/shell/browser/resources/win
+[ $(identify electron.ico | wc -l) = 4 ] #Sanity check
+convert electron.ico -strip extracted.png
+identify extracted-0.png | grep -F 16x16
+identify extracted-1.png | grep -F 32x32
+identify extracted-2.png | grep -F 48x48
+identify extracted-3.png | grep -F 256x256
+popd
+
+
# GN sets lto on its own and we need just ldflag options, not cflags
%define _lto_cflags %{nil}
@@ -1310,8 +1320,13 @@
install -pm 0755 %{SOURCE10} %{buildroot}%{_bindir}/%{mod_name}
sed -i 's[XXXLIBDIRXXX[%{_libdir}[g' %{buildroot}%{_bindir}/%{mod_name}
-install -pm 0644 electron/default_app/icon.png
%{buildroot}%{_datadir}/pixmaps/%{mod_name}.png
-install -pm 0644 %{SOURCE12}
%{buildroot}%{_datadir}/icons/hicolor/symbolic/apps/electron-symbolic.svg
+install -pvDm644 electron/default_app/icon.png
%{buildroot}%{_datadir}/icons/hicolor/1024x1024/%{mod_name}.png
+
+install -pvDm644 electron/shell/browser/resources/win/extracted-0.png
%{buildroot}%{_datadir}/icons/hicolor/16x16/apps/%{mod_name}.png
+install -pvDm644 electron/shell/browser/resources/win/extracted-1.png
%{buildroot}%{_datadir}/icons/hicolor/32x32/apps/%{mod_name}.png
+install -pvDm644 electron/shell/browser/resources/win/extracted-2.png
%{buildroot}%{_datadir}/icons/hicolor/48x48/apps/%{mod_name}.png
+install -pvDm644 electron/shell/browser/resources/win/extracted-3.png
%{buildroot}%{_datadir}/icons/hicolor/256x256/apps/%{mod_name}.png
+
desktop-file-install --dir %{buildroot}%{_datadir}/applications/ %{SOURCE11}
@@ -1359,16 +1374,15 @@
%files
%license electron/LICENSE out/Release/LICENSES.chromium.html
%{_bindir}/electron
-%{_datadir}/pixmaps/electron.png
-%{_datadir}/icons/hicolor/symbolic/apps/electron-symbolic.svg
%{_datadir}/applications/electron.desktop
-
+%{_datadir}/icons/hicolor/16x16/apps/electron.png
+%{_datadir}/icons/hicolor/32x32/apps/electron.png
+%{_datadir}/icons/hicolor/48x48/apps/electron.png
+%{_datadir}/icons/hicolor/256x256/apps/electron.png
+%{_datadir}/icons/hicolor/1024x1024
%{_libdir}/electron/
-%dir %{_sysconfdir}/webapps
-%dir %{_datadir}/webapps
-
%files devel
%{_includedir}/electron
%{_rpmconfigdir}/macros.d/macros.electron
++++++ electron.desktop ++++++
--- /var/tmp/diff_new_pack.idJKIA/_old 2023-10-12 23:48:06.881943104 +0200
+++ /var/tmp/diff_new_pack.idJKIA/_new 2023-10-12 23:48:06.885943249 +0200
@@ -4,5 +4,6 @@
Icon=electron
Exec=electron %u
Categories=Development;GTK;
+NoDisplay=true
StartupNotify=true
++++++ icon.patch ++++++
--- a/electron/default_app/default_app.ts
+++ b/electron/default_app/default_app.ts
@@ -60,7 +60,7 @@
};
if (process.platform === 'linux') {
- options.icon = path.join(__dirname, 'icon.png');
+ options.icon = '/usr/share/icons/hicolor/1024x1024/apps/electron.png';
}
mainWindow = new BrowserWindow(options);
--- a/electron/filenames.gni
+++ b/electron/filenames.gni
@@ -6,7 +6,6 @@
]
default_app_static_sources = [
- "default_app/icon.png",
"default_app/index.html",
"default_app/package.json",
"default_app/styles.css",
