Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package python-jupyter-server-terminals for
openSUSE:Factory checked in at 2024-03-07 18:31:27
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/python-jupyter-server-terminals (Old)
and /work/SRC/openSUSE:Factory/.python-jupyter-server-terminals.new.1770
(New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "python-jupyter-server-terminals"
Thu Mar 7 18:31:27 2024 rev:6 rq:1155951 version:0.5.2
Changes:
--------
---
/work/SRC/openSUSE:Factory/python-jupyter-server-terminals/python-jupyter-server-terminals.changes
2024-01-21 23:10:44.182710946 +0100
+++
/work/SRC/openSUSE:Factory/.python-jupyter-server-terminals.new.1770/python-jupyter-server-terminals.changes
2024-03-07 18:32:39.868205113 +0100
@@ -1,0 +2,9 @@
+Thu Mar 7 13:47:16 UTC 2024 - Ben Greiner <[email protected]>
+
+- Update to 0.5.2
+ * Fix usage of await #106 (@blink1073)
+ * Set terminals_available to False when not enabled #105
+ (@Wh1isper)
+- Skip testing on python39
+
+-------------------------------------------------------------------
Old:
----
jupyter_server_terminals-0.5.1.tar.gz
New:
----
jupyter_server_terminals-0.5.2.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ python-jupyter-server-terminals.spec ++++++
--- /var/tmp/diff_new_pack.koMSja/_old 2024-03-07 18:32:40.536229763 +0100
+++ /var/tmp/diff_new_pack.koMSja/_new 2024-03-07 18:32:40.536229763 +0100
@@ -1,5 +1,5 @@
#
-# spec file
+# spec file for package python-jupyter-server-terminals
#
# Copyright (c) 2024 SUSE LLC
#
@@ -20,14 +20,15 @@
%if "%{flavor}" == "test"
%define psuffix -test
%bcond_without test
+%define skip_python39 1
%else
%define psuffix %{nil}
%bcond_with test
%endif
-%define distversion 0.5.1
+%define distversion 0.5.2
Name: python-jupyter-server-terminals%{psuffix}
-Version: 0.5.1
+Version: 0.5.2
Release: 0
Summary: A Jupyter Server Extension Providing Terminals
License: BSD-3-Clause
++++++ jupyter_server_terminals-0.5.1.tar.gz ->
jupyter_server_terminals-0.5.2.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/jupyter_server_terminals-0.5.1/.github/dependabot.yml
new/jupyter_server_terminals-0.5.2/.github/dependabot.yml
--- old/jupyter_server_terminals-0.5.1/.github/dependabot.yml 2020-02-02
01:00:00.000000000 +0100
+++ new/jupyter_server_terminals-0.5.2/.github/dependabot.yml 2020-02-02
01:00:00.000000000 +0100
@@ -4,7 +4,15 @@
directory: "/"
schedule:
interval: "weekly"
+ groups:
+ actions:
+ patterns:
+ - "*"
- package-ecosystem: "pip"
directory: "/"
schedule:
interval: "weekly"
+ groups:
+ actions:
+ patterns:
+ - "*"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/jupyter_server_terminals-0.5.1/.pre-commit-config.yaml
new/jupyter_server_terminals-0.5.2/.pre-commit-config.yaml
--- old/jupyter_server_terminals-0.5.1/.pre-commit-config.yaml 2020-02-02
01:00:00.000000000 +0100
+++ new/jupyter_server_terminals-0.5.2/.pre-commit-config.yaml 2020-02-02
01:00:00.000000000 +0100
@@ -31,7 +31,7 @@
- id: mdformat
- repo: https://github.com/pre-commit/mirrors-prettier
- rev: "v3.1.0"
+ rev: "v4.0.0-alpha.8"
hooks:
- id: prettier
types_or: [yaml, html, json]
@@ -56,7 +56,7 @@
- id: rst-inline-touching-normal
- repo: https://github.com/pre-commit/mirrors-mypy
- rev: "v1.7.1"
+ rev: "v1.8.0"
hooks:
- id: mypy
files: "^jupyter_server_terminals"
@@ -66,7 +66,7 @@
["traitlets>=5.13", "jupyter_server>=2.10.1", "terminado>=0.18"]
- repo: https://github.com/astral-sh/ruff-pre-commit
- rev: v0.1.7
+ rev: v0.1.9
hooks:
- id: ruff
types_or: [python, jupyter]
@@ -75,7 +75,7 @@
types_or: [python, jupyter]
- repo: https://github.com/scientific-python/cookie
- rev: "2023.11.17"
+ rev: "2023.12.21"
hooks:
- id: sp-repo-review
additional_dependencies: ["repo-review[cli]"]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/jupyter_server_terminals-0.5.1/CHANGELOG.md
new/jupyter_server_terminals-0.5.2/CHANGELOG.md
--- old/jupyter_server_terminals-0.5.1/CHANGELOG.md 2020-02-02
01:00:00.000000000 +0100
+++ new/jupyter_server_terminals-0.5.2/CHANGELOG.md 2020-02-02
01:00:00.000000000 +0100
@@ -4,6 +4,27 @@
<!-- <START NEW CHANGELOG ENTRY> -->
+## 0.5.2
+
+([Full
Changelog](https://github.com/jupyter-server/jupyter_server_terminals/compare/v0.5.1...1d47163a9c02f75ff24943faa6a69bf8639b3517))
+
+### Bugs fixed
+
+- Fix usage of await
[#106](https://github.com/jupyter-server/jupyter_server_terminals/pull/106)
([@blink1073](https://github.com/blink1073))
+- Set terminals_available to False when not enabled
[#105](https://github.com/jupyter-server/jupyter_server_terminals/pull/105)
([@Wh1isper](https://github.com/Wh1isper))
+
+### Maintenance and upkeep improvements
+
+- chore: update pre-commit hooks
[#104](https://github.com/jupyter-server/jupyter_server_terminals/pull/104)
([@pre-commit-ci](https://github.com/pre-commit-ci))
+
+### Contributors to this release
+
+([GitHub contributors page for this
release](https://github.com/jupyter-server/jupyter_server_terminals/graphs/contributors?from=2023-12-26&to=2024-01-22&type=c))
+
+[@blink1073](https://github.com/search?q=repo%3Ajupyter-server%2Fjupyter_server_terminals+involves%3Ablink1073+updated%3A2023-12-26..2024-01-22&type=Issues)
|
[@pre-commit-ci](https://github.com/search?q=repo%3Ajupyter-server%2Fjupyter_server_terminals+involves%3Apre-commit-ci+updated%3A2023-12-26..2024-01-22&type=Issues)
|
[@Wh1isper](https://github.com/search?q=repo%3Ajupyter-server%2Fjupyter_server_terminals+involves%3AWh1isper+updated%3A2023-12-26..2024-01-22&type=Issues)
+
+<!-- <END NEW CHANGELOG ENTRY> -->
+
## 0.5.1
([Full
Changelog](https://github.com/jupyter-server/jupyter_server_terminals/compare/v0.5.0...58ad66a5ce0bca03f6c569b32a8bef9c1bdccd2b))
@@ -18,8 +39,6 @@
[@welcome](https://github.com/search?q=repo%3Ajupyter-server%2Fjupyter_server_terminals+involves%3Awelcome+updated%3A2023-12-11..2023-12-26&type=Issues)
|
[@zhanba](https://github.com/search?q=repo%3Ajupyter-server%2Fjupyter_server_terminals+involves%3Azhanba+updated%3A2023-12-11..2023-12-26&type=Issues)
-<!-- <END NEW CHANGELOG ENTRY> -->
-
## 0.5.0
([Full
Changelog](https://github.com/jupyter-server/jupyter_server_terminals/compare/v0.4.4...00eb4ee20b8d5838e44de7a756823e4cf02949fa))
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/jupyter_server_terminals-0.5.1/PKG-INFO
new/jupyter_server_terminals-0.5.2/PKG-INFO
--- old/jupyter_server_terminals-0.5.1/PKG-INFO 2020-02-02 01:00:00.000000000
+0100
+++ new/jupyter_server_terminals-0.5.2/PKG-INFO 2020-02-02 01:00:00.000000000
+0100
@@ -1,6 +1,6 @@
Metadata-Version: 2.1
Name: jupyter_server_terminals
-Version: 0.5.1
+Version: 0.5.2
Summary: A Jupyter Server Extension Providing Terminals.
Project-URL: Homepage, https://jupyter.org
Author-email: Jupyter Development Team <[email protected]>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/jupyter_server_terminals-0.5.1/jupyter_server_terminals/_version.py
new/jupyter_server_terminals-0.5.2/jupyter_server_terminals/_version.py
--- old/jupyter_server_terminals-0.5.1/jupyter_server_terminals/_version.py
2020-02-02 01:00:00.000000000 +0100
+++ new/jupyter_server_terminals-0.5.2/jupyter_server_terminals/_version.py
2020-02-02 01:00:00.000000000 +0100
@@ -1,2 +1,2 @@
"""Version info for jupyter_server_terminals."""
-__version__ = "0.5.1"
+__version__ = "0.5.2"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/jupyter_server_terminals-0.5.1/jupyter_server_terminals/app.py
new/jupyter_server_terminals-0.5.2/jupyter_server_terminals/app.py
--- old/jupyter_server_terminals-0.5.1/jupyter_server_terminals/app.py
2020-02-02 01:00:00.000000000 +0100
+++ new/jupyter_server_terminals-0.5.2/jupyter_server_terminals/app.py
2020-02-02 01:00:00.000000000 +0100
@@ -37,6 +37,7 @@
def initialize_settings(self) -> None:
"""Initialize settings."""
if not self.serverapp or not self.serverapp.terminals_enabled:
+ self.settings.update({"terminals_available": False})
return
self.initialize_configurables()
self.settings.update(
@@ -73,8 +74,15 @@
def initialize_handlers(self) -> None:
"""Initialize handlers."""
- if not self.serverapp or not self.serverapp.terminals_enabled:
- # Checking self.terminals_available instead breaks enabling
terminals
+ if not self.serverapp:
+ # Already set `terminals_available` as `False` in
`initialize_settings`
+ return
+
+ if not self.serverapp.terminals_enabled:
+ # webapp settings for backwards compat (used by nbclassic), #12
+ self.serverapp.web_app.settings["terminals_available"] =
self.settings[
+ "terminals_available"
+ ]
return
self.handlers.append(
(
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/jupyter_server_terminals-0.5.1/jupyter_server_terminals/handlers.py
new/jupyter_server_terminals-0.5.2/jupyter_server_terminals/handlers.py
--- old/jupyter_server_terminals-0.5.1/jupyter_server_terminals/handlers.py
2020-02-02 01:00:00.000000000 +0100
+++ new/jupyter_server_terminals-0.5.2/jupyter_server_terminals/handlers.py
2020-02-02 01:00:00.000000000 +0100
@@ -5,6 +5,7 @@
import typing as t
+from jupyter_core.utils import ensure_async
from jupyter_server._tz import utcnow
from jupyter_server.auth.utils import warn_disabled_authorization
from jupyter_server.base.handlers import JupyterHandler
@@ -54,11 +55,11 @@
raise web.HTTPError(404)
resp = super().get(*args, **kwargs)
if resp is not None:
- await resp
+ await ensure_async(resp) # type:ignore[arg-type]
async def on_message(self, message: t.Any) -> None: #
type:ignore[override]
"""Handle a socket message."""
- await super().on_message(message)
+ await ensure_async(super().on_message(message)) #
type:ignore[arg-type]
self._update_activity()
def write_message(self, message: t.Any, binary: bool = False) -> None: #
type:ignore[override]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/jupyter_server_terminals-0.5.1/tests/test_disable_app.py
new/jupyter_server_terminals-0.5.2/tests/test_disable_app.py
--- old/jupyter_server_terminals-0.5.1/tests/test_disable_app.py
1970-01-01 01:00:00.000000000 +0100
+++ new/jupyter_server_terminals-0.5.2/tests/test_disable_app.py
2020-02-02 01:00:00.000000000 +0100
@@ -0,0 +1,13 @@
+import pytest
+from traitlets.config.loader import Config
+
+
[email protected]()
+def jp_server_config():
+ return Config({"ServerApp": {"terminals_enabled": False}})
+
+
+async def test_not_enabled(jp_configurable_serverapp):
+ assert jp_configurable_serverapp().terminals_enabled is False
+ assert jp_configurable_serverapp().web_app.settings["terminals_available"]
is False
+ assert "terminal_manager" not in
jp_configurable_serverapp().web_app.settings
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/jupyter_server_terminals-0.5.1/tests/test_terminal.py
new/jupyter_server_terminals-0.5.2/tests/test_terminal.py
--- old/jupyter_server_terminals-0.5.1/tests/test_terminal.py 2020-02-02
01:00:00.000000000 +0100
+++ new/jupyter_server_terminals-0.5.2/tests/test_terminal.py 2020-02-02
01:00:00.000000000 +0100
@@ -236,6 +236,12 @@
assert non_existing_path not in message_stdout
+async def test_app_config(jp_configurable_serverapp):
+ assert jp_configurable_serverapp().terminals_enabled is True
+ assert jp_configurable_serverapp().web_app.settings["terminals_available"]
is True
+ assert jp_configurable_serverapp().web_app.settings["terminal_manager"]
+
+
async def test_culling_config(jp_configurable_serverapp):
terminal_mgr_config =
jp_configurable_serverapp().config.ServerApp.TerminalManager
assert terminal_mgr_config.cull_inactive_timeout == CULL_TIMEOUT
