Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package aws-c-auth for openSUSE:Factory checked in at 2024-04-07 22:10:31 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/aws-c-auth (Old) and /work/SRC/openSUSE:Factory/.aws-c-auth.new.1905 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "aws-c-auth" Sun Apr 7 22:10:31 2024 rev:3 rq:1165450 version:0.7.17 Changes: -------- --- /work/SRC/openSUSE:Factory/aws-c-auth/aws-c-auth.changes 2024-02-21 17:59:16.329499257 +0100 +++ /work/SRC/openSUSE:Factory/.aws-c-auth.new.1905/aws-c-auth.changes 2024-04-07 22:12:46.249466880 +0200 @@ -1,0 +2,7 @@ +Thu Apr 4 15:38:20 UTC 2024 - John Paul Adrian Glaubitz <[email protected]> + +- Update to version 0.7.17 + * Additional logging for default credentials chain by @jamesbornholt in (#231) + * Remove unused test files by @jmklix in (#232) + +------------------------------------------------------------------- Old: ---- v0.7.16.tar.gz New: ---- v0.7.17.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ aws-c-auth.spec ++++++ --- /var/tmp/diff_new_pack.pm1qFC/_old 2024-04-07 22:12:47.413509508 +0200 +++ /var/tmp/diff_new_pack.pm1qFC/_new 2024-04-07 22:12:47.417509656 +0200 @@ -20,7 +20,7 @@ %define library_pkg 1_0_0 %define library_soversion 1 Name: aws-c-auth -Version: 0.7.16 +Version: 0.7.17 Release: 0 Summary: AWS C99 library implementation of AWS client-side authentication License: Apache-2.0 ++++++ v0.7.16.tar.gz -> v0.7.17.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-auth-0.7.16/source/credentials_provider_default_chain.c new/aws-c-auth-0.7.17/source/credentials_provider_default_chain.c --- old/aws-c-auth-0.7.16/source/credentials_provider_default_chain.c 2024-02-13 20:09:52.000000000 +0100 +++ new/aws-c-auth-0.7.17/source/credentials_provider_default_chain.c 2024-03-26 17:14:24.000000000 +0100 @@ -69,6 +69,10 @@ * to try and use the ecs provider anywhere outside the default chain. */ if (ecs_relative_uri && ecs_relative_uri->len) { + AWS_LOGF_INFO( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "default chain: ECS credentials provider with relative URI %s will be used to retrieve credentials", + aws_string_c_str(ecs_relative_uri)); struct aws_credentials_provider_ecs_options ecs_options = { .shutdown_options = *shutdown_options, .bootstrap = bootstrap, @@ -83,9 +87,19 @@ struct aws_uri uri; struct aws_byte_cursor uri_cstr = aws_byte_cursor_from_string(ecs_full_uri); if (AWS_OP_ERR == aws_uri_init_parse(&uri, allocator, &uri_cstr)) { + AWS_LOGF_ERROR( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "default chain: failed to parse URI %s during default credentials provider chain initialization: %s", + aws_string_c_str(ecs_full_uri), + aws_error_str(aws_last_error())); goto clean_up; } + AWS_LOGF_INFO( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "default chain: ECS credentials provider with full URI %s will be used to retrieve credentials", + aws_string_c_str(ecs_full_uri)); + struct aws_byte_cursor path_and_query = uri.path_and_query; if (path_and_query.len == 0) { path_and_query = aws_byte_cursor_from_c_str("/"); @@ -104,6 +118,9 @@ ecs_or_imds_provider = aws_credentials_provider_new_ecs(allocator, &ecs_options); aws_uri_clean_up(&uri); } else if (ec2_imds_disable == NULL || aws_string_eq_c_str_ignore_case(ec2_imds_disable, "false")) { + AWS_LOGF_INFO( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "default chain: IMDS credentials provider will be used to retrieve credentials"); struct aws_credentials_provider_imds_options imds_options = { .shutdown_options = *shutdown_options, .bootstrap = bootstrap, @@ -112,6 +129,11 @@ } clean_up: + if (ecs_or_imds_provider == NULL) { + AWS_LOGF_INFO( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "default chain: neither ECS nor IMDS will be used to retrieve credentials"); + } aws_string_destroy(ecs_relative_uri); aws_string_destroy(ecs_full_uri); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-auth-0.7.16/source/credentials_provider_ecs.c new/aws-c-auth-0.7.17/source/credentials_provider_ecs.c --- old/aws-c-auth-0.7.16/source/credentials_provider_ecs.c 2024-02-13 20:09:52.000000000 +0100 +++ new/aws-c-auth-0.7.17/source/credentials_provider_ecs.c 2024-03-26 17:14:24.000000000 +0100 @@ -431,6 +431,9 @@ aws_on_get_credentials_callback_fn callback, void *user_data) { + AWS_LOGF_DEBUG( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, "id=%p: ECS provider trying to load credentials", (void *)provider); + struct aws_credentials_provider_ecs_impl *impl = provider->impl; struct aws_credentials_provider_ecs_user_data *wrapped_user_data = diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-auth-0.7.16/source/credentials_provider_environment.c new/aws-c-auth-0.7.17/source/credentials_provider_environment.c --- old/aws-c-auth-0.7.16/source/credentials_provider_environment.c 2024-02-13 20:09:52.000000000 +0100 +++ new/aws-c-auth-0.7.17/source/credentials_provider_environment.c 2024-03-26 17:14:24.000000000 +0100 @@ -40,6 +40,17 @@ error_code = AWS_AUTH_CREDENTIALS_PROVIDER_INVALID_ENVIRONMENT; } + if (error_code == AWS_ERROR_SUCCESS) { + AWS_LOGF_INFO( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, "id=%p: Loaded credentials from environment variables", (void *)provider); + } else { + AWS_LOGF_INFO( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "id=%p: Failed to load credentials from environment variables: %s", + (void *)provider, + aws_error_str(error_code)); + } + callback(credentials, error_code, user_data); aws_credentials_release(credentials); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-auth-0.7.16/source/credentials_provider_imds.c new/aws-c-auth-0.7.17/source/credentials_provider_imds.c --- old/aws-c-auth-0.7.16/source/credentials_provider_imds.c 2024-02-13 20:09:52.000000000 +0100 +++ new/aws-c-auth-0.7.17/source/credentials_provider_imds.c 2024-03-26 17:14:24.000000000 +0100 @@ -155,6 +155,18 @@ static void s_on_get_credentials(const struct aws_credentials *credentials, int error_code, void *user_data) { (void)error_code; struct imds_provider_user_data *wrapped_user_data = user_data; + if (error_code == AWS_OP_SUCCESS) { + AWS_LOGF_INFO( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "id=%p: IMDS provider successfully retrieved credentials", + (void *)wrapped_user_data->imds_provider); + } else { + AWS_LOGF_INFO( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "id=%p: IMDS provider failed to retrieve credentials: %s", + (void *)wrapped_user_data->imds_provider, + aws_error_str(error_code)); + } wrapped_user_data->original_callback( (struct aws_credentials *)credentials, error_code, wrapped_user_data->original_user_data); s_imds_provider_user_data_destroy(wrapped_user_data); @@ -180,6 +192,11 @@ return; on_error: + AWS_LOGF_INFO( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "id=%p: IMDS provider failed to retrieve role: %s", + (void *)wrapped_user_data->imds_provider, + aws_error_str(error_code)); wrapped_user_data->original_callback( NULL, AWS_AUTH_CREDENTIALS_PROVIDER_IMDS_SOURCE_FAILURE, wrapped_user_data->original_user_data); s_imds_provider_user_data_destroy(wrapped_user_data); @@ -190,6 +207,9 @@ aws_on_get_credentials_callback_fn callback, void *user_data) { + AWS_LOGF_DEBUG( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, "id=%p: IMDS provider trying to load credentials", (void *)provider); + struct aws_credentials_provider_imds_impl *impl = provider->impl; struct imds_provider_user_data *wrapped_user_data = s_imds_provider_user_data_new(provider, callback, user_data); @@ -204,6 +224,11 @@ return AWS_OP_SUCCESS; error: + AWS_LOGF_ERROR( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "id=%p: IMDS provider failed to request credentials: %s", + (void *)provider, + aws_error_str(aws_last_error())); s_imds_provider_user_data_destroy(wrapped_user_data); return AWS_OP_ERR; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-auth-0.7.16/source/credentials_provider_profile.c new/aws-c-auth-0.7.17/source/credentials_provider_profile.c --- old/aws-c-auth-0.7.16/source/credentials_provider_profile.c 2024-02-13 20:09:52.000000000 +0100 +++ new/aws-c-auth-0.7.17/source/credentials_provider_profile.c 2024-03-26 17:14:24.000000000 +0100 @@ -137,6 +137,15 @@ } } + if (error_code == AWS_ERROR_SUCCESS) { + AWS_LOGF_INFO(AWS_LS_AUTH_CREDENTIALS_PROVIDER, "Loaded credentials from profile provider"); + } else { + AWS_LOGF_INFO( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "Failed to load credentials from profile provider: %s", + aws_error_str(error_code)); + } + callback(credentials, error_code, user_data); /* @@ -175,10 +184,14 @@ struct aws_string *config_file_path, const struct aws_string *profile_name, struct aws_profile_collection *profile_collection_cached) { - struct aws_credentials_provider *provider = NULL; struct aws_credentials_provider_profile_file_impl *impl = NULL; + AWS_LOGF_INFO( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "static: profile %s attempting to create profile-based credentials provider", + aws_string_c_str(profile_name)); + aws_mem_acquire_many( allocator, 2, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-auth-0.7.16/source/credentials_provider_sts_web_identity.c new/aws-c-auth-0.7.17/source/credentials_provider_sts_web_identity.c --- old/aws-c-auth-0.7.16/source/credentials_provider_sts_web_identity.c 2024-02-13 20:09:52.000000000 +0100 +++ new/aws-c-auth-0.7.17/source/credentials_provider_sts_web_identity.c 2024-03-26 17:14:24.000000000 +0100 @@ -748,6 +748,11 @@ struct aws_credentials_provider_sts_web_identity_impl *impl = provider->impl; + AWS_LOGF_DEBUG( + AWS_LS_AUTH_CREDENTIALS_PROVIDER, + "id=%p: STS_WEB_IDENTITY provider trying to load credentials", + (void *)provider); + struct sts_web_identity_user_data *wrapped_user_data = s_user_data_new(provider, callback, user_data); if (wrapped_user_data == NULL) { goto error; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-auth-0.7.16/tests/aws-signing-test-suite/v4/get-vanilla-query-order-key/context.json new/aws-c-auth-0.7.17/tests/aws-signing-test-suite/v4/get-vanilla-query-order-key/context.json --- old/aws-c-auth-0.7.16/tests/aws-signing-test-suite/v4/get-vanilla-query-order-key/context.json 2024-02-13 20:09:52.000000000 +0100 +++ new/aws-c-auth-0.7.17/tests/aws-signing-test-suite/v4/get-vanilla-query-order-key/context.json 1970-01-01 01:00:00.000000000 +0100 @@ -1,12 +0,0 @@ -{ - "credentials": { - "access_key_id": "AKIDEXAMPLE", - "secret_access_key": "wJalrXUtnFEMI/K7MDENG+bPxRfiCYEXAMPLEKEY" - }, - "expiration_in_seconds": 3600, - "normalize": true, - "region": "us-east-1", - "service": "service", - "sign_body": false, - "timestamp": "2015-08-30T12:36:00Z" -} \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-auth-0.7.16/tests/aws-signing-test-suite/v4/get-vanilla-query-order-key/request.txt new/aws-c-auth-0.7.17/tests/aws-signing-test-suite/v4/get-vanilla-query-order-key/request.txt --- old/aws-c-auth-0.7.16/tests/aws-signing-test-suite/v4/get-vanilla-query-order-key/request.txt 2024-02-13 20:09:52.000000000 +0100 +++ new/aws-c-auth-0.7.17/tests/aws-signing-test-suite/v4/get-vanilla-query-order-key/request.txt 1970-01-01 01:00:00.000000000 +0100 @@ -1,2 +0,0 @@ -GET /?Param1=value2&Param1=Value1 HTTP/1.1 -Host:example.amazonaws.com diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-auth-0.7.16/tests/aws-signing-test-suite/v4/get-vanilla-query-order-value/context.json new/aws-c-auth-0.7.17/tests/aws-signing-test-suite/v4/get-vanilla-query-order-value/context.json --- old/aws-c-auth-0.7.16/tests/aws-signing-test-suite/v4/get-vanilla-query-order-value/context.json 2024-02-13 20:09:52.000000000 +0100 +++ new/aws-c-auth-0.7.17/tests/aws-signing-test-suite/v4/get-vanilla-query-order-value/context.json 1970-01-01 01:00:00.000000000 +0100 @@ -1,12 +0,0 @@ -{ - "credentials": { - "access_key_id": "AKIDEXAMPLE", - "secret_access_key": "wJalrXUtnFEMI/K7MDENG+bPxRfiCYEXAMPLEKEY" - }, - "expiration_in_seconds": 3600, - "normalize": true, - "region": "us-east-1", - "service": "service", - "sign_body": false, - "timestamp": "2015-08-30T12:36:00Z" -} \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-auth-0.7.16/tests/aws-signing-test-suite/v4/get-vanilla-query-order-value/request.txt new/aws-c-auth-0.7.17/tests/aws-signing-test-suite/v4/get-vanilla-query-order-value/request.txt --- old/aws-c-auth-0.7.16/tests/aws-signing-test-suite/v4/get-vanilla-query-order-value/request.txt 2024-02-13 20:09:52.000000000 +0100 +++ new/aws-c-auth-0.7.17/tests/aws-signing-test-suite/v4/get-vanilla-query-order-value/request.txt 1970-01-01 01:00:00.000000000 +0100 @@ -1,2 +0,0 @@ -GET /?Param1=value2&Param1=value1 HTTP/1.1 -Host:example.amazonaws.com
