Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package clazy for openSUSE:Factory checked in at 2024-05-22 21:29:56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/clazy (Old) and /work/SRC/openSUSE:Factory/.clazy.new.1880 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "clazy" Wed May 22 21:29:56 2024 rev:25 rq:1175582 version:1.11git.20240520T014559~87b83e3 Changes: -------- --- /work/SRC/openSUSE:Factory/clazy/clazy.changes 2024-03-11 15:43:05.754669585 +0100 +++ /work/SRC/openSUSE:Factory/.clazy.new.1880/clazy.changes 2024-05-22 21:30:16.885164426 +0200 @@ -1,0 +2,11 @@ +Tue May 21 13:15:49 UTC 2024 - [email protected] + +- Update to version 1.11git.20240520T014559~87b83e3: + * no-module-include: Fix test with Qt6, ignore internal include + of QtQmlBuiltinsDepends file + * lambda-in-connect test: remove unused and confusing member + variable + * Fix false positive from lambda-in-connect when the receiver + is on the stack + +------------------------------------------------------------------- Old: ---- clazy-1.11git.20240311T110110~ebf99de.obscpio New: ---- clazy-1.11git.20240520T014559~87b83e3.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ clazy.spec ++++++ --- /var/tmp/diff_new_pack.1goxUq/_old 2024-05-22 21:30:18.689230325 +0200 +++ /var/tmp/diff_new_pack.1goxUq/_new 2024-05-22 21:30:18.689230325 +0200 @@ -1,7 +1,7 @@ # # spec file for package clazy # -# Copyright (c) 2021 SUSE LLC +# Copyright (c) 2024 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,19 +17,19 @@ Name: clazy -Version: 1.11git.20240311T110110~ebf99de +Version: 1.11git.20240520T014559~87b83e3 Release: 0 Summary: Qt oriented code checker based on the Clang framework License: LGPL-2.0-or-later Group: Development/Tools/Other URL: https://www.kdab.com/clazy-video/ -Source0: https://download.kde.org/stable/%{name}/%{version}/src/%{name}-%{version}.tar.xz +Source0: %{name}-%{version}.tar.xz BuildRequires: clang BuildRequires: clang-devel >= 11.0 BuildRequires: cmake >= 3.7 %if 0%{?suse_version} == 1500 -BuildRequires: gcc13-c++ BuildRequires: gcc13-PIE +BuildRequires: gcc13-c++ %endif BuildRequires: libstdc++-devel %requires_eq clang%{_llvm_sonum} ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.1goxUq/_old 2024-05-22 21:30:18.761232956 +0200 +++ /var/tmp/diff_new_pack.1goxUq/_new 2024-05-22 21:30:18.765233102 +0200 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">https://invent.kde.org/sdk/clazy.git</param> - <param name="changesrevision">ebf99de982239da1aa1ce425ef2b233162a32bb8</param></service></servicedata> + <param name="changesrevision">87b83e35f21715ae81ff0f18cb1859efb6d58ea2</param></service></servicedata> (No newline at EOF) ++++++ clazy-1.11git.20240311T110110~ebf99de.obscpio -> clazy-1.11git.20240520T014559~87b83e3.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/clazy-1.11git.20240311T110110~ebf99de/dev-scripts/docker/AppImage/clazy.AppDir/clazy.desktop new/clazy-1.11git.20240520T014559~87b83e3/dev-scripts/docker/AppImage/clazy.AppDir/clazy.desktop --- old/clazy-1.11git.20240311T110110~ebf99de/dev-scripts/docker/AppImage/clazy.AppDir/clazy.desktop 2024-03-11 12:01:10.000000000 +0100 +++ new/clazy-1.11git.20240520T014559~87b83e3/dev-scripts/docker/AppImage/clazy.AppDir/clazy.desktop 2024-05-20 03:45:59.000000000 +0200 @@ -14,6 +14,7 @@ Name[fi]=Clazy Name[fr]=Clazy Name[gl]=Clazy +Name[he]=Clazy Name[hi]=à¤à¥à¤²à¥à¤à¤¼à¥ Name[hu]=Clazy Name[it]=Clazy diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/clazy-1.11git.20240311T110110~ebf99de/org.kde.clazy.metainfo.xml new/clazy-1.11git.20240520T014559~87b83e3/org.kde.clazy.metainfo.xml --- old/clazy-1.11git.20240311T110110~ebf99de/org.kde.clazy.metainfo.xml 2024-03-11 12:01:10.000000000 +0100 +++ new/clazy-1.11git.20240520T014559~87b83e3/org.kde.clazy.metainfo.xml 2024-05-20 03:45:59.000000000 +0200 @@ -73,7 +73,7 @@ <summary xml:lang="sk">Plugin prekladaÄ Clang, ktorý generuje upozornenia súvisiace s najlepÅ¡Ãmi praktikami Qt</summary> <summary xml:lang="sl">VtiÄnik za prevajalnik Clang, ki oddaja opozorila, povezana z najboljÅ¡imi praksami Qt</summary> <summary xml:lang="sv">Ett insticksprogram för Clang-kompilatorn som producerar varningar relaterade till bästa praxis för Qt</summary> - <summary xml:lang="tr">Qt için Kod Düzenleyici</summary> + <summary xml:lang="tr">Qt için Kod Düzenleyicisi</summary> <summary xml:lang="uk">ÐодаÑок до компÑлÑÑоÑа Clang, Ñкий попеÑÐµÐ´Ð¶Ð°Ñ Ð¿Ñо поÑÑÑÐµÐ½Ð½Ñ Ð¿Ñавил пÑавилÑного пÑогÑамÑÐ²Ð°Ð½Ð½Ñ Ð· викоÑиÑÑаннÑм Qt</summary> <summary xml:lang="vi">Má»t phần cà i cắm trình biên dá»ch Clang, ÄÆ°a ra các cảnh báo liên quan Äến các thá»±c hà nh Qt tá»t nhất</summary> <summary xml:lang="x-test">xxA Clang compiler plugin which emits warnings related to Qt best practicesxx</summary> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/clazy-1.11git.20240311T110110~ebf99de/src/checkbase.h new/clazy-1.11git.20240520T014559~87b83e3/src/checkbase.h --- old/clazy-1.11git.20240311T110110~ebf99de/src/checkbase.h 2024-03-11 12:01:10.000000000 +0100 +++ new/clazy-1.11git.20240520T014559~87b83e3/src/checkbase.h 2024-05-20 03:45:59.000000000 +0200 @@ -134,7 +134,9 @@ void emitWarning(clang::SourceLocation loc, std::string error, const std::vector<clang::FixItHint> &fixits, bool printWarningTag = true); void emitInternalError(clang::SourceLocation loc, std::string error); - virtual void registerASTMatchers(clang::ast_matchers::MatchFinder &){}; + virtual void registerASTMatchers(clang::ast_matchers::MatchFinder &) + { + } bool canIgnoreIncludes() const { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/clazy-1.11git.20240311T110110~ebf99de/src/checks/level0/lambda-in-connect.cpp new/clazy-1.11git.20240520T014559~87b83e3/src/checks/level0/lambda-in-connect.cpp --- old/clazy-1.11git.20240311T110110~ebf99de/src/checks/level0/lambda-in-connect.cpp 2024-03-11 12:01:10.000000000 +0100 +++ new/clazy-1.11git.20240520T014559~87b83e3/src/checks/level0/lambda-in-connect.cpp 2024-05-20 03:45:59.000000000 +0200 @@ -55,6 +55,12 @@ } ValueDecl *receiverDecl = clazy::signalReceiverForConnect(callExpr); + if (receiverDecl) { + const Type *t = receiverDecl->getType().getTypePtrOrNull(); + if (t && !t->isPointerType()) { + return; + } + } for (auto capture : captures) { if (capture.getCaptureKind() == clang::LCK_ByRef) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/clazy-1.11git.20240311T110110~ebf99de/src/checks/level0/no-module-include.cpp new/clazy-1.11git.20240520T014559~87b83e3/src/checks/level0/no-module-include.cpp --- old/clazy-1.11git.20240311T110110~ebf99de/src/checks/level0/no-module-include.cpp 2024-03-11 12:01:10.000000000 +0100 +++ new/clazy-1.11git.20240520T014559~87b83e3/src/checks/level0/no-module-include.cpp 2024-05-20 03:45:59.000000000 +0200 @@ -38,6 +38,7 @@ "Sql", "PrintSupport", "NetworkAuth", + "QmlBuiltins", "QmlIntegration", } { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/clazy-1.11git.20240311T110110~ebf99de/tests/lambda-in-connect/main.cpp new/clazy-1.11git.20240520T014559~87b83e3/tests/lambda-in-connect/main.cpp --- old/clazy-1.11git.20240311T110110~ebf99de/tests/lambda-in-connect/main.cpp 2024-03-11 12:01:10.000000000 +0100 +++ new/clazy-1.11git.20240520T014559~87b83e3/tests/lambda-in-connect/main.cpp 2024-05-20 03:45:59.000000000 +0200 @@ -37,14 +37,14 @@ QObject::connect(o, &QObject::destroyed, [&m]() { m; }); // Warn QObject o2; - QObject::connect(&o2, &QObject::destroyed, [&m]() { m; }); // OK, o is on the stack + QObject::connect(&o2, &QObject::destroyed, [&m]() { m; }); // OK, o2 is on the stack QObject *o3; QObject::connect(o3, &QObject::destroyed, o3, [&o3] { o3; }); // OK, the captured variable is on the 3rd parameter too. It will get destroyed - } - int m; + QObject::connect(o3, &QObject::destroyed, &o2, [&m]() { m; }); // OK, o2 is on the stack + } }; @@ -53,9 +53,12 @@ // Checks that we shouldn't warn when the captured variable matches the 3rd argument QObject context; + QObject *obj; int m = 0; - QObject::connect(sender, &QObject::destroyed, &context, [&] { + QObject::connect(sender, &QObject::destroyed, obj, [&] { qDebug() << m; // Warn + }); + QObject::connect(sender, &QObject::destroyed, &context, [&] { qDebug() << context.objectName(); // OK }); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/clazy-1.11git.20240311T110110~ebf99de/tests/lambda-in-connect/main.cpp.expected new/clazy-1.11git.20240520T014559~87b83e3/tests/lambda-in-connect/main.cpp.expected --- old/clazy-1.11git.20240311T110110~ebf99de/tests/lambda-in-connect/main.cpp.expected 2024-03-11 12:01:10.000000000 +0100 +++ new/clazy-1.11git.20240520T014559~87b83e3/tests/lambda-in-connect/main.cpp.expected 2024-05-20 03:45:59.000000000 +0200 @@ -4,4 +4,4 @@ lambda-in-connect/main.cpp:17:57: warning: captured local variable by reference might go out of scope before lambda is called [-Wclazy-lambda-in-connect] lambda-in-connect/main.cpp:22:48: warning: captured local variable by reference might go out of scope before lambda is called [-Wclazy-lambda-in-connect] lambda-in-connect/main.cpp:37:52: warning: captured local variable by reference might go out of scope before lambda is called [-Wclazy-lambda-in-connect] -lambda-in-connect/main.cpp:58:21: warning: captured local variable by reference might go out of scope before lambda is called [-Wclazy-lambda-in-connect] +lambda-in-connect/main.cpp:59:21: warning: captured local variable by reference might go out of scope before lambda is called [-Wclazy-lambda-in-connect] ++++++ clazy.obsinfo ++++++ --- /var/tmp/diff_new_pack.1goxUq/_old 2024-05-22 21:30:19.129246398 +0200 +++ /var/tmp/diff_new_pack.1goxUq/_new 2024-05-22 21:30:19.133246545 +0200 @@ -1,5 +1,5 @@ name: clazy -version: 1.11git.20240311T110110~ebf99de -mtime: 1710154870 -commit: ebf99de982239da1aa1ce425ef2b233162a32bb8 +version: 1.11git.20240520T014559~87b83e3 +mtime: 1716169559 +commit: 87b83e35f21715ae81ff0f18cb1859efb6d58ea2
