This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".
The branch, master has been updated
via 21584f8eef13b77c2eb39167ad4fec292727922f (commit)
from ef77ea4de575bd1c15bae8c5bad2234602fdd127 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=21584f8eef13b77c2eb39167ad4fec292727922f
commit 21584f8eef13b77c2eb39167ad4fec292727922f
Author: Giuseppe Scrivano <[email protected]>
Date: Mon Dec 28 00:45:49 2009 +0100
Fix buffer overflows in the telnet client
diff --git a/ChangeLog b/ChangeLog
index bcb67d6..9216a04 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-12-28 Giuseppe Scrivano <[email protected]>
+ Reported by: Zhitong Wangzt <[email protected]>
+
+ * bootstrap.conf (gnulib_modules): Add `xvasprintf'.
+ * telnet/commands.c (cmdrc): Alloc `rcname' dinamically.
+ (m1save): Remove.
+ (rcbuf): Remove.
+
2009-12-19 Alfred M. Szmidt <[email protected]>
* configure.ac: Bump version number to 1.7.90.
diff --git a/bootstrap.conf b/bootstrap.conf
index ba67bc6..43e7a0c 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -78,6 +78,7 @@ xgetcwd
xgetdomainname
xgethostname
xsize
+xvasprintf
"
# Read local configuration file
diff --git a/lib/.gitignore b/lib/.gitignore
index c76a7a5..c47b0b9 100644
--- a/lib/.gitignore
+++ b/lib/.gitignore
@@ -18,6 +18,7 @@ argp-version-etc.h
argp-xinl.c
argp.h
asnprintf.c
+asprintf.c
at-func.c
basename-lgpl.c
basename.c
@@ -225,6 +226,7 @@ unlinkat.c
unlocked-io.h
vasnprintf.c
vasnprintf.h
+vasprintf.c
verify.h
version-etc-fsf.c
version-etc.c
@@ -238,6 +240,7 @@ wctype.h
wctype.in.h
xalloc-die.c
xalloc.h
+xasprintf.c
xgetcwd.c
xgetcwd.h
xgetdomainname.c
@@ -248,3 +251,5 @@ xmalloc.c
xsize.h
xstrndup.c
xstrndup.h
+xvasprintf.c
+xvasprintf.h
diff --git a/telnet/commands.c b/telnet/commands.c
index aeb684a..320be85 100644
--- a/telnet/commands.c
+++ b/telnet/commands.c
@@ -97,6 +97,9 @@
#include "defines.h"
#include "types.h"
+#include "xalloc.h"
+#include "xvasprintf.h"
+
#if !defined(CRAY) && !defined(sysV88)
# ifdef HAVE_NETINET_IN_SYSTM_H
# include <netinet/in_systm.h>
@@ -3008,7 +3011,6 @@ help (int argc, char *argv[])
}
static char *rcname = 0;
-static char rcbuf[128];
static void
cmdrc (char *m1, char *m2)
@@ -3018,23 +3020,17 @@ cmdrc (char *m1, char *m2)
int gotmachine = 0;
int l1 = strlen (m1);
int l2 = strlen (m2);
- char m1save[64];
if (skiprc)
return;
- strcpy (m1save, m1);
- m1 = m1save;
-
if (rcname == 0)
{
- rcname = getenv ("HOME");
- if (rcname)
- strcpy (rcbuf, rcname);
+ const char *home = getenv ("HOME");
+ if (home)
+ rcname = xasprintf ("%s/.telnetrc", home);
else
- rcbuf[0] = '\0';
- strcat (rcbuf, "/.telnetrc");
- rcname = rcbuf;
+ rcname = xstrdup ("/.telnetrc");
}
if ((rcfile = fopen (rcname, "r")) == 0)
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 8 ++++++++
bootstrap.conf | 1 +
lib/.gitignore | 5 +++++
telnet/commands.c | 18 +++++++-----------
4 files changed, 21 insertions(+), 11 deletions(-)
hooks/post-receive
--
GNU Inetutils
_______________________________________________
Commit-inetutils mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/commit-inetutils
