Hello community, here is the log from the commit of package bup for openSUSE:Factory checked in at 2020-11-19 12:00:37 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/bup (Old) and /work/SRC/openSUSE:Factory/.bup.new.5913 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "bup" Thu Nov 19 12:00:37 2020 rev:2 rq:849287 version:0.31 Changes: -------- --- /work/SRC/openSUSE:Factory/bup/bup.changes 2020-10-23 15:12:47.138089026 +0200 +++ /work/SRC/openSUSE:Factory/.bup.new.5913/bup.changes 2020-11-23 10:23:58.808921890 +0100 @@ -1,0 +2,5 @@ +Tue Nov 17 16:26:21 UTC 2020 - Dominique Leuenberger <[email protected]> + +- Add bup-i586.patch: Fix build on 32bit archs. + +------------------------------------------------------------------- New: ---- bup-i586.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ bup.spec ++++++ --- /var/tmp/diff_new_pack.CiBV5z/_old 2020-11-23 10:23:59.412922573 +0100 +++ /var/tmp/diff_new_pack.CiBV5z/_new 2020-11-23 10:23:59.416922577 +0100 @@ -28,6 +28,7 @@ URL: https://bup.github.io/ Source0: https://github.com/bup/bup/archive/%{version}/%{name}-%{version}.tar.gz Patch1: %{name}-python.patch +Patch2: bup-i586.patch BuildRequires: git-core >= 1.5.3.1 BuildRequires: pandoc BuildRequires: perl-Time-HiRes @@ -53,8 +54,7 @@ (among and within files, including virtual machine images). %prep -%setup -q -%patch1 -p1 +%autosetup -p1 # rpmlint: fix incorrect-fsf-address find . -type f | xargs sed -i -e 's:59 Temple Place\, Suite 330\, Boston\, MA 02111-1307 USA:51 Franklin Street\, Fifth Floor\, Boston\, MA 02110-1301 USA:g' # fix binpath @@ -70,7 +70,7 @@ # FIXME: you should use the %%configure macro # With macro %%configure package will not build. ./configure -%make_build PYTHON=python +%make_build PYTHON=python3 %install %if 0%{!?make_install:1} ++++++ bup-i586.patch ++++++ From 12e34701f83624dd1c7962411901d41b3c0cca57 Mon Sep 17 00:00:00 2001 From: Johannes Berg <[email protected]> Date: Tue, 17 Nov 2020 19:55:50 +0100 Subject: [PATCH] _helpers: fix sign-compare warning Fix two sign-compare warnings when this code is compiled on (32-bit) platforms where ssize_t is 32 bits. Signed-off-by: Johannes Berg <[email protected]> --- lib/bup/_helpers.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/bup/_helpers.c b/lib/bup/_helpers.c index e60dc5957c22..5a82e8cb6ad7 100644 --- a/lib/bup/_helpers.c +++ b/lib/bup/_helpers.c @@ -1068,7 +1068,13 @@ static PyObject *write_idx(PyObject *self, PyObject *args) part = PyList_GET_ITEM(idx, i); PyList_Sort(part); plen = PyList_GET_SIZE(part); - if (plen > UINT32_MAX || UINT32_MAX - count < plen) { + /* + * Limit to INT32_MAX so that on 32-bit platforms we don't get sign + * comparison issues (and it's an unrealistic limit anyway); then + * the cast to uint32_t is fine as it cannot lose/mess up anything + * (considering also that plen as a list length cannot be negative.) + */ + if (plen > INT32_MAX || UINT32_MAX - count < (uint32_t)plen) { PyErr_Format(PyExc_OverflowError, "too many objects in index part"); goto clean_and_return; } -- 2.26.2 _______________________________________________ openSUSE Commits mailing list -- [email protected] To unsubscribe, email [email protected] List Netiquette: https://en.opensuse.org/openSUSE:Mailing_list_netiquette List Archives: https://lists.opensuse.org/archives/list/[email protected]
