Hello community,
here is the log from the commit of package yast2-ruby-bindings for
openSUSE:Factory checked in at 2020-11-23 15:36:08
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-ruby-bindings (Old)
and /work/SRC/openSUSE:Factory/.yast2-ruby-bindings.new.5913 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-ruby-bindings"
Mon Nov 23 15:36:08 2020 rev:106 rq:849365 version:4.3.11
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-ruby-bindings/yast2-ruby-bindings.changes
2020-11-13 18:57:26.786004469 +0100
+++
/work/SRC/openSUSE:Factory/.yast2-ruby-bindings.new.5913/yast2-ruby-bindings.changes
2020-11-23 16:27:55.380686088 +0100
@@ -1,0 +2,13 @@
+Thu Nov 19 10:13:01 UTC 2020 - Stefan Hundhammer <shundham...@suse.com>
+
+- Removed Requires / BuildRequires to libyui (build failure)
+ (related to bsc#1175489)
+- 4.3.11
+
+-------------------------------------------------------------------
+Mon Nov 16 16:21:33 UTC 2020 - Stefan Hundhammer <shundham...@suse.com>
+
+- Added UI test for menu bar shortcut priority (bsc#1175489)
+- 4.3.10
+
+-------------------------------------------------------------------
Old:
----
yast2-ruby-bindings-4.3.9.tar.bz2
New:
----
yast2-ruby-bindings-4.3.11.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-ruby-bindings.spec ++++++
--- /var/tmp/diff_new_pack.WErE0L/_old 2020-11-23 16:27:55.988687230 +0100
+++ /var/tmp/diff_new_pack.WErE0L/_new 2020-11-23 16:27:55.988687230 +0100
@@ -17,7 +17,7 @@
Name: yast2-ruby-bindings
-Version: 4.3.9
+Version: 4.3.11
Release: 0
URL: https://github.com/yast/yast-ruby-bindings
BuildRoot: %{_tmppath}/%{name}-%{version}-build
@@ -41,8 +41,8 @@
Requires: yast2-core >= 3.2.2
BuildRequires: yast2-core-devel >= 3.2.2
# MenuBar-shortcuts-test.rb
-Requires: yast2-ycp-ui-bindings >= 4.3.6
-BuildRequires: yast2-ycp-ui-bindings-devel >= 4.3.6
+Requires: yast2-ycp-ui-bindings >= 4.3.7
+BuildRequires: yast2-ycp-ui-bindings-devel >= 4.3.7
# The test suite includes a regression test (std_streams_spec.rb) for a
# libyui-ncurses bug fixed in 2.47.3
BuildRequires: libyui-ncurses >= 2.47.3
++++++ yast2-ruby-bindings-4.3.9.tar.bz2 -> yast2-ruby-bindings-4.3.11.tar.bz2
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.3.9/package/yast2-ruby-bindings.changes
new/yast2-ruby-bindings-4.3.11/package/yast2-ruby-bindings.changes
--- old/yast2-ruby-bindings-4.3.9/package/yast2-ruby-bindings.changes
2020-11-12 11:45:50.000000000 +0100
+++ new/yast2-ruby-bindings-4.3.11/package/yast2-ruby-bindings.changes
2020-11-19 11:35:39.000000000 +0100
@@ -1,4 +1,17 @@
-------------------------------------------------------------------
+Thu Nov 19 10:13:01 UTC 2020 - Stefan Hundhammer <shundham...@suse.com>
+
+- Removed Requires / BuildRequires to libyui (build failure)
+ (related to bsc#1175489)
+- 4.3.11
+
+-------------------------------------------------------------------
+Mon Nov 16 16:21:33 UTC 2020 - Stefan Hundhammer <shundham...@suse.com>
+
+- Added UI test for menu bar shortcut priority (bsc#1175489)
+- 4.3.10
+
+-------------------------------------------------------------------
Thu Nov 12 10:20:58 UTC 2020 - Martin Vidner <mvid...@suse.com>
- Build fix for "error creating /run/tmux/399" (bsc#1178394)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.3.9/package/yast2-ruby-bindings.spec
new/yast2-ruby-bindings-4.3.11/package/yast2-ruby-bindings.spec
--- old/yast2-ruby-bindings-4.3.9/package/yast2-ruby-bindings.spec
2020-11-12 11:45:50.000000000 +0100
+++ new/yast2-ruby-bindings-4.3.11/package/yast2-ruby-bindings.spec
2020-11-19 11:35:39.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-ruby-bindings
-Version: 4.3.9
+Version: 4.3.11
Release: 0
URL: https://github.com/yast/yast-ruby-bindings
BuildRoot: %{_tmppath}/%{name}-%{version}-build
@@ -41,8 +41,8 @@
Requires: yast2-core >= 3.2.2
BuildRequires: yast2-core-devel >= 3.2.2
# MenuBar-shortcuts-test.rb
-Requires: yast2-ycp-ui-bindings >= 4.3.6
-BuildRequires: yast2-ycp-ui-bindings-devel >= 4.3.6
+Requires: yast2-ycp-ui-bindings >= 4.3.7
+BuildRequires: yast2-ycp-ui-bindings-devel >= 4.3.7
# The test suite includes a regression test (std_streams_spec.rb) for a
# libyui-ncurses bug fixed in 2.47.3
BuildRequires: libyui-ncurses >= 2.47.3
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.3.9/tests/libyui/menu_item_spec.rb
new/yast2-ruby-bindings-4.3.11/tests/libyui/menu_item_spec.rb
--- old/yast2-ruby-bindings-4.3.9/tests/libyui/menu_item_spec.rb
2020-11-12 11:45:50.000000000 +0100
+++ new/yast2-ruby-bindings-4.3.11/tests/libyui/menu_item_spec.rb
2020-11-19 11:35:39.000000000 +0100
@@ -1,20 +1,23 @@
require_relative "rspec_tmux_tui"
describe "Menu Item" do
- around(:each) do |ex|
+ before(:all) do
+ @base = "multi_selection_box_basics"
@tui = YastTui.new
- @tui.example("MenuBar-shortcuts-test") do
- ex.run
- end
+ @tui.example("MenuBar-shortcuts-test")
+ @tui.await(/File.*Edit.*View/)
+ end
+
+ after(:all) do
+ @tui.send_keys "M-Q" # &Quit
end
bug = "1177760" # https://bugzilla.suse.com/show_bug.cgi?id=1177760
- it "has hotkeys in menu items, boo##{bug}" do
- @base = "menu_hotkeys_#{bug}"
- @tui.await(/File.*Edit.*View/)
+ it "has shortcuts in menu items, boo##{bug}" do
+ @base = "menu_shortcuts_#{bug}"
@tui.capture_pane_to("#{@base}-1-initial")
- @tui.send_keys "M-V" # &View
+ @tui.send_keys "M-V" # &View menu
@tui.capture_pane_to("#{@base}-2-view-menu-activated")
@tui.send_keys "M-N" # &Normal
@@ -24,17 +27,50 @@
expect(@tui.capture_pane).to include("Last Event")
# the output
expect(@tui.capture_pane).to include("view_normal")
+ end
- @tui.send_keys "M-Q" # &Quit
+ bug = nil
+ it "menu shortcuts have higher priority than button shortcuts" do
+ @base = "menu_shortcuts_prio"
+ @tui.capture_pane_to("#{@base}-1-initial")
+
+ # No extra buttons: The "&View" menu has shortcut "V"
+ expect(@tui.capture_pane).not_to include("[File]", "[Edit]", "[View]")
+ @tui.send_keys "M-V" # &View menu
+ @tui.capture_pane_to("#{@base}-2-view-menu-activated")
+ expect(@tui.capture_pane).to include("Normal", "Compact", "Detailed",
"Zoom")
+ @tui.send_keys "Down"
+ @tui.send_keys "Enter"
+ @tui.capture_pane_to("#{@base}-3-view-compact-activated")
+ expect(@tui.capture_pane).to include("Last Event:", "view_compact")
+
+ # Toggle extra buttons
+ @tui.send_keys "M-B" # Extra &Buttons
+ @tui.capture_pane_to("#{@base}-4-extra-buttons-activated")
+ expect(@tui.capture_pane).to include("[File]", "[Edit]", "[View]")
+
+ # With extra buttons: The "&View" menu still has shortcut "V"
+ @tui.send_keys "M-V" # &View menu
+ @tui.capture_pane_to("#{@base}-5-view-menu-activated")
+ expect(@tui.capture_pane).to include("Normal", "Compact", "Detailed",
"Zoom")
+ @tui.send_keys "Down"
+ @tui.send_keys "Down"
+ @tui.send_keys "Enter"
+ @tui.capture_pane_to("#{@base}-6-view-detailed-activated")
+ expect(@tui.capture_pane).to include("Last Event:", "view_detailed")
+
+ # And the "View" button has "W"
+ @tui.send_keys "M-W" # Vie&w button
+ @tui.capture_pane_to("#{@base}-7-view-button-activated")
+ expect(@tui.capture_pane).to include("Last Event:", "b_view")
end
bug = "1178394" # https://bugzilla.suse.com/show_bug.cgi?id=1178394
- it "remains disabled after hotkeys are recomputed" do
+ it "remains disabled after shortcuts are recomputed" do
@base = "menu_disabled_#{bug}"
- @tui.await(/File.*Edit.*View/)
@tui.capture_pane_to("#{@base}-1-initial")
- @tui.send_keys "M-E" # &Edit
+ @tui.send_keys "M-E" # &Edit menu
@tui.capture_pane_to("#{@base}-2-edit-menu-activated")
# select the 1st available item; it is Copy because Cut is disabled
@@ -42,18 +78,19 @@
@tui.capture_pane_to("#{@base}-3-copy-item-activated")
expect(@tui.capture_pane).to include("Last Event:", "copy")
- # This changes the shortcuts!
@tui.send_keys "M-B" # Extra &Buttons
@tui.capture_pane_to("#{@base}-4-extra-buttons-activated")
- @tui.send_keys "M-T" # Edi&t
+ # Enabling the extra buttons calls UI.ReplaceWidget() which triggers
+ # checking keyboard shortcuts which causes the menu tree to be rebuilt.
+ # The bug was that this did not honor the item enabled/disabled state.
+
+ @tui.send_keys "M-E" # &Edit menu
@tui.capture_pane_to("#{@base}-5-edit-menu-activated")
# select the 1st available item; it is Copy because Cut is disabled
@tui.send_keys "Enter"
@tui.capture_pane_to("#{@base}-6-copy-item-activated")
expect(@tui.capture_pane).to include("Last Event:", "copy")
-
- @tui.send_keys "M-Q" # &Quit
end
end
_______________________________________________
openSUSE Commits mailing list -- commit@lists.opensuse.org
To unsubscribe, email commit-le...@lists.opensuse.org
List Netiquette: https://en.opensuse.org/openSUSE:Mailing_list_netiquette
List Archives:
https://lists.opensuse.org/archives/list/commit@lists.opensuse.org
