Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package open-lldp for openSUSE:Factory checked in at 2021-01-15 19:43:34 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/open-lldp (Old) and /work/SRC/openSUSE:Factory/.open-lldp.new.28504 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "open-lldp" Fri Jan 15 19:43:34 2021 rev:19 rq:861815 version:1.1+36.e926f7172b96 Changes: -------- --- /work/SRC/openSUSE:Factory/open-lldp/open-lldp.changes 2020-12-13 17:29:23.128327990 +0100 +++ /work/SRC/openSUSE:Factory/.open-lldp.new.28504/open-lldp.changes 2021-01-15 19:43:38.841782060 +0100 @@ -1,0 +2,15 @@ +Fri Jan 08 22:14:35 UTC 2021 - ldun...@suse.com + +- Update to version v1.1+36.e926f7172b96: + * tx: rename variable + * event_iface: only set rcv buf size if too small (bsc#1175570) + * tx: when operating in rx-only mode don't send a port shutdown pdu + * Update .travis.yml + * vdp22: manpage typo + * lldptool: fix manpage + * lldp_head: remove all references + * add_rtattr: only copy if data is provided + * autoconf: convenience to setup asan and ubsan + * Post 1.1 release + +------------------------------------------------------------------- Old: ---- open-lldp-v1.1+18.0e969d0edcc4.tar.xz New: ---- open-lldp-v1.1+36.e926f7172b96.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ open-lldp.spec ++++++ --- /var/tmp/diff_new_pack.d0X6N2/_old 2021-01-15 19:43:39.281782781 +0100 +++ /var/tmp/diff_new_pack.d0X6N2/_new 2021-01-15 19:43:39.285782787 +0100 @@ -1,7 +1,7 @@ # # spec file for package open-lldp # -# Copyright (c) 2020 SUSE LLC +# Copyright (c) 2021 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -21,7 +21,7 @@ Summary: Link Layer Discovery Protocol (LLDP) Agent License: GPL-2.0-only Group: System/Daemons -Version: 1.1+18.0e969d0edcc4 +Version: 1.1+36.e926f7172b96 Release: 0 BuildRequires: bison BuildRequires: flex ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.d0X6N2/_old 2021-01-15 19:43:39.333782865 +0100 +++ /var/tmp/diff_new_pack.d0X6N2/_new 2021-01-15 19:43:39.333782865 +0100 @@ -1,4 +1,4 @@ <servicedata> <service name="tar_scm"> <param name="url">https://github.com/openSUSE/lldpad.git</param> - <param name="changesrevision">0e969d0edcc41444b18fc579535516218421c388</param></service></servicedata> \ No newline at end of file + <param name="changesrevision">e926f7172b967ee4ca588b27906940fd5996cb0e</param></service></servicedata> \ No newline at end of file ++++++ open-lldp-v1.1+18.0e969d0edcc4.tar.xz -> open-lldp-v1.1+36.e926f7172b96.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/open-lldp-v1.1+18.0e969d0edcc4/.travis.yml new/open-lldp-v1.1+36.e926f7172b96/.travis.yml --- old/open-lldp-v1.1+18.0e969d0edcc4/.travis.yml 2020-12-10 23:40:08.000000000 +0100 +++ new/open-lldp-v1.1+36.e926f7172b96/.travis.yml 2021-01-08 23:12:44.000000000 +0100 @@ -1,5 +1,8 @@ language: c dist: xenial +arch: + - amd64 + - ppc64le #before_install: sudo apt-get update install: sudo apt-get install -y libconfig-dev libnl-3-dev rpm before_script: ./bootstrap.sh diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/open-lldp-v1.1+18.0e969d0edcc4/ChangeLog new/open-lldp-v1.1+36.e926f7172b96/ChangeLog --- old/open-lldp-v1.1+18.0e969d0edcc4/ChangeLog 2020-12-10 23:40:08.000000000 +0100 +++ new/open-lldp-v1.1+36.e926f7172b96/ChangeLog 2021-01-08 23:12:44.000000000 +0100 @@ -1,4 +1,4 @@ -Changes from 1.1.0 to +Changes from 1.1.0 to 1.2.0 Changes from 1.0.1 to 1.1 - VDP: introduce vdptool - VDP: support retrieving vsi parameter diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/open-lldp-v1.1+18.0e969d0edcc4/configure.ac new/open-lldp-v1.1+36.e926f7172b96/configure.ac --- old/open-lldp-v1.1+18.0e969d0edcc4/configure.ac 2020-12-10 23:40:08.000000000 +0100 +++ new/open-lldp-v1.1+36.e926f7172b96/configure.ac 2021-01-08 23:12:44.000000000 +0100 @@ -1,4 +1,4 @@ -AC_INIT([lldpad], [1.1.0], [lldp-de...@open-lldp.org]) +AC_INIT([lldpad], [1.2.99], [lldp-de...@open-lldp.org]) AM_INIT_AUTOMAKE([-Wall -Werror foreign subdir-objects]) m4_pattern_allow([AM_PROG_AR]) @@ -31,6 +31,8 @@ dnl Configure developer type flags OPENLLDP_CHECK_WARNINGS OPENLLDP_CHECK_ERROR +OPENLLDP_CHECK_UBSAN +OPENLLDP_CHECK_ASAN dnl Set sysvinit values, if system has systemd it will be rewritten AC_SUBST(SPEC_BUILD_REQUIRES_POST, "chkconfig") @@ -116,7 +118,6 @@ AC_C_INLINE AC_FUNC_CHOWN -AC_FUNC_MALLOC AC_FUNC_REALLOC AC_HEADER_STDBOOL AC_PREREQ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/open-lldp-v1.1+18.0e969d0edcc4/lldp/agent.c new/open-lldp-v1.1+36.e926f7172b96/lldp/agent.c --- old/open-lldp-v1.1+18.0e969d0edcc4/lldp/agent.c 2020-12-10 23:40:08.000000000 +0100 +++ new/open-lldp-v1.1+36.e926f7172b96/lldp/agent.c 2021-01-08 23:12:44.000000000 +0100 @@ -200,7 +200,7 @@ LLDPAD_DBG("Send shutdown frame on port %s\n", port->ifname); LIST_FOREACH(agent, &port->agent_head, entry) { - process_tx_shutdown_frame(port, agent); + process_tx_shutdown_frame(port, agent, false); } } else { LLDPAD_DBG("No shutdown frame is sent on port %s\n", diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/open-lldp-v1.1+18.0e969d0edcc4/lldp/states.h new/open-lldp-v1.1+36.e926f7172b96/lldp/states.h --- old/open-lldp-v1.1+18.0e969d0edcc4/lldp/states.h 2020-12-10 23:40:08.000000000 +0100 +++ new/open-lldp-v1.1+36.e926f7172b96/lldp/states.h 2021-01-08 23:12:44.000000000 +0100 @@ -85,7 +85,7 @@ void run_tx_sm(struct port *, struct lldp_agent *); void process_tx_initialize_sm(struct port *); void process_tx_idle(struct lldp_agent *); -void process_tx_shutdown_frame(struct port *, struct lldp_agent *); +void process_tx_shutdown_frame(struct port *, struct lldp_agent *, bool); void process_tx_info_frame(struct port *, struct lldp_agent *); void update_tx_timers(struct lldp_agent *); void run_tx_timers_sm(struct port *, struct lldp_agent *); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/open-lldp-v1.1+18.0e969d0edcc4/lldp/tx.c new/open-lldp-v1.1+36.e926f7172b96/lldp/tx.c --- old/open-lldp-v1.1+18.0e969d0edcc4/lldp/tx.c 2020-12-10 23:40:08.000000000 +0100 +++ new/open-lldp-v1.1+36.e926f7172b96/lldp/tx.c 2021-01-08 23:12:44.000000000 +0100 @@ -270,7 +270,7 @@ process_tx_idle(agent); break; case TX_SHUTDOWN_FRAME: - process_tx_shutdown_frame(port, agent); + process_tx_shutdown_frame(port, agent, true); break; case TX_INFO_FRAME: process_tx_info_frame(port, agent); @@ -330,8 +330,19 @@ return; } -void process_tx_shutdown_frame(struct port *port, struct lldp_agent *agent) +/* we ignore 'adminStatus' in the case that we have recently transitioned + * to the shutdown state (in the case of the 'tx' state change) to allow + * for transmitting the ttl==0 as required by the IEEE standard. */ +void process_tx_shutdown_frame(struct port *port, struct lldp_agent *agent, + bool ignoreStatus) { + if (agent->adminStatus != enabledRxTx && + agent->adminStatus != enabledTxOnly) { + if (!ignoreStatus) { + return; + } + } + if (agent->timers.txShutdownWhile == 0) { if (mibConstrShutdownLLDPDU(port, agent)) txFrame(port, agent); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/open-lldp-v1.1+18.0e969d0edcc4/m4/openlldp.m4 new/open-lldp-v1.1+36.e926f7172b96/m4/openlldp.m4 --- old/open-lldp-v1.1+18.0e969d0edcc4/m4/openlldp.m4 2020-12-10 23:40:08.000000000 +0100 +++ new/open-lldp-v1.1+36.e926f7172b96/m4/openlldp.m4 2021-01-08 23:12:44.000000000 +0100 @@ -31,6 +31,19 @@ AC_LANG_POP() ]) +AC_DEFUN([_CHECK_C_LINK_FLAG], [ + AC_LANG_PUSH([C]) + AC_MSG_CHECKING(for $CC support of $1) + old_LDFLAGS="$LDFLAGS" + LDFLAGS="$LDFLAGS $1" + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([],[])], + AC_MSG_RESULT(yes), + AC_MSG_RESULT(no) + LDFLAGS="$old_LDFLAGS") + AC_LANG_POP() +]) + + dnl Check for the various warning flags AC_DEFUN([OPENLLDP_CHECK_WARNINGS], [ AC_MSG_CHECKING([checking for warnings flag]) @@ -64,3 +77,35 @@ _CHECK_C_COMPILER_FLAG([-Werror]) ]) ]) + +dnl Set up undefined sanitizer +AC_DEFUN([OPENLLDP_CHECK_UBSAN], + [AC_MSG_CHECKING([checking for ubsan]) + AC_ARG_ENABLE([ubsan], + AS_HELP_STRING([--enable-ubsan], + [Build with undefined behavior sanitizer]), [ubsan=$enableval], [ubsan=no]) + AM_CONDITIONAL([UBSAN_ENABLED], [test "x$ubsan" = "xyes"]) + AC_SUBST([UBSAN_ENABLED], [$ubsan]) + AC_MSG_RESULT($ubsan) + + AS_IF([ test "x$ubsan" = "xyes"], [ + _CHECK_C_COMPILER_FLAG([-fsanitize=undefined]) + _CHECK_C_LINK_FLAG([-fsanitize=undefined]) + ]) +]) + +dnl Set up address sanitizer +AC_DEFUN([OPENLLDP_CHECK_ASAN], + [AC_MSG_CHECKING([checking for asan]) + AC_ARG_ENABLE([asan], + AS_HELP_STRING([--enable-asan], + [Build with address sanitizer]), [asan=$enableval], [asan=no]) + AM_CONDITIONAL([ASAN_ENABLED], [test "x$asan" = "xyes"]) + AC_SUBST([ASAN_ENABLED], [$asan]) + AC_MSG_RESULT($asan) + + AS_IF([ test "x$asan" = "xyes"], [ + _CHECK_C_COMPILER_FLAG([-fsanitize=address]) + _CHECK_C_LINK_FLAG([-fsanitize=address]) + ]) +])