Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package tcmu-runner.15565 for 
openSUSE:Leap:15.1:Update checked in at 2021-01-20 16:22:42
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Leap:15.1:Update/tcmu-runner.15565 (Old)
 and      /work/SRC/openSUSE:Leap:15.1:Update/.tcmu-runner.15565.new.28504 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "tcmu-runner.15565"

Wed Jan 20 16:22:42 2021 rev:1 rq:864079 version:1.4.0

Changes:
--------
New Changes file:

--- /dev/null   2021-01-11 18:20:20.070723563 +0100
+++ 
/work/SRC/openSUSE:Leap:15.1:Update/.tcmu-runner.15565.new.28504/tcmu-runner.changes
        2021-01-20 16:22:43.699409023 +0100
@@ -0,0 +1,175 @@
+-------------------------------------------------------------------
+Thu Jan  7 23:43:54 UTC 2021 - David Disseldorp <[email protected]>
+
+- Fix for security advisory CVE-2020-28374; (bsc#1180676).
+  + tcmu-runner-fail-cross-device-XCOPY-requests.patch
+
+-------------------------------------------------------------------
+Tue Jun 18 17:15:22 UTC 2019 - David Disseldorp <[email protected]>
+
+- Move tcmu.conf into main package; (bsc#1138443)
+
+-------------------------------------------------------------------
+Wed May 22 13:32:52 UTC 2019 - David Disseldorp <[email protected]>
+
+- Add explicit libtcmu package dependency to avoid incorrect upstream
+  .so versioning; (bsc#1135815)
+
+-------------------------------------------------------------------
+Tue May 21 13:48:20 UTC 2019 - David Disseldorp <[email protected]>
+
+- Rename openSUSE zbc patches:
+  + file_zbc-fixed-compile-error-under-ppc64le ->
+    file_zbc-fixed-compile-error-under-ppc64le.patch
+  + file_zbc-optionally-build-zbc-handler ->
+    file_zbc-optionally-build-zbc-handler.patch
+
+-------------------------------------------------------------------
+Fri Oct 19 18:19:42 UTC 2018 - [email protected]
+
+- Update to version 1.4.0:
+  * tcmu-runner: bump version to 1.4.0
+  * Disable explicit alua support.
+  * logger: notification on changing the options for dynamic reloading
+  * logger: update .gitignore for logrotate.conf_install.cmake
+  * logger: fix the return value
+  * Sync sig handler naming.
+  * Add logrotate support
+  * Move starting log message.
+  * Allow log file restart from SIGHUP
+  * Simplify log outputs
+  Replacing tcmu-runner-1.3.0.tar.gz with tcmu-runner-1.4.0.tar.xz,
+  updating the SPEC file, and removing patches:
+  * api-avoid-compiler-Werror-return-type-failures.patch
+  * build-drop-versionless-libtcmu.so-symlink.patch
+  * tcmu-runner-remove-uio-include-for-iovec.patch
+  * support custom cephx credentials; (bsc#1135369)
+
+-------------------------------------------------------------------
+Fri Feb  9 17:28:47 UTC 2018 - [email protected]
+
+- Update to version 1.3.0; (fate#322524)
+  + Improved Ceph RBD integration
+  + Support XCOPY copy-offload commands
+  + Support COMPARE_AND_WRITE, with Ceph OSD request mapping
+  + Asynchronous I/O improvements and bug fixes
+- Remove a number of downstream patches now carried upstream:
+  + glfs-discard-glfs_check_config
+  + 
fixed-local-dos-when-unregisterhandler-was-called-for-a-not-existing-handler
+  + 
only-allow-dynamic-unregisterhandler-for-external-handlers-thereby-fixing-dos
+  + fixed-a-number-of-memory-leaks-with-deregistering-of-dbus-handlers
+  + removed-all-check_config-callback-implementations-to-avoid-security-issues
+  + tcmu-runner-add-local-target_core_user-h
+- Remove development packages (bsc#1080619)
+  + API discontinued upstream
+- Add fix for -Werror-return-type failures:
+  + api-avoid-compiler-Werror-return-type-failures.patch
+- Add fix for library versioning:
+  + build-drop-versionless-libtcmu.so-symlink.patch
+
+-------------------------------------------------------------------
+Wed Sep 20 22:59:29 UTC 2017 - [email protected]
+
+- Add two patches: make target_core_user.h local, to insulate
+  tcmu-runner from kernel version/data structure/naming
+  changes, and add include of <sys/uio.h> to that file,
+  to fix "stuct iovec" not defined issue  (bsc#1058303),
+  adding patches:
+  * tcmu-runner-add-local-target_core_user-h
+  * tcmu-runner-remove-uio-include-for-iovec.patch
+  The latter patch is added only for SUSE version >= 13.3,
+  since it is only needed there.
+
+-------------------------------------------------------------------
+Wed Aug  9 21:48:42 UTC 2017 - [email protected]
+
+- Remove install prefix from beginning of install libdir when
+  setting tcmu-runner plugin path (bsc#1052795), adding
+  SUSE-specific patch:
+  * tcmu-runner-remove-handler-path-install-prefix.patch
+
+-------------------------------------------------------------------
+Thu Jul 20 01:53:01 UTC 2017 - [email protected]
+
+- One more update from Security Audit, adding one more patch:
+  - removed-all-check_config-callback-implementations-to-avoid-security-issues
+    (bsc#1049491)
+
+-------------------------------------------------------------------
+Thu Jul 20 01:18:42 UTC 2017 - [email protected]
+
+- Updates based on Security Audit, adding 4 patches:
+  * glfs-discard-glfs_check_config (bsc#1049485)
+  * 
fixed-local-dos-when-unregisterhandler-was-called-for-a-not-existing-handler
+    (bsc#1049488)
+  * 
only-allow-dynamic-unregisterhandler-for-external-handlers-thereby-fixing-dos
+    (bsc#1049489)
+  * fixed-a-number-of-memory-leaks-with-deregistering-of-dbus-handlers
+    (bsc#1049490)
+
+-------------------------------------------------------------------
+Mon May 15 16:14:50 UTC 2017 - [email protected]
+
+- Make Ceph RBD handler aarch64 and x86-64 only for now
+  + librbd isn't yet available for all platforms
+
+-------------------------------------------------------------------
+Thu May 11 20:46:08 UTC 2017 - [email protected]
+
+- Build the Ceph RBD handler and package separately; (fate#322524).
+- Split the GlusterFS handler into a separate package
+  + avoid adding an unnecessary dependencies to tcmu-runner core
+
+-------------------------------------------------------------------
+Thu May 11 17:25:11 UTC 2017 - [email protected]
+
+- Explicitly disable the GlusterFS handler for SLE builds.
+
+-------------------------------------------------------------------
+Thu May 11 15:12:24 UTC 2017 - [email protected]
+
+- Update to upstream version 1.2.0; (bsc#1038712).
+  + Add remove devices when tcmulib teardown
+  + fix builds done outside of source directory
+  + free tcmu_device after dev->fd is closed
+  + fix Read_Capacity_16
+  + detect INQURY response truncation
+  + fix incorrect memcpy length
+  + fix inquiry buffer length calculations
+  + add tcmu.conf for log level configuration
+- Remove upstreamed fixes:
+  + tcmu-runner-include-falloc-in-qcow.patch
+  + tcmu-runner-let-cmake-install-man-page.patch
+  + tcmu-runner-Use-CMake-FULL-library-directory-for-SOs.patch
+  + include-tcmu-runner-h-in-install.patch
+
+-------------------------------------------------------------------
+Sun Aug 21 17:08:20 UTC 2016 - [email protected]
+
+- rename libtcmu1-devel to libtcmu-devel
+- drop unnecessary %oname indirect macro
+
+-------------------------------------------------------------------
+Tue Aug 16 03:37:30 UTC 2016 - [email protected]
+
+- Updated SPEC file to break library into separate packages
+- Install tcmu-runner.h, adding:
+  * include-tcmu-runner-h-in-install.patch
+
+-------------------------------------------------------------------
+Fri Jul 29 15:08:48 UTC 2016 - [email protected]
+
+- Drop silly buildrequires on libgfapi0/libglib-2_0-0.
+  Abolish old macros.
+
+-------------------------------------------------------------------
+Sat May 28 16:55:45 UTC 2016 - [email protected]
+
+- Updated SPEC file to install LICENSE file (bsc#982130)
+
+-------------------------------------------------------------------
+Thu May  5 01:46:10 UTC 2016 - [email protected]
+
+- Created from upstream version 1.0.4
+
+-------------------------------------------------------------------

New:
----
  _service
  _servicedata
  file_zbc-fixed-compile-error-under-ppc64le.patch
  file_zbc-optionally-build-zbc-handler.patch
  tcmu-runner-1.4.0.tar.xz
  tcmu-runner-fail-cross-device-XCOPY-requests.patch
  tcmu-runner-handler_file-add-libtcmu.patch
  tcmu-runner-remove-handler-path-install-prefix.patch
  tcmu-runner.changes
  tcmu-runner.spec

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ tcmu-runner.spec ++++++
#
# spec file for package tcmu-runner
#
# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
# upon. The license for this file, and modifications and additions to the
# file, is the same license as for the pristine package itself (unless the
# license for the pristine package is not an Open Source License, in which
# case the license is the MIT License). An "Open Source License" is a
# license that conforms to the Open Source Definition (Version 1.9)
# published by the Open Source Initiative.

# Please submit bugfixes or comments via https://bugs.opensuse.org/
#


%if 0%{?sle_version} == 0
%define         build_handler_glusterfs 1
%endif

%if 0%{?sle_version} == 0 || 0%{?sle_version} >= 120300
%ifarch aarch64 x86_64
%define         build_handler_rbd 1
%endif
%endif

%if 0%{?sle_version} == 0
%ifarch aarch64 x86_64
%define         build_handler_zbc 1
%endif
%endif

Name:           tcmu-runner
Version:        1.4.0
Release:        0
Summary:        A userspace daemon that handles the LIO TCM-User backstore
License:        Apache-2.0
Group:          System/Management
Url:            https://github.com/agrover/%{name}
Source:         %{name}-%{version}.tar.xz
Patch1:         %{name}-handler_file-add-libtcmu.patch
Patch2:         %{name}-remove-handler-path-install-prefix.patch
Patch3:         file_zbc-fixed-compile-error-under-ppc64le.patch
Patch4:         file_zbc-optionally-build-zbc-handler.patch
Patch5:         %{name}-fail-cross-device-XCOPY-requests.patch
BuildRoot:      %{_tmppath}/%{name}-%{version}-build
BuildRequires:  cmake
BuildRequires:  glib2-devel
BuildRequires:  glibc-devel
%if 0%{?build_handler_glusterfs}
BuildRequires:  glusterfs-devel
%endif
%if 0%{?build_handler_rbd}
BuildRequires:  librbd-devel
%endif
%if 0%{?build_handler_zbc}
BuildRequires:  libzbc-devel
%endif
BuildRequires:  libkmod-devel
BuildRequires:  libnl3-devel
BuildRequires:  systemd-rpm-macros
BuildRequires:  zlib-devel
Requires:       libtcmu2 = %{version}
Requires:       logrotate
%{?systemd_requires}

%description
LIO is the SCSI target in the Linux kernel. It is entirely kernel
code, and allows exported SCSI logical  units (LUNs) to be backed
by regular files or block devices. But, if we want to get fancier with
the capabilities of the device we're emulating, the kernel is not
necessarily the right place. While there are userspace libraries for
compression, encryption, and clustered storage solutions like
Ceph or Gluster, these are not accessible from the kernel. 

The TCMU userspace-passthrough backstore allows a userspace process to
handle requests to a LUN. But since the kernel-user interface that
TCMU provides must be fast and flexible, it is complex enough that
we'd like to avoid each  userspace handler having to write boilerplate
code.

tcmu-runner handles the messy details of the TCMU interface -- UIO,
netlink, pthreads, and DBus -- and exports a more friendly C plugin
module API. Modules using this API are called "TCMU handlers". Handler
authors can write code just to handle the SCSI commands as desired,
and can also link with whatever userspace libraries they like.

%package -n libtcmu2
Summary:        Runtime libraries for tcmu-runner
Group:          System/Libraries

%description -n libtcmu2
This package contains the runtime libraries for tcmu-runner.

%if 0%{?build_handler_glusterfs}
%package handler-glusterfs
Summary:        GlusterFS handler for tcmu-runner
Group:          System/Libraries
Requires:       tcmu-runner = %{version}

%description handler-glusterfs
This package contains the GlusterFS handler for tcmu-runner, which
allows for LIO/tcmu logical units to be backed by GlusterFS provisioned
storage.
%endif

%if 0%{?build_handler_rbd}
%package handler-rbd
Summary:        Ceph RBD handler for tcmu-runner
Group:          System/Libraries
Requires:       tcmu-runner = %{version}

%description handler-rbd
This package contains the Ceph RADOS Block Device (RBD) handler for
tcmu-runner, which allows for LIO/tcmu logical units to be backed by
RBD images.
%endif

%if 0%{?build_handler_zbc}
%package handler-zbc
Summary:        Ceph ZBC handler for tcmu-runner
Group:          System/Libraries
Requires:       tcmu-runner = %{version}

%description handler-zbc
This package contains the Ceph RADOS ZBC disc emulation, using a
file backstore in tcmu-runner.
%endif

%prep
%setup
%patch1 -p1
%patch2 -p1
%patch3 -p1
%patch4 -p1
%patch5 -p1

%build
CMAKE_OPTIONS="\
        -DSUPPORT_SYSTEMD=1 \
%if 0%{?build_handler_glusterfs}
        -Dwith-glfs=1 \
%else
        -Dwith-glfs=0 \
%endif
%if 0%{?build_handler_rbd}
        -Dwith-rbd=1 \
%else
        -Dwith-rbd=0 \
%endif
%if 0%{?build_handler_zbc}
        -Dwith-zbc=1 \
%else
        -Dwith-zbc=0 \
%endif
"
%cmake -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--as-needed -Wl,-z,now" \
        ${CMAKE_OPTIONS}
make %{?_smp_mflags}

%install
%cmake_install
install -d -m 755 %{buildroot}/%{_sbindir}
ln -s %{_sbindir}/service %{buildroot}/%{_sbindir}/rctcmu-runner

%post
%{run_ldconfig}
%{service_add_post tcmu-runner.service}

%postun
%{service_del_postun tcmu-runner.service}
%{run_ldconfig}

%pre
%{service_add_pre tcmu-runner.service}

%preun
%{service_del_preun tcmu-runner.service}

%post -n libtcmu2 -p /sbin/ldconfig

%postun -n libtcmu2 -p /sbin/ldconfig

%files
%defattr(-,root,root)
%{_bindir}/tcmu-runner
%{_sbindir}/rctcmu-runner
%doc README.md
%license LICENSE.Apache2
%license LICENSE.LGPLv2.1
%dir %{_libdir}/tcmu-runner
%{_libdir}/tcmu-runner/handler_qcow.so
%dir %{_datadir}/dbus-1
%dir %{_datadir}/dbus-1/system-services
%{_datadir}/dbus-1/system-services/org.kernel.TCMUService1.service
%dir %{_sysconfdir}/dbus-1
%dir %{_sysconfdir}/dbus-1/system.d
%config %{_sysconfdir}/dbus-1/system.d/tcmu-runner.conf
%{_unitdir}/tcmu-runner.service
%doc %{_mandir}/man8/tcmu-runner.8%{ext_man}
%config %{_sysconfdir}/logrotate.d/tcmu-runner
%dir %{_sysconfdir}/tcmu
%config(noreplace) %{_sysconfdir}/tcmu/tcmu.conf

%files -n libtcmu2
%defattr(-,root,root)
%{_libdir}/libtcmu.so.2

%if 0%{?build_handler_glusterfs}
%files handler-glusterfs
%{_libdir}/tcmu-runner/handler_glfs.so
%endif

%if 0%{?build_handler_rbd}
%files handler-rbd
%{_libdir}/tcmu-runner/handler_rbd.so
%endif

%if 0%{?build_handler_zbc}
%files handler-zbc
%{_libdir}/tcmu-runner/handler_file_zbc.so
%endif

%changelog
++++++ _service ++++++
<services>
  <service name="tar_scm" mode="disabled">
    <param name="scm">git</param>
    <param name="url">https://github.com/open-iscsi/tcmu-runner.git</param>
    <param name="subdir"></param>
    <param name="filename">tcmu-runner</param>
    <param name="versionformat">1.4.0</param>
    <param name="revision">v1.4.0</param>
    <param name="changesgenerate">enable</param>
  </service>
  <service name="recompress" mode="disabled">
    <param name="file">tcmu-runner*.tar</param>
    <param name="compression">xz</param>
  </service>
  <service name="set_version" mode="disabled"/>
</services>
++++++ _servicedata ++++++
<servicedata>
<service name="tar_scm">
                <param 
name="url">https://github.com/open-iscsi/tcmu-runner.git</param>
              <param 
name="changesrevision">2c125073c597139a00d3bbab6b5ae233a74e657b</param></service></servicedata>++++++
 file_zbc-fixed-compile-error-under-ppc64le.patch ++++++
From: Jason Dillaman <[email protected]>
Date: Tue, 9 Oct 2018 12:52:28 -0400
Subject: file_zbc: fixed compile error under ppc64le
Git-repo: https://github.com/agrover/tcmu-runner.git
Git-commit: bc4cfb8cc88f3c97e77840e0c4dcd63f04dcc147

Signed-off-by: Jason Dillaman <[email protected]>
Acked-by: Lee Duncan <[email protected]>
---
 file_zbc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/file_zbc.c b/file_zbc.c
index 99f6b42dbc12..783c2a149e61 100644
--- a/file_zbc.c
+++ b/file_zbc.c
@@ -2060,8 +2060,8 @@ static int zbc_write_check_zones(struct tcmu_device *dev,
 
                /* Check LBA on write pointer */
                if (zbc_zone_seq_req(zone) && lba != zone->wp) {
-                       tcmu_dev_err(dev, "Unaligned write lba %"PRIu64", wp 
%llu\n",
-                                    lba, zone->wp);
+                       tcmu_dev_err(dev, "Unaligned write lba %"PRIu64", wp 
%"PRIu64"\n",
+                                    lba, (uint64_t)zone->wp);
                        return tcmu_set_sense_data(cmd->sense_buf,
                                                   ILLEGAL_REQUEST,
                                                   ASC_UNALIGNED_WRITE_COMMAND);

++++++ file_zbc-optionally-build-zbc-handler.patch ++++++
From: Jason Dillaman <[email protected]>
Date: Tue, 9 Oct 2018 12:56:35 -0400
Subject: file_zbc: optionally build zbc handler
Git-repo: https://github.com/agrover/tcmu-runner.git
Git-commit: aa87146e0ef46e535dd5ba6243a41323de6b53a4

Signed-off-by: Jason Dillaman <[email protected]>
Acked-by: Lee Duncan <[email protected]>
---
 CMakeLists.txt | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2a4c4b0a3197..01f7777d4357 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -11,6 +11,7 @@ set(tcmu-runner_HANDLER_PATH 
"${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}/tc
 option(with-glfs "build Gluster glfs handler" true)
 option(with-qcow "build qcow handler" true)
 option(with-rbd "build Ceph rbd handler" true)
+option(with-zbc "build zbc handler" true)
 
 find_library(LIBNL_LIB nl-3)
 find_library(LIBNL_GENL_LIB nl-genl-3)
@@ -168,26 +169,28 @@ target_include_directories(handler_file_optical
   )
 target_link_libraries(handler_file_optical ${PTHREAD})
 
-# Stuff for building the file zbc handler
-add_library(handler_file_zbc
-  SHARED
-  file_zbc.c
-  )
-set_target_properties(handler_file_zbc
-  PROPERTIES
-  PREFIX ""
-  )
-target_include_directories(handler_file_zbc
-  PUBLIC ${PROJECT_SOURCE_DIR}/ccan
-  )
-install(TARGETS handler_file_zbc DESTINATION 
${CMAKE_INSTALL_LIBDIR}/tcmu-runner)
-
 # The minimal library consumer
 add_executable(consumer
   consumer.c
   )
 target_link_libraries(consumer tcmu)
 
+if (with-zbc)
+       # Stuff for building the file zbc handler
+       add_library(handler_file_zbc
+         SHARED
+         file_zbc.c
+         )
+       set_target_properties(handler_file_zbc
+         PROPERTIES
+         PREFIX ""
+         )
+       target_include_directories(handler_file_zbc
+         PUBLIC ${PROJECT_SOURCE_DIR}/ccan
+         )
+       install(TARGETS handler_file_zbc DESTINATION 
${CMAKE_INSTALL_LIBDIR}/tcmu-runner)
+endif (with-zbc)
+
 if (with-rbd)
        find_library(LIBRBD rbd)
 

++++++ tcmu-runner-fail-cross-device-XCOPY-requests.patch ++++++
>From 5901e05ce30f75ef46d90f78a42c9a63d4a2b469 Mon Sep 17 00:00:00 2001
From: David Disseldorp <[email protected]>
Date: Mon, 16 Nov 2020 12:25:32 +0100
Subject: [PATCH] tcmur: fail cross-device XCOPY requests

tcmu-runner can't determine whether the device(s) referred to in XCOPY
Copy Source/Copy Destination (CSCD) descriptors should be accessible to
the initiator via transport settings, ACLs, etc. Consequently, fail
XCOPY requests with CSCD descriptors which refer to any device other
than where the XCOPY request is processed.

References: CVE-2020-28374
Fixes: 9c86bd0 ("tcmur: Add emulate XCOPY command support")
Signed-off-by: David Disseldorp <[email protected]>
Reviewed-by: Lee Duncan <[email protected]>
[ddiss: backport for 1.4.0]
---
 tcmur_cmd_handler.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Index: tcmu-runner-1.4.0/tcmur_cmd_handler.c
===================================================================
--- tcmu-runner-1.4.0.orig/tcmur_cmd_handler.c
+++ tcmu-runner-1.4.0/tcmur_cmd_handler.c
@@ -1400,6 +1400,18 @@ static int xcopy_parse_parameter_list(st
        if (ret != TCMU_STS_OK)
                goto err;
 
+       /*
+        * tcmu-runner can't determine whether the device(s) referred to in an
+        * XCOPY request should be accessible to the initiator via transport
+        * settings, ACLs, etc. XXX Consequently, we need to fail any
+        * cross-device requests for safety reasons.
+        */
+       if (dev != xcopy->src_dev || dev != xcopy->dst_dev) {
+               tcmu_dev_err(dev, "Cross-device XCOPY not supported\n");
+               ret = TCMU_STS_CP_TGT_DEV_NOTCONN;
+               goto err;
+       }
+
        if (tcmu_get_dev_block_size(xcopy->src_dev) !=
            tcmu_get_dev_block_size(xcopy->dst_dev)) {
                tcmu_dev_err(dev, "The block size of src dev %u != dst dev 
%u\n",
++++++ tcmu-runner-handler_file-add-libtcmu.patch ++++++
---
 CMakeLists.txt |    1 +
 1 file changed, 1 insertion(+)

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -146,6 +146,7 @@ add_library(handler_file
   SHARED
   file_example.c
   )
+target_link_libraries(handler_file tcmu)
 set_target_properties(handler_file
   PROPERTIES
   PREFIX ""
++++++ tcmu-runner-remove-handler-path-install-prefix.patch ++++++
From: Lee Duncan <[email protected]>
Date: Wed Aug  9 14:46:08 PDT 2017
Subject: [tcmu-runner] remove handler path install prefix
Patch-mainline: never (suse-specific)
Reference: bsc#1052795

The SUSE %cmake macro sets CMAKE_INSTALL_LIBDIR to /usr/lib64 but
then sets CMAKE_INSTALL_PREFIX to /usr, so that the plugin path
gets set to /usr/usr/lib64/tcmu-runner, which is not good.

This fixes it for SUSE.

diff -aurp tcmu-runner-1.2.0.orig/CMakeLists.txt 
tcmu-runner-1.2.0/CMakeLists.txt
--- tcmu-runner-1.2.0.orig/CMakeLists.txt       2017-08-09 14:43:09.852647786 
-0700
+++ tcmu-runner-1.2.0/CMakeLists.txt    2017-08-09 14:44:07.134410581 -0700
@@ -6,7 +6,7 @@ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wal
 include(GNUInstallDirs)
 include(CheckIncludeFile)
 
-set(tcmu-runner_HANDLER_PATH 
"${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}/tcmu-runner")
+set(tcmu-runner_HANDLER_PATH "${CMAKE_INSTALL_LIBDIR}/tcmu-runner")
 
 option(with-glfs "build Gluster glfs handler" true)
 option(with-qcow "build qcow handler" true)

Reply via email to