Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package rubygem-delayed_job for
openSUSE:Factory checked in at 2021-01-20 18:28:27
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/rubygem-delayed_job (Old)
and /work/SRC/openSUSE:Factory/.rubygem-delayed_job.new.28504 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "rubygem-delayed_job"
Wed Jan 20 18:28:27 2021 rev:18 rq:864641 version:4.1.9
Changes:
--------
--- /work/SRC/openSUSE:Factory/rubygem-delayed_job/rubygem-delayed_job.changes
2020-03-07 21:37:49.460255368 +0100
+++
/work/SRC/openSUSE:Factory/.rubygem-delayed_job.new.28504/rubygem-delayed_job.changes
2021-01-20 18:29:01.287605564 +0100
@@ -1,0 +2,7 @@
+Sun Dec 20 00:06:17 UTC 2020 - Matthew Trescott <[email protected]>
+
+- updated to version 4.1.9
+ Support for Rails 6.1
+ Add support for parameterized mailers via delay call (#1121)
+
+-------------------------------------------------------------------
Old:
----
delayed_job-4.1.8.gem
New:
----
delayed_job-4.1.9.gem
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ rubygem-delayed_job.spec ++++++
--- /var/tmp/diff_new_pack.KSVzFV/_old 2021-01-20 18:29:01.847606077 +0100
+++ /var/tmp/diff_new_pack.KSVzFV/_new 2021-01-20 18:29:01.851606081 +0100
@@ -24,7 +24,7 @@
#
Name: rubygem-delayed_job
-Version: 4.1.8
+Version: 4.1.9
Release: 0
%define mod_name delayed_job
%define mod_full_name %{mod_name}-%{version}
++++++ delayed_job-4.1.8.gem -> delayed_job-4.1.9.gem ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/CHANGELOG.md new/CHANGELOG.md
--- old/CHANGELOG.md 2019-08-16 23:09:59.000000000 +0200
+++ new/CHANGELOG.md 2020-12-09 21:22:42.000000000 +0100
@@ -1,29 +1,34 @@
+4.1.9 - 2020-12-09
+==================
+* Support for Rails 6.1
+* Add support for parameterized mailers via delay call (#1121)
+
4.1.8 - 2019-08-16
-=================
+==================
* Support for Rails 6.0.0
4.1.7 - 2019-06-20
-=================
+==================
* Fix loading Delayed::PerformableMailer when ActionMailer isn't loaded yet
4.1.6 - 2019-06-19
-=================
+==================
* Properly initialize ActionMailer outside railties (#1077)
* Fix Psych load_tags support (#1093)
* Replace REMOVED with FAILED in log message (#1048)
* Misc doc updates (#1052, #1074, #1064, #1063)
4.1.5 - 2018-04-13
-=================
+==================
* Allow Rails 5.2
4.1.4 - 2017-12-29
-=================
+==================
* Use `yaml_tag` instead of deprecated `yaml_as` (#996)
* Support ruby 2.5.0
4.1.3 - 2017-05-26
-=================
+==================
* Don't mutate the options hash (#877)
* Log an error message when a deserialization error occurs (#894)
* Adding the queue name to the log output (#917)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/README.md new/README.md
--- old/README.md 2019-08-16 23:09:59.000000000 +0200
+++ new/README.md 2020-12-09 21:22:42.000000000 +0100
@@ -1,17 +1,16 @@
**If you're viewing this at https://github.com/collectiveidea/delayed_job,
you're reading the documentation for the master branch.
[View documentation for the latest release
-(4.1.8).](https://github.com/collectiveidea/delayed_job/tree/v4.1.8)**
+(4.1.9).](https://github.com/collectiveidea/delayed_job/tree/v4.1.9)**
Delayed::Job
============
[][gem]
-[][travis]
+
[][codeclimate]
[][coveralls]
[gem]: https://rubygems.org/gems/delayed_job
-[travis]: https://travis-ci.org/collectiveidea/delayed_job
[codeclimate]: https://codeclimate.com/github/collectiveidea/delayed_job
[coveralls]: https://coveralls.io/r/collectiveidea/delayed_job
@@ -168,9 +167,10 @@
If you ever want to call a `handle_asynchronously`'d method without Delayed
Job, for instance while debugging something at the console, just add
`_without_delay` to the method name. For instance, if your original method was
`foo`, then call `foo_without_delay`.
-Rails 3 Mailers
-===============
-Due to how mailers are implemented in Rails 3, we had to do a little work
around to get delayed_job to work.
+Rails Mailers
+=============
+Delayed Job uses special syntax for Rails Mailers.
+Do not call the `.deliver` method when using `.delay`.
```ruby
# without delayed_job
@@ -179,12 +179,16 @@
# with delayed_job
Notifier.delay.signup(@user)
-# with delayed_job running at a specific time
+# delayed_job running at a specific time
Notifier.delay(run_at: 5.minutes.from_now).signup(@user)
+
+# when using parameters, the .with method must be called before the .delay
method
+Notifier.with(foo: 1, bar: 2).delay.signup(@user)
```
-Remove the `.deliver` method to make it work. It's not ideal, but it's the best
-we could do for now.
+You may also wish to consider using
+[Active Job with Action
Mailer](https://edgeguides.rubyonrails.org/active_job_basics.html#action-mailer)
+which provides convenient `.deliver_later` syntax that forwards to Delayed Job
under-the-hood.
Named Queues
============
Binary files old/checksums.yaml.gz and new/checksums.yaml.gz differ
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/delayed_job.gemspec new/delayed_job.gemspec
--- old/delayed_job.gemspec 2019-08-16 23:09:59.000000000 +0200
+++ new/delayed_job.gemspec 2020-12-09 21:22:42.000000000 +0100
@@ -1,7 +1,7 @@
# -*- encoding: utf-8 -*-
Gem::Specification.new do |spec|
- spec.add_dependency 'activesupport', ['>= 3.0', '< 6.1']
+ spec.add_dependency 'activesupport', ['>= 3.0', '< 6.2']
spec.authors = ['Brandon Keepers', 'Brian Ryckbost', 'Chris Gaffney',
'David Genord II', 'Erik Michaels-Ober', 'Matt Griffin', 'Steve Richert',
'Tobias L??tke']
spec.description = 'Delayed_job (or DJ) encapsulates the common pattern
of asynchronously executing longer tasks in the background. It is a direct
extraction from Shopify where the job table is responsible for a multitude of
core tasks.'
spec.email = ['[email protected]']
@@ -13,5 +13,10 @@
spec.require_paths = ['lib']
spec.summary = 'Database-backed asynchronous priority queue system --
Extracted from Shopify'
spec.test_files = Dir.glob('spec/**/*')
- spec.version = '4.1.8'
+ spec.version = '4.1.9'
+ spec.metadata = {
+ 'changelog_uri' =>
'https://github.com/collectiveidea/delayed_job/blob/master/CHANGELOG.md',
+ 'bug_tracker_uri' =>
'https://github.com/collectiveidea/delayed_job/issues',
+ 'source_code_uri' => 'https://github.com/collectiveidea/delayed_job'
+ }
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/lib/delayed_job.rb new/lib/delayed_job.rb
--- old/lib/delayed_job.rb 2019-08-16 23:09:59.000000000 +0200
+++ new/lib/delayed_job.rb 2020-12-09 21:22:42.000000000 +0100
@@ -16,6 +16,7 @@
ActiveSupport.on_load(:action_mailer) do
require 'delayed/performable_mailer'
ActionMailer::Base.extend(Delayed::DelayMail)
+ ActionMailer::Parameterized::Mailer.include(Delayed::DelayMail) if
defined?(ActionMailer::Parameterized::Mailer)
end
module Delayed
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/metadata new/metadata
--- old/metadata 2019-08-16 23:09:59.000000000 +0200
+++ new/metadata 2020-12-09 21:22:42.000000000 +0100
@@ -1,7 +1,7 @@
--- !ruby/object:Gem::Specification
name: delayed_job
version: !ruby/object:Gem::Version
- version: 4.1.8
+ version: 4.1.9
platform: ruby
authors:
- Brandon Keepers
@@ -15,7 +15,7 @@
autorequire:
bindir: bin
cert_chain: []
-date: 2019-08-16 00:00:00.000000000 Z
+date: 2020-12-09 00:00:00.000000000 Z
dependencies:
- !ruby/object:Gem::Dependency
name: activesupport
@@ -26,7 +26,7 @@
version: '3.0'
- - "<"
- !ruby/object:Gem::Version
- version: '6.1'
+ version: '6.2'
type: :runtime
prerelease: false
version_requirements: !ruby/object:Gem::Requirement
@@ -36,7 +36,7 @@
version: '3.0'
- - "<"
- !ruby/object:Gem::Version
- version: '6.1'
+ version: '6.2'
description: Delayed_job (or DJ) encapsulates the common pattern of
asynchronously
executing longer tasks in the background. It is a direct extraction from
Shopify
where the job table is responsible for a multitude of core tasks.
@@ -102,7 +102,10 @@
homepage: http://github.com/collectiveidea/delayed_job
licenses:
- MIT
-metadata: {}
+metadata:
+ changelog_uri:
https://github.com/collectiveidea/delayed_job/blob/master/CHANGELOG.md
+ bug_tracker_uri: https://github.com/collectiveidea/delayed_job/issues
+ source_code_uri: https://github.com/collectiveidea/delayed_job
post_install_message:
rdoc_options: []
require_paths:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/spec/helper.rb new/spec/helper.rb
--- old/spec/helper.rb 2019-08-16 23:09:59.000000000 +0200
+++ new/spec/helper.rb 2020-12-09 21:22:42.000000000 +0100
@@ -1,13 +1,19 @@
require 'simplecov'
-require 'coveralls'
+require 'simplecov-lcov'
-SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter,
Coveralls::SimpleCov::Formatter]
+SimpleCov::Formatter::LcovFormatter.config do |c|
+ c.report_with_single_file = true
+ c.single_report_path = 'coverage/lcov.info'
+end
+SimpleCov.formatters = SimpleCov::Formatter::MultiFormatter.new(
+ [
+ SimpleCov::Formatter::HTMLFormatter,
+ SimpleCov::Formatter::LcovFormatter
+ ]
+)
SimpleCov.start do
add_filter '/spec/'
- # Each version of ruby and version of rails test different things
- # This should probably just be removed.
- minimum_coverage(85.0)
end
require 'logger'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/spec/performable_mailer_spec.rb
new/spec/performable_mailer_spec.rb
--- old/spec/performable_mailer_spec.rb 2019-08-16 23:09:59.000000000 +0200
+++ new/spec/performable_mailer_spec.rb 2020-12-09 21:22:42.000000000 +0100
@@ -40,3 +40,29 @@
end
end
end
+
+if defined?(ActionMailer::Parameterized::Mailer)
+ describe ActionMailer::Parameterized::Mailer do
+ describe 'delay' do
+ it 'enqueues a PerformableEmail job' do
+ expect do
+ job = MyMailer.with(:foo => 1, :bar =>
2).delay.signup('[email protected]')
+ expect(job.payload_object.class).to eq(Delayed::PerformableMailer)
+ expect(job.payload_object.object.class).to
eq(ActionMailer::Parameterized::Mailer)
+
expect(job.payload_object.object.instance_variable_get('@mailer')).to
eq(MyMailer)
+
expect(job.payload_object.object.instance_variable_get('@params')).to eq(:foo
=> 1, :bar => 2)
+ expect(job.payload_object.method_name).to eq(:signup)
+ expect(job.payload_object.args).to eq(['[email protected]'])
+ end.to change { Delayed::Job.count }.by(1)
+ end
+ end
+
+ describe 'delay on a mail object' do
+ it 'raises an exception' do
+ expect do
+ MyMailer.with(:foo => 1, :bar => 2).signup('[email protected]').delay
+ end.to raise_error(RuntimeError)
+ end
+ end
+ end
+end
