Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package tilda for openSUSE:Factory checked 
in at 2021-01-25 18:24:51
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/tilda (Old)
 and      /work/SRC/openSUSE:Factory/.tilda.new.28504 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "tilda"

Mon Jan 25 18:24:51 2021 rev:14 rq:866523 version:1.5.4

Changes:
--------
--- /work/SRC/openSUSE:Factory/tilda/tilda.changes      2020-08-20 
22:32:40.724089362 +0200
+++ /work/SRC/openSUSE:Factory/.tilda.new.28504/tilda.changes   2021-01-25 
18:25:17.988575122 +0100
@@ -1,0 +2,12 @@
+Tue Jan 12 04:49:20 UTC 2021 - Avindra Goolcharan <avin...@opensuse.org>
+
+- Update to 1.5.4
+  * Fixed an issue that occurs with custom commands in newer VTE versions
+  * Fixes an incorrect usage of 32bit data type for X11 time, which
+    should be 64bit instead
+- includes 1.5.3:
+  * Fixed an issue that could cause tilda to crash due to a BadMatch X11
+    error in certain situations (such as when using the Marco
+    window manager of the Mate Desktop 1.24.1)
+
+-------------------------------------------------------------------

Old:
----
  tilda-1.5.2.tar.gz

New:
----
  tilda-1.5.4.tar.gz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ tilda.spec ++++++
--- /var/tmp/diff_new_pack.ANvMXE/_old  2021-01-25 18:25:18.740576215 +0100
+++ /var/tmp/diff_new_pack.ANvMXE/_new  2021-01-25 18:25:18.744576221 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package tilda
 #
-# Copyright (c) 2020 SUSE LLC
+# Copyright (c) 2021 SUSE LLC
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
 
 
 Name:           tilda
-Version:        1.5.2
+Version:        1.5.4
 Release:        0
 Summary:        A Gtk based drop down terminal for Linux and Unix
 License:        GPL-2.0-or-later

++++++ tilda-1.5.2.tar.gz -> tilda-1.5.4.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/tilda-tilda-1.5.2/ChangeLog 
new/tilda-tilda-1.5.4/ChangeLog
--- old/tilda-tilda-1.5.2/ChangeLog     2020-05-09 12:39:43.000000000 +0200
+++ new/tilda-tilda-1.5.4/ChangeLog     2020-12-24 11:31:23.000000000 +0100
@@ -1,3 +1,15 @@
+version 1.5.4 (2020-12-24):
+       * Fixed an issue that occurs with newer tilda versions which prevents
+         custom commands from working correctly in newer VTE versions.
+               Fixes #435, #436, #440 (Jimun Batty).
+       * Fixes an incorrect usage of 32bit data type for X11 time, which
+         should be 64bit instead (Sebastian Geiger).
+
+version 1.5.3 (2020-11-01):
+       * Fixed an issue that could cause tilda to crash due to a BadMatch X11
+         error in certain situations (such as when using the Marco
+               window manager of the Mate Desktop 1.24.1) (Emanuele F.).
+
 version 1.5.2 (2020-05-09):
        * Fixed an issue in the URL matching code that caused a VTE warning
          about a missing multiline flag to be emitted at runtime.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/tilda-tilda-1.5.2/configure.ac 
new/tilda-tilda-1.5.4/configure.ac
--- old/tilda-tilda-1.5.2/configure.ac  2020-05-09 12:39:43.000000000 +0200
+++ new/tilda-tilda-1.5.4/configure.ac  2020-12-24 11:31:23.000000000 +0100
@@ -12,7 +12,7 @@
 AC_PREREQ([2.68])
 
 AC_INIT([Tilda],
-        [1.5.2],
+        [1.5.4],
         [tilda_issues],
         [tilda],
         [tilda_repository])
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/tilda-tilda-1.5.2/src/tilda_terminal.c 
new/tilda-tilda-1.5.4/src/tilda_terminal.c
--- old/tilda-tilda-1.5.2/src/tilda_terminal.c  2020-05-09 12:39:43.000000000 
+0200
+++ new/tilda-tilda-1.5.4/src/tilda_terminal.c  2020-12-24 11:31:23.000000000 
+0100
@@ -464,7 +464,11 @@
         gint command_timeout = config_getint ("command_timeout_ms");
 
         char **envv = malloc(2*sizeof(void *));
-        envv[0] = getenv("PATH");
+        char *path_value = getenv("PATH");
+
+        gchar *path_prefixed = g_strconcat("PATH=", path_value, NULL);
+
+        envv[0] = path_prefixed;
         envv[1] = NULL;
 
         vte_terminal_spawn_async (VTE_TERMINAL (tt->vte_term),
@@ -483,6 +487,7 @@
 
         g_strfreev (argv);
         g_free (envv);
+        g_free(path_prefixed);
     } else {
         start_default_shell (tt);
     }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/tilda-tilda-1.5.2/src/tomboykeybinder.c 
new/tilda-tilda-1.5.4/src/tomboykeybinder.c
--- old/tilda-tilda-1.5.2/src/tomboykeybinder.c 2020-05-09 12:39:43.000000000 
+0200
+++ new/tilda-tilda-1.5.4/src/tomboykeybinder.c 2020-12-24 11:31:23.000000000 
+0100
@@ -382,7 +382,7 @@
     }
 }
 
-guint32
+Time
 tomboy_keybinder_get_current_event_time (void)
 {
     if (processing_event)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/tilda-tilda-1.5.2/src/tomboykeybinder.h 
new/tilda-tilda-1.5.4/src/tomboykeybinder.h
--- old/tilda-tilda-1.5.2/src/tomboykeybinder.h 2020-05-09 12:39:43.000000000 
+0200
+++ new/tilda-tilda-1.5.4/src/tomboykeybinder.h 2020-12-24 11:31:23.000000000 
+0100
@@ -25,6 +25,7 @@
 #define __TOMBOY_KEY_BINDER_H__
 
 #include <glib.h>
+#include <X11/X.h>
 
 G_BEGIN_DECLS
 
@@ -41,7 +42,7 @@
 
 gboolean tomboy_keybinder_is_modifier (guint keycode);
 
-guint32 tomboy_keybinder_get_current_event_time (void);
+Time tomboy_keybinder_get_current_event_time (void);
 
 G_END_DECLS
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/tilda-tilda-1.5.2/src/xerror.c 
new/tilda-tilda-1.5.4/src/xerror.c
--- old/tilda-tilda-1.5.2/src/xerror.c  2020-05-09 12:39:43.000000000 +0200
+++ new/tilda-tilda-1.5.4/src/xerror.c  2020-12-24 11:31:23.000000000 +0100
@@ -32,10 +32,13 @@
 
     gchar errtxt[128];
 
-    if (e->error_code != BadWindow)
+    /* 
https://tronche.com/gui/x/xlib/event-handling/protocol-errors/default-handlers.html
 */
+    if ((e->error_code != BadWindow) &&
+        /* 
https://www.x.org/releases/X11R7.7/doc/xproto/x11protocol.html#requests:SetInputFocus
 */
+        ((e->request_code != 42 /* SetInputFocus */) || (e->error_code != 
BadMatch)))
     {
         XGetErrorText(d, e->error_code, errtxt, 127);
-        g_error(_("X Error: %s"), errtxt);
+        g_error(_("X Error [opcode %d]: %s"), e->request_code, errtxt);
     }
 
     return 0;

Reply via email to