Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package brp-check-suse for openSUSE:Factory checked in at 2021-02-02 14:24:18 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/brp-check-suse (Old) and /work/SRC/openSUSE:Factory/.brp-check-suse.new.28504 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "brp-check-suse" Tue Feb 2 14:24:18 2021 rev:68 rq:863264 version:84.87+git20201203.5008eba Changes: -------- --- /work/SRC/openSUSE:Factory/brp-check-suse/brp-check-suse.changes 2021-01-10 19:37:59.257413951 +0100 +++ /work/SRC/openSUSE:Factory/.brp-check-suse.new.28504/brp-check-suse.changes 2021-02-02 14:24:19.799266614 +0100 @@ -1,0 +2,10 @@ +Fri Jan 15 09:04:13 UTC 2021 - co...@suse.com + +- Update to version 84.87+git20201203.5008eba: + * brp-25-symlink: Detect if a link points inside the build root + * brp-25-symlink: Remove unused $link part of the case statement + * brp-25-symlink: Print all errors before exiting + * Makefile: enable -O2, use standard variables and clean up + * simplify split_paths using std::getline + +------------------------------------------------------------------- Old: ---- brp-check-suse-84.87+git20201201.9bbfade.tar.xz New: ---- brp-check-suse-84.87+git20201203.5008eba.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ brp-check-suse.spec ++++++ --- /var/tmp/diff_new_pack.WjvRX4/_old 2021-02-02 14:24:20.591267846 +0100 +++ /var/tmp/diff_new_pack.WjvRX4/_new 2021-02-02 14:24:20.595267852 +0100 @@ -1,7 +1,7 @@ # # spec file for package brp-check-suse # -# Copyright (c) 2020 SUSE LLC +# Copyright (c) 2021 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -23,7 +23,7 @@ License: GPL-2.0-or-later Group: Development/Tools/Building Requires: perl -Version: 84.87+git20201201.9bbfade +Version: 84.87+git20201203.5008eba Release: 0 URL: https://github.com/openSUSE/brp-check-suse BuildRequires: gcc-c++ ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.WjvRX4/_old 2021-02-02 14:24:20.639267920 +0100 +++ /var/tmp/diff_new_pack.WjvRX4/_new 2021-02-02 14:24:20.643267927 +0100 @@ -1,5 +1,5 @@ <servicedata> <service name="tar_scm"> <param name="url">git://github.com/openSUSE/brp-check-suse.git</param> - <param name="changesrevision">e16a2204491eba4e9875fc7501c4abee96aeb30d</param></service> + <param name="changesrevision">94d2e68c24b161dcb5f986033e4e1eff53db06e6</param></service> </servicedata> \ No newline at end of file ++++++ brp-check-suse-84.87+git20201201.9bbfade.tar.xz -> brp-check-suse-84.87+git20201203.5008eba.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/brp-check-suse-84.87+git20201201.9bbfade/brp-25-symlink new/brp-check-suse-84.87+git20201203.5008eba/brp-25-symlink --- old/brp-check-suse-84.87+git20201201.9bbfade/brp-25-symlink 2020-12-01 11:11:06.000000000 +0100 +++ new/brp-check-suse-84.87+git20201203.5008eba/brp-25-symlink 2020-12-03 15:36:23.000000000 +0100 @@ -32,32 +32,42 @@ do if test "$link" = "$link_dest"; then echo "ERROR: $link points to itself (as $orig_link_dest)" - exit 1 + had_errors=1 + continue fi - case "$link,$link_absolut" in - *,/etc/alternatives/*) # update alternative links are special + case "$link_absolut" in + /etc/alternatives/*) # update alternative links are special link_dest=$link_absolut ;; - *,*share/automake-*) - echo "ERROR: link target $link points into automake directory" - echo " You might want to add a -c to the automake call (or just" - echo " skip the files from packaging)" - exit 1 + /opt/kde3/share/doc*/HTML/*/common) # white listed for not existant ;; - *,/opt/kde3/share/doc*/HTML/*/common) # white listed for not existant + /usr/share/doc/kde/HTML/*/common) # white listed for not existant ;; - *,/usr/share/doc/kde/HTML/*/common) # white listed for not existant - ;; - *,/proc/*|*,/dev/*|*,/sys/*) # links pointing into kernel file system should be absolute + /proc/*|/dev/*|/sys/*) # links pointing into kernel file system should be absolute link_dest=$link_absolut ;; + ${RPM_BUILD_ROOT}*) + echo "ERROR: Link $link -> $link_orig points inside build root!" + had_errors=1 + continue + ;; + *share/automake-*) + echo "ERROR: link target $link points into automake directory" + echo " You might want to add a -c to the automake call (or just" + echo " skip the files from packaging)" + had_errors=1 + continue + ;; *) if test ! -L ./"$link_absolut" && test ! -e "$link_absolut" && test ! -e ./"$link_absolut"; then echo "ERROR: link target doesn't exist (neither in build root nor in installed system):" echo " $link -> $link_orig" echo "Add the package providing the target to BuildRequires and Requires" - test "$NO_BRP_STALE_LINK_ERROR" != "yes" && had_errors=1 + if [ "$NO_BRP_STALE_LINK_ERROR" != "yes" ]; then + had_errors=1 + continue + fi fi ;; esac diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/brp-check-suse-84.87+git20201201.9bbfade/prg-brp-symlink/Makefile new/brp-check-suse-84.87+git20201203.5008eba/prg-brp-symlink/Makefile --- old/brp-check-suse-84.87+git20201201.9bbfade/prg-brp-symlink/Makefile 2020-12-01 11:11:06.000000000 +0100 +++ new/brp-check-suse-84.87+git20201203.5008eba/prg-brp-symlink/Makefile 2020-12-03 15:36:23.000000000 +0100 @@ -1,7 +1,10 @@ +CXXFLAGS=-O2 -Wall +CXX=g++ + all: brp-symlink brp-symlink: main.cpp - g++ -I. -std=c++17 main.cpp -o brp-symlink + $(CXX) $(CXXFLAGS) -o $@ $^ check: brp-symlink ./brp-symlink < tests.in > tests.new diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/brp-check-suse-84.87+git20201201.9bbfade/prg-brp-symlink/main.cpp new/brp-check-suse-84.87+git20201203.5008eba/prg-brp-symlink/main.cpp --- old/brp-check-suse-84.87+git20201201.9bbfade/prg-brp-symlink/main.cpp 2020-12-01 11:11:06.000000000 +0100 +++ new/brp-check-suse-84.87+git20201203.5008eba/prg-brp-symlink/main.cpp 2020-12-03 15:36:23.000000000 +0100 @@ -31,21 +31,18 @@ return (tmp + p2); } -vector<string> split_paths(string path) +vector<string> split_paths(const string &path) { - size_t pos = 0; string token; vector<string> paths; - while ((pos = path.find("/")) != string::npos) { - token = path.substr(0, pos); + stringstream ss(path); + while (getline(ss, token, '/')) { if (token == "..") { paths.pop_back(); - } else if (token != ".") { + } else if (token != "." || ss.eof()) { paths.push_back(token); } - path.erase(0, pos + 1); } - paths.push_back(path); return paths; }
